Hello community, here is the log from the commit of package systemtap for openSUSE:Factory checked in at 2019-11-13 13:12:34 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/systemtap (Old) and /work/SRC/openSUSE:Factory/.systemtap.new.2990 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "systemtap" Wed Nov 13 13:12:34 2019 rev:107 rq:746400 version:4.1 Changes: -------- systemtap-dtrace.changes: same change systemtap-headers.changes: same change --- /work/SRC/openSUSE:Factory/systemtap/systemtap.changes 2019-10-17 12:17:24.947905885 +0200 +++ /work/SRC/openSUSE:Factory/.systemtap.new.2990/systemtap.changes 2019-11-13 13:12:38.758718163 +0100 @@ -1,0 +2,8 @@ +Thu Nov 7 18:18:07 UTC 2019 - Tony Jones <[email protected]> + +- Add support for gcc -Wimplicit-fallthrough to resolve compilation errors + of the form "this statement may fall through" + New patch: systemtap-support-wimplicit-fallthrough-vsprintf.patch + New patch: systemtap-support-wimplicit-fallthrough-gen_map.patch + +------------------------------------------------------------------- New: ---- systemtap-support-wimplicit-fallthrough-gen_map.patch systemtap-support-wimplicit-fallthrough-vsprintf.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ systemtap-dtrace.spec: same change systemtap-headers.spec: same change ++++++ systemtap.spec ++++++ --- /var/tmp/diff_new_pack.S0F7hj/_old 2019-11-13 13:12:40.006719462 +0100 +++ /var/tmp/diff_new_pack.S0F7hj/_new 2019-11-13 13:12:40.006719462 +0100 @@ -33,6 +33,8 @@ Source4: README-KEYRING Source5: stap-server.conf Patch1: systemtap-build-source-dir.patch +Patch2: systemtap-support-wimplicit-fallthrough-vsprintf.patch +Patch3: systemtap-support-wimplicit-fallthrough-gen_map.patch BuildRequires: autoconf BuildRequires: automake BuildRequires: gcc-c++ @@ -95,6 +97,8 @@ %prep %setup -q %patch1 -p1 +%patch2 -p1 +%patch3 -p1 %build autoreconf -fi ++++++ systemtap-support-wimplicit-fallthrough-gen_map.patch ++++++ Author: Frank Ch. Eigler <[email protected]> Date: Thu Nov 7 13:47:34 2019 -0500 Subject: runtime gen-map.c: add /* fallthru */ to satisfy gcc 9's -Wimplicit-fallthrough Git-commit: c4034101819829b6fb6cea38474c76fd50fa9eda References: none (found during testing of SLE15-SP2 v4.1 update) Signed-off-by: Tony Jones <[email protected]> runtime gen-map.c: add /* fallthru */ to satisfy gcc 9's -Wimplicit-fallthrough diff --git a/runtime/map-gen.c b/runtime/map-gen.c index 413e20edb..d8fc48710 100644 --- a/runtime/map-gen.c +++ b/runtime/map-gen.c @@ -112,7 +112,9 @@ k1 = 0; \ switch(mylen & 3) { \ case 3: k1 ^= tail[2] << 16; \ + /* fallthrough */ \ case 2: k1 ^= tail[1] << 8; \ + /* fallthrough */ \ case 1: k1 ^= tail[0]; \ k1 *= c1; k1 = ROTL32(k1,15); k1 *= c2; h1 ^= k1; \ } \ ++++++ systemtap-support-wimplicit-fallthrough-vsprintf.patch ++++++ From: Frank Ch. Eigler <[email protected]> Date: Sun Aug 11 15:00:27 2019 +0000 Subject: add /* fallthru */ to satisfy gcc 9's -Wimplicit-fallthrough Git-commit: 910acbe2663d7432e38ee3563c56dfd10b05b7db References: none (found during testing of SLE15-SP2 v4.1 update) Signed-off-by: Tony Jones <[email protected]> rhbz1737589: add /* fallthru */ to satisfy gcc 9's -Wimplicit-fallthrough We need annotate switch statements with deliberate case-to-case fallthroughs. diff --git a/runtime/vsprintf.c b/runtime/vsprintf.c index 7bae9f841..388a87110 100644 --- a/runtime/vsprintf.c +++ b/runtime/vsprintf.c @@ -639,6 +639,7 @@ _stp_vsnprintf(char *buf, size_t size, const char *fmt, va_list args) case 'X': flags |= STP_LARGE; + /* fallthru */ case 'x': base = 16; break; @@ -646,6 +647,7 @@ _stp_vsnprintf(char *buf, size_t size, const char *fmt, va_list args) case 'd': case 'i': flags |= STP_SIGN; + /* fallthru */ case 'u': break; @@ -826,6 +828,7 @@ _stp_vsnprintf(char *buf, size_t size, const char *fmt, va_list args) case 'X': flags |= STP_LARGE; + /* fallthru */ case 'x': base = 16; break; @@ -833,6 +836,7 @@ _stp_vsnprintf(char *buf, size_t size, const char *fmt, va_list args) case 'd': case 'i': flags |= STP_SIGN; + /* fallthru */ case 'u': break;
