Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2019-11-15 00:02:02 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.26869 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Fri Nov 15 00:02:02 2019 rev:201 rq:748497 version:2.2.1 Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2019-10-30 14:43:17.513893521 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.26869/virt-manager.changes 2019-11-15 00:02:03.856336712 +0100 @@ -1,0 +2,10 @@ +Tue Nov 12 10:17:56 MST 2019 - [email protected] + +- Upstream bug fixes (bsc#1027942) + 1547e16d-domcapabilities-Get-video-devices.patch + 2e20b128-domcapabilities-Add-supports_video_bochs.patch + ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch + 51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch + d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch + +------------------------------------------------------------------- New: ---- 1547e16d-domcapabilities-Get-video-devices.patch 2e20b128-domcapabilities-Add-supports_video_bochs.patch 51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-manager.spec ++++++ --- /var/tmp/diff_new_pack.hYQsSr/_old 2019-11-15 00:02:06.136335899 +0100 +++ /var/tmp/diff_new_pack.hYQsSr/_new 2019-11-15 00:02:06.140335898 +0100 @@ -39,8 +39,13 @@ Patch5: 3009888a-urlfetcher-Dont-override-fullurl-when-its-explicitly-set.patch Patch6: 9465da41-urlfetcher-Deal-with-file-in-_LocalURLFetcher.patch Patch7: 651e5b6d-devices-video-Simplify-model-hvm-check.patch -Patch8: d9736db9-addhardware-Add-bochs-display-to-the-video-list.patch -Patch9: 8f4c53ea-video-Prefer-bochs-when-its-supported..patch +Patch8: 1547e16d-domcapabilities-Get-video-devices.patch +Patch9: 2e20b128-domcapabilities-Add-supports_video_bochs.patch +Patch10: d9736db9-addhardware-Add-bochs-display-to-the-video-list.patch +Patch11: 8f4c53ea-video-Prefer-bochs-when-its-supported..patch +Patch12: ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch +Patch13: 51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch +Patch14: d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch # SUSE Only Patch70: virtman-desktop.patch Patch71: virtman-kvm.patch @@ -182,6 +187,11 @@ %patch7 -p1 %patch8 -p1 %patch9 -p1 +%patch10 -p1 +%patch11 -p1 +%patch12 -p1 +%patch13 -p1 +%patch14 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 ++++++ 1547e16d-domcapabilities-Get-video-devices.patch ++++++ Subject: domcapabilities: Get video devices From: Fabiano Fidêncio [email protected] Thu Oct 3 10:44:52 2019 +0200 Date: Fri Oct 4 11:15:09 2019 -0400: Git: 1547e16d62736c861a0e4dadeb86ef372d2698bd domcapabilities already handles disk and hostdev. Let's add support for getting video devices as well. Signed-off-by: Fabiano Fidêncio <[email protected]> diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py index f11f18aa..9cc27bc2 100644 --- a/virtinst/domcapabilities.py +++ b/virtinst/domcapabilities.py @@ -95,6 +95,7 @@ class _Devices(_CapsBlock): XML_NAME = "devices" hostdev = XMLChildProperty(_make_capsblock("hostdev"), is_single=True) disk = XMLChildProperty(_make_capsblock("disk"), is_single=True) + video = XMLChildProperty(_make_capsblock("video"), is_single=True) class _Features(_CapsBlock): ++++++ 2e20b128-domcapabilities-Add-supports_video_bochs.patch ++++++ Subject: domcapabilities: Add supports_video_bochs() From: Fabiano Fidêncio [email protected] Thu Oct 3 10:47:15 2019 +0200 Date: Fri Oct 4 11:15:09 2019 -0400: Git: 2e20b128a1a1f064c5036d3d3d0cf5b09117b9da Returns whether bochs display is supported, according to the domain capabilities. Signed-off-by: Fabiano Fidêncio <[email protected]> Index: virt-manager-2.2.1/virtinst/domcapabilities.py =================================================================== --- virt-manager-2.2.1.orig/virtinst/domcapabilities.py +++ virt-manager-2.2.1/virtinst/domcapabilities.py @@ -325,6 +325,14 @@ class DomainCapabilities(XMLBuilder): """ return bool(self.features.sev.supported) + def supports_video_bochs(self): + """ + Returns False if either libvirt or qemu do not have support to bochs + video type. + """ + models = self.devices.video.get_enum("modelType").get_values() + return bool("bochs" in models) + XML_NAME = "domainCapabilities" os = XMLChildProperty(_OS, is_single=True) cpu = XMLChildProperty(_CPU, is_single=True) ++++++ 51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch ++++++ Subject: connection: Avoid repeated default pool creation attempts From: Michael Weiser [email protected] Fri Oct 25 21:27:18 2019 +0200 Date: Tue Nov 12 12:28:34 2019 -0500: Git: 51d84c54cb63350145f4ad3a2adba17313e1f227 During startup virtinst.StoragePool.build_default_pool() tries to determine whether the default storage pool already exists. Because events have not yet been processed, the list of existing storage pools is still empty. Therefore it seems as if it does not exist yet and build_default_pool() falls back to creating it which causes an error message from libvirtd in the system log: libvirtd: operation failed: pool 'default' already exists with uuid. Move default pool creation after event processing to avoid these redundant creation attempts. Signed-off-by: Michael Weiser <[email protected]> diff --git a/virtManager/connection.py b/virtManager/connection.py index f6dc5f5b..e526d495 100644 --- a/virtManager/connection.py +++ b/virtManager/connection.py @@ -990,13 +990,6 @@ class vmmConnection(vmmGObject): log.debug("%s capabilities:\n%s", self.get_uri(), self.caps.get_xml()) - # Try to create the default storage pool - # We want this before events setup to save some needless polling - try: - virtinst.StoragePool.build_default_pool(self.get_backend()) - except Exception as e: - log.debug("Building default pool failed: %s", str(e)) - self._add_conn_events() try: @@ -1025,6 +1018,14 @@ class vmmConnection(vmmGObject): self._init_object_event = None self._init_object_count = None + # Try to create the default storage pool + # We need this after events setup so we can determine if the default + # pool already exists + try: + virtinst.StoragePool.build_default_pool(self.get_backend()) + except Exception as e: + log.debug("Building default pool failed: %s", str(e)) + def _open_thread(self): ConnectError = None try: ++++++ ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch ++++++ Subject: fix resizing of spice clients with guest resizing enabled From: Florian Ludwig [email protected] Wed Oct 9 11:18:53 2019 +0200 Date: Tue Nov 12 11:46:35 2019 -0500: Git: ae19d6d6ec0b48085ce1c765fb2264e27fb51c63 Fixes 1414718 diff --git a/virtManager/details/console.py b/virtManager/details/console.py index 8ef8631a..193e79eb 100644 --- a/virtManager/details/console.py +++ b/virtManager/details/console.py @@ -374,7 +374,10 @@ class vmmConsolePages(vmmGObjectUI): if is_resizeguest: # With resize guest, we don't want to maintain aspect ratio, # since the guest can resize to arbitrary resolutions. - self._viewer.console_set_size_request(req.width, req.height) + viewer_alloc = Gdk.Rectangle() + viewer_alloc.width = req.width + viewer_alloc.height = req.height + self._viewer.console_size_allocate(viewer_alloc) return if not is_scale: ++++++ d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch ++++++ Subject: domcaps: Fix check for uncached security features From: Cole Robinson [email protected] Tue Nov 12 14:15:56 2019 -0500 Date: Tue Nov 12 14:17:21 2019 -0500: Git: d934d6f266e1731a5b881bbb9ae4cd60acd7887e We need to check against None, which is the initial value, otherwise a host with none of the security features present will repeatedly poll libvirt baseline APIs Signed-off-by: Cole Robinson <[email protected]> diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py index ea0ffd1f..34991ed7 100644 --- a/virtinst/domcapabilities.py +++ b/virtinst/domcapabilities.py @@ -296,7 +296,7 @@ class DomainCapabilities(XMLBuilder): 'virt-ssbd', 'md-clear'] - if self._features: + if self._features is not None: return self._features self._features = [] ++++++ virtinst-python2-to-python3-conversion.patch ++++++ --- /var/tmp/diff_new_pack.hYQsSr/_old 2019-11-15 00:02:07.036335578 +0100 +++ /var/tmp/diff_new_pack.hYQsSr/_new 2019-11-15 00:02:07.036335578 +0100 @@ -1,7 +1,7 @@ -Index: virt-manager-2.2.0/virtinst/osdict.py +Index: virt-manager-2.2.1/virtinst/osdict.py =================================================================== ---- virt-manager-2.2.0.orig/virtinst/osdict.py -+++ virt-manager-2.2.0/virtinst/osdict.py +--- virt-manager-2.2.1.orig/virtinst/osdict.py ++++ virt-manager-2.2.1/virtinst/osdict.py @@ -54,7 +54,7 @@ def _sort(tosort): distro_mappings = {} retlist = [] @@ -11,10 +11,10 @@ # Libosinfo has some duplicate version numbers here, so append .1 # if there's a collision sortby = _sortby(osinfo) -Index: virt-manager-2.2.0/virtinst/install/installertreemedia.py +Index: virt-manager-2.2.1/virtinst/install/installertreemedia.py =================================================================== ---- virt-manager-2.2.0.orig/virtinst/install/installertreemedia.py -+++ virt-manager-2.2.0/virtinst/install/installertreemedia.py +--- virt-manager-2.2.1.orig/virtinst/install/installertreemedia.py ++++ virt-manager-2.2.1/virtinst/install/installertreemedia.py @@ -20,7 +20,7 @@ from ..osdict import OSDB (MEDIA_DIR, MEDIA_ISO, @@ -24,10 +24,10 @@ def _is_url(url): -Index: virt-manager-2.2.0/virtinst/xmlbuilder.py +Index: virt-manager-2.2.1/virtinst/xmlbuilder.py =================================================================== ---- virt-manager-2.2.0.orig/virtinst/xmlbuilder.py -+++ virt-manager-2.2.0/virtinst/xmlbuilder.py +--- virt-manager-2.2.1.orig/virtinst/xmlbuilder.py ++++ virt-manager-2.2.1/virtinst/xmlbuilder.py @@ -661,7 +661,7 @@ class XMLBuilder(object): whenever child objects are added or removed """ @@ -37,11 +37,11 @@ for obj in xmlutil.listify(getattr(self, propname)): idxstr = "" if not xmlprop.is_single: -Index: virt-manager-2.2.0/virtinst/domcapabilities.py +Index: virt-manager-2.2.1/virtinst/domcapabilities.py =================================================================== ---- virt-manager-2.2.0.orig/virtinst/domcapabilities.py -+++ virt-manager-2.2.0/virtinst/domcapabilities.py -@@ -217,7 +217,7 @@ class DomainCapabilities(XMLBuilder): +--- virt-manager-2.2.1.orig/virtinst/domcapabilities.py ++++ virt-manager-2.2.1/virtinst/domcapabilities.py +@@ -218,7 +218,7 @@ class DomainCapabilities(XMLBuilder): return _("BIOS") return _("None") @@ -50,10 +50,10 @@ for pattern in patterns: if re.match(pattern, path): return (_("UEFI %(arch)s: %(path)s") % -Index: virt-manager-2.2.0/virtinst/devices/disk.py +Index: virt-manager-2.2.1/virtinst/devices/disk.py =================================================================== ---- virt-manager-2.2.0.orig/virtinst/devices/disk.py -+++ virt-manager-2.2.0/virtinst/devices/disk.py +--- virt-manager-2.2.1.orig/virtinst/devices/disk.py ++++ virt-manager-2.2.1/virtinst/devices/disk.py @@ -269,7 +269,7 @@ class DeviceDisk(Device): digit = 1 @@ -77,10 +77,10 @@ for i in ran: postfix = self.num_to_target(i + 1) -Index: virt-manager-2.2.0/virtinst/pollhelpers.py +Index: virt-manager-2.2.1/virtinst/pollhelpers.py =================================================================== ---- virt-manager-2.2.0.orig/virtinst/pollhelpers.py -+++ virt-manager-2.2.0/virtinst/pollhelpers.py +--- virt-manager-2.2.1.orig/virtinst/pollhelpers.py ++++ virt-manager-2.2.1/virtinst/pollhelpers.py @@ -129,7 +129,7 @@ def fetch_pools(backend, origmap, build_ for obj in objs: try:
