Hello community, here is the log from the commit of package drkonqi5 for openSUSE:Factory checked in at 2019-11-15 22:34:03 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/drkonqi5 (Old) and /work/SRC/openSUSE:Factory/.drkonqi5.new.26869 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "drkonqi5" Fri Nov 15 22:34:03 2019 rev:41 rq:747829 version:5.17.3 Changes: -------- --- /work/SRC/openSUSE:Factory/drkonqi5/drkonqi5.changes 2019-10-31 18:10:19.649701209 +0100 +++ /work/SRC/openSUSE:Factory/.drkonqi5.new.26869/drkonqi5.changes 2019-11-15 22:34:05.464025533 +0100 @@ -1,0 +2,12 @@ +Tue Nov 12 11:01:06 UTC 2019 - Fabian Vogt <[email protected]> + +- Update to 5.17.3 + * New bugfix release + * For more details please see: + * https://www.kde.org/announcements/plasma-5.17.3.php +- Changes since 5.17.2: + * move plus character in query test to connection + * force encoding on all queries + * force-encode passwords on login (kde#413920) + +------------------------------------------------------------------- Old: ---- drkonqi-5.17.2.tar.xz drkonqi-5.17.2.tar.xz.sig New: ---- drkonqi-5.17.3.tar.xz drkonqi-5.17.3.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ drkonqi5.spec ++++++ --- /var/tmp/diff_new_pack.XAzzMr/_old 2019-11-15 22:34:06.200025210 +0100 +++ /var/tmp/diff_new_pack.XAzzMr/_new 2019-11-15 22:34:06.200025210 +0100 @@ -23,7 +23,7 @@ %{!?_plasma5_bugfix: %define _plasma5_bugfix %{version}} # Latest ABI-stable Plasma (e.g. 5.8 in KF5, but 5.9.1 in KUF) %{!?_plasma5_version: %define _plasma5_version %(echo %{_plasma5_bugfix} | awk -F. '{print $1"."$2}')} -Version: 5.17.2 +Version: 5.17.3 Release: 0 Summary: Helper for debugging and reporting crashes License: GPL-2.0-or-later ++++++ drkonqi-5.17.2.tar.xz -> drkonqi-5.17.3.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/drkonqi-5.17.2/CMakeLists.txt new/drkonqi-5.17.3/CMakeLists.txt --- old/drkonqi-5.17.2/CMakeLists.txt 2019-10-29 19:08:06.000000000 +0100 +++ new/drkonqi-5.17.3/CMakeLists.txt 2019-11-12 11:11:45.000000000 +0100 @@ -1,7 +1,7 @@ cmake_minimum_required(VERSION 3.0) project(drkonqi) -set(PROJECT_VERSION "5.17.2") +set(PROJECT_VERSION "5.17.3") set(PROJECT_VERSION_MAJOR 5) set(QT_MIN_VERSION "5.12.0") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/drkonqi-5.17.2/po/cs/drkonqi5.po new/drkonqi-5.17.3/po/cs/drkonqi5.po --- old/drkonqi-5.17.2/po/cs/drkonqi5.po 2019-10-29 19:07:49.000000000 +0100 +++ new/drkonqi-5.17.3/po/cs/drkonqi5.po 2019-11-12 11:11:35.000000000 +0100 @@ -17,7 +17,7 @@ "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" "Plural-Forms: nplurals=3; plural=(n==1) ? 0 : (n>=2 && n<=4) ? 1 : 2;\n" -"X-Generator: Lokalize 19.08.0\n" +"X-Generator: Lokalize 19.08.2\n" #, kde-format msgctxt "NAME OF TRANSLATORS" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/drkonqi-5.17.2/po/it/drkonqi5.po new/drkonqi-5.17.3/po/it/drkonqi5.po --- old/drkonqi-5.17.2/po/it/drkonqi5.po 2019-10-29 19:07:54.000000000 +0100 +++ new/drkonqi-5.17.3/po/it/drkonqi5.po 2019-11-12 11:11:38.000000000 +0100 @@ -19,7 +19,7 @@ "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" "Plural-Forms: nplurals=2; plural=(n != 1);\n" -"X-Generator: Lokalize 19.08.0\n" +"X-Generator: Lokalize 19.08.2\n" #, kde-format msgctxt "NAME OF TRANSLATORS" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/drkonqi-5.17.2/src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp new/drkonqi-5.17.3/src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp --- old/drkonqi-5.17.2/src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp 2019-10-29 19:07:38.000000000 +0100 +++ new/drkonqi-5.17.3/src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp 2019-11-12 11:11:30.000000000 +0100 @@ -78,7 +78,13 @@ qDebug() << httpBlob; // The query is important to see if this actually gets properly // passed along! - if (httpBlob.startsWith("GET /hi?informal=yes")) { + // Reason it has a plus: + // https://bugs.kde.org/show_bug.cgi?id=413920 + // QUrlQuery doesn't encode plus characters, bugzilla serverside however + // needs it encoded which is a bit weird because it doesn't actually + // require full-form encoding either (i.e. space becomes plus and + // plus becomes encoded). + if (httpBlob.startsWith("GET /hi?informal=yes%2Bcertainly")) { QFile file(QFINDTESTDATA("data/hi.http")); file.open(QFile::ReadOnly | QFile::Text); socket->write(file.readAll()); @@ -95,7 +101,7 @@ root.setPort(t.serverPort()); HTTPConnection c(root); QUrlQuery query; - query.addQueryItem("informal", "yes"); + query.addQueryItem("informal", "yes+certainly"); auto job = c.get("/hi", query); job->exec(); QCOMPARE(job->data(), "Hello!\n"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/drkonqi-5.17.2/src/bugzillaintegration/libbugzilla/connection.cpp new/drkonqi-5.17.3/src/bugzillaintegration/libbugzilla/connection.cpp --- old/drkonqi-5.17.2/src/bugzillaintegration/libbugzilla/connection.cpp 2019-10-29 19:07:38.000000000 +0100 +++ new/drkonqi-5.17.3/src/bugzillaintegration/libbugzilla/connection.cpp 2019-11-12 11:11:30.000000000 +0100 @@ -106,7 +106,17 @@ query.addQueryItem(QStringLiteral("token"), m_token); } - url.setQuery(query); + // https://bugs.kde.org/show_bug.cgi?id=413920 + // Force encoding. QUrlQuery by default wouldn't encode '+' and bugzilla doesn't like that... + // For any query argument. Tested with username, password, and products (for bug search) + // on bugzilla 5.0.6. As a result let's force full encoding on every argument. + QUrlQuery escapedQuery(query); // copy delimiter properties and the like + escapedQuery.clear(); // but then throw away the values + for (const auto &pair : query.queryItems(QUrl::FullyDecoded)) { + escapedQuery.addQueryItem(pair.first, QString::fromUtf8(QUrl::toPercentEncoding(pair.second))); + } + + url.setQuery(escapedQuery); return url; }
