Hello community, here is the log from the commit of package konsole for openSUSE:Factory checked in at 2019-11-15 22:37:40 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/konsole (Old) and /work/SRC/openSUSE:Factory/.konsole.new.26869 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "konsole" Fri Nov 15 22:37:40 2019 rev:117 rq:748907 version:19.08.3 Changes: -------- --- /work/SRC/openSUSE:Factory/konsole/konsole.changes 2019-11-12 11:38:15.658274036 +0100 +++ /work/SRC/openSUSE:Factory/.konsole.new.26869/konsole.changes 2019-11-15 22:37:42.284018993 +0100 @@ -1,0 +2,6 @@ +Fri Nov 15 06:16:30 UTC 2019 - Wolfgang Bauer <[email protected]> + +- Add Fix-tabs-not-indicating-activity.patch to fix indicating + activity in background tabs (kde#406828) + +------------------------------------------------------------------- New: ---- Fix-tabs-not-indicating-activity.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ konsole.spec ++++++ --- /var/tmp/diff_new_pack.FNNtuU/_old 2019-11-15 22:37:43.520022999 +0100 +++ /var/tmp/diff_new_pack.FNNtuU/_new 2019-11-15 22:37:43.536023051 +0100 @@ -42,6 +42,8 @@ Source26: utilities-terminal-su-128.png # PATCH-FIX-OPENSUSE Patch0: fix-build-with-gcc48.patch +# PATCH-FIX-UPSTREAM +Patch1: Fix-tabs-not-indicating-activity.patch BuildRequires: fdupes BuildRequires: kbookmarks-devel BuildRequires: kcompletion-devel @@ -115,6 +117,7 @@ %if 0%{?suse_version} < 1500 %patch0 -p1 %endif +%patch1 -p1 %build %cmake_kf5 -d build ++++++ Fix-tabs-not-indicating-activity.patch ++++++ >From 69a8a99d15eef1a3cc7782cc8ff5df132b997cd1 Mon Sep 17 00:00:00 2001 From: Petr Velan <[email protected]> Date: Thu, 7 Nov 2019 09:18:30 -0500 Subject: Fix tabs not indicating activity Summary: This fixes the bug with tabs not indicating terminal activity. When the tab is split and has multiple child terminals, activity in any of the child terminals will be indicated. BUG: 406828 FIXED-IN: 19.12.0 Test Plan: Open two tabs, run `sleep 2` in the first one and switch to the other. After the sleep ends, the tab activity is indicated just as it was before the bug was introduced. Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: hindenburg, anthonyfieroni, nucleo, konsole-devel, #konsole Tags: #konsole Differential Revision: https://phabricator.kde.org/D25151 --- src/ViewContainer.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ViewContainer.cpp b/src/ViewContainer.cpp index 8115730..5002c97 100644 --- a/src/ViewContainer.cpp +++ b/src/ViewContainer.cpp @@ -543,7 +543,9 @@ void TabbedViewContainer::setTabActivity(int index, bool activity) void TabbedViewContainer::updateActivity(ViewProperties *item) { auto controller = qobject_cast<SessionController*>(item); - auto index = indexOf(controller->view()); + auto topLevelSplitter = qobject_cast<ViewSplitter*>(controller->view()->parentWidget())->getToplevelSplitter(); + + const int index = indexOf(topLevelSplitter); if (index != currentIndex()) { setTabActivity(index, true); } -- cgit v1.1
