Hello community,

here is the log from the commit of package gnome-shell-extension-desktop-icons 
for openSUSE:Factory checked in at 2019-11-24 00:16:49
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gnome-shell-extension-desktop-icons (Old)
 and      
/work/SRC/openSUSE:Factory/.gnome-shell-extension-desktop-icons.new.26869 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "gnome-shell-extension-desktop-icons"

Sun Nov 24 00:16:49 2019 rev:2 rq:749285 version:19.10.2

Changes:
--------
--- 
/work/SRC/openSUSE:Factory/gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons.changes
  2019-10-09 15:20:04.976401545 +0200
+++ 
/work/SRC/openSUSE:Factory/.gnome-shell-extension-desktop-icons.new.26869/gnome-shell-extension-desktop-icons.changes
       2019-11-24 00:16:50.591143698 +0100
@@ -1,0 +2,17 @@
+Thu Nov 14 19:25:20 UTC 2019 - Bjørn Lie <[email protected]>
+
+- Drop superfluous tarball, we use sourceservice during build.
+
+-------------------------------------------------------------------
+Wed Nov 13 06:34:34 UTC 2019 - Xiaoguang Wang <[email protected]>
+
+- Update to version 19.10.2:
+  * desktopGrid.js: fix rename button
+  * General: Fix thumbnails not centered
+  * desktopGrid: Properly inherit Placeholder from a GObject class
+  * desktopGrid: Use default upstream styling for rename popup
+  * desktopGrid: Derive the RenamePoup from PopupMenu
+  * desktopGrid: Open the rename popup only when item menu is 
+    closed
+
+-------------------------------------------------------------------

Old:
----
  desktop-icons-19.10.1.obscpio
  desktop-icons-19.10.1.tar.xz

New:
----
  desktop-icons-19.10.2.obscpio

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ gnome-shell-extension-desktop-icons.spec ++++++
--- /var/tmp/diff_new_pack.IA3TR3/_old  2019-11-24 00:16:51.359143777 +0100
+++ /var/tmp/diff_new_pack.IA3TR3/_new  2019-11-24 00:16:51.363143778 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package gnome-shell-extension-desktop-icons
 #
-# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LLC.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
 
 
 Name:           gnome-shell-extension-desktop-icons
-Version:        19.10.1
+Version:        19.10.2
 Release:        0
 Summary:        Desktop icon support for GNOME Shell
 License:        GPL-3.0-or-later

++++++ _service ++++++
--- /var/tmp/diff_new_pack.IA3TR3/_old  2019-11-24 00:16:51.391143781 +0100
+++ /var/tmp/diff_new_pack.IA3TR3/_new  2019-11-24 00:16:51.391143781 +0100
@@ -2,7 +2,7 @@
   <service name="obs_scm" mode="disabled" >
     <param 
name="url">https://gitlab.gnome.org/World/ShellExtensions/desktop-icons.git</param>
     <param name="scm">git</param>
-    <param name="revision">19.10.1</param>
+    <param name="revision">19.10.2</param>
     <param name="versionformat">@PARENT_TAG@</param>
     <param name="changesgenerate">enable</param>
     <param name="changesauthor">suse</param>

++++++ _servicedata ++++++
--- /var/tmp/diff_new_pack.IA3TR3/_old  2019-11-24 00:16:51.403143782 +0100
+++ /var/tmp/diff_new_pack.IA3TR3/_new  2019-11-24 00:16:51.403143782 +0100
@@ -1,4 +1,4 @@
 <servicedata>
 <service name="tar_scm">
                 <param 
name="url">https://gitlab.gnome.org/World/ShellExtensions/desktop-icons.git</param>
-              <param 
name="changesrevision">049b5f652859723d52ff2db6790d4c65ac529340</param></service></servicedata>
\ No newline at end of file
+              <param 
name="changesrevision">b1768a8eff6bf38f471d15b292f59515d41bd4b4</param></service></servicedata>
\ No newline at end of file

++++++ desktop-icons-19.10.1.obscpio -> desktop-icons-19.10.2.obscpio ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/desktop-icons-19.10.1/desktopGrid.js 
new/desktop-icons-19.10.2/desktopGrid.js
--- old/desktop-icons-19.10.1/desktopGrid.js    2019-10-03 00:27:27.000000000 
+0200
+++ new/desktop-icons-19.10.2/desktopGrid.js    2019-10-10 00:15:54.000000000 
+0200
@@ -21,6 +21,7 @@
 const St = imports.gi.St;
 const Gio = imports.gi.Gio;
 const GLib = imports.gi.GLib;
+const GObject = imports.gi.GObject;
 const Shell = imports.gi.Shell;
 
 const Signals = imports.signals;
@@ -62,11 +63,10 @@
     ASSIGN:2,
 };
 
-class Placeholder extends St.Bin {
-    constructor() {
-        super();
-    }
-}
+var Placeholder = GObject.registerClass({
+    GTypeName: 'DesktopIcons_Placeholder',
+}, class Placeholder extends St.Bin {
+});
 
 var DesktopGrid = class {
 
@@ -92,6 +92,11 @@
         });
         this.actor._delegate = this;
 
+        this.actor.connect('style-changed', () => {
+            if (this.isFirst)
+                Extension.desktopManager.scheduleReLayoutChildren();
+        });
+
         this._grid = new St.Widget({
             name: 'DesktopGrid',
             layout_manager: this.layout,
@@ -103,8 +108,7 @@
         });
         this.actor.add_child(this._grid);
 
-        this._renamePopup = new RenamePopup(this);
-        this.actor.add_child(this._renamePopup.actor);
+        this._menuManager = new PopupMenu.PopupMenuManager(this.actor);
 
         this._bgManager._container.add_child(this.actor);
 
@@ -127,6 +131,22 @@
         this._grid.connect('key-press-event', this._onKeyPress.bind(this));
 
         this._grid.connect('allocation-changed', () => 
Extension.desktopManager.scheduleReLayoutChildren());
+
+        let themeNodeBase = this.actor.get_theme_node();
+        let themeContext = St.ThemeContext.get_for_stage(global.stage);
+        let themeNode = St.ThemeNode.new(themeContext, null,
+            themeNodeBase.get_theme(), themeNodeBase.get_element_type(),
+            null, "file-item", null, "fake-id {}");
+        this._extra_width =  themeNode.get_margin(St.Side.LEFT) +
+                             themeNode.get_margin(St.Side.RIGHT) +
+                             themeNode.get_border_width(St.Side.LEFT) +
+                             themeNode.get_border_width(St.Side.RIGHT) +
+                             themeNode.get_horizontal_padding();
+        this._extra_height = themeNode.get_margin(St.Side.TOP) +
+                             themeNode.get_margin(St.Side.BOTTOM) +
+                             themeNode.get_border_width(St.Side.TOP) +
+                             themeNode.get_border_width(St.Side.BOTTOM) +
+                             themeNode.get_vertical_padding();
     }
 
     _onKeyPress(actor, event) {
@@ -190,6 +210,7 @@
             this._bgManager.backgroundActor.disconnect(this._bgDestroyedId);
         this._bgDestroyedId = 0;
         this._bgManager = null;
+        this._menuManager = null;
     }
 
     _onNewFolderClicked() {
@@ -372,7 +393,7 @@
         /* Since the handler is in the press event it needs to ignore the 
release event
          * to not immediately close the menu on release
          */
-        this.actor._desktopBackgroundManager.ignoreRelease();
+        this._menuManager.ignoreRelease();
     }
 
     _addFileItemTo(fileItem, column, row, coordinatesAction) {
@@ -380,7 +401,7 @@
         placeholder.child = fileItem.actor;
         this._fileItems.push(fileItem);
         let selectedId = fileItem.connect('selected', 
this._onFileItemSelected.bind(this));
-        let renameId = fileItem.connect('rename-clicked', 
this.doRename.bind(this));
+        let renameId = fileItem.connect('rename-clicked', 
this._onRenameClicked.bind(this));
         this._fileItemHandlers.set(fileItem, [selectedId, renameId]);
 
         /* If this file is new in the Desktop and hasn't yet
@@ -397,6 +418,7 @@
 
     addFileItemCloseTo(fileItem, x, y, coordinatesAction) {
         let [column, row] = this._getEmptyPlaceClosestTo(x, y, 
coordinatesAction);
+        fileItem.set_margins(this._extra_width, this._extra_height);
         this._addFileItemTo(fileItem, column, row, coordinatesAction);
     }
 
@@ -511,27 +533,27 @@
     }
 
     _addDesktopBackgroundMenu() {
-        let popupManagerArgs = ExtensionUtils.versionCheck(['3.28', '3.30', 
'3.32'], Config.PACKAGE_VERSION) ?
-            { actor: this.actor } : this.actor;
         this.actor._desktopBackgroundMenu = 
this._createDesktopBackgroundMenu();
-        this.actor._desktopBackgroundManager = new 
PopupMenu.PopupMenuManager(popupManagerArgs);
-        
this.actor._desktopBackgroundManager.addMenu(this.actor._desktopBackgroundMenu);
+        this._menuManager.addMenu(this.actor._desktopBackgroundMenu);
 
         this.actor.connect('destroy', () => {
             this.actor._desktopBackgroundMenu.destroy();
             this.actor._desktopBackgroundMenu = null;
-            this.actor._desktopBackgroundManager = null;
         });
     }
 
     _getMaxColumns() {
         let gridWidth = this._grid.allocation.x2 - this._grid.allocation.x1;
-        return Math.floor(gridWidth / 
Prefs.get_desired_width(St.ThemeContext.get_for_stage(global.stage).scale_factor));
+        let scaleFactor = 
St.ThemeContext.get_for_stage(global.stage).scale_factor;
+        let desiredWidth = Prefs.getDesiredWidth(scaleFactor, 
this._extra_width);
+        return Math.floor(gridWidth / desiredWidth);
     }
 
     _getMaxRows() {
         let gridHeight = this._grid.allocation.y2 - this._grid.allocation.y1;
-        return Math.floor(gridHeight / 
Prefs.get_desired_height(St.ThemeContext.get_for_stage(global.stage).scale_factor));
+        let scaleFactor = 
St.ThemeContext.get_for_stage(global.stage).scale_factor;
+        let desiredHeight = Prefs.getDesiredHeight(scaleFactor, 
this._extra_height);
+        return Math.floor(gridHeight / desiredHeight);
     }
 
     acceptDrop(source, actor, x, y, time) {
@@ -574,129 +596,142 @@
         this._grid.grab_key_focus();
     }
 
-    doRename(fileItem) {
-        this._renamePopup.onFileItemRenameClicked(fileItem);
+    _onRenameClicked(fileItem) {
+        if (fileItem.menu && fileItem.menu.isOpen) {
+            let id = fileItem.menu.connect('menu-closed', () => {
+                fileItem.menu.disconnect(id);
+                this.doRename(fileItem);
+            });
+        } else {
+            this.doRename(fileItem);
+        }
     }
-};
-
-var RenamePopup = class {
-
-    constructor(grid) {
-        this._source = null;
-        this._isOpen = false;
-
-        this._renameEntry = new St.Entry({ hint_text: _("Enter file name…"),
-                                           can_focus: true,
-                                           x_expand: true });
-        this._renameEntry.clutter_text.connect('activate', 
this._onRenameAccepted.bind(this));
-        this._renameOkButton= new St.Button({ label: _("OK"),
-                                              style_class: 'app-view-control 
button',
-                                              button_mask: St.ButtonMask.ONE | 
St.ButtonMask.THREE,
-                                              reactive: true,
-                                              can_focus: true,
-                                              x_expand: true });
-        this._renameCancelButton = new St.Button({ label: _("Cancel"),
-                                                   style_class: 
'app-view-control button',
-                                                   button_mask: 
St.ButtonMask.ONE | St.ButtonMask.THREE,
-                                                   reactive: true,
-                                                   can_focus: true,
-                                                   x_expand: true });
-        this._renameCancelButton.connect('clicked', () => { 
this._onRenameCanceled(); });
-        this._renameOkButton.connect('clicked', () => { 
this._onRenameAccepted(); });
-        let renameButtonsBoxLayout = new Clutter.BoxLayout({ homogeneous: true 
});
-        let renameButtonsBox = new St.Widget({ layout_manager: 
renameButtonsBoxLayout,
-                                               x_expand: true });
-        renameButtonsBox.add_child(this._renameCancelButton);
-        renameButtonsBox.add_child(this._renameOkButton);
-
-        let renameContentLayout = new Clutter.BoxLayout({ spacing: 6,
-                                                          orientation: 
Clutter.Orientation.VERTICAL });
-        let renameContent = new St.Widget({ style_class: 'rename-popup',
-                                            layout_manager: 
renameContentLayout,
-                                            x_expand: true });
-        renameContent.add_child(this._renameEntry);
-        renameContent.add_child(renameButtonsBox);
-
-        this._boxPointer = new BoxPointer.BoxPointer(St.Side.TOP, { can_focus: 
false, x_expand: false });
-        if (ExtensionUtils.versionCheck(['3.28', '3.30', '3.32'], 
Config.PACKAGE_VERSION))
-            this.actor = this._boxPointer.actor;
-        else
-            this.actor = this._boxPointer;
 
-        this.actor.style_class = 'popup-menu-boxpointer';
-        this.actor.add_style_class_name('popup-menu');
-        this.actor.visible = false;
-        this._boxPointer.bin.set_child(renameContent);
+    doRename(fileItem) {
+        let renamePopup = new RenamePopup(fileItem);
+        this._menuManager.addMenu(renamePopup);
+        this._menuManager.ignoreRelease();
 
-        this._grabHelper = new GrabHelper.GrabHelper(grid.actor, { actionMode: 
Shell.ActionMode.POPUP });
-        this._grabHelper.addActor(this.actor);
+        renamePopup.connect('menu-closed', () => renamePopup.destroy());
+        renamePopup.open();
     }
+};
 
-    _popup() {
-        if (this._isOpen)
-            return;
-
-        this._isOpen = this._grabHelper.grab({ actor: this.actor,
-                                               onUngrab: 
this._popdown.bind(this) });
-
-        if (!this._isOpen) {
-            this._grabHelper.ungrab({ actor: this.actor });
-            return;
-        }
+var RenamePopupMenuItem = GObject.registerClass(
+class RenamePopupMenuItem extends PopupMenu.PopupBaseMenuItem {
+    _init(fileItem) {
+        super._init({
+            style_class: 'rename-popup-item',
+            reactive: false,
+        });
 
-        this._boxPointer.setPosition(this._source.actor, 0.5);
-        if (ExtensionUtils.versionCheck(['3.28', '3.30'], 
Config.PACKAGE_VERSION))
-            this._boxPointer.show(BoxPointer.PopupAnimation.FADE |
-                                  BoxPointer.PopupAnimation.SLIDE);
-        else
-            this._boxPointer.open(BoxPointer.PopupAnimation.FADE |
-                                  BoxPointer.PopupAnimation.SLIDE);
+        if (PopupMenu.Ornament.HIDDEN !== undefined)
+            this.setOrnament(PopupMenu.Ornament.HIDDEN);
+        else /* Support version prior 3.34.1 */
+            this._ornamentLabel.visible = false;
+
+        this._fileItem = fileItem;
+
+        // Entry
+        this._entry = new St.Entry({
+            hint_text: _("Enter file name…"),
+            x_expand: true,
+            width: 200,
+        });
+        this.add_child(this._entry);
 
-        this.emit('open-state-changed', true);
+        this._entry.clutter_text.connect(
+            'notify::text', this._validate.bind(this));
+        this._entry.clutter_text.connect(
+            'activate', this._onRenameAccepted.bind(this));
+
+        // Rename button
+        this._button = new St.Button({
+            style_class: 'button',
+            reactive: true,
+            button_mask: St.ButtonMask.ONE | St.ButtonMask.TWO,
+            can_focus: true,
+            label: _('Rename'),
+        });
+        this.add_child(this._button);
+        this._button.connect('clicked', this._onRenameAccepted.bind(this));
     }
 
-    _popdown() {
-        if (!this._isOpen)
-            return;
-
-        this._grabHelper.ungrab({ actor: this.actor });
-
-        if (ExtensionUtils.versionCheck(['3.28', '3.30'], 
Config.PACKAGE_VERSION))
-            this._boxPointer.hide(BoxPointer.PopupAnimation.FADE |
-                                   BoxPointer.PopupAnimation.SLIDE);
-        else
-            this._boxPointer.close(BoxPointer.PopupAnimation.FADE |
-                                  BoxPointer.PopupAnimation.SLIDE);
+    vfunc_map() {
+        this._entry.text = this._fileItem.displayName;
+        this._entry.clutter_text.set_selection(0, -1);
+        super.vfunc_map();
+    }
 
-        this._isOpen = false;
-        this.emit('open-state-changed', false);
+    vfunc_key_focus_in() {
+        super.vfunc_key_focus_in();
+        this._entry.clutter_text.grab_key_focus();
     }
 
-    onFileItemRenameClicked(fileItem) {
-        this._source = fileItem;
+    _isValidFolderName() {
+        let newName = this._entry.text.trim();
 
-        this._renameEntry.text = fileItem.displayName;
+        return newName.length > 0 && newName.indexOf('/') === -1 &&
+               newName != this._fileItem.displayName;
+    }
 
-        this._popup();
-        this._renameEntry.grab_key_focus();
-        this._renameEntry.navigate_focus(null, Gtk.DirectionType.TAB_FORWARD, 
false);
-        let extensionOffset = 
DesktopIconsUtil.getFileExtensionOffset(fileItem.displayName, 
fileItem.isDirectory);
-        this._renameEntry.clutter_text.set_selection(0, extensionOffset);
+    _validate() {
+        this._button.reactive = this._isValidFolderName();
     }
 
     _onRenameAccepted() {
-        this._popdown();
-        
DBusUtils.NautilusFileOperationsProxy.RenameFileRemote(this._source.file.get_uri(),
-                                                               
this._renameEntry.get_text(),
+        if (!this._isValidFolderName())
+            return;
+
+        DBusUtils.NautilusFileOperationsProxy.RenameFileRemote(
+            this._fileItem.file.get_uri(),
+            this._entry.text.trim(),
             (result, error) => {
                 if (error)
                     throw new Error('Error renaming file: ' + error.message);
             }
         );
+
+        this.activate(Clutter.get_current_event());
     }
+});
+
+var RenamePopup = class RenameFolderMenu extends PopupMenu.PopupMenu {
+    constructor(fileItem) {
+        super(fileItem.actor, 0.5, St.Side.TOP);
+        this.actor.add_style_class_name('rename-popup');
+
+        // We want to keep the item hovered while the menu is up
+        this.blockSourceEvents = true;
+
+        let menuItem = new RenamePopupMenuItem(fileItem);
+        this.addMenuItem(menuItem);
+
+        if (this.focusActor !== undefined) {
+            // Focus the text entry on menu pop-up, works starting 3.34.1
+            this.focusActor = menuItem;
+        } else {
+            this.connect('open-state-changed', (_menu, state) => {
+                if (state)
+                    this._openId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
+                        delete this._openId;
+                        menuItem.grab_key_focus()
+                    });
+                else if (this._openId)
+                    GLib.source_remove(this._openId);
+            });
+        }
+
+        // Chain our visibility and lifecycle to that of the fileItem source
+        this._fileItemMappedId = fileItem.actor.connect('notify::mapped', () 
=> {
+            if (!fileItem.actor.mapped)
+                this.close();
+        });
+        fileItem.actor.connect('destroy', () => {
+            fileItem.actor.disconnect(this._fileItemMappedId);
+            this.destroy();
+        });
 
-    _onRenameCanceled() {
-        this._popdown();
+        Main.uiGroup.add_actor(this.actor);
     }
 };
-Signals.addSignalMethods(RenamePopup.prototype);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/desktop-icons-19.10.1/desktopManager.js 
new/desktop-icons-19.10.2/desktopManager.js
--- old/desktop-icons-19.10.1/desktopManager.js 2019-10-03 00:27:27.000000000 
+0200
+++ new/desktop-icons-19.10.2/desktopManager.js 2019-10-10 00:15:54.000000000 
+0200
@@ -183,6 +183,7 @@
     }
 
     _addDesktopIcons() {
+        let first_element = true;
         forEachBackgroundManager(bgManager => {
             let newGrid = new DesktopGrid.DesktopGrid(bgManager);
             newGrid.actor.connect('destroy', (actor) => {
@@ -193,6 +194,8 @@
                         break;
                     }
             });
+            newGrid.isFirst = first_element;
+            first_element = false;
             this._desktopGrids[bgManager._monitorIndex] = newGrid;
         });
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/desktop-icons-19.10.1/fileItem.js 
new/desktop-icons-19.10.2/fileItem.js
--- old/desktop-icons-19.10.1/fileItem.js       2019-10-03 00:27:27.000000000 
+0200
+++ new/desktop-icons-19.10.2/fileItem.js       2019-10-10 00:15:54.000000000 
+0200
@@ -79,8 +79,6 @@
         this.actor = new St.Bin({ visible: true });
         this.actor.set_fill(true, true);
         let scaleFactor = 
St.ThemeContext.get_for_stage(global.stage).scale_factor;
-        this.actor.set_height(Prefs.get_desired_height(scaleFactor));
-        this.actor.set_width(Prefs.get_desired_width(scaleFactor));
         this.actor._delegate = this;
         this.actor.connect('destroy', () => this._onDestroy());
 
@@ -158,6 +156,12 @@
         });
     }
 
+    set_margins(width, height) {
+        let scaleFactor = 
St.ThemeContext.get_for_stage(global.stage).scale_factor;
+        this.actor.set_width(Prefs.getDesiredWidth(scaleFactor, width));
+        this.actor.set_height(Prefs.getDesiredHeight(scaleFactor, height));
+    }
+
     onAttributeChanged() {
         if (this._isDesktopFile) {
             this._refreshMetadataAsync(true);
@@ -334,7 +338,7 @@
                                 );
                                 let icon = new Clutter.Actor();
                                 icon.set_content(thumbnailImage);
-                                let width = 
Prefs.get_desired_width(scaleFactor);
+                                let width = Prefs.getDesiredWidth(scaleFactor, 
0);
                                 let height = Prefs.get_icon_size() * 
scaleFactor;
                                 let aspectRatio = thumbnailPixbuf.width / 
thumbnailPixbuf.height;
                                 if ((width / height) > aspectRatio)
@@ -571,6 +575,10 @@
                'border-color: ' + border_color + ';'
     }
 
+    get menu() {
+        return this._menu;
+    }
+
     _removeMenu() {
         if (this._menu != null) {
             if (this._menuManager != null)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/desktop-icons-19.10.1/meson.build 
new/desktop-icons-19.10.2/meson.build
--- old/desktop-icons-19.10.1/meson.build       2019-10-03 00:27:27.000000000 
+0200
+++ new/desktop-icons-19.10.2/meson.build       2019-10-10 00:15:54.000000000 
+0200
@@ -1,5 +1,5 @@
 project('desktop-icons',
-  version: '19.10.1',
+  version: '19.10.2',
   license: 'GPL3'
 )
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/desktop-icons-19.10.1/prefs.js 
new/desktop-icons-19.10.2/prefs.js
--- old/desktop-icons-19.10.1/prefs.js  2019-10-03 00:27:27.000000000 +0200
+++ new/desktop-icons-19.10.2/prefs.js  2019-10-10 00:15:54.000000000 +0200
@@ -33,8 +33,8 @@
 const SCHEMA = 'org.gnome.shell.extensions.desktop-icons';
 
 const ICON_SIZE = { 'small': 48, 'standard': 64, 'large': 96 };
-const ICON_WIDTH = { 'small': 120, 'standard': 128, 'large': 128 };
-const ICON_HEIGHT = { 'small': 98, 'standard': 114, 'large': 146 };
+const ICON_WIDTH = { 'small': 108, 'standard': 116, 'large': 116 };
+const ICON_HEIGHT = { 'small': 86, 'standard': 102, 'large': 134 };
 
 var FileType = {
     NONE: null,
@@ -150,10 +150,10 @@
     return ICON_SIZE[settings.get_string('icon-size')];
 }
 
-function get_desired_width(scale_factor) {
-    return ICON_WIDTH[settings.get_string('icon-size')] * scale_factor;
+function getDesiredWidth(scale_factor, margin) {
+    return (ICON_WIDTH[settings.get_string('icon-size')] + margin) * 
scale_factor;
 }
 
-function get_desired_height(scale_factor) {
-    return ICON_HEIGHT[settings.get_string('icon-size')] * scale_factor;
+function getDesiredHeight(scale_factor, margin) {
+    return (ICON_HEIGHT[settings.get_string('icon-size')] + margin) * 
scale_factor;
 }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/desktop-icons-19.10.1/stylesheet.css 
new/desktop-icons-19.10.2/stylesheet.css
--- old/desktop-icons-19.10.1/stylesheet.css    2019-10-03 00:27:27.000000000 
+0200
+++ new/desktop-icons-19.10.2/stylesheet.css    2019-10-10 00:15:54.000000000 
+0200
@@ -23,6 +23,14 @@
     margin: 6px;
 }
 
+.rename-popup .rename-popup-item {
+  spacing: 6px;
+}
+.rename-popup .rename-popup-item:ltr,
+.rename-popup .rename-popup-item:rtl {
+    padding: 0, 12px;
+}
+
 .create-folder-dialog-entry {
     width: 20em;
     margin-bottom: 6px;

++++++ desktop-icons.obsinfo ++++++
--- /var/tmp/diff_new_pack.IA3TR3/_old  2019-11-24 00:16:51.547143797 +0100
+++ /var/tmp/diff_new_pack.IA3TR3/_new  2019-11-24 00:16:51.547143797 +0100
@@ -1,5 +1,5 @@
 name: desktop-icons
-version: 19.10.1
-mtime: 1570055247
-commit: 049b5f652859723d52ff2db6790d4c65ac529340
+version: 19.10.2
+mtime: 1570659354
+commit: b1768a8eff6bf38f471d15b292f59515d41bd4b4
 


Reply via email to