Hello community, here is the log from the commit of package kfilemetadata5 for openSUSE:Factory checked in at 2019-12-18 14:40:52 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kfilemetadata5 (Old) and /work/SRC/openSUSE:Factory/.kfilemetadata5.new.4691 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kfilemetadata5" Wed Dec 18 14:40:52 2019 rev:79 rq:757032 version:5.65.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kfilemetadata5/kfilemetadata5.changes 2019-11-12 11:46:27.562790600 +0100 +++ /work/SRC/openSUSE:Factory/.kfilemetadata5.new.4691/kfilemetadata5.changes 2019-12-18 14:42:44.197785432 +0100 @@ -1,0 +2,11 @@ +Sun Dec 8 11:18:32 UTC 2019 - Christophe Giboudeaux <christo...@krop.fr> + +- Update to 5.65.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.65.0.php +- Changes since 5.64.0: + * xattr: fix crash on dangling symlinks (kde#414227) + * disable writercollectiontest when taglib is not installed + +------------------------------------------------------------------- Old: ---- kfilemetadata-5.64.0.tar.xz kfilemetadata-5.64.0.tar.xz.sig New: ---- kfilemetadata-5.65.0.tar.xz kfilemetadata-5.65.0.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kfilemetadata5.spec ++++++ --- /var/tmp/diff_new_pack.k8zg1V/_old 2019-12-18 14:42:44.609785620 +0100 +++ /var/tmp/diff_new_pack.k8zg1V/_new 2019-12-18 14:42:44.613785622 +0100 @@ -1,7 +1,7 @@ # # spec file for package kfilemetadata5 # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -16,7 +16,7 @@ # -%define _tar_path 5.64 +%define _tar_path 5.65 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) @@ -24,7 +24,7 @@ %bcond_without ffmpeg %bcond_without lang Name: kfilemetadata5 -Version: 5.64.0 +Version: 5.65.0 Release: 0 Summary: Library for extracting Metadata License: GPL-2.0-or-later AND LGPL-2.1-or-later AND LGPL-3.0-only ++++++ kfilemetadata-5.64.0.tar.xz -> kfilemetadata-5.65.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.64.0/CMakeLists.txt new/kfilemetadata-5.65.0/CMakeLists.txt --- old/kfilemetadata-5.64.0/CMakeLists.txt 2019-11-02 13:55:38.000000000 +0100 +++ new/kfilemetadata-5.65.0/CMakeLists.txt 2019-12-12 23:37:05.000000000 +0100 @@ -1,11 +1,11 @@ cmake_minimum_required(VERSION 3.5) -set(KF5_VERSION "5.64.0") # handled by release scripts -set(KF5_DEP_VERSION "5.64.0") # handled by release scripts +set(KF5_VERSION "5.65.0") # handled by release scripts +set(KF5_DEP_VERSION "5.65.0") # handled by release scripts project(KFileMetaData VERSION ${KF5_VERSION}) include(FeatureSummary) -find_package(ECM 5.64.0 NO_MODULE) +find_package(ECM 5.65.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -117,7 +117,7 @@ ) add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00) -add_definitions(-DQT_DEPRECATED_WARNINGS_SINCE=0x060000) +add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00) add_definitions(-DTRANSLATION_DOMAIN=\"kfilemetadata5\") add_definitions(-DQT_NO_FOREACH) add_subdirectory(src) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.64.0/autotests/CMakeLists.txt new/kfilemetadata-5.65.0/autotests/CMakeLists.txt --- old/kfilemetadata-5.64.0/autotests/CMakeLists.txt 2019-11-02 13:55:38.000000000 +0100 +++ new/kfilemetadata-5.65.0/autotests/CMakeLists.txt 2019-12-12 23:37:05.000000000 +0100 @@ -166,14 +166,16 @@ LINK_LIBRARIES Qt5::Test KF5::FileMetaData ) -set(writercollection_SRCS - writercollectiontest.cpp -) +if(TAGLIB_FOUND) + set(writercollection_SRCS + writercollectiontest.cpp + ) -ecm_add_test(${writercollection_SRCS} - TEST_NAME "writercollectiontest" - LINK_LIBRARIES Qt5::Test KF5::FileMetaData -) + ecm_add_test(${writercollection_SRCS} + TEST_NAME "writercollectiontest" + LINK_LIBRARIES Qt5::Test KF5::FileMetaData + ) +endif() # # XML diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.64.0/autotests/usermetadatawritertest.cpp new/kfilemetadata-5.65.0/autotests/usermetadatawritertest.cpp --- old/kfilemetadata-5.64.0/autotests/usermetadatawritertest.cpp 2019-11-02 13:55:38.000000000 +0100 +++ new/kfilemetadata-5.65.0/autotests/usermetadatawritertest.cpp 2019-12-12 23:37:05.000000000 +0100 @@ -25,6 +25,7 @@ #include <QFile> #define TEST_FILENAME "writertest.txt" +#define TEST_SYMLINK "dangling_symlink" using namespace KFileMetaData; @@ -38,6 +39,8 @@ QFile testFile(testFilePath("plain_text_file.txt")); QFile writerTestFile(testFilePath(TEST_FILENAME)); QFile::copy(testFilePath("plain_text_file.txt"), testFilePath(TEST_FILENAME)); + + QFile::link(testFilePath("invalid_target"), testFilePath(TEST_SYMLINK)); } void UserMetaDataWriterTest::test() @@ -119,9 +122,17 @@ QVERIFY(!md.hasAttribute(QStringLiteral("test.check_contains"))); } + +void UserMetaDataWriterTest::testDanglingSymlink() +{ + KFileMetaData::UserMetaData md(testFilePath(TEST_SYMLINK)); + QVERIFY(md.queryAttributes(UserMetaData::Attribute::All) == UserMetaData::Attribute::None); +} + void UserMetaDataWriterTest::cleanupTestCase() { QFile::remove(testFilePath(TEST_FILENAME)); + QFile::remove(testFilePath(TEST_SYMLINK)); } QTEST_GUILESS_MAIN(UserMetaDataWriterTest) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.64.0/autotests/usermetadatawritertest.h new/kfilemetadata-5.65.0/autotests/usermetadatawritertest.h --- old/kfilemetadata-5.64.0/autotests/usermetadatawritertest.h 2019-11-02 13:55:38.000000000 +0100 +++ new/kfilemetadata-5.65.0/autotests/usermetadatawritertest.h 2019-12-12 23:37:05.000000000 +0100 @@ -31,6 +31,7 @@ private Q_SLOTS: void initTestCase(); void test(); + void testDanglingSymlink(); void cleanupTestCase(); }; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.64.0/po/et/kfilemetadata5.po new/kfilemetadata-5.65.0/po/et/kfilemetadata5.po --- old/kfilemetadata-5.64.0/po/et/kfilemetadata5.po 2019-11-02 13:55:38.000000000 +0100 +++ new/kfilemetadata-5.65.0/po/et/kfilemetadata5.po 2019-12-12 23:37:05.000000000 +0100 @@ -7,7 +7,7 @@ "Project-Id-Version: \n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2019-07-19 02:55+0200\n" -"PO-Revision-Date: 2019-10-31 13:13+0200\n" +"PO-Revision-Date: 2019-11-22 11:53+0200\n" "Last-Translator: Marek Laane <qiila...@gmail.com>\n" "Language-Team: Estonian <kde...@lists.linux.ee>\n" "Language: et\n" @@ -105,7 +105,7 @@ #, kde-format msgctxt "Description of photo flash" msgid "Yes, compulsory" -msgstr "" +msgstr "Jah, kohustuslik" #: src/formatstrings.cpp:115 #, kde-format @@ -123,7 +123,7 @@ #, kde-format msgctxt "Description of photo flash" msgid "No, compulsory" -msgstr "" +msgstr "Ei, kohustuslik" #: src/formatstrings.cpp:118 #, kde-format @@ -135,13 +135,13 @@ #, kde-format msgctxt "Description of photo flash" msgid "No, auto" -msgstr "" +msgstr "Ei, automaatne" #: src/formatstrings.cpp:120 #, kde-format msgctxt "Description of photo flash" msgid "Yes, auto" -msgstr "" +msgstr "Jah, automaatne" #: src/formatstrings.cpp:121 #, kde-format @@ -171,7 +171,7 @@ #, kde-format msgctxt "Description of photo flash" msgid "Yes, red-eye reduction" -msgstr "" +msgstr "Jah, punasilmsuse vähendamine" #: src/formatstrings.cpp:126 #, kde-format @@ -207,19 +207,19 @@ #, kde-format msgctxt "Description of photo flash" msgid "No, red-eye reduction" -msgstr "" +msgstr "Ei. punasilmsuse vähendamine" #: src/formatstrings.cpp:132 #, kde-format msgctxt "Description of photo flash" msgid "No, auto, red-eye reduction" -msgstr "" +msgstr "Ei, automaatne, punasilmsuse vähendamine" #: src/formatstrings.cpp:133 #, kde-format msgctxt "Description of photo flash" msgid "Yes, auto, red-eye reduction" -msgstr "" +msgstr "Jah, automaatne, punasilmsuse vähendamine" #: src/formatstrings.cpp:134 #, kde-format @@ -633,7 +633,7 @@ #, kde-format msgctxt "@label" msgid "Arranger" -msgstr "" +msgstr "Arranžeeerija" #: src/propertyinfo.cpp:433 #, kde-format @@ -645,7 +645,7 @@ #, kde-format msgctxt "@label" msgid "Compilation" -msgstr "" +msgstr "Kogumik" #: src/propertyinfo.cpp:445 #, kde-format diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.64.0/po/zh_CN/kfilemetadata5.po new/kfilemetadata-5.65.0/po/zh_CN/kfilemetadata5.po --- old/kfilemetadata-5.64.0/po/zh_CN/kfilemetadata5.po 2019-11-02 13:55:38.000000000 +0100 +++ new/kfilemetadata-5.65.0/po/zh_CN/kfilemetadata5.po 2019-12-12 23:37:05.000000000 +0100 @@ -10,7 +10,7 @@ "Project-Id-Version: kdeorg\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2019-07-19 02:55+0200\n" -"PO-Revision-Date: 2019-10-09 09:45\n" +"PO-Revision-Date: 2019-11-19 23:01\n" "Last-Translator: Guo Yunhe (guoyunhe)\n" "Language-Team: Chinese Simplified\n" "Language: zh_CN\n" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.64.0/src/xattr_p.h new/kfilemetadata-5.65.0/src/xattr_p.h --- old/kfilemetadata-5.64.0/src/xattr_p.h 2019-11-02 13:55:38.000000000 +0100 +++ new/kfilemetadata-5.65.0/src/xattr_p.h 2019-12-12 23:37:05.000000000 +0100 @@ -225,15 +225,15 @@ return UserMetaData::Attribute::None; } - if (size == -1 && errno == ENOTSUP) { - return UserMetaData::Attribute::None; - } + if (size < 0) { + if (errno == E2BIG) { + return UserMetaData::Attribute::All; + } - if (size == -1 && errno == E2BIG) { - return UserMetaData::Attribute::All; + return UserMetaData::Attribute::None; } - if (size > 0 && attributes == UserMetaData::Attribute::Any) { + if (attributes == UserMetaData::Attribute::Any) { return UserMetaData::Attribute::All; }
