Hello community,
here is the log from the commit of package wavemon for openSUSE:Factory checked
in at 2019-12-30 12:35:34
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/wavemon (Old)
and /work/SRC/openSUSE:Factory/.wavemon.new.6675 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "wavemon"
Mon Dec 30 12:35:34 2019 rev:26 rq:760009 version:0.9.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/wavemon/wavemon.changes 2019-05-20
10:29:45.657889144 +0200
+++ /work/SRC/openSUSE:Factory/.wavemon.new.6675/wavemon.changes
2019-12-30 12:35:35.583829056 +0100
@@ -1,0 +2,15 @@
+Mon Dec 30 00:03:35 UTC 2019 - Martin Hauke <mar...@gmx.de>
+
+- Update to version 0.9.1
+ Fixes
+ * Compatibility:
+ - replace non-portable on_exit with portable at_exit
+ - address gcc8 compiler warnings;
+ * Scan Screen:
+ - fix memory leak in scan handler
+ * Info Screen:
+ - fix logic around uninitialized variable
+ * Configuration Screen:
+ - fix numerical key issue on ARM 32bit (Raspberri Pi 2)
+
+-------------------------------------------------------------------
Old:
----
wavemon-0.9.0.tar.gz
New:
----
wavemon-0.9.1.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ wavemon.spec ++++++
--- /var/tmp/diff_new_pack.ZzNEMN/_old 2019-12-30 12:35:36.159829365 +0100
+++ /var/tmp/diff_new_pack.ZzNEMN/_new 2019-12-30 12:35:36.163829367 +0100
@@ -17,7 +17,7 @@
Name: wavemon
-Version: 0.9.0
+Version: 0.9.1
Release: 0
Summary: An ncurses monitoring application for wireless network devices
License: GPL-2.0-or-later
++++++ wavemon-0.9.0.tar.gz -> wavemon-0.9.1.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/wavemon-0.9.0/conf_scr.c new/wavemon-0.9.1/conf_scr.c
--- old/wavemon-0.9.0/conf_scr.c 2018-12-30 02:08:25.000000000 +0100
+++ new/wavemon-0.9.1/conf_scr.c 2019-12-30 00:45:44.000000000 +0100
@@ -51,7 +51,7 @@
break;
case t_list:
assert(item->list && item->list[*item->v.i]);
- strncpy(s, item->list[*item->v.i], sizeof(s));
+ strncpy(s, item->list[*item->v.i], sizeof(s)-1);
/* Fall through, dummy statements to pacify gcc -Wall */
case t_sep:
case t_func:
@@ -90,7 +90,7 @@
}
}
-static void change_item(int inum, char sign)
+static void change_item(int inum, int sign)
{
struct conf_item *item = ll_get(conf_items, inum);
int tmp;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/wavemon-0.9.0/configure new/wavemon-0.9.1/configure
--- old/wavemon-0.9.0/configure 2018-12-30 02:08:25.000000000 +0100
+++ new/wavemon-0.9.1/configure 2019-12-30 00:45:44.000000000 +0100
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for wavemon 0.9.0.
+# Generated by GNU Autoconf 2.69 for wavemon 0.9.1.
#
# Report bugs to <https://github.com/uoaerg/wavemon>.
#
@@ -580,8 +580,8 @@
# Identity of this package.
PACKAGE_NAME='wavemon'
PACKAGE_TARNAME='wavemon-current'
-PACKAGE_VERSION='0.9.0'
-PACKAGE_STRING='wavemon 0.9.0'
+PACKAGE_VERSION='0.9.1'
+PACKAGE_STRING='wavemon 0.9.1'
PACKAGE_BUGREPORT='https://github.com/uoaerg/wavemon'
PACKAGE_URL='https://github.com/uoaerg/wavemon'
@@ -1261,7 +1261,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures wavemon 0.9.0 to adapt to many kinds of systems.
+\`configure' configures wavemon 0.9.1 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1327,7 +1327,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of wavemon 0.9.0:";;
+ short | recursive ) echo "Configuration of wavemon 0.9.1:";;
esac
cat <<\_ACEOF
@@ -1425,7 +1425,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-wavemon configure 0.9.0
+wavemon configure 0.9.1
generated by GNU Autoconf 2.69
Copyright (C) 2012 Free Software Foundation, Inc.
@@ -1848,7 +1848,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by wavemon $as_me 0.9.0, which was
+It was created by wavemon $as_me 0.9.1, which was
generated by GNU Autoconf 2.69. Invocation command line was
$ $0 $@
@@ -4974,7 +4974,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by wavemon $as_me 0.9.0, which was
+This file was extended by wavemon $as_me 0.9.1, which was
generated by GNU Autoconf 2.69. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -5028,7 +5028,7 @@
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //;
s/[\\""\`\$]/\\\\&/g'`"
ac_cs_version="\\
-wavemon config.status 0.9.0
+wavemon config.status 0.9.1
configured by $0, generated by GNU Autoconf 2.69,
with options \\"\$ac_cs_config\\"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/wavemon-0.9.0/configure.ac
new/wavemon-0.9.1/configure.ac
--- old/wavemon-0.9.0/configure.ac 2018-12-30 02:08:25.000000000 +0100
+++ new/wavemon-0.9.1/configure.ac 2019-12-30 00:45:44.000000000 +0100
@@ -1,6 +1,6 @@
dnl Process this file with autoconf to produce a configure script.
AC_PREREQ(2.64)
-AC_INIT([wavemon], [0.9.0], [https://github.com/uoaerg/wavemon],
[wavemon-current],
+AC_INIT([wavemon], [0.9.1], [https://github.com/uoaerg/wavemon],
[wavemon-current],
[https://github.com/uoaerg/wavemon])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/wavemon-0.9.0/info_scr.c new/wavemon-0.9.1/info_scr.c
--- old/wavemon-0.9.0/info_scr.c 2018-12-30 02:08:25.000000000 +0100
+++ new/wavemon-0.9.1/info_scr.c 2019-12-30 00:45:44.000000000 +0100
@@ -78,7 +78,7 @@
char tmp[0x100];
int line;
bool noise_data_valid;
- int sig_qual = -1, sig_qual_max, sig_level;
+ int sig_qual = -1, sig_qual_max = 0, sig_level = 0;
noise_data_valid = iw_nl80211_have_survey_data(&linkstat.data);
sig_level = linkstat.data.signal;
@@ -175,7 +175,7 @@
static void display_stats(void)
{
- char tmp[0x100];
+ char tmp[0x120];
/*
* Interface RX stats
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/wavemon-0.9.0/iw_if.c new/wavemon-0.9.1/iw_if.c
--- old/wavemon-0.9.0/iw_if.c 2018-12-30 02:08:25.000000000 +0100
+++ new/wavemon-0.9.1/iw_if.c 2019-12-30 00:45:44.000000000 +0100
@@ -87,11 +87,13 @@
return if_set_up_or_down(ifname, false);
}
-/** Exit handler to restore interface 'down' state on exit via on_exit(3). */
-void if_set_down_on_exit(int rc, void *arg)
+/** Exit handler to restore interface 'down' state on exit via atexit(3). */
+void if_set_down_on_exit(void)
{
- if (if_set_down(arg) < 0) {
- err_msg("unable to restore %s interface state - set down
manually", arg);
+ const char *ifname = conf_ifname();
+
+ if (ifname && if_set_down(ifname) < 0) {
+ err_msg("unable to restore %s interface state - set down
manually", ifname);
}
}
@@ -109,7 +111,7 @@
info->flags = if_get_flags(skfd, ifname);
- strncpy(ifr.ifr_name, ifname, IFNAMSIZ);
+ strncpy(ifr.ifr_name, ifname, IFNAMSIZ-1);
if (ioctl(skfd, SIOCGIFMTU, &ifr) == 0)
info->mtu = ifr.ifr_mtu;
@@ -185,7 +187,7 @@
err_sys("%s: can not open socket", __func__);
memset(info, 0, sizeof(*info));
- strncpy(iwr.ifr_name, ifname, IFNAMSIZ);
+ strncpy(iwr.ifr_name, ifname, IFNAMSIZ-1);
if (ioctl(skfd, SIOCGIWNAME, &iwr) < 0)
err_sys("can not open device '%s'", ifname);
@@ -272,7 +274,7 @@
err_sys("%s: can not open socket", __func__);
memset(range, 0, sizeof(struct iw_range));
- strncpy(iwr.ifr_name, ifname, IFNAMSIZ);
+ strncpy(iwr.ifr_name, ifname, IFNAMSIZ-1);
iwr.u.data.pointer = (caddr_t) range;
iwr.u.data.length = sizeof(struct iw_range);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/wavemon-0.9.0/iw_if.h new/wavemon-0.9.1/iw_if.h
--- old/wavemon-0.9.0/iw_if.h 2018-12-30 02:08:25.000000000 +0100
+++ new/wavemon-0.9.1/iw_if.h 2019-12-30 00:45:44.000000000 +0100
@@ -76,7 +76,7 @@
};
extern bool if_is_up(const char *ifname);
extern int if_set_up(const char *ifname);
-extern void if_set_down_on_exit(int rc, void *arg);
+extern void if_set_down_on_exit(void);
extern void if_getinf(const char *ifname, struct if_info *info);
/**
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/wavemon-0.9.0/iw_scan.c new/wavemon-0.9.1/iw_scan.c
--- old/wavemon-0.9.0/iw_scan.c 2018-12-30 02:08:25.000000000 +0100
+++ new/wavemon-0.9.1/iw_scan.c 2019-12-30 00:45:44.000000000 +0100
@@ -143,7 +143,7 @@
int scan_dump_handler(struct nl_msg *msg, void *arg)
{
struct scan_result *sr = (struct scan_result *)arg;
- struct scan_entry *new = calloc(1, sizeof(*new));
+ struct scan_entry *new;
struct genlmsghdr *gnlh = nlmsg_data(nlmsg_hdr(msg));
struct nlattr *tb[NL80211_ATTR_MAX + 1];
struct nlattr *bss[NL80211_BSS_MAX + 1];
@@ -430,7 +430,7 @@
if (if_set_up(conf_ifname()) < 0)
err_sys("Can not bring up interface
'%s'", conf_ifname());
- if (on_exit(if_set_down_on_exit, (void
*)conf_ifname()) < 0)
+ if (atexit(if_set_down_on_exit) < 0)
snprintf(sr->msg, sizeof(sr->msg),
"Warning: unable to restore %s down state on exit", conf_ifname());
break;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/wavemon-0.9.0/wavemon.h new/wavemon-0.9.1/wavemon.h
--- old/wavemon-0.9.0/wavemon.h 2018-12-30 02:08:25.000000000 +0100
+++ new/wavemon-0.9.1/wavemon.h 2019-12-30 00:45:44.000000000 +0100
@@ -174,7 +174,7 @@
int *dep; /* dependency */
bool hidden; /* only allow to set via wavemonrc */
- double min, /* value boundaries */
+ int min, /* value boundaries */
max,
inc; /* increment for value changes */
@@ -387,7 +387,7 @@
/* Integer units - similar to %g for float. */
static inline char *int_counts(uint32_t count)
{
- static char result[0x100];
+ static char result[0x10];
if (count < 1000)
sprintf(result, "%u", count);
