Hello community, here is the log from the commit of package yast2-packager for openSUSE:Factory checked in at 2020-01-04 19:20:54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-packager (Old) and /work/SRC/openSUSE:Factory/.yast2-packager.new.6675 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-packager" Sat Jan 4 19:20:54 2020 rev:383 rq:760602 version:4.2.42 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-packager/yast2-packager.changes 2019-12-14 12:04:39.287390735 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-packager.new.6675/yast2-packager.changes 2020-01-04 19:21:03.097129537 +0100 @@ -1,0 +2,20 @@ +Thu Jan 2 16:29:45 UTC 2020 - Josef Reidinger <[email protected]> + +- Improve warning when all repositories are disabled (bsc#1158512) +- 4.2.42 + +------------------------------------------------------------------- +Mon Dec 30 15:46:03 UTC 2019 - Josef Reidinger <[email protected]> + +- Do not unexpectly end during slide show script progress + (bsc#1159461) +- 4.2.41 + +------------------------------------------------------------------- +Fri Dec 20 10:51:24 UTC 2019 - Josef Reidinger <[email protected]> + +- do not crash when invalid URL is used in config mode + (bsc#1073208) +- 4.2.40 + +------------------------------------------------------------------- Old: ---- yast2-packager-4.2.39.tar.bz2 New: ---- yast2-packager-4.2.42.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-packager.spec ++++++ --- /var/tmp/diff_new_pack.WkkmOv/_old 2020-01-04 19:21:03.589129755 +0100 +++ /var/tmp/diff_new_pack.WkkmOv/_new 2020-01-04 19:21:03.589129755 +0100 @@ -1,7 +1,7 @@ # # spec file for package yast2-packager # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: yast2-packager -Version: 4.2.39 +Version: 4.2.42 Release: 0 Summary: YaST2 - Package Library License: GPL-2.0-or-later ++++++ yast2-packager-4.2.39.tar.bz2 -> yast2-packager-4.2.42.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.2.39/package/yast2-packager.changes new/yast2-packager-4.2.42/package/yast2-packager.changes --- old/yast2-packager-4.2.39/package/yast2-packager.changes 2019-12-12 13:03:16.000000000 +0100 +++ new/yast2-packager-4.2.42/package/yast2-packager.changes 2020-01-03 10:26:49.000000000 +0100 @@ -1,4 +1,24 @@ ------------------------------------------------------------------- +Thu Jan 2 16:29:45 UTC 2020 - Josef Reidinger <[email protected]> + +- Improve warning when all repositories are disabled (bsc#1158512) +- 4.2.42 + +------------------------------------------------------------------- +Mon Dec 30 15:46:03 UTC 2019 - Josef Reidinger <[email protected]> + +- Do not unexpectly end during slide show script progress + (bsc#1159461) +- 4.2.41 + +------------------------------------------------------------------- +Fri Dec 20 10:51:24 UTC 2019 - Josef Reidinger <[email protected]> + +- do not crash when invalid URL is used in config mode + (bsc#1073208) +- 4.2.40 + +------------------------------------------------------------------- Wed Dec 11 17:11:04 UTC 2019 - Imobach Gonzalez Sosa <[email protected]> - Speed up product renames calculation (bsc#1157926). diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.2.39/package/yast2-packager.spec new/yast2-packager-4.2.42/package/yast2-packager.spec --- old/yast2-packager-4.2.39/package/yast2-packager.spec 2019-12-12 13:03:16.000000000 +0100 +++ new/yast2-packager-4.2.42/package/yast2-packager.spec 2020-01-03 10:26:49.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-packager -Version: 4.2.39 +Version: 4.2.42 Release: 0 Summary: YaST2 - Package Library License: GPL-2.0-or-later diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.2.39/src/clients/sw_single.rb new/yast2-packager-4.2.42/src/clients/sw_single.rb --- old/yast2-packager-4.2.39/src/clients/sw_single.rb 2019-12-12 13:03:16.000000000 +0100 +++ new/yast2-packager-4.2.42/src/clients/sw_single.rb 2020-01-03 10:26:49.000000000 +0100 @@ -340,7 +340,7 @@ end if Builtins.size(Pkg.SourceGetCurrent(enabled_only)).zero? Report.Warning( - _("No repository is defined.\nOnly installed packages are displayed.") + _("No enabled repository configured.\nOnly installed packages are displayed.") ) end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.2.39/src/modules/SlideShowCallbacks.rb new/yast2-packager-4.2.42/src/modules/SlideShowCallbacks.rb --- old/yast2-packager-4.2.39/src/modules/SlideShowCallbacks.rb 2019-12-12 13:03:16.000000000 +0100 +++ new/yast2-packager-4.2.42/src/modules/SlideShowCallbacks.rb 2020-01-03 10:26:49.000000000 +0100 @@ -157,7 +157,7 @@ input = UI.PollInput Builtins.y2milestone("input: %1", input) - [:abort, :close].include?(input) + ![:abort, :close].include?(input) end def ScriptProblem(description) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.2.39/src/modules/SourceManager.rb new/yast2-packager-4.2.42/src/modules/SourceManager.rb --- old/yast2-packager-4.2.39/src/modules/SourceManager.rb 2019-12-12 13:03:16.000000000 +0100 +++ new/yast2-packager-4.2.42/src/modules/SourceManager.rb 2020-01-03 10:26:49.000000000 +0100 @@ -272,7 +272,9 @@ UI.CloseDialog if !Mode.commandline - if Builtins.size(@newSources).zero? + # Pkg.SourceScan can return Array with repos or -1 if failed. So be more + # paranoid here and accept only non empty list as success result. + if [email protected]_a?(::Array) || @newSources.empty? message1 = Builtins.sformat( _("Unable to create repository\nfrom URL '%1'."), URL.HidePassword(url) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.2.39/test/slide_show_callabacks_test.rb new/yast2-packager-4.2.42/test/slide_show_callabacks_test.rb --- old/yast2-packager-4.2.39/test/slide_show_callabacks_test.rb 2019-12-12 13:03:16.000000000 +0100 +++ new/yast2-packager-4.2.42/test/slide_show_callabacks_test.rb 2020-01-03 10:26:49.000000000 +0100 @@ -70,4 +70,28 @@ include_examples "free space check" end end + + describe "ScriptProgress" do + let(:input) { nil } + + before do + allow(Yast::UI).to receive(:PollInput).and_return(input) + end + + context "user does not click anything" do + let(:input) { nil } + + it "returns true" do + expect(subject.ScriptProgress(0, nil)).to eq true + end + end + + context "user click on abort" do + let(:input) { :abort } + + it "returns false" do + expect(subject.ScriptProgress(0, nil)).to eq false + end + end + end end
