Hello community,
here is the log from the commit of package gstreamer for openSUSE:Factory
checked in at 2020-01-12 23:15:55
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gstreamer (Old)
and /work/SRC/openSUSE:Factory/.gstreamer.new.6675 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gstreamer"
Sun Jan 12 23:15:55 2020 rev:64 rq:761775 version:1.16.2
Changes:
--------
--- /work/SRC/openSUSE:Factory/gstreamer/gstreamer.changes 2019-12-11
12:09:02.332641578 +0100
+++ /work/SRC/openSUSE:Factory/.gstreamer.new.6675/gstreamer.changes
2020-01-12 23:16:23.798638881 +0100
@@ -1,0 +2,6 @@
+Mon Dec 23 18:20:52 UTC 2019 - Bjørn Lie <bjorn....@gmail.com>
+
+- Add gstreamer-revert-encforce-elements.patch: Revert enforce
+ elements, patches from upstream stable branch.
+
+-------------------------------------------------------------------
New:
----
gstreamer-revert-encforce-elements.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ gstreamer.spec ++++++
--- /var/tmp/diff_new_pack.c6vWwh/_old 2020-01-12 23:16:24.826639261 +0100
+++ /var/tmp/diff_new_pack.c6vWwh/_new 2020-01-12 23:16:24.838639265 +0100
@@ -38,6 +38,8 @@
Patch1: gstreamer-rpm-prov.patch
# PATCH-FIX-OPENSUSE gstreamer-pie.patch mgo...@suse.com -- create
position-independent executables.
Patch2: gstreamer-pie.patch
+# PATCH-FIX-UPSTREAM gstreamer-revert-encforce-elements.patch -- Revert
enforce elements
+Patch3: gstreamer-revert-encforce-elements.patch
BuildRequires: bison >= 2.4
BuildRequires: check-devel
@@ -165,6 +167,7 @@
# The order matters. Only run gnome-patch-translation-update after patching!
%patch1 -p1
%patch2 -p1
+%patch3 -p1
gnome-patch-translation-update po gstreamer-%{gst_branch}
%build
++++++ gstreamer-revert-encforce-elements.patch ++++++
>From 3c21d6a29f42731b5f47561a07f251ce8f875c5a Mon Sep 17 00:00:00 2001
From: Mathieu Duponchelle <math...@centricular.com>
Date: Thu, 5 Dec 2019 09:47:30 +0100
Subject: [PATCH] Revert "device: Enforce that elements created by
gst_device_create_element() are floating"
See https://gitlab.freedesktop.org/gstreamer/gstreamer/merge_requests/333
The reference we receive when calling g_object_new should be
floating, but we can't force it at our level.
This reverts commit cc6342d853f4252c5d5cf09fff9d3379ad467fbc.
---
gst/gstdevice.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/gst/gstdevice.c b/gst/gstdevice.c
index 64f5ba5309f..60407823f56 100644
--- a/gst/gstdevice.c
+++ b/gst/gstdevice.c
@@ -205,20 +205,13 @@ GstElement *
gst_device_create_element (GstDevice * device, const gchar * name)
{
GstDeviceClass *klass = GST_DEVICE_GET_CLASS (device);
- GstElement *element = NULL;
g_return_val_if_fail (GST_IS_DEVICE (device), NULL);
if (klass->create_element)
- element = klass->create_element (device, name);
-
- /* Ensure that the reference is floating. Bindings might have a hard time
- * making sure that the reference is indeed still floating after returning
- * here */
- if (element)
- g_object_force_floating ((GObject *) element);
-
- return element;
+ return klass->create_element (device, name);
+ else
+ return NULL;
}
/**
--
2.24.1
>From 5c47fe611894ebfd8da946797802913042eff3bf Mon Sep 17 00:00:00 2001
From: Mathieu Duponchelle <math...@centricular.com>
Date: Thu, 5 Dec 2019 09:47:38 +0100
Subject: [PATCH] Revert "element: Enforce that elements created by
gst_element_factory_create/make() are floating"
See https://gitlab.freedesktop.org/gstreamer/gstreamer/merge_requests/333
The reference we receive when calling g_object_new should be
floating, but we can't force it at our level.
This reverts commit ce43de86902c4e9c8ed4e9682602664cb9bce2ee.
---
gst/gstelementfactory.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/gst/gstelementfactory.c b/gst/gstelementfactory.c
index 3ccfc1420ab..cf3b1007744 100644
--- a/gst/gstelementfactory.c
+++ b/gst/gstelementfactory.c
@@ -386,12 +386,6 @@ gst_element_factory_create (GstElementFactory * factory,
const gchar * name)
/* This ref will never be dropped as the class is never destroyed */
GST_OBJECT_FLAG_SET (factory, GST_OBJECT_FLAG_MAY_BE_LEAKED);
- /* Ensure that the reference is floating. Bindings might have a hard time
- * making sure that the reference is indeed still floating after returning
- * here */
- if (element)
- g_object_force_floating ((GObject *) element);
-
GST_DEBUG ("created element \"%s\"", GST_OBJECT_NAME (factory));
return element;
--
2.24.1
