Hello community, here is the log from the commit of package librepo for openSUSE:Leap:15.2 checked in at 2020-01-22 08:19:22 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/librepo (Old) and /work/SRC/openSUSE:Leap:15.2/.librepo.new.26092 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "librepo" Wed Jan 22 08:19:22 2020 rev:23 rq:765596 version:1.11.2 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/librepo/librepo.changes 2020-01-15 15:24:59.258562008 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.librepo.new.26092/librepo.changes 2020-01-22 08:19:22.810179391 +0100 @@ -1,0 +2,9 @@ +Sun Jan 19 14:52:18 UTC 2020 - Neal Gompa <[email protected]> + +- Upgrade to 1.11.2 + + Fix calling Python API without holding GIL (rh#1788918) + + Do not unref LrErr_Exception on exit (rh#1778854) + + Cleanup zchunk-related error messages (rh#1790625) +- Fix typo in changes entry about version update to 1.11.1 + +------------------------------------------------------------------- @@ -4 +13 @@ -- Upgrade to 1.1.1 +- Upgrade to 1.11.1 Old: ---- librepo-1.11.1.tar.gz New: ---- librepo-1.11.2.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ librepo.spec ++++++ --- /var/tmp/diff_new_pack.jwit21/_old 2020-01-22 08:19:23.510179768 +0100 +++ /var/tmp/diff_new_pack.jwit21/_new 2020-01-22 08:19:23.510179768 +0100 @@ -2,7 +2,7 @@ # spec file for package librepo # # Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. -# Copyright (c) 2019 Neal Gompa <[email protected]>. +# Copyright (c) 2020 Neal Gompa <[email protected]>. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -37,7 +37,7 @@ %define devname %{name}-devel Name: librepo -Version: 1.11.1 +Version: 1.11.2 Release: 0 Summary: Repodata downloading library License: LGPL-2.0-or-later ++++++ librepo-1.11.1.tar.gz -> librepo-1.11.2.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/librepo-1.11.1/VERSION.cmake new/librepo-1.11.2/VERSION.cmake --- old/librepo-1.11.1/VERSION.cmake 2019-12-09 11:25:59.000000000 +0100 +++ new/librepo-1.11.2/VERSION.cmake 2020-01-19 15:50:24.000000000 +0100 @@ -1,3 +1,3 @@ SET(LIBREPO_MAJOR "1") SET(LIBREPO_MINOR "11") -SET(LIBREPO_PATCH "1") +SET(LIBREPO_PATCH "2") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/librepo-1.11.1/librepo/downloader.c new/librepo-1.11.2/librepo/downloader.c --- old/librepo-1.11.1/librepo/downloader.c 2019-12-09 11:25:59.000000000 +0100 +++ new/librepo-1.11.2/librepo/downloader.c 2020-01-19 15:50:24.000000000 +0100 @@ -1221,7 +1221,7 @@ } if(!zck_copy_chunks(zck_src, zck)) { - g_warning("Error copying chunks from %s to %s", cf, uf); + g_warning("Error copying chunks from %s to %s: %s", cf, uf, zck_get_error(zck)); zck_free(&zck_src); close(chk_fd); continue; @@ -1334,7 +1334,7 @@ if(!cks_good) { // Error while validating checksums g_set_error(err, LR_DOWNLOADER_ERROR, LRE_ZCK, "%s: Error validating zchunk file: %s", __func__, - target->target->path); + zck_get_error(zck)); return FALSE; } @@ -1356,7 +1356,7 @@ if(!cks_good) { // Error while validating checksums g_set_error(err, LR_DOWNLOADER_ERROR, LRE_ZCK, "%s: Error validating zchunk file: %s", __func__, - target->target->path); + zck_get_error(zck)); return FALSE; } @@ -1836,6 +1836,25 @@ target->mirror->max_ranges); } return TRUE; + } else if (target->target->zck_dl != NULL && zck_is_error(zck_dl_get_zck(target->target->zck_dl)) > 0) { + zckCtx *zck = zck_dl_get_zck(target->target->zck_dl); + + // Something went wrong while writing the zchunk file + g_set_error(transfer_err, LR_DOWNLOADER_ERROR, LRE_ZCK, + "Zchunk error: %s", + zck_get_error(zck)); + if (zck_is_error(zck) == 1) { + // Non-fatal zchunk error + g_info("Serious zchunk error: %s", + zck_get_error(zck)); + *serious_error = TRUE; + } else { // zck_is_error(zck) == 2 + // Fatal zchunk error + g_info("Fatal zchunk error: %s", + zck_get_error(zck)); + *fatal_error = TRUE; + } + return TRUE; } #endif /* WITH_ZCHUNK */ else { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/librepo-1.11.1/librepo/python/handle-py.c new/librepo-1.11.2/librepo/python/handle-py.c --- old/librepo-1.11.1/librepo/python/handle-py.c 2019-12-09 11:25:59.000000000 +0100 +++ new/librepo-1.11.2/librepo/python/handle-py.c 2020-01-19 15:50:24.000000000 +0100 @@ -142,6 +142,8 @@ else user_data = Py_None; + EndAllowThreads(self->state); + if (!ptr) { pydata = Py_None; } else { @@ -159,7 +161,6 @@ } } - EndAllowThreads(self->state); result = PyObject_CallFunction(self->fastestmirror_cb, "(OlO)", user_data, (long) stage, pydata); Py_XDECREF(result); @@ -187,11 +188,12 @@ else user_data = Py_None; + EndAllowThreads(self->state); + py_msg = PyStringOrNone_FromString(msg); py_url = PyStringOrNone_FromString(url); py_metadata = PyStringOrNone_FromString(metadata); - EndAllowThreads(self->state); result = PyObject_CallFunction(self->hmf_cb, "(OOOO)", user_data, py_msg, py_url, py_metadata); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/librepo-1.11.1/librepo/python/librepomodule.c new/librepo-1.11.2/librepo/python/librepomodule.c --- old/librepo-1.11.1/librepo/python/librepomodule.c 2019-12-09 11:25:59.000000000 +0100 +++ new/librepo-1.11.2/librepo/python/librepomodule.c 2020-01-19 15:50:24.000000000 +0100 @@ -134,7 +134,6 @@ { Py_XDECREF(debug_cb); Py_XDECREF(debug_cb_data); - Py_XDECREF(LrErr_Exception); } struct module_state { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/librepo-1.11.1/librepo/python/metadatatarget-py.c new/librepo-1.11.2/librepo/python/metadatatarget-py.c --- old/librepo-1.11.1/librepo/python/metadatatarget-py.c 2019-12-09 11:25:59.000000000 +0100 +++ new/librepo-1.11.2/librepo/python/metadatatarget-py.c 2020-01-19 15:50:24.000000000 +0100 @@ -142,10 +142,11 @@ else user_data = Py_None; + EndAllowThreads(self->state); + py_msg = PyStringOrNone_FromString(msg); py_url = PyStringOrNone_FromString(url); - EndAllowThreads(self->state); result = PyObject_CallFunction(self->mirrorfailure_cb, "(OOO)", user_data, py_msg, py_url); @@ -205,9 +206,10 @@ else user_data = Py_None; + EndAllowThreads(self->state); + py_msg = PyStringOrNone_FromString(msg); - EndAllowThreads(self->state); result = PyObject_CallFunction(self->end_cb, "(OiO)", user_data, status, py_msg); Py_DECREF(py_msg); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/librepo-1.11.1/librepo/python/packagetarget-py.c new/librepo-1.11.2/librepo/python/packagetarget-py.c --- old/librepo-1.11.1/librepo/python/packagetarget-py.c 2019-12-09 11:25:59.000000000 +0100 +++ new/librepo-1.11.2/librepo/python/packagetarget-py.c 2020-01-19 15:50:24.000000000 +0100 @@ -134,9 +134,10 @@ else user_data = Py_None; + EndAllowThreads(self->state); + py_msg = PyStringOrNone_FromString(msg); - EndAllowThreads(self->state); result = PyObject_CallFunction(self->end_cb, "(OiO)", user_data, status, py_msg); Py_DECREF(py_msg); @@ -185,10 +186,11 @@ else user_data = Py_None; + EndAllowThreads(self->state); + py_msg = PyStringOrNone_FromString(msg); py_url = PyStringOrNone_FromString(url); - EndAllowThreads(self->state); result = PyObject_CallFunction(self->mirrorfailure_cb, "(OOO)", user_data, py_msg, py_url); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/librepo-1.11.1/librepo.spec new/librepo-1.11.2/librepo.spec --- old/librepo-1.11.1/librepo.spec 2019-12-09 11:25:59.000000000 +0100 +++ new/librepo-1.11.2/librepo.spec 2020-01-19 15:50:24.000000000 +0100 @@ -26,7 +26,7 @@ %global dnf_conflict 2.8.8 Name: librepo -Version: 1.11.1 +Version: 1.11.2 Release: 1%{?dist} Summary: Repodata downloading library
