Hello community,

here is the log from the commit of package perl-Net-Ident for openSUSE:Factory 
checked in at 2020-01-23 16:10:06
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Net-Ident (Old)
 and      /work/SRC/openSUSE:Factory/.perl-Net-Ident.new.26092 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "perl-Net-Ident"

Thu Jan 23 16:10:06 2020 rev:17 rq:765862 version:1.25

Changes:
--------
--- /work/SRC/openSUSE:Factory/perl-Net-Ident/perl-Net-Ident.changes    
2015-04-22 01:08:08.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.perl-Net-Ident.new.26092/perl-Net-Ident.changes 
2020-01-23 16:10:49.435632635 +0100
@@ -1,0 +2,13 @@
+Mon Jan 20 03:13:49 UTC 2020 -  <[email protected]>
+
+- updated to 1.25
+   see /usr/share/doc/packages/perl-Net-Ident/Changes
+
+  1.25 Sat Jan 18 2020
+      - Enable github actions testing
+      - Switch to README.md and point to testing status
+      - Fix spelling typo provided by Debian project
+      - Switch primary tracker to github issues
+      - Remove META.yml from source control
+
+-------------------------------------------------------------------

Old:
----
  Net-Ident-1.24.tar.gz

New:
----
  Net-Ident-1.25.tar.gz
  cpanspec.yml

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ perl-Net-Ident.spec ++++++
--- /var/tmp/diff_new_pack.YtHxYN/_old  2020-01-23 16:10:51.131633641 +0100
+++ /var/tmp/diff_new_pack.YtHxYN/_new  2020-01-23 16:10:51.155633655 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package perl-Net-Ident
 #
-# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -12,19 +12,20 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
 Name:           perl-Net-Ident
-Version:        1.24
+Version:        1.25
 Release:        0
 %define cpan_name Net-Ident
-Summary:        lookup the username on the remote end of a TCP/IP connection
-License:        GPL-1.0+ or Artistic-1.0
+Summary:        Lookup the username on the remote end of a TCP/IP connection
+License:        Artistic-1.0 OR GPL-1.0-or-later
 Group:          Development/Libraries/Perl
-Url:            http://search.cpan.org/dist/Net-Ident/
-Source:         
http://www.cpan.org/authors/id/T/TO/TODDR/%{cpan_name}-%{version}.tar.gz
+Url:            https://metacpan.org/release/%{cpan_name}
+Source0:        
https://cpan.metacpan.org/authors/id/T/TO/TODDR/%{cpan_name}-%{version}.tar.gz
+Source1:        cpanspec.yml
 BuildArch:      noarch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 BuildRequires:  perl
@@ -39,14 +40,14 @@
 
 %prep
 %setup -q -n %{cpan_name}-%{version}
-find . -type f -print0 | xargs -0 chmod 644
+find . -type f ! -path "*/t/*" ! -name "*.pl" ! -path "*/bin/*" ! -path 
"*/script/*" ! -name "configure" -print0 | xargs -0 chmod 644
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
-%{__make} %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor
+make %{?_smp_mflags}
 
 %check
-%{__make} test
+make test
 
 %install
 %perl_make_install
@@ -55,6 +56,6 @@
 
 %files -f %{name}.files
 %defattr(-,root,root,755)
-%doc Changes README
+%doc Changes README.md
 
 %changelog

++++++ Net-Ident-1.24.tar.gz -> Net-Ident-1.25.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/Changes new/Net-Ident-1.25/Changes
--- old/Net-Ident-1.24/Changes  2014-12-14 08:07:37.000000000 +0100
+++ new/Net-Ident-1.25/Changes  2020-01-19 07:02:33.000000000 +0100
@@ -1,5 +1,12 @@
 Revision history for Perl extension Net::Ident.
 
+1.25 Sat Jan 18 2020
+    - Enable github actions testing
+    - Switch to README.md and point to testing status
+    - Fix spelling typo provided by Debian project
+    - Switch primary tracker to github issues
+    - Remove META.yml from source control
+
 1.24 Sun Dec 14 2014
     - RT 79165 - Fix for Strawberry Perl
     - Tidy code base for conformity of future patches
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/Ident.pm new/Net-Ident-1.25/Ident.pm
--- old/Net-Ident-1.24/Ident.pm 2014-12-14 08:08:02.000000000 +0100
+++ new/Net-Ident-1.25/Ident.pm 2020-01-19 07:02:33.000000000 +0100
@@ -1,6 +1,8 @@
 package Net::Ident;
 
 use strict;
+use warnings;
+
 use Socket;
 use Fcntl;
 use FileHandle;
@@ -9,15 +11,14 @@
 use Errno;
 require Exporter;
 
-use vars qw(@ISA @EXPORT_OK $DEBUG $VERSION %EXPORT_TAGS @EXPORT_FAIL
-  %EXPORT_HOOKS @EXPORT);
-
-@ISA       = qw(Exporter);
-@EXPORT_OK = qw(ident_lookup lookup lookupFromInAddr);
+our @ISA       = qw(Exporter);
+our @EXPORT_OK = qw(ident_lookup lookup lookupFromInAddr);
+our @EXPORT_FAIL;
+our %EXPORT_TAGS;
 
 # EXPORT_HOOKS is a sortof Exporter extension. Whenever one of the keys
 # of this hash is imported as a "tag", the corresponding function is called
-%EXPORT_HOOKS = (
+our %EXPORT_HOOKS = (
     'fh'     => \&_add_fh_method,
     'apache' => \&_add_apache_method,
     'debug'  => \&_set_debug,
@@ -40,9 +41,9 @@
 # for compatibility mode, uncomment the next line @@ s/^#\s*// @@
 # @EXPORT = qw(_export_hook_fh);
 
-$VERSION = "1.24";
+our $VERSION = "1.25";
 
-$DEBUG ||= 0;
+our $DEBUG = 0;
 *STDDBG = *STDERR;
 
 sub _set_debug {
@@ -860,7 +861,7 @@
 method, wich will return the error message.
 
 The timeout is I<not> implemented using C<alarm()>. In fact you can
-use C<alarm()> completely independant of this library, they do not
+use C<alarm()> completely independent of this library, they do not
 interfere.
 
 =item C<newFromInAddr $localaddr, $remoteaddr, $timeout>
@@ -870,7 +871,7 @@
 
 =item C<query $obj>
 
-This object method queries the remote rfc931 deamon, and blocks until
+This object method queries the remote rfc931 daemon, and blocks until
 the connection to the ident daemon is writable, if necessary (but you
 are supposed to make sure it is, of course). Returns true on success
 (or rather it returns the I<$obj> itself), or undef on error.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/MANIFEST new/Net-Ident-1.25/MANIFEST
--- old/Net-Ident-1.24/MANIFEST 2014-12-14 08:12:06.000000000 +0100
+++ new/Net-Ident-1.25/MANIFEST 2020-01-19 07:04:57.000000000 +0100
@@ -3,7 +3,7 @@
 Ident.pm       the module itself, contains pod
 MANIFEST       this file
 Makefile.PL    feed to perl to get a makefile
-README         extract of the manpage, gives a brief overview
+README.md      extract of the manpage, gives a brief overview
 t/0use.t       script to test "use Net::Ident"
 t/Ident.t      test script that actually makes ident lookups
 t/apache.t     script to test Net::Ident within apache and mod_perl
@@ -18,5 +18,5 @@
 t/apache/perl/testmodperl      script to test mod_perl operates OK
 t/apache/perl/testident                script to actually test ident within 
mod_perl
 t/apache/logs/.exists          Directory for the logfiles
-META.yml
+META.yml                                 Module YAML meta-data (added by 
MakeMaker)
 META.json                                Module JSON meta-data (added by 
MakeMaker)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/META.json new/Net-Ident-1.25/META.json
--- old/Net-Ident-1.24/META.json        2014-12-14 08:12:06.000000000 +0100
+++ new/Net-Ident-1.25/META.json        2020-01-19 07:04:57.000000000 +0100
@@ -4,13 +4,13 @@
       "Jan-Pieter Cornet <[email protected]>"
    ],
    "dynamic_config" : 1,
-   "generated_by" : "ExtUtils::MakeMaker version 7.04, CPAN::Meta::Converter 
version 2.143240",
+   "generated_by" : "ExtUtils::MakeMaker version 7.34, CPAN::Meta::Converter 
version 2.150010",
    "license" : [
       "unknown"
    ],
    "meta-spec" : {
       "url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec";,
-      "version" : "2"
+      "version" : 2
    },
    "name" : "Net-Ident",
    "no_index" : {
@@ -46,7 +46,9 @@
    },
    "release_status" : "stable",
    "resources" : {
-      "homepage" : "http://wiki.github.com/toddr/Net-Ident/";,
+      "bugtracker" : {
+         "web" : "http://github.com/toddr/Net-Ident/issues";
+      },
       "license" : [
          "http://dev.perl.org/licenses/";
       ],
@@ -54,5 +56,6 @@
          "url" : "http://github.com/toddr/Net-Ident";
       }
    },
-   "version" : "1.24"
+   "version" : "1.25",
+   "x_serialization_backend" : "JSON::PP version 4.02"
 }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/META.yml new/Net-Ident-1.25/META.yml
--- old/Net-Ident-1.24/META.yml 2014-12-14 08:12:06.000000000 +0100
+++ new/Net-Ident-1.25/META.yml 2020-01-19 07:04:57.000000000 +0100
@@ -9,7 +9,7 @@
 configure_requires:
   ExtUtils::MakeMaker: '0'
 dynamic_config: 1
-generated_by: 'ExtUtils::MakeMaker version 7.04, CPAN::Meta::Converter version 
2.143240'
+generated_by: 'ExtUtils::MakeMaker version 7.34, CPAN::Meta::Converter version 
2.150010'
 license: unknown
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -28,7 +28,8 @@
   Socket: '0'
   vars: '0'
 resources:
-  homepage: http://wiki.github.com/toddr/Net-Ident/
+  bugtracker: http://github.com/toddr/Net-Ident/issues
   license: http://dev.perl.org/licenses/
   repository: http://github.com/toddr/Net-Ident
-version: '1.24'
+version: '1.25'
+x_serialization_backend: 'CPAN::Meta::YAML version 0.018'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/Makefile.PL 
new/Net-Ident-1.25/Makefile.PL
--- old/Net-Ident-1.24/Makefile.PL      2014-12-14 08:01:54.000000000 +0100
+++ new/Net-Ident-1.25/Makefile.PL      2020-01-19 07:02:33.000000000 +0100
@@ -4,6 +4,8 @@
 # $Id: Makefile.PL,v 1.57 1999/08/27 00:00:09 john Exp $
 
 use strict;
+use warnings;
+
 use ExtUtils::MakeMaker qw(:DEFAULT prompt);
 use Getopt::Long;
 use Pod::Text;
@@ -20,7 +22,7 @@
 
 HELP
 
-use vars qw($opt_help $opt_force_compat $opt_test_apache);
+our ($opt_help, $opt_force_compat, $opt_test_apache);
 my %options = (
     'help|h'         => "Produce this helptext",
     'force-compat|c' => q{
@@ -645,9 +647,7 @@
         },
         resources => {
             license  => 'http://dev.perl.org/licenses/',
-            homepage => 'http://wiki.github.com/toddr/Net-Ident/',
-
-            #            bugtracker => 
'https://rt.cpan.org/Dist/Display.html?Queue=Net-Ident',
+            bugtracker => 'http://github.com/toddr/Net-Ident/issues',
             repository => 'http://github.com/toddr/Net-Ident',
         },
     },
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/README new/Net-Ident-1.25/README
--- old/Net-Ident-1.24/README   2010-06-07 06:30:34.000000000 +0200
+++ new/Net-Ident-1.25/README   1970-01-01 01:00:00.000000000 +0100
@@ -1,49 +0,0 @@
-NAME
-       Net::Ident - lookup the username on the remote end of a
-       TCP/IP connection
-
-SYNOPSIS
-        use Net::Ident;
-
-        $username = Net::Ident::lookup(SOCKET, $timeout);
-
-        $username = Net::Ident::lookupFromInAddr($localsockaddr,
-                                                  $remotesockaddr, $timeout);
-
-        $obj = Net::Ident->new(SOCKET, $timeout);
-        $obj = Net::Ident->newFromInAddr($localsockaddr, $remotesockaddr,
-                                               $timeout);
-        $status = $obj->query;
-        $status = $obj->ready;
-        $username = $obj->username;
-        ($username, $opsys, $error) = $obj->username;
-        $fh = $obj->getfh;
-        $txt = $obj->geterror;
-
-        use Net::Ident 'ident_lookup';
-
-        $username = ident_lookup(SOCKET, $timeout);
-
-        use Net::Ident 'lookupFromInAddr';
-
-        $username = lookupFromInAddr($localsockaddr, $remotesockaddr, 
$timeout);
-
-        use Net::Ident ':fh';
-
-        $username = SOCKET->ident_lookup($timeout);
-
-        use Net::Ident ':apache';
-
-        # my Apache $r;
-        $c = $r->connection;
-        $username = $c->ident_lookup($timeout);
-
-
-OVERVIEW
-       Net::Ident is a module that looks up the username on the
-       remote side of a TCP/IP connection through the ident
-       (auth/tap) protocol described in RFC1413 (which supersedes
-       RFC931). Note that this requires the remote site to run a
-       daemon (often called identd) to provide the requested
-       information, so it is not always available for all TCP/IP
-       connections.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/README.md new/Net-Ident-1.25/README.md
--- old/Net-Ident-1.24/README.md        1970-01-01 01:00:00.000000000 +0100
+++ new/Net-Ident-1.25/README.md        2020-01-19 06:42:06.000000000 +0100
@@ -0,0 +1,387 @@
+[![](https://github.com/toddr/Net-Ident/workflows/linux/badge.svg)](https://github.com/toddr/Net-Ident/actions)
 
[![](https://github.com/toddr/Net-Ident/workflows/macos/badge.svg)](https://github.com/toddr/Net-Ident/actions)
 
[![](https://github.com/toddr/Net-Ident/workflows/windows/badge.svg)](https://github.com/toddr/Net-Ident/actions)
+
+# NAME
+
+Net::Ident - lookup the username on the remote end of a TCP/IP connection
+
+# SYNOPSIS
+
+    use Net::Ident;
+    
+    $username = Net::Ident::lookup(SOCKET, $timeout);
+
+    $username = Net::Ident::lookupFromInAddr($localsockaddr,
+                                              $remotesockaddr, $timeout);
+    
+    $obj = Net::Ident->new(SOCKET, $timeout);
+    $obj = Net::Ident->newFromInAddr($localsockaddr, $remotesockaddr,
+                                           $timeout);
+    $status = $obj->query;
+    $status = $obj->ready;
+    $username = $obj->username;
+    ($username, $opsys, $error) = $obj->username;
+    $fh = $obj->getfh;
+    $txt = $obj->geterror;
+    
+    use Net::Ident 'ident_lookup';
+    
+    $username = ident_lookup(SOCKET, $timeout);
+
+    use Net::Ident 'lookupFromInAddr';
+
+    $username = lookupFromInAddr($localsockaddr, $remotesockaddr, $timeout);
+
+    use Net::Ident ':fh';
+
+    $username = SOCKET->ident_lookup($timeout);
+
+    use Net::Ident ':apache';
+
+    # my Apache $r;
+    $c = $r->connection;
+    $username = $c->ident_lookup($timeout);
+
+# OVERVIEW
+
+**Net::Ident** is a module that looks up the username on the remote
+side of a TCP/IP connection through the ident (auth/tap) protocol
+described in RFC1413 (which supersedes RFC931). Note that this
+requires the remote site to run a daemon (often called **identd**) to
+provide the requested information, so it is not always available for
+all TCP/IP connections.
+
+# DESCRIPTION
+
+You can either use the simple interface, which does one ident
+lookup at a time, or use the asynchronous interface to perform
+(possibly) many simultaneous lookups, or simply continue serving other
+things while the lookup is proceeding.
+
+## Simple Interface
+
+The simple interface comes in four varieties. An object oriented method
+call of a FileHandle object, an object oriented method of an Apache::Connection
+object, and as one of two different simple subroutine calls. Other than the
+calling method, these routines behave exactly the same.
+
+- `Net::Ident::lookup (SOCKET` \[`, $timeout`\]`)`
+
+    **Net::Ident::lookup** is an exportable function. However, due to the
+    generic name of the **lookup** function, it is recommended that you
+    instead import the alias function **Net::Ident::ident\_lookup**. Both
+    functions are exported through `@EXPORT_OK`, so you'll have to
+    explicitly ask for it if you want the function **ident\_lookup** to be
+    callable from your program.
+
+    You can pass the socket using either a string, which doesn't have to be
+    qualified with a package name, or using the more modern FileHandle calling
+    styles: as a glob or as a reference to a glob. The Socket has to be a
+    connected TCP/IP socket, ie. something which is either **connect()**ed
+    or **accept()**ed. The optional timeout parameter specifies a timeout
+    in seconds. If you do not specify a timeout, or use a value of undef,
+    there will be no timeout (apart from any default system timeouts like
+    TCP connection timeouts).
+
+- `Net::Ident::lookupFromInAddr ($localaddr, $remoteaddr` \[`, $timeout`\]`)`
+
+    **Net::Ident::lookupFromInAddr** is an exportable function (via 
`@EXPORT_OK`).
+    The arguments are the local and remote address of a connection, in packed
+    \`\`sockaddr'' format (the kind of thing that `getsockname` returns). The
+    optional timeout value specifies a timeout in seconds, see also the
+    description of the timeout value in the `Net::Ident::lookup` section above.
+
+    The given localaddr **must** have the IP address of a local interface of
+    the machine you're calling this on, otherwise an error will occur.
+
+    You can use this function whenever you have a local and remote socket 
address,
+    but no direct access to the socket itself. For example, because you are
+    parsing the output of "netstat" and extracting socket address, or because 
you
+    are writing a mod\_perl script under apache (in that case, also see the
+    Apache::Connection method below).
+
+- `ident_lookup SOCKET` \[`$timeout`\]
+
+    When you import the \`\`magic'' tag ':fh' using `use Net::Ident ':fh';`,
+    the **Net::Ident** module extends the **FileHandle** class with one
+    extra method call, **ident\_lookup**. It assumes that the object (a
+    FileHandle) it is operating on, is a connected TCP/IP socket,
+    ie. something which is either **connect()**ed or **accept()**ed. The 
optional
+    parameter specifies the timeout in seconds, just like the timeout parameter
+    of the function calls above.
+
+     
+
+    Some people do not like the way that \`\`proper'' object design is broken
+    by letting one module add methods to another class. This is why, starting
+    from version 1.20, you have to explicitly ask for this behaviour to occur.
+    Personally, I this it's a compromise: if you want an object-oriented
+    interface, then either you make a derived class, like a
+    FileHandleThatCanPerformIdentLookups, and make sure all appropriate
+    internal functions get wrappers that do the necessary re-blessing. Or,
+    you simply extend the FileHandle class. And since Perl doesn't object to 
this
+    (pun intended :), I find this an acceptable solution. But you might think
+    otherwise.
+
+- `ident_lookup Apache::Connection` \[`$timeout`\]
+
+    When you import the \`\`magic'' tag ':apache' using `use Net::Ident 
':apache';`,
+    the **Net::Ident** module extends the **Apache::Connection** class with one
+    extra method call, **ident\_lookup**. This method takes one optional 
parameter:
+    a timeout value in seconds.
+
+    This is a similar convenience function as the FileHandle::ident\_lookup 
method,
+    to be used with mod\_perl scripts under Apache.
+
+What these functions return depends on the context:
+
+- scalar context
+
+    In scalar context, these functions return the remote username on
+    success, or undef on error. "Error" is rather broad, it might mean:
+    some network error occurred, function arguments are invalid, the remote 
site
+    is not responding (in time) or is not running an ident daemon, or the
+    remote site ident daemon says there's no user connected with that
+    particular connection.
+
+    More precisely, the functions return whatever the remote daemon
+    specified as the ID that belongs to that particular connection. This
+    is often the username, but it doesn't necessarily have to be. Some
+    sites, out of privacy and/or security measures, return an opaque ID
+    that is unique for each user, but is not identical to the username.
+    See _RFC1413_ for more information.
+
+- array context
+
+    In array context, these functions return: `($username, $opsys,
+    $error)`.  The _$username_ is the remote username or ID, as returned
+    in the scalar context, or undef on error.
+
+    The _$opsys_ is the remote operating system as reported by the remote
+    ident daemon, or undef on a network error, or **"ERROR"** when the
+    remote ident daemon reported an error. This could also contain the
+    character set of the returned username. See RFC1413.
+
+    The _$error_ is the error message, either the error reported by the
+    remote ident daemon (in which case _$opsys_ is **"ERROR"**), or the
+    internal message from the **Net::Ident** module, which includes the
+    system errno `$!` whenever possible. A likely candidate is
+    **"Connection refused"** when the remote site isn't running an ident
+    daemon, or **"Connection timed out"** when the remote site isn't
+    answering our connection request.
+
+    When _$username_ has a value, _$error_ is always undef, and vice versa.
+
+## EXAMPLE
+
+The following code is a complete example, implementing a server that
+waits for a connection on a port, tells you who you are and what time
+it is, and closes the connection again. The majority of the code will
+look very familiar if you just read 
[perlipc](https://metacpan.org/pod/perlipc).
+
+Excersize this server by telnetting to it, preferably from a machine
+that has a suitable ident daemon installed.
+
+    #!/usr/bin/perl -w
+
+    use Net::Ident;
+    # uncomment the below line if you want lots of debugging info
+    # $Net::Ident::DEBUG = 2;
+    use Socket;
+    use strict;
+    
+    sub logmsg { print "$0 $$: @_ at ", scalar localtime, "\n" }
+    
+    my $port = shift || 2345;
+    my $proto = getprotobyname('tcp');
+    socket(Server, PF_INET, SOCK_STREAM, $proto) or die "socket: $!";
+    setsockopt(Server, SOL_SOCKET, SO_REUSEADDR, pack("l", 1)) or
+      die "setsockopt: $!";
+    bind(Server, sockaddr_in($port, INADDR_ANY)) or die "bind: $!";
+    listen(Server,SOMAXCONN) or die "listen: $!";
+    
+    logmsg "server started on port $port";
+    
+    my $paddr;
+    
+    for ( ; $paddr = accept(Client,Server); close Client) {
+        my($port,$iaddr) = sockaddr_in($paddr);
+        my $name = gethostbyaddr($iaddr,AF_INET) || inet_ntoa($iaddr);
+        logmsg "connection from $name [" . inet_ntoa($iaddr) .
+          "] at port $port";
+       
+        my $username = Client->ident_lookup(30) || "~unknown";
+        logmsg "User at $name:$port is $username";
+        
+        print Client "Hello there, $username\@$name, it's now ",
+           scalar localtime, "\n";
+    }
+
+## Asynchronous Interface
+
+The asynchronous interface is meant for those who know the ins and outs
+of the `select()` call (the 4-argument version of `select()`, but I
+didn't need saying that, did I?). This interface is completely object
+oriented. The following methods are available:
+
+- `new Net::Ident SOCKET, $timeout`
+
+    This constructs a new Net::Ident object, and initiates the connection
+    to the remote ident daemon. The parameters are the same as described
+    above for the **Net::Ident::lookup** subroutine. This method returns
+    immediately, the supplied _$timeout_ is only stored in the object and
+    used in future methods.
+
+    If you want to implement your own timeout, that's fine. Simply throw
+    away the object when you don't want it anymore.
+
+    The constructor will always succeed. When it detects an error,
+    however, it returns an object that "has already failed" internally. In
+    this case, all methods will return `undef` except for the `geterror`
+    method, wich will return the error message.
+
+    The timeout is _not_ implemented using `alarm()`. In fact you can
+    use `alarm()` completely independant of this library, they do not
+    interfere.
+
+- `newFromInAddr $localaddr, $remoteaddr, $timeout`
+
+    Alternative constructor, that takes two packed sockaddr structures. 
Otherwise
+    behaves identical to the `new` constructor above.
+
+- `query $obj`
+
+    This object method queries the remote rfc931 deamon, and blocks until
+    the connection to the ident daemon is writable, if necessary (but you
+    are supposed to make sure it is, of course). Returns true on success
+    (or rather it returns the _$obj_ itself), or undef on error.
+
+- `ready $obj` \[`$blocking`\]
+
+    This object method returns whether the data received from the remote
+    daemon is complete (true or false). Returns undef on error. Reads any
+    data from the connection.  If _$blocking_ is true, it blocks and
+    waits until all data is received (it never returns false when blocking
+    is true, only true or undef). If _$blocking_ is not true, it doesn't
+    block at all (unless... see below).
+
+    If you didn't call `query $obj` yet, this method calls it for you,
+    which means it _can_ block, regardless of the value of _$blocking_,
+    depending on whether the connection to the ident is writable.
+
+    Obviously, you are supposed to call this routine whenever you see that
+    the connection to the ident daemon is readable, and act appropriately
+    when this returns true.
+
+    Note that once **ready** returns true, there are no longer checks on
+    timeout (because the networking part of the lookup is over anyway).
+    This means that even `ready $obj` can return true way after the
+    timeout has expired, provided it returned true at least once before
+    the timeout expired. This is to be construed as a feature.
+
+- `username $obj`
+
+    This object method parses the return from the remote ident daemon, and
+    blocks until the query is complete, if necessary (it effectively calls
+    `ready $obj 1` for you if you didn't do it yourself). Returns the
+    parsed username on success, or undef on error. In an array context,
+    the return values are the same as described for the
+    **Net::Ident::lookup** subroutine.
+
+- `getfh $obj`
+
+    This object method returns the internal FileHandle used for the
+    connection to the remote ident daemon. Invaluable if you want it to
+    dance in your select() ring. Returns undef when an error has occurred.
+
+- `geterror $obj`
+
+    This object method returns the error message in case there was an
+    error. undef when there was no error.
+
+An asynchronous example implementing the above server in a multi-threaded
+way via select, is left as an excersize for the interested reader.
+
+# DISCLAIMER
+
+I make NO WARRANTY or representation, either express or implied,
+with respect to this software, its quality, accuracy, merchantability, or
+fitness for a particular purpose.  This software is provided "AS IS",
+and you, its user, assume the entire risk as to its quality and accuracy.
+
+# AUTHOR
+
+Jan-Pieter Cornet, <[email protected]>
+
+# COPYRIGHT
+
+Copyright (c) 1995, 1997, 1999 Jan-Pieter Cornet. All rights reserved. You
+can distribute and use this program under the same terms as Perl itself.
+
+# REVISION HISTORY
+
+- V1.20
+
+    August 2, 1999. Finally implemented the long-asked-for lookupFromInAddr
+    method. Other changes:
+
+    - No longer imports ident\_lookup into package FileHandle by default, 
unless you
+    explicitly ask for it (or unless you installed it that way during compile 
time
+    for compatibility reasons).
+    - Allow adding an ident\_lookup method to the Apache::Connection class, as 
a
+    convenience for mod\_perl script writers.
+    - Rewritten tests, included test for the Apache::Connection method by 
actually
+    launching apache and performing ident lookups from within mod\_perl.
+    - Moved selection of FileHandle/IO::Handle class out of the Makefile.PL. 
+    PAUSE/CPAN didn't really like modules that weren't present in the
+    distribution, and it didn't allow you to upgrade your perl version
+    underneath.
+
+- V1.11
+
+    Jan 15th, 1997. Several bugfixes, and some slight interface changes:
+
+    - constructor now called `new` instead of `initconnect`, constructor
+    now always succeeds, if something has gone wrong in the constructor,
+    all methods return undef (like `getfh`), except for `geterror`, which
+    returns the error message.
+    - The recommended exported function is now `ident_lookup` instead of
+    `lookup`
+    - Fixed a bug: now chooses O\_NDELAY or O\_NONBLOCK from %Config, instead
+    of hardcoding O\_NDELAY (argh)
+    - Adding a method to FileHandle would break in perl5.004, it should get
+    added in IO::Handle. Added intelligence in Makefile.PL to detect that
+    and choose the appropriate package.
+    - Miscellaneous pod fixes.
+    - Test script now actually tests multiple different things.
+
+- V1.10
+
+    Jan 11th, 1997. Complete rewrite for perl5. Requires perl5.002 or up.
+
+- V1.02
+
+    Jan 20th, 1995. Quite a big bugfix: "connection refused" to the ident
+    port would kill the perl process with a SIGPIPE if the connect didn't
+    immediately signal it (ie. almost always on remote machines). Also
+    recognises the perl5 package separator :: now on fully qualified
+    descriptors. This is still perl4-compatible, a perl5- only version
+    would require a rewrite to make it neater.  Fixed the constants
+    normally found in .ph files (but you shouldn't use those anyway).
+
+    \[this release wasn't called **Net::Ident**, of course, it was called
+    **rfc931.pl**\]
+
+- V1.01
+
+    Around November 1994. Removed a spurious **perl5 -w** complaint. First
+    public release.  Has been tested against **perl 5.000** and **perl 4.036**.
+
+- V1.00
+
+    Dunno, somewhere 1994. First neat collection of dusty routines put in
+    a package.
+
+# SEE ALSO
+
+[Socket](https://metacpan.org/pod/Socket)
+RFC1413, RFC931
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Net-Ident-1.24/t/apache.t 
new/Net-Ident-1.25/t/apache.t
--- old/Net-Ident-1.24/t/apache.t       2014-12-14 08:01:54.000000000 +0100
+++ new/Net-Ident-1.25/t/apache.t       2020-01-19 07:02:33.000000000 +0100
@@ -1,6 +1,8 @@
 # $Id: apache.t,v 1.28 1999/08/26 23:39:52 john Exp $
 
 use strict;
+use warnings;
+
 use Cwd;
 use IO::Socket;
 use Net::Ident;
@@ -33,7 +35,7 @@
     };
 }
 
-use vars qw($apache_bin $apache_addr $apache_root $username $ourpid);
+my ($apache_bin, $apache_addr, $apache_root, $username, $ourpid);
 
 END {
     # make sure apache dies when we exit, but only if we exit ourselves

++++++ cpanspec.yml ++++++
---
#description_paragraphs: 3
#description: |-
#  override description from CPAN
#summary: override summary from CPAN
#no_testing: broken upstream
#sources:
#  - source1
#  - source2
#patches:
#  foo.patch: -p1
#  bar.patch:
#preamble: |-
# BuildRequires:  gcc-c++
#post_prep: |-
# hunspell=`pkg-config --libs hunspell | sed -e 's,-l,,; s,  *,,g'`
# sed -i -e "s,hunspell-X,$hunspell," t/00-prereq.t Makefile.PL 
#post_build: |-
# rm unused.files
#post_install: |-
# sed on %{name}.files
#license: SUSE-NonFree
#skip_noarch: 1
#custom_build: |-
#./Build build flags=%{?_smp_mflags} --myflag
#custom_test: |-
#startserver && make test
#ignore_requires: Bizarre::Module

Reply via email to