Hello community, here is the log from the commit of package libvirt for openSUSE:Leap:15.2 checked in at 2020-02-16 18:25:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/libvirt (Old) and /work/SRC/openSUSE:Leap:15.2/.libvirt.new.26092 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libvirt" Sun Feb 16 18:25:53 2020 rev:110 rq:772170 version:6.0.0 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/libvirt/libvirt.changes 2020-02-04 17:54:29.720752018 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.libvirt.new.26092/libvirt.changes 2020-02-16 18:25:54.322642139 +0100 @@ -1,0 +2,26 @@ +Wed Feb 5 22:51:48 UTC 2020 - James Fehlig <[email protected]> + +- xen: Fix the list of supported ovmf firmwares + suse-xen-ovmf-loaders.patch + bsc#1159793 + +------------------------------------------------------------------- +Mon Feb 3 18:32:49 UTC 2020 - James Fehlig <[email protected]> + +- lib: Prohibit parallel connections with tunneled migration + e092daac-prohib-parallel-tunneled-mig.patch + jsc#SLE-6998 + +------------------------------------------------------------------- +Mon Feb 3 15:27:17 UTC 2020 - Dominique Leuenberger <[email protected]> + +- BuildRequire pkgconfig((lib)?udev) instead of (lib)?udev: allow + OBS to shortcut through -mini flavors. + +------------------------------------------------------------------- +Thu Jan 30 22:05:24 UTC 2020 - James Fehlig <[email protected]> + +- spec: Fix several rpmlint warnings + 72ed254b-drop-exec-perms-bashcompletion.patch + +------------------------------------------------------------------- New: ---- 72ed254b-drop-exec-perms-bashcompletion.patch e092daac-prohib-parallel-tunneled-mig.patch suse-xen-ovmf-loaders.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libvirt.spec ++++++ --- /var/tmp/diff_new_pack.oSo6rA/_old 2020-02-16 18:25:55.182642589 +0100 +++ /var/tmp/diff_new_pack.oSo6rA/_new 2020-02-16 18:25:55.186642591 +0100 @@ -251,8 +251,8 @@ # For pool-build probing for existing pools BuildRequires: libblkid-devel >= 2.17 BuildRequires: libpciaccess0-devel >= 0.10.9 -BuildRequires: libudev-devel >= 145 BuildRequires: libyajl-devel +BuildRequires: pkgconfig(libudev) >= 145 %if %{with_sanlock} BuildRequires: sanlock-devel >= 2.4 %endif @@ -340,6 +340,8 @@ # Upstream patches Patch0: 6c1dddaf-libxl-shutdown-inhibit.patch Patch1: 849052ec-libxl-support-credit2.patch +Patch2: 72ed254b-drop-exec-perms-bashcompletion.patch +Patch3: e092daac-prohib-parallel-tunneled-mig.patch # Patches pending upstream review Patch100: libxl-dom-reset.patch Patch101: network-don-t-use-dhcp-authoritative-on-static-netwo.patch @@ -366,6 +368,7 @@ Patch211: libvirt-suse-netcontrol.patch Patch212: lxc-wait-after-eth-del.patch Patch213: suse-libxl-disable-autoballoon.patch +Patch214: suse-xen-ovmf-loaders.patch # SLES-Only patches %if ! 0%{?is_opensuse} Patch400: virt-create-rootfs.patch @@ -403,7 +406,7 @@ # for /sbin/ip & /sbin/tc Requires: iproute Requires: logrotate -Requires: udev >= 145 +Requires: pkgconfig(udev) >= 145 Recommends: polkit >= 0.112 %ifarch %ix86 x86_64 ia64 # For virConnectGetSysinfo @@ -417,8 +420,7 @@ # libvirtd depends on 'messagebus' service Requires: dbus-1 -# libvirt is configured with paths to UEFI firmwares in %build, -# hence add a dependency to the firmware packages +# A KVM or Xen libvirt stack really does need UEFI firmware these days %ifarch x86_64 Requires: qemu-ovmf-x86_64 %endif @@ -835,7 +837,7 @@ %package devel Summary: Libraries, includes, etc. to compile with the libvirt library Group: Development/Libraries/C and C++ -Requires: %{name}-client = %{version}-%{release} +Requires: %{name}-libs = %{version}-%{release} Suggests: %{name}-doc = %{version}-%{release} Requires: pkg-config @@ -875,6 +877,8 @@ %setup -q %patch0 -p1 %patch1 -p1 +%patch2 -p1 +%patch3 -p1 %patch100 -p1 %patch101 -p1 %patch150 -p1 @@ -898,6 +902,7 @@ %patch211 -p1 %patch212 -p1 %patch213 -p1 +%patch214 -p1 %if ! 0%{?is_opensuse} %patch400 -p1 %endif @@ -1244,7 +1249,7 @@ %pre daemon %{_bindir}/getent group libvirt >/dev/null || %{_sbindir}/groupadd -r libvirt -%service_add_pre libvirtd.service virtlockd.service virtlockd.socket virtlogd.service virtlogd.socket virtlockd-admin.socket virtlogd-admin.socket +%service_add_pre libvirtd.service libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tcp.socket libvirtd-tls.socket virtlockd.service virtlockd.socket virtlogd.service virtlogd.socket virtlockd-admin.socket virtlogd-admin.socket virtproxyd.service virtproxyd.socket virtproxyd-ro.socket virtproxyd-admin.socket virtproxyd-tcp.socket virtproxyd-tls.socket virt-guest-shutdown.target %post daemon /sbin/ldconfig @@ -1254,7 +1259,7 @@ %if %{with_firewalld} %firewalld_reload %endif -%service_add_post libvirtd.service libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tcp.socket libvirtd-tls.socket virtlockd.service virtlockd.socket virtlogd.service virtlogd.socket virtlockd-admin.socket virtlogd-admin.socket virtproxyd.service virtproxyd.socket virtproxyd-ro.socket virtproxyd-admin.socket virtproxyd-tcp.socket virtproxyd-tls.socket +%service_add_post libvirtd.service libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tcp.socket libvirtd-tls.socket virtlockd.service virtlockd.socket virtlogd.service virtlogd.socket virtlockd-admin.socket virtlogd-admin.socket virtproxyd.service virtproxyd.socket virtproxyd-ro.socket virtproxyd-admin.socket virtproxyd-tcp.socket virtproxyd-tls.socket virt-guest-shutdown.target %{fillup_only -n libvirtd} %{fillup_only -n virtlockd} %{fillup_only -n virtlogd} @@ -1268,7 +1273,7 @@ fi %preun daemon -%service_del_preun libvirtd.service libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tcp.socket libvirtd-tls.socket virtlockd.service virtlockd.socket virtlogd.service virtlogd.socket virtlockd-admin.socket virtlogd-admin.socket +%service_del_preun libvirtd.service libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tcp.socket libvirtd-tls.socket virtlockd.service virtlockd.socket virtlogd.service virtlogd.socket virtlockd-admin.socket virtlogd-admin.socket virtproxyd.service virtproxyd.socket virtproxyd-ro.socket virtproxyd-admin.socket virtproxyd-tcp.socket virtproxyd-tls.socket virt-guest-shutdown.target %postun daemon /sbin/ldconfig @@ -1279,7 +1284,7 @@ done /usr/bin/systemctl daemon-reload >/dev/null 2>&1 || : fi -%service_del_postun libvirtd.service virtlockd.service virtlockd.socket virtlogd.service virtlogd.socket virtlockd-admin.socket virtlogd-admin.socket +%service_del_postun libvirtd.service libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tcp.socket libvirtd-tls.socket virtlockd.service virtlockd.socket virtlogd.service virtlogd.socket virtlockd-admin.socket virtlogd-admin.socket virtproxyd.service virtproxyd.socket virtproxyd-ro.socket virtproxyd-admin.socket virtproxyd-tcp.socket virtproxyd-tls.socket virt-guest-shutdown.target %posttrans daemon # All connection drivers should be installed post transaction. @@ -1343,17 +1348,17 @@ %postun daemon-driver-nwfilter %service_del_postun virtnwfilterd.service virtnwfilterd.socket virtnwfilterd-ro.socket virtnwfilterd-admin.socket -%pre daemon-driver-storage +%pre daemon-driver-storage-core %service_add_pre virtstoraged.service virtstoraged.socket virtstoraged-ro.socket virtstoraged-admin.socket -%post daemon-driver-storage +%post daemon-driver-storage-core %service_add_post virtstoraged.service virtstoraged.socket virtstoraged-ro.socket virtstoraged-admin.socket %{fillup_only -n virtstoraged} -%preun daemon-driver-storage +%preun daemon-driver-storage-core %service_del_preun virtstoraged.service virtstoraged.socket virtstoraged-ro.socket virtstoraged-admin.socket -%postun daemon-driver-storage +%postun daemon-driver-storage-core %service_del_postun virtstoraged.service virtstoraged.socket virtstoraged-ro.socket virtstoraged-admin.socket %pre daemon-driver-interface ++++++ 72ed254b-drop-exec-perms-bashcompletion.patch ++++++ commit 72ed254b38571a2139ed2a43607e07750fea459f Author: Jim Fehlig <[email protected]> Date: Thu Jan 30 11:29:41 2020 -0700 build: Drop execute permissions on virsh bash completion command rpmlint complains about "script-without-shebang" due to the execute permissions on /usr/share/bash-completion/completions/vsh. Use INSTALL_DATA instead of INSTALL_SCRIPT to avoid the unnecessary execute permissions. Signed-off-by: Jim Fehlig <[email protected]> Reviewed-by: Michal Privoznik <[email protected]> Index: libvirt-6.0.0/tools/Makefile.am =================================================================== --- libvirt-6.0.0.orig/tools/Makefile.am +++ libvirt-6.0.0/tools/Makefile.am @@ -357,7 +357,7 @@ libvirt-guests.service: libvirt-guests.s if WITH_BASH_COMPLETION install-bash-completion: $(MKDIR_P) "$(DESTDIR)$(BASH_COMPLETIONS_DIR)" - $(INSTALL_SCRIPT) $(srcdir)/bash-completion/vsh \ + $(INSTALL_DATA) $(srcdir)/bash-completion/vsh \ "$(DESTDIR)$(BASH_COMPLETIONS_DIR)/vsh" ( cd $(DESTDIR)$(BASH_COMPLETIONS_DIR) && \ rm -f virsh virt-admin && \ ++++++ e092daac-prohib-parallel-tunneled-mig.patch ++++++ commit e092daacee330b8f758bceaf1e9a0ccfec2e00c8 Author: Jim Fehlig <[email protected]> Date: Fri Jan 17 10:36:32 2020 -0700 lib: Prohibit parallel connections with tunneled migration As discussed on the developer list, parallel migration connections are not compatible with tunneled migration https://www.redhat.com/archives/libvir-list/2020-January/msg00463.html Prohibit the concurrent use of parallel and tunneled migration options. Signed-off-by: Jim Fehlig <[email protected]> Reviewed-by: Ján Tomko <[email protected]> Index: libvirt-6.0.0/src/libvirt-domain.c =================================================================== --- libvirt-6.0.0.orig/src/libvirt-domain.c +++ libvirt-6.0.0/src/libvirt-domain.c @@ -3548,6 +3548,10 @@ virDomainMigrate(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_TUNNELLED, + VIR_MIGRATE_PARALLEL, + error); + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { @@ -3703,6 +3707,10 @@ virDomainMigrate2(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_TUNNELLED, + VIR_MIGRATE_PARALLEL, + error); + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { @@ -4089,6 +4097,10 @@ virDomainMigrateToURI(virDomainPtr domai virCheckReadOnlyGoto(domain->conn->flags, error); virCheckNonNullArgGoto(duri, error); + VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_TUNNELLED, + VIR_MIGRATE_PARALLEL, + error); + if (virDomainMigrateUnmanagedCheckCompat(domain, flags) < 0) goto error; @@ -4161,6 +4173,10 @@ virDomainMigrateToURI2(virDomainPtr doma virCheckDomainReturn(domain, -1); virCheckReadOnlyGoto(domain->conn->flags, error); + VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_TUNNELLED, + VIR_MIGRATE_PARALLEL, + error); + if (virDomainMigrateUnmanagedCheckCompat(domain, flags) < 0) goto error; @@ -4234,6 +4250,10 @@ virDomainMigrateToURI3(virDomainPtr doma virCheckDomainReturn(domain, -1); virCheckReadOnlyGoto(domain->conn->flags, error); + VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_TUNNELLED, + VIR_MIGRATE_PARALLEL, + error); + if (virDomainMigrateUnmanagedCheckCompat(domain, flags) < 0) goto error; ++++++ suse-xen-ovmf-loaders.patch ++++++ libxl: Temporarily hardcode paths to ovmf firmwares This is a quick, hacky fix for bsc#1159793 until there is time to work on upstream support for firmware autoselection in the xen driver. Sadly, the upstream efforts to improve firmware handling in the qemu driver broke the firmware handling in the xen driver. Index: libvirt-6.0.0/src/libxl/libxl_conf.c =================================================================== --- libvirt-6.0.0.orig/src/libxl/libxl_conf.c +++ libvirt-6.0.0/src/libxl/libxl_conf.c @@ -1776,6 +1776,15 @@ libxlDriverConfigNew(void) goto error; } + /* Begin hack --- + * bsc#1159793: Until there is time to work on proper upstream support for + * firmware autoselection in the xen driver we'll go with this minimal fix. + */ +#define DEFAULT_LOADER_NVRAM "/usr/share/qemu/ovmf-x86_64-ms-4m.bin:/usr/share/qemu/ovmf-x86_64-ms-4m-vars.bin:/usr/share/qemu/ovmf-x86_64-ms.bin:/usr/share/qemu/ovmf-x86_64-ms-vars.bin" + /* + * --- End hack + */ + #ifdef DEFAULT_LOADER_NVRAM if (virFirmwareParseList(DEFAULT_LOADER_NVRAM, &cfg->firmwares,
