Hello community, here is the log from the commit of package totem for openSUSE:Leap:15.2 checked in at 2020-03-06 12:37:51 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/totem (Old) and /work/SRC/openSUSE:Leap:15.2/.totem.new.26092 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "totem" Fri Mar 6 12:37:51 2020 rev:40 rq:779633 version:3.34.1 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/totem/totem.changes 2020-01-30 14:49:12.234864281 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.totem.new.26092/totem.changes 2020-03-06 12:38:15.502647095 +0100 @@ -1,0 +2,11 @@ +Sat Jan 25 14:20:24 UTC 2020 - Dominique Leuenberger <[email protected]> + +- No longer recommend -lang: supplements are in use + +------------------------------------------------------------------- +Sat Jan 11 20:05:25 UTC 2020 - Bjørn Lie <[email protected]> + +- Add totem-Fix-bracket-keys-and-backspace.patch: variable-rate: + Fix bracket keys and backspace not working in search entry. + +------------------------------------------------------------------- New: ---- totem-Fix-bracket-keys-and-backspace.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ totem.spec ++++++ --- /var/tmp/diff_new_pack.s8hpJ4/_old 2020-03-06 12:38:17.074648050 +0100 +++ /var/tmp/diff_new_pack.s8hpJ4/_new 2020-03-06 12:38:17.114648074 +0100 @@ -1,7 +1,7 @@ # # spec file for package totem # -# Copyright (c) 2019 SUSE LLC +# Copyright (c) 2020 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -27,6 +27,8 @@ Source0: https://download.gnome.org/sources/totem/3.34/%{name}-%{version}.tar.xz # PATCH-FEATURE-OPENSUSE totem-revert-vaapi-disable.patch -- Revert upstreams disabling of vaapi support Patch0: totem-revert-vaapi-disable.patch +# PATCH-FIX-UPSTREAM totem-Fix-bracket-keys-and-backspace.patch -- variable-rate: Fix bracket keys and backspace not working +Patch1: totem-Fix-bracket-keys-and-backspace.patch BuildRequires: appstream-glib BuildRequires: fdupes @@ -68,7 +70,6 @@ Requires: gstreamer-plugins-base Requires: gstreamer-plugins-good Requires: iso-codes -Recommends: %{name}-lang # Required for cluttersink Recommends: gstreamer-plugin-cluttergst3 Recommends: gstreamer-plugins-bad ++++++ totem-Fix-bracket-keys-and-backspace.patch ++++++ >From af5c6473920f30b4d0d65dc702fe91bf2da7ba7d Mon Sep 17 00:00:00 2001 From: Gabor Karsay <[email protected]> Date: Mon, 21 Oct 2019 12:24:31 +0200 Subject: [PATCH] variable-rate: Fix bracket keys and backspace not working in search entry Let plugin handle key press events only in player mode and propagate them in all other modes, e.g. to the search entry. Closes: #212 --- .../totem-variable-rate-plugin.c | 28 ++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/src/plugins/variable-rate/totem-variable-rate-plugin.c b/src/plugins/variable-rate/totem-variable-rate-plugin.c index 792c0cb69..c59a31078 100644 --- a/src/plugins/variable-rate/totem-variable-rate-plugin.c +++ b/src/plugins/variable-rate/totem-variable-rate-plugin.c @@ -48,8 +48,10 @@ typedef struct { TotemObject *totem; guint handler_id_key_press; + guint handler_id_main_page; GSimpleAction *action; GMenuItem *submenu_item; + gboolean player_page; } TotemVariableRatePluginPrivate; #define NUM_RATES 6 @@ -161,12 +163,24 @@ change_rate (TotemVariableRatePlugin *pi, g_action_change_state (G_ACTION (priv->action), state); } +static void +on_totem_main_page_notify (GObject *object, GParamSpec *spec, TotemVariableRatePlugin *plugin) +{ + TotemVariableRatePlugin *pi = TOTEM_VARIABLE_RATE_PLUGIN (plugin); + char *main_page; + + g_object_get (pi->priv->totem, "main-page", &main_page, NULL); + pi->priv->player_page = (g_strcmp0 (main_page, "player") == 0); + g_free (main_page); +} + static gboolean on_window_key_press_event (GtkWidget *window, GdkEventKey *event, TotemVariableRatePlugin *plugin) { TotemVariableRatePlugin *pi = TOTEM_VARIABLE_RATE_PLUGIN (plugin); - if (event->state == 0 || + if (!pi->priv->player_page || + event->state == 0 || event->state & (GDK_CONTROL_MASK | GDK_SUPER_MASK | GDK_HYPER_MASK | GDK_META_MASK)) { return FALSE; } @@ -200,6 +214,12 @@ impl_activate (PeasActivatable *plugin) priv->totem = g_object_get_data (G_OBJECT (plugin), "object"); + /* Cache totem's main page */ + priv->handler_id_main_page = g_signal_connect (G_OBJECT(priv->totem), + "notify::main-page", + G_CALLBACK (on_totem_main_page_notify), + pi); + /* Key press handler */ window = totem_object_get_main_window (priv->totem); priv->handler_id_key_press = g_signal_connect (G_OBJECT(window), @@ -245,6 +265,12 @@ impl_deactivate (PeasActivatable *plugin) g_object_unref (window); } + if (priv->handler_id_main_page != 0) { + g_signal_handler_disconnect (G_OBJECT(priv->totem), + priv->handler_id_main_page); + priv->handler_id_main_page = 0; + } + /* Remove the menu */ totem_object_empty_menu_section (priv->totem, "variable-rate-placeholder"); -- 2.24.1
