Hello community, here is the log from the commit of package yast2-network for openSUSE:Factory checked in at 2020-03-07 21:36:54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-network (Old) and /work/SRC/openSUSE:Factory/.yast2-network.new.26092 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network" Sat Mar 7 21:36:54 2020 rev:420 rq:781522 version:4.2.60 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes 2020-03-01 21:27:33.932501816 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-network.new.26092/yast2-network.changes 2020-03-07 21:36:56.232219428 +0100 @@ -1,0 +2,15 @@ +Mon Mar 2 21:01:33 UTC 2020 - Michal Filka <mfi...@suse.com> + +- bsc#1164506 + - fixed setting hostname in installer +- bsc#1164587 + - fixed setting hostname according to AY profile +- 4.2.60 + +------------------------------------------------------------------- +Mon Mar 2 19:12:32 UTC 2020 - Knut Anderssen <kanders...@suse.com> + +- Do not modify interface name when enslaving it (bsc#1165463) +- 4.2.59 + +------------------------------------------------------------------- Old: ---- yast2-network-4.2.58.tar.bz2 New: ---- yast2-network-4.2.60.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-network.spec ++++++ --- /var/tmp/diff_new_pack.lHu4xt/_old 2020-03-07 21:36:57.392220211 +0100 +++ /var/tmp/diff_new_pack.lHu4xt/_new 2020-03-07 21:36:57.396220214 +0100 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.2.58 +Version: 4.2.60 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only ++++++ yast2-network-4.2.58.tar.bz2 -> yast2-network-4.2.60.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/package/yast2-network.changes new/yast2-network-4.2.60/package/yast2-network.changes --- old/yast2-network-4.2.58/package/yast2-network.changes 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/package/yast2-network.changes 2020-03-04 08:24:53.000000000 +0100 @@ -1,4 +1,19 @@ ------------------------------------------------------------------- +Mon Mar 2 21:01:33 UTC 2020 - Michal Filka <mfi...@suse.com> + +- bsc#1164506 + - fixed setting hostname in installer +- bsc#1164587 + - fixed setting hostname according to AY profile +- 4.2.60 + +------------------------------------------------------------------- +Mon Mar 2 19:12:32 UTC 2020 - Knut Anderssen <kanders...@suse.com> + +- Do not modify interface name when enslaving it (bsc#1165463) +- 4.2.59 + +------------------------------------------------------------------- Thu Feb 27 20:40:51 UTC 2020 - Knut Anderssen <kanders...@suse.com> - Do not crash when running the network configuration client if diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/package/yast2-network.spec new/yast2-network-4.2.60/package/yast2-network.spec --- old/yast2-network-4.2.58/package/yast2-network.spec 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/package/yast2-network.spec 2020-03-04 08:24:53.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.2.58 +Version: 4.2.60 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/src/include/network/services/dns.rb new/yast2-network-4.2.60/src/include/network/services/dns.rb --- old/yast2-network-4.2.58/src/include/network/services/dns.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/src/include/network/services/dns.rb 2020-03-04 08:24:53.000000000 +0100 @@ -257,6 +257,18 @@ deep_copy(settings) end + # Stores user's input from hostname field + # + # @param value [String] + # @return [String] stored hostname + def store_hostname(value) + hostname = Yast::Lan.yast_config.hostname + hostname.static = value + hostname.installer = value if Stage.initial + + value + end + # @param [Hash] settings map of settings to be stored to DNS:: def StoreSettings(settings) settings = deep_copy(settings) @@ -270,7 +282,8 @@ " ,\n\t" ) - DNS.hostname = Ops.get_string(settings, "HOSTNAME", "") + store_hostname(settings["HOSTNAME"] || "") + valid_nameservers = NonEmpty(nameservers).each_with_object([]) do |ip_str, all| all << IPAddr.new(ip_str) if IP.Check(ip_str) end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/src/lib/y2network/autoinst/config_reader.rb new/yast2-network-4.2.60/src/lib/y2network/autoinst/config_reader.rb --- old/yast2-network-4.2.58/src/lib/y2network/autoinst/config_reader.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/src/lib/y2network/autoinst/config_reader.rb 2020-03-04 08:24:53.000000000 +0100 @@ -22,6 +22,7 @@ require "y2network/config" require "y2network/autoinst/routing_reader" require "y2network/autoinst/dns_reader" +require "y2network/autoinst/hostname_reader" require "y2network/autoinst/interfaces_reader" require "y2network/autoinst/udev_rules_reader" require "y2network/autoinst_profile/networking_section" @@ -48,10 +49,13 @@ # @return [Y2Network::Config] Network configuration def config config = @original_config.copy + # apply at first udev rules, so interfaces names are correct UdevRulesReader.new(section.udev_rules).apply(config) if section.udev_rules config.routing = RoutingReader.new(section.routing).config if section.routing config.dns = DNSReader.new(section.dns).config if section.dns + config.hostname = HostnameReader.new(section.dns).config if section.dns + if section.interfaces interfaces = InterfacesReader.new(section.interfaces).config interfaces.each do |interface| diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/src/lib/y2network/autoinst/hostname_reader.rb new/yast2-network-4.2.60/src/lib/y2network/autoinst/hostname_reader.rb --- old/yast2-network-4.2.58/src/lib/y2network/autoinst/hostname_reader.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/src/lib/y2network/autoinst/hostname_reader.rb 2020-03-04 08:24:53.000000000 +0100 @@ -40,7 +40,8 @@ def config Y2Network::Hostname.new( dhcp_hostname: section.dhcp_hostname, - hostname: section.hostname || default_hostname + static: section.hostname || default_hostname, + installer: section.hostname ) end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/src/lib/y2network/hostname.rb new/yast2-network-4.2.60/src/lib/y2network/hostname.rb --- old/yast2-network-4.2.58/src/lib/y2network/hostname.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/src/lib/y2network/hostname.rb 2020-03-04 08:24:53.000000000 +0100 @@ -31,7 +31,8 @@ # @return [String] dynamically defined hostname (e.g. from DHCP), defaults to static attr_accessor :transient - # @return [String, nil] hostname as read from linuxrc (if set) in installer, nil otherwise + # @return [String, nil] hostname as read from linuxrc (if set) or explicitly set + # in installer, nil otherwise attr_accessor :installer # @return [String,Symbol] Whether to take the hostname from DHCP. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/src/lib/y2network/interface.rb new/yast2-network-4.2.60/src/lib/y2network/interface.rb --- old/yast2-network-4.2.58/src/lib/y2network/interface.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/src/lib/y2network/interface.rb 2020-03-04 08:24:53.000000000 +0100 @@ -74,7 +74,7 @@ # @param name [String] Interface name (e.g., "eth0") # @param type [InterfaceType] Interface type def initialize(name, type: InterfaceType::ETHERNET) - @name = name + @name = name.freeze @description = "" @type = type # TODO: move renaming logic to physical interfaces only @@ -109,7 +109,7 @@ def rename(new_name, mechanism) log.info "Rename interface '#{name}' to '#{new_name}' using the '#{mechanism}'" @old_name = name if name != new_name # same name, just set different mechanism - @name = new_name + @name = new_name.freeze @renaming_mechanism = mechanism end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/src/lib/y2network/sysconfig/hostname_writer.rb new/yast2-network-4.2.60/src/lib/y2network/sysconfig/hostname_writer.rb --- old/yast2-network-4.2.58/src/lib/y2network/sysconfig/hostname_writer.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/src/lib/y2network/sysconfig/hostname_writer.rb 2020-03-04 08:24:53.000000000 +0100 @@ -76,7 +76,7 @@ hostname = hostname.static # 1) when user asked for erasing hostname from /etc/hostname, we keep runtime as it is # 2) we will write whatever user wants even FQDN - no changes under the hood - Yast::Execute.on_target!("/usr/bin/hostname", hostname) if !hostname.empty? + Yast::Execute.locally!("/usr/bin/hostname", hostname) if !hostname.empty? Yast::SCR.Write( Yast::Path.new(".target.string"), HOSTNAME_PATH, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/src/lib/y2network/widgets/slave_items.rb new/yast2-network-4.2.60/src/lib/y2network/widgets/slave_items.rb --- old/yast2-network-4.2.58/src/lib/y2network/widgets/slave_items.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/src/lib/y2network/widgets/slave_items.rb 2020-03-04 08:24:53.000000000 +0100 @@ -52,7 +52,7 @@ description = Yast::NetworkInterfaces.GetDevTypeDescription(interface.type.short_name, true) else - description = interface.name + description = interface.name.dup # this conditions origin from bridge configuration # if enslaving a configured device then its configuration is rewritten @@ -64,7 +64,7 @@ selected = enslaved_ifaces.include?(interface.name) if physical_port_id?(interface.name) - description << " (Port ID: #{physical_port_id(interface.name)})" + description += " (Port ID: #{physical_port_id(interface.name)})" end result << Yast::Term.new(:item, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/src/modules/DNS.rb new/yast2-network-4.2.60/src/modules/DNS.rb --- old/yast2-network-4.2.58/src/modules/DNS.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/src/modules/DNS.rb 2020-03-04 08:24:53.000000000 +0100 @@ -74,7 +74,6 @@ # for backward compatibility as long as old DNS module is used as an API # for new dns and hostname classes alias_method :hostname, :static - alias_method :hostname=, :static= def main Yast.import "UI" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/test/dns_test.rb new/yast2-network-4.2.60/test/dns_test.rb --- old/yast2-network-4.2.58/test/dns_test.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/test/dns_test.rb 2020-03-04 08:24:53.000000000 +0100 @@ -257,15 +257,4 @@ expect(subject.hostname).to eq "install" end end - - describe "#hostname=" do - let(:hostname_config) do - Y2Network::Hostname.new - end - - it "sets static hostname" do - subject.hostname = "test" - expect(subject.hostname).to eq "test" - end - end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.2.58/test/y2network/hostname_writer_test.rb new/yast2-network-4.2.60/test/y2network/hostname_writer_test.rb --- old/yast2-network-4.2.58/test/y2network/hostname_writer_test.rb 2020-02-28 12:45:32.000000000 +0100 +++ new/yast2-network-4.2.60/test/y2network/hostname_writer_test.rb 2020-03-04 08:24:53.000000000 +0100 @@ -51,7 +51,7 @@ it "updates system with the new hostname" do expect(Yast::Execute) - .to receive(:on_target!) + .to receive(:locally!) .with("/usr/bin/hostname", hostname) expect(Yast::SCR) .to receive(:Write)