Hello community, here is the log from the commit of package tcmu-runner for openSUSE:Leap:15.2 checked in at 2020-03-09 18:13:47 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/tcmu-runner (Old) and /work/SRC/openSUSE:Leap:15.2/.tcmu-runner.new.26092 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "tcmu-runner" Mon Mar 9 18:13:47 2020 rev:19 rq:782194 version:1.5.2 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/tcmu-runner/tcmu-runner.changes 2020-01-15 16:05:50.256002327 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.tcmu-runner.new.26092/tcmu-runner.changes 2020-03-09 18:14:31.481415949 +0100 @@ -1,0 +2,159 @@ +Mon Mar 02 18:12:48 UTC 2020 - [email protected] + +- Update to version 1.5.2 (see jsc#SLE-7751): + * Bump version to 1.5.2 + * Fix man unmap len reporting + * Bump version to 1.5.1. + * spec: fix build error + * Bump version to 1.5.0. + * Disable explicit alua support. + * Don't install headers. + * Add missing whatis entry for manpage + * Add link to tcmu-runner manpage from tcmu-runner.service + * Fix spelling s/Igoring/Ignoring/ + * Fix spelling s/reseting/resetting/ + * darray.h: avoid UB when decrementing zero pointer + * Log timed out commands + * lib/runner: Add helpers to convert lbas and bytes + * Check for optional handler callouts + * Drop unused tcmulib_cmd code + * Convert runner handlers and core code to tcmur_cmd + * Add tcmur-runner cmd struct + * Prep for separating runner fields from tcmulib_cmd + * tcmu-runner: simplify format unit io limit check + * Cleanup runner callout definitions + * runner: unbind aio code from tcmulib_cmd + * Set write_verify cbks in write_verify_init + * Set handle_caw_read_cbk in caw_init_readcmd + * Add tcmu-runner cmd completion function + * runner: fix up callout return info + * rename tcmur tcmulib command completion function + * libtcmu: Allow handlers to allocate n bytes with each command + * tcmur: remove useless code + * alua: fix pthread attr destroy + * tcmur: fix free of xcopy parse + * fbo: fix mutex destroy + * reconfig_device: add request cfg type to logs + * api: tcmu_cdb_print_info convert err log to debug + * tcmu: reconfig_device convert err log to debug + * tcmu: link libtcmalloc with libtcmu and handlers + * runner: fix crash during compound command execution + * cmake: set '-fno-builtin-XYZ' options when tcmalloc is used + * configfs: fix index out of bounds + * cmake: add a minor .so version number to libtcmu + * spec: track backuped files + * spec: update the spec file to fix the build error + * spec: pass the tcmalloc option to cmake command + * spec: switch to use rpm conditional switches + * extra: add gperftools-devel to install_dep script + * Optionally link against tcmalloc for improved small IO performance + * libtcmu_time: void header file include muti-times + * glfs: update the glfs logdir + * README: update to add uninstall + * lockfile: switch to use /run/tcmu.lock + * logrotate: fix duplicate log entry error + * Validate input for tcmu_log_dir_check() + * Fix parameter for tcmu_setup_log() + * Follow coding style, move leading brace + * Add method to query whether OOOC is supported + * glfs: fix build error for GFAPI version check + * glfs: add gfapi version check + * Fix unmap to handle refcount being 0 + * fix typo in code + * rpm: remove %defattr + * rpm: remove %clean section + * rpm: use valid short name licenses in License field + * configfs: clean up the code + * Fix pthread error ret + * rbd: fix the error ret in tcmu_rbd_unlock + * Drop sense arg from tcmu_explicit_transition + * libtcmu: setup_netlink maybe failure but can't sensed + * Drop is_sync arg from tcmu_acquire_dev_lock + * Allow some commands to run while taking lock + * Drop in_lock_thread from __tcmu_reopen_dev + * Fix pthread error handling + * Check if device is opened before calling handler + * main: load_our_module maybe failure but can't sensed + * tcmu: clean up the code + * spec: fix building error + * logrotate: do not overwrite the exist config file + * logrotate: fix the install cmake file + * README: update and add the make_runnerrpm.sh info + * Fix 80 col formatting in def_log_path setup + * format-security: fix snprintf usage + * config: clean up the code + * Drop cfg path variable + * Switch some inotify messages from info to debug. + * libtcmu: carve-out library packages separately + * logger: skip resetting options if they match with current + * load_config: retry opening conf-file if the initial attempt fail + * cmake_install: backup old tcmu.conf version as tcmu.conf.old + * doc: update readme + * daemon: log start/exit msgs with crit level + * dyn-logger-config: honor the precedence + * main: organize the cleanup sequence + * config: deprecate tcmu_parse_config + * logger-init: honor the defaults when config key:value pair is commented + * config: cleanup few allocations and naming + * inotify: watch the directory not just file + * logger: check for -1 return value on open + * Call block/reset nl directly + * Call block/reset dev directly + * Fix up configfs file not found error message + * Move tcmu_get_runner_handler + * Build zbc/fbo with scsi.c + * Remove daemon priv hack + * Sync lbtmcu cmd and misc naming + * Sync libtcmu dev get/set naming + * Rename dev/nl block/reset cfgfs functions + * Rename tcmu_get_wwn to tcmu_cfgfs_dev_get_wwn + * Use uin32_t for cfgfs action values + * Rename tcmu_cfgfs_dev_get_attr to tcmu_cfgfs_dev_get_attr_int + * Drop tcmu_get_dev_size + * Drop tcmu_set_dev_size + * Rename tcmu_set_control to match cfgfs lib functions + * Use uin32_t instead of unsigned long for cfgfs lib function + * cfgfs: Add tcmu_cfgfs prefix to cfgfs lib functions + * lib: Update tcmulib_command_complete comments + * Partial revert of "libtcmu: do not install headers and drop libtcmu stable API" + * Revert "build: drop versionless libtcmu.so symlink" + * libtcmu: move tcmu_get_runner_handler into scsi.c + * libtcmu: move SCSI helpers out of libtcmu + * libtcmu: declare tcmu_cancel_thread in libtcmu_common.h + * libtcmu_log: get subtype from tcmulib_handler + * libtcmu_priv.h: drop unnecessary header files + * libtcmu: explicitly include tcmu-runner.h where necessary + * cmake: drop rsyslog build time check + * spec: remove changelog + * cmake: add rsyslog to dependencies list + * spec: add rsyslog to requires list + * systemd: start rsyslog.service before tcmu-runner.service + * config: do not update the logdir when it's commented in conf + * logger: add critical log level support + * libtcmu: remove useless parameter in remove_device + * spec-file: further changes to take options to ignore dependencies + * logrotate: add logrotate support for tcmu-runner-glfs.log + * tcmur: fix the unmap logging format + * glfs: add writesame support + * api: add zeroed iov check support + * tcmu: Fix CMake to install file_optical + * tcmu:fix extra backslash + * tcmu-runner.spec: fix the rpm build errors + * tcmu: Simplify command completion + * file_zbc: optionally build zbc handler + * file_zbc: fixed compile error under ppc64le + * Enable explicit alua support. + + This replaced tcmu-runner-1.4.0.tar.xz with + tcmu-runner-1.5.2.tar.xz, and removed two patches that are + already in 1.5.2 so no longer needed: + * file_zbc-fixed-compile-error-under-ppc64le.patch + * file_zbc-optionally-build-zbc-handler.patch + + Also, fixed i586 compilation complaint in tcmur_cmd_handler.c, adding: + * tcmu-runner-fix-i586-size_t-error.patch + (which came from David Disseldorp). Also, added requirement for + libnl3-devel version that supports signed network functions, + such as nla_put_s32(). + +------------------------------------------------------------------- Old: ---- file_zbc-fixed-compile-error-under-ppc64le.patch file_zbc-optionally-build-zbc-handler.patch tcmu-runner-1.4.0.tar.xz New: ---- tcmu-runner-1.5.2.tar.xz tcmu-runner-fix-i586-size_t-error.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ tcmu-runner.spec ++++++ --- /var/tmp/diff_new_pack.6W4suZ/_old 2020-03-09 18:14:31.869416138 +0100 +++ /var/tmp/diff_new_pack.6W4suZ/_new 2020-03-09 18:14:31.873416140 +0100 @@ -1,7 +1,7 @@ # # spec file for package tcmu-runner # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -32,22 +32,24 @@ %endif %endif +%bcond_with tcmalloc + Name: tcmu-runner -Version: 1.4.0 +Version: 1.5.2 Release: 0 Summary: A userspace daemon that handles the LIO TCM-User backstore License: Apache-2.0 Group: System/Management -Url: https://github.com/agrover/%{name} +Url: https://github.com/open-iscsi/%{name} Source: %{name}-%{version}.tar.xz Patch1: %{name}-handler_file-add-libtcmu.patch Patch2: %{name}-remove-handler-path-install-prefix.patch -Patch3: file_zbc-fixed-compile-error-under-ppc64le.patch -Patch4: file_zbc-optionally-build-zbc-handler.patch +Patch3: %{name}-fix-i586-size_t-error.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: cmake BuildRequires: glib2-devel BuildRequires: glibc-devel +BuildRequires: gperftools-devel %if 0%{?build_handler_glusterfs} BuildRequires: glusterfs-devel %endif @@ -58,11 +60,15 @@ BuildRequires: libzbc-devel %endif BuildRequires: libkmod-devel -BuildRequires: libnl3-devel +BuildRequires: libnl3-devel >= 3.3 BuildRequires: systemd-rpm-macros BuildRequires: zlib-devel Requires: libtcmu2 = %{version} Requires: logrotate +%if %{with tcmalloc} +BuildRequires: gperftools-devel +Requires: gperftools-libs +%endif %{?systemd_requires} %description @@ -133,7 +139,6 @@ %patch1 -p1 %patch2 -p1 %patch3 -p1 -%patch4 -p1 %build CMAKE_OPTIONS="\ @@ -153,6 +158,9 @@ %else -Dwith-zbc=0 \ %endif + -Dwith-qcow=1 \ + -Dwith-fbo=0 \ + %{?_without_tcmalloc:-Dwith-tcmalloc=false} \ " %cmake -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--as-needed -Wl,-z,now" \ ${CMAKE_OPTIONS} @@ -204,7 +212,7 @@ %files -n libtcmu2 %defattr(-,root,root) -%{_libdir}/libtcmu.so.2 +%{_libdir}/libtcmu.so* %if 0%{?build_handler_glusterfs} %files handler-glusterfs ++++++ _service ++++++ --- /var/tmp/diff_new_pack.6W4suZ/_old 2020-03-09 18:14:31.893416149 +0100 +++ /var/tmp/diff_new_pack.6W4suZ/_new 2020-03-09 18:14:31.897416151 +0100 @@ -4,8 +4,8 @@ <param name="url">https://github.com/open-iscsi/tcmu-runner.git</param> <param name="subdir"></param> <param name="filename">tcmu-runner</param> - <param name="versionformat">1.4.0</param> - <param name="revision">v1.4.0</param> + <param name="versionformat">1.5.2</param> + <param name="revision">v1.5.2</param> <param name="changesgenerate">enable</param> </service> <service name="recompress" mode="disabled"> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.6W4suZ/_old 2020-03-09 18:14:31.909416157 +0100 +++ /var/tmp/diff_new_pack.6W4suZ/_new 2020-03-09 18:14:31.913416159 +0100 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/open-iscsi/tcmu-runner.git</param> - <param name="changesrevision">2c125073c597139a00d3bbab6b5ae233a74e657b</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">9c84f7a4348ac326ac269fbdda507953dba6ec2c</param></service></servicedata> \ No newline at end of file ++++++ tcmu-runner-1.4.0.tar.xz -> tcmu-runner-1.5.2.tar.xz ++++++ ++++ 10709 lines of diff (skipped) ++++++ tcmu-runner-fix-i586-size_t-error.patch ++++++ From: David Disseldorp <[email protected]> Date: Fri Jan 3 09:10:02 PST 2020 Subject: tcmu-runner: fix i586 size_t error Patch-mainline: submitted pull request on github 1/2020 This fix silences a compiler complaint on i586 (32-bit). Signed-off-by: Lee Duncan <[email protected]> --- tcmur_cmd_handler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tcmur_cmd_handler.c +++ b/tcmur_cmd_handler.c @@ -712,7 +712,7 @@ static int handle_writesame(struct tcmu_ uint32_t block_size = tcmu_dev_get_block_size(dev); uint64_t start_lba = tcmu_cdb_get_lba(cdb); uint64_t write_lbas; - size_t max_xfer_length, length = 1024 * 1024; + uint64_t max_xfer_length, length = 1024 * 1024; struct write_same *write_same; int i, ret; ++++++ tcmu-runner-handler_file-add-libtcmu.patch ++++++ --- /var/tmp/diff_new_pack.6W4suZ/_old 2020-03-09 18:14:32.009416206 +0100 +++ /var/tmp/diff_new_pack.6W4suZ/_new 2020-03-09 18:14:32.009416206 +0100 @@ -1,10 +1,18 @@ +From David Disseldorp <[email protected]> +Date: Tue May 21 13:48:20 UTC 2019 +Subject: tcmu-runner: handler_file: add libtcmu +Patch-mainline: never (SUSE-specific) +References: bsc#1135815 + +Add explicit libtcmu package dependency to avoid incorrect +upstream ".so" versioning. --- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) --- a/CMakeLists.txt +++ b/CMakeLists.txt -@@ -146,6 +146,7 @@ add_library(handler_file +@@ -161,6 +161,7 @@ add_library(handler_file SHARED file_example.c ) ++++++ tcmu-runner-remove-handler-path-install-prefix.patch ++++++ --- /var/tmp/diff_new_pack.6W4suZ/_old 2020-03-09 18:14:32.017416209 +0100 +++ /var/tmp/diff_new_pack.6W4suZ/_new 2020-03-09 18:14:32.017416209 +0100 @@ -2,14 +2,14 @@ Date: Wed Aug 9 14:46:08 PDT 2017 Subject: [tcmu-runner] remove handler path install prefix Patch-mainline: never (suse-specific) -Reference: bsc#1052795 +References: bsc#1052795 The SUSE %cmake macro sets CMAKE_INSTALL_LIBDIR to /usr/lib64 but then sets CMAKE_INSTALL_PREFIX to /usr, so that the plugin path gets set to /usr/usr/lib64/tcmu-runner, which is not good. This fixes it for SUSE. - +--- diff -aurp tcmu-runner-1.2.0.orig/CMakeLists.txt tcmu-runner-1.2.0/CMakeLists.txt --- tcmu-runner-1.2.0.orig/CMakeLists.txt 2017-08-09 14:43:09.852647786 -0700 +++ tcmu-runner-1.2.0/CMakeLists.txt 2017-08-09 14:44:07.134410581 -0700
