Hello community, here is the log from the commit of package tracker for openSUSE:Factory checked in at 2020-03-11 18:32:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/tracker (Old) and /work/SRC/openSUSE:Factory/.tracker.new.3160 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "tracker" Wed Mar 11 18:32:53 2020 rev:126 rq:782594 version:2.3.2 Changes: -------- --- /work/SRC/openSUSE:Factory/tracker/tracker.changes 2020-02-22 19:02:28.593876147 +0100 +++ /work/SRC/openSUSE:Factory/.tracker.new.3160/tracker.changes 2020-03-11 18:32:57.586921251 +0100 @@ -1,0 +2,8 @@ +Thu Mar 5 02:41:37 UTC 2020 - Alynx Zhou <[email protected]> + +- Add tracker-fix-segfault-in-writeback.patch: Check if argument is + NULL before using it and dispose connection and data_manager + before shutting down writeback and events to prevent segmentation + fault (bsc#1165357, glgo#GNOME/tracker!192). + +------------------------------------------------------------------- New: ---- tracker-fix-segfault-in-writeback.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ tracker.spec ++++++ --- /var/tmp/diff_new_pack.I2KbjG/_old 2020-03-11 18:32:58.298921687 +0100 +++ /var/tmp/diff_new_pack.I2KbjG/_new 2020-03-11 18:32:58.298921687 +0100 @@ -1,7 +1,7 @@ # # spec file for package tracker # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany. # Copyright (c) 2010 Luis Medinas, Portugal # # All modifications and additions to the file contributed by third parties @@ -28,6 +28,8 @@ Group: Productivity/Other URL: https://wiki.gnome.org/Projects/Tracker Source0: https://download.gnome.org/sources/tracker/2.3/%{name}-%{version}.tar.xz +# PATCH-FIX-UPSTREAM tracker-fix-segfault-in-writeback.patch bsc#1165357 glgo#GNOME/tracker!192 [email protected] -- Fix tracker segmentation fault in writeback +Patch0: tracker-fix-segfault-in-writeback.patch BuildRequires: fdupes BuildRequires: gcc-c++ ++++++ tracker-fix-segfault-in-writeback.patch ++++++ diff --git a/src/tracker-store/tracker-main.vala b/src/tracker-store/tracker-main.vala index 1e8d1ddd2..0db9b6653 100644 --- a/src/tracker-store/tracker-main.vala +++ b/src/tracker-store/tracker-main.vala @@ -368,12 +368,12 @@ License which can be viewed at: message ("Cleaning up"); + data_manager = null; + connection = null; + /* Shutdown major subsystems */ Tracker.Writeback.shutdown (); Tracker.Events.shutdown (); - - data_manager = null; - connection = null; Tracker.DBus.shutdown (); Tracker.Log.shutdown (); diff --git a/src/tracker-store/tracker-writeback.c b/src/tracker-store/tracker-writeback.c index 32517d553..fde45afc0 100644 --- a/src/tracker-store/tracker-writeback.c +++ b/src/tracker-store/tracker-writeback.c @@ -200,6 +200,8 @@ tracker_writeback_transact (void) GHashTableIter iter; gpointer key, value; + g_return_if_fail (private == NULL); + if (!private->pending_events) return;
