Hello community,
here is the log from the commit of package libsignal-protocol-c for
openSUSE:Leap:15.2 checked in at 2020-03-31 07:24:19
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Leap:15.2/libsignal-protocol-c (Old)
and /work/SRC/openSUSE:Leap:15.2/.libsignal-protocol-c.new.3160 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libsignal-protocol-c"
Tue Mar 31 07:24:19 2020 rev:13 rq:789901 version:2.3.3
Changes:
--------
---
/work/SRC/openSUSE:Leap:15.2/libsignal-protocol-c/libsignal-protocol-c.changes
2020-01-15 15:25:09.422567688 +0100
+++
/work/SRC/openSUSE:Leap:15.2/.libsignal-protocol-c.new.3160/libsignal-protocol-c.changes
2020-03-31 07:24:41.466458117 +0200
@@ -1,0 +2,10 @@
+Mon Mar 30 11:27:27 UTC 2020 - Michael Vetter <[email protected]>
+
+- Update to 2.3.3:
+ * Add limits.h include to provide INT_MAX
+ * Introduce srand_deterministic to match OpenBSD (#120)
+ * Test for endianness during CMake setup
+ * Fix leaks in session_cipher get functions
+- Remove fix_bigendian.patch: upstreamed
+
+-------------------------------------------------------------------
Old:
----
fix_bigendian.patch
libsignal-protocol-c-2.3.2.tar.gz
New:
----
libsignal-protocol-c-2.3.3.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libsignal-protocol-c.spec ++++++
--- /var/tmp/diff_new_pack.g6nQwF/_old 2020-03-31 07:24:41.866458282 +0200
+++ /var/tmp/diff_new_pack.g6nQwF/_new 2020-03-31 07:24:41.866458282 +0200
@@ -1,7 +1,7 @@
#
# spec file for package libsignal-protocol-c
#
-# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2020 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -18,14 +18,13 @@
%define c_lib libsignal-protocol-c2
Name: libsignal-protocol-c
-Version: 2.3.2
+Version: 2.3.3
Release: 0
Summary: Signal Protocol C Library
License: GPL-3.0-only
Group: Development/Libraries/C and C++
-Url: https://github.com/signalapp/libsignal-protocol-c/
+URL: https://github.com/signalapp/libsignal-protocol-c/
Source:
https://github.com/signalapp/%{name}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
-Patch0: fix_bigendian.patch
BuildRequires: check-devel >= 0.9.10
BuildRequires: cmake >= 2.8.4
BuildRequires: gcc-c++
@@ -52,7 +51,6 @@
%prep
%setup -q
-%patch0 -p1
%build
%cmake \
@@ -77,7 +75,7 @@
%license LICENSE
%doc README.md
%{_libdir}/libsignal-protocol-c.so.2
-%{_libdir}/libsignal-protocol-c.so.2.3.2
+%{_libdir}/libsignal-protocol-c.so.2.3.3
%files devel
%dir %{_includedir}/signal
++++++ libsignal-protocol-c-2.3.2.tar.gz -> libsignal-protocol-c-2.3.3.tar.gz
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libsignal-protocol-c-2.3.2/CMakeLists.txt
new/libsignal-protocol-c-2.3.3/CMakeLists.txt
--- old/libsignal-protocol-c-2.3.2/CMakeLists.txt 2018-05-14
16:02:23.000000000 +0200
+++ new/libsignal-protocol-c-2.3.3/CMakeLists.txt 2020-03-28
01:15:49.000000000 +0100
@@ -8,7 +8,7 @@
SET(SIGNAL_PROTOCOL_C_VERSION_MAJOR 2)
SET(SIGNAL_PROTOCOL_C_VERSION_MINOR 3)
-SET(SIGNAL_PROTOCOL_C_VERSION_PATCH 2)
+SET(SIGNAL_PROTOCOL_C_VERSION_PATCH 3)
SET(SIGNAL_PROTOCOL_C_VERSION
${SIGNAL_PROTOCOL_C_VERSION_MAJOR}.${SIGNAL_PROTOCOL_C_VERSION_MINOR}.${SIGNAL_PROTOCOL_C_VERSION_PATCH})
SET(LIB_SUFFIX "" CACHE STRING "Define suffix of directory name (32/64)")
@@ -19,6 +19,7 @@
INCLUDE(CheckSymbolExists)
INCLUDE(CheckCCompilerFlag)
+INCLUDE(TestBigEndian)
CHECK_SYMBOL_EXISTS(memset_s "string.h" HAVE_MEMSET_S)
@@ -50,6 +51,11 @@
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DHAVE_MEMSET_S=1")
ENDIF(HAVE_MEMSET_S)
+TEST_BIG_ENDIAN(WORDS_BIGENDIAN)
+IF(WORDS_BIGENDIAN)
+ ADD_DEFINITIONS(-DWORDS_BIGENDIAN)
+ENDIF(WORDS_BIGENDIAN)
+
IF(COVERAGE)
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fprofile-arcs -ftest-coverage")
SET(LINK_FLAGS "${LINK_FLAGS} -fprofile-arcs -ftest-coverage")
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libsignal-protocol-c-2.3.2/src/session_cipher.c
new/libsignal-protocol-c-2.3.3/src/session_cipher.c
--- old/libsignal-protocol-c-2.3.2/src/session_cipher.c 2018-05-14
16:02:23.000000000 +0200
+++ new/libsignal-protocol-c-2.3.3/src/session_cipher.c 2020-03-28
01:15:49.000000000 +0100
@@ -744,6 +744,7 @@
id_result = session_state_get_remote_registration_id(state);
complete:
+ SIGNAL_UNREF(record);
if(result >= 0) {
*remote_id = id_result;
}
@@ -784,6 +785,7 @@
version_result = session_state_get_session_version(state);
complete:
+ SIGNAL_UNREF(record);
if(result >= 0) {
*version = version_result;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libsignal-protocol-c-2.3.2/tests/test_common.c
new/libsignal-protocol-c-2.3.3/tests/test_common.c
--- old/libsignal-protocol-c-2.3.2/tests/test_common.c 2018-05-14
16:02:23.000000000 +0200
+++ new/libsignal-protocol-c-2.3.3/tests/test_common.c 2020-03-28
01:15:49.000000000 +0100
@@ -845,3 +845,11 @@
signal_protocol_store_context_set_sender_key_store(context, &store);
}
+
+#ifndef __OpenBSD__
+void srand_deterministic(unsigned int seed)
+{
+ srand(seed);
+}
+#endif
+
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libsignal-protocol-c-2.3.2/tests/test_common.h
new/libsignal-protocol-c-2.3.3/tests/test_common.h
--- old/libsignal-protocol-c-2.3.2/tests/test_common.h 2018-05-14
16:02:23.000000000 +0200
+++ new/libsignal-protocol-c-2.3.3/tests/test_common.h 2020-03-28
01:15:49.000000000 +0100
@@ -84,4 +84,10 @@
void test_sender_key_store_destroy(void *user_data);
void setup_test_sender_key_store(signal_protocol_store_context *context,
signal_context *global_context);
+/* Portability */
+#ifndef __OpenBSD__
+/* OpenBSD extension */
+void srand_deterministic(unsigned int seed);
+#endif
+
#endif /* TEST_COMMON_H */
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libsignal-protocol-c-2.3.2/tests/test_common_openssl.c
new/libsignal-protocol-c-2.3.3/tests/test_common_openssl.c
--- old/libsignal-protocol-c-2.3.2/tests/test_common_openssl.c 2018-05-14
16:02:23.000000000 +0200
+++ new/libsignal-protocol-c-2.3.3/tests/test_common_openssl.c 2020-03-28
01:15:49.000000000 +0100
@@ -1,5 +1,6 @@
#include "test_common.h"
+#include <limits.h>
#include <openssl/opensslv.h>
#include <openssl/evp.h>
#include <openssl/hmac.h>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libsignal-protocol-c-2.3.2/tests/test_session_builder.c
new/libsignal-protocol-c-2.3.3/tests/test_session_builder.c
--- old/libsignal-protocol-c-2.3.2/tests/test_session_builder.c 2018-05-14
16:02:23.000000000 +0200
+++ new/libsignal-protocol-c-2.3.3/tests/test_session_builder.c 2020-03-28
01:15:49.000000000 +0100
@@ -1426,9 +1426,9 @@
}
time_t seed = time(0);
- srand(seed);
+ srand_deterministic(seed);
shuffle_buffers(alice_ooo_plaintext, 10);
- srand(seed);
+ srand_deterministic(seed);
shuffle_buffers(alice_ooo_ciphertext, 10);
fprintf(stderr, "Shuffled Alice->Bob messages created\n");
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libsignal-protocol-c-2.3.2/tests/test_session_cipher.c
new/libsignal-protocol-c-2.3.3/tests/test_session_cipher.c
--- old/libsignal-protocol-c-2.3.2/tests/test_session_cipher.c 2018-05-14
16:02:23.000000000 +0200
+++ new/libsignal-protocol-c-2.3.3/tests/test_session_cipher.c 2020-03-28
01:15:49.000000000 +0100
@@ -206,9 +206,9 @@
/* Randomize the two arrays using the same seed */
time_t seed = time(0);
- srand(seed);
+ srand_deterministic(seed);
shuffle_buffers(plaintext_messages, size);
- srand(seed);
+ srand_deterministic(seed);
shuffle_buffers(ciphertext_messages, size);
}
