Hello community,
here is the log from the commit of package matrix-quaternion for
openSUSE:Factory checked in at 2020-04-02 17:43:09
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/matrix-quaternion (Old)
and /work/SRC/openSUSE:Factory/.matrix-quaternion.new.3248 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "matrix-quaternion"
Thu Apr 2 17:43:09 2020 rev:4 rq:790713 version:0.0.9.4e
Changes:
--------
--- /work/SRC/openSUSE:Factory/matrix-quaternion/matrix-quaternion.changes
2020-04-01 19:17:29.619508314 +0200
+++
/work/SRC/openSUSE:Factory/.matrix-quaternion.new.3248/matrix-quaternion.changes
2020-04-02 17:43:10.109387342 +0200
@@ -1,0 +2,13 @@
+Wed Apr 1 20:17:42 UTC 2020 - [email protected]
+
+- Update to 0.0.9.4e
+ - Another quick-fixup release, using libQMatrixClient 0.5.3.2,
+ and fixing an occasional crash upon a successful SSO login
+ (described in an issue with a fancy number #666)
+
+-------------------------------------------------------------------
+Wed Apr 1 18:28:50 UTC 2020 - [email protected]
+
+- Change to needed libqmatrixclient version 0.5.3
+
+-------------------------------------------------------------------
Old:
----
matrix-quaternion-0.0.9.4d.tar.gz
New:
----
matrix-quaternion-0.0.9.4e.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ matrix-quaternion.spec ++++++
--- /var/tmp/diff_new_pack.1Gm0lP/_old 2020-04-02 17:43:10.777387860 +0200
+++ /var/tmp/diff_new_pack.1Gm0lP/_new 2020-04-02 17:43:10.781387863 +0200
@@ -17,7 +17,7 @@
Name: matrix-quaternion
-Version: 0.0.9.4d
+Version: 0.0.9.4e
Release: 0
Summary: QT Matrix client
License: GPL-3.0-only
@@ -29,7 +29,7 @@
BuildRequires: pkgconfig
BuildRequires: cmake(Qt5Keychain)
BuildRequires: cmake(Qt5LinguistTools)
-BuildRequires: pkgconfig(QMatrixClient) >= 0.5.1
+BuildRequires: pkgconfig(QMatrixClient) >= 0.5.3
BuildRequires: pkgconfig(Qt5Core) >= 5.9
BuildRequires: pkgconfig(Qt5DBus)
BuildRequires: pkgconfig(Qt5Gui)
++++++ matrix-quaternion-0.0.9.4d.tar.gz -> matrix-quaternion-0.0.9.4e.tar.gz
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Quaternion-0.0.9.4d/client/main.cpp
new/Quaternion-0.0.9.4e/client/main.cpp
--- old/Quaternion-0.0.9.4d/client/main.cpp 2020-03-31 08:00:03.000000000
+0200
+++ new/Quaternion-0.0.9.4e/client/main.cpp 2020-04-01 20:43:46.000000000
+0200
@@ -39,7 +39,7 @@
QApplication::setOrganizationName(QStringLiteral("QMatrixClient"));
QApplication::setApplicationName(QStringLiteral("quaternion"));
QApplication::setApplicationDisplayName(QStringLiteral("Quaternion"));
- QApplication::setApplicationVersion(QStringLiteral("0.0.9.4d"));
+ QApplication::setApplicationVersion(QStringLiteral("0.0.9.4e"));
QMatrixClient::Settings::setLegacyNames(
QStringLiteral("Quaternion"), QStringLiteral("quaternion"));
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Quaternion-0.0.9.4d/client/mainwindow.cpp
new/Quaternion-0.0.9.4e/client/mainwindow.cpp
--- old/Quaternion-0.0.9.4d/client/mainwindow.cpp 2020-03-31
08:00:03.000000000 +0200
+++ new/Quaternion-0.0.9.4e/client/mainwindow.cpp 2020-04-01
20:43:46.000000000 +0200
@@ -828,8 +828,11 @@
void MainWindow::doOpenLoginDialog(LoginDialog* dialog)
{
- dialog->setAttribute(Qt::WA_DeleteOnClose);
dialog->open();
+ // See #666: WA_DeleteOnClose kills the dialog object too soon,
+ // invalidating the connection object before it's released to the local
+ // variable below; so the dialog object is explicitly deleted instead of
+ // using WA_DeleteOnClose automagic.
connect(dialog, &QDialog::accepted, this, [this, dialog] {
auto connection = dialog->releaseConnection();
AccountSettings account(connection->userId());
@@ -845,9 +848,11 @@
logoutOnExit.push_back(connection);
account.sync();
+ auto deviceName = dialog->deviceName();
+ dialog->deleteLater();
+
showFirstSyncIndicator();
- auto deviceName = dialog->deviceName();
if (isInConnections(connection->userId())) {
if (QMessageBox::warning(
this, tr("Logging in into a logged in account"),
@@ -861,6 +866,7 @@
}
addConnection(connection, deviceName);
});
+ connect(dialog, &QDialog::rejected, dialog, &QObject::deleteLater);
}
void MainWindow::showAboutWindow()
