Hello community, here is the log from the commit of package lxc for openSUSE:Leap:15.2 checked in at 2020-04-05 17:07:29 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/lxc (Old) and /work/SRC/openSUSE:Leap:15.2/.lxc.new.3248 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "lxc" Sun Apr 5 17:07:29 2020 rev:18 rq:790957 version:4.0.0 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/lxc/lxc.changes 2020-02-09 11:25:00.711285051 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.lxc.new.3248/lxc.changes 2020-04-05 17:07:41.826253434 +0200 @@ -1,0 +2,30 @@ +Thu Apr 2 08:24:44 UTC 2020 - Aleksa Sarai <[email protected]> + +- Add backport of https://github.com/lxc/lxc/pull/3347 and + https://github.com/lxc/lxc/pull/3349 to fix builds on Leap. + + 0002-cgroups-fix-uninitialized-transient_len-warning.patch + + 0003-cgroups-fix-build-warning-on-GCC-7.patch + +------------------------------------------------------------------- +Wed Apr 1 14:23:25 UTC 2020 - Aleksa Sarai <[email protected]> + +- Update to LXC 4.0.0. The full upstream changelog is available from: + https://discuss.linuxcontainers.org/t/lxc-4-0-lts-has-been-released/7182 + Related to the LXD 4.0.0 update (boo#1168338). + + cgroups: Full cgroup2 support + + cgroups: Freezer support in CGroup2 + + cgroups: eBPF device controller support in CGroup2 + + AppArmor: Deny access to /proc/acpi/** + + config: Add lxc.autodev.tmpfs.size configuration key + + config: Add lxc.selinux.context.keyring key + + config: Add lxc.keyring.session + + seccomp: Add s390 support + * network: Improved network device creation and removal + + network: Allow moving wireless devices +- Add backport of patch to fix build: + + 0001-autotools-don-t-install-run-coccinelle.sh.patch +- Remove upstreamed patches: + - lxc-3.2.1-cgroups-init-cpuset-properly.patch + - 0001-tree-wide-initialize-all-auto-cleanup-variables.patch + +------------------------------------------------------------------- Old: ---- 0001-tree-wide-initialize-all-auto-cleanup-variables.patch lxc-3.2.1-cgroups-init-cpuset-properly.patch lxc-3.2.1.tar.gz lxc-3.2.1.tar.gz.asc New: ---- 0001-autotools-don-t-install-run-coccinelle.sh.patch 0002-cgroups-fix-uninitialized-transient_len-warning.patch 0003-cgroups-fix-build-warning-on-GCC-7.patch lxc-4.0.0.tar.gz lxc-4.0.0.tar.gz.asc ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lxc.spec ++++++ --- /var/tmp/diff_new_pack.nGrJU7/_old 2020-04-05 17:07:42.310253950 +0200 +++ /var/tmp/diff_new_pack.nGrJU7/_new 2020-04-05 17:07:42.314253954 +0200 @@ -23,7 +23,9 @@ # In later versions of openSUSE's permissions config, lxc-user-nic was # whitelisted with a setuid bit enabled -- but in order to allow building on # old distros we must not make it setuid on pre-15.1 distros. See bsc#988348. -%if 0%{suse_version} < 1510 +# +# NOTE: For some reason, it looks like Leap 15.1 always has suse_version 1500? +%if 0%{suse_version} <= 1500 %define old_permissions 1 %endif %define setuid_mode 0%{!?old_permissions:4}750 @@ -34,7 +36,7 @@ %define shlib_version 1 Name: lxc -Version: 3.2.1 +Version: 4.0.0 Release: 0 Url: http://linuxcontainers.org/ Summary: Userspace tools for Linux kernel containers @@ -46,9 +48,12 @@ Source3: lxc-createconfig.in Source90: openSUSE-apparmor.conf Source91: missing_setuid.txt.in -# FIX-UPSTREAM: Backport of https://github.com/lxc/lxc/pull/3102. -Patch1: 0001-tree-wide-initialize-all-auto-cleanup-variables.patch -Patch2: lxc-3.2.1-cgroups-init-cpuset-properly.patch +# FIX-UPSTREAM: Backport of https://github.com/lxc/lxc/pull/3345. +Patch1: 0001-autotools-don-t-install-run-coccinelle.sh.patch +# FIX-UPSTREAM: Backport of https://github.com/lxc/lxc/pull/3347. +Patch2: 0002-cgroups-fix-uninitialized-transient_len-warning.patch +# FIX-UPSTREAM: Backport of https://github.com/lxc/lxc/pull/3349 . +Patch3: 0003-cgroups-fix-build-warning-on-GCC-7.patch BuildRequires: gcc BuildRequires: automake BuildRequires: libtool @@ -130,9 +135,9 @@ %prep %setup -# Fix -Werror=maybe-uninitialized build errors. %patch1 -p1 %patch2 -p1 +%patch3 -p1 %build ./autogen.sh ++++++ 0001-autotools-don-t-install-run-coccinelle.sh.patch ++++++ >From f553c217467b26c6e134f8060d7635b4e0a20128 Mon Sep 17 00:00:00 2001 From: Christian Brauner <[email protected]> Date: Wed, 1 Apr 2020 22:25:53 +0200 Subject: [PATCH] autotools: don't install run-coccinelle.sh Signed-off-by: Christian Brauner <[email protected]> --- coccinelle/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/coccinelle/Makefile.am b/coccinelle/Makefile.am index a3c8b03d95a7..059f5df41bed 100644 --- a/coccinelle/Makefile.am +++ b/coccinelle/Makefile.am @@ -3,5 +3,3 @@ EXTRA_DIST = exit.cocci \ run-coccinelle.sh \ while-true.cocci - -bin_SCRIPTS = run-coccinelle.sh -- 2.26.0 ++++++ 0002-cgroups-fix-uninitialized-transient_len-warning.patch ++++++ >From 346830421a968c41e3198ca64ab3f7217075e491 Mon Sep 17 00:00:00 2001 From: Aleksa Sarai <[email protected]> Date: Thu, 2 Apr 2020 19:15:11 +1100 Subject: [PATCH] cgroups: fix "uninitialized transient_len" warning Without this change, a build error is triggered if you compile with -Werror=maybe-uninitialized. cgroups/cgfsng.c: In function 'cgfsng_monitor_enter': groups/cgfsng.c:1387:9: error: 'transient_len' may be used uninitialized in this function ret = lxc_writeat(h->cgfd_mon, "cgroup.procs", transient, transient_len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The issue is that if handler->transient_pid is 0, then transient_len is uninitialised but lxc_writeat(..., transient_len) still gets called. Signed-off-by: Aleksa Sarai <[email protected]> --- src/lxc/cgroups/cgfsng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/cgroups/cgfsng.c b/src/lxc/cgroups/cgfsng.c index 564400221fae..21c2c3f7cec5 100644 --- a/src/lxc/cgroups/cgfsng.c +++ b/src/lxc/cgroups/cgfsng.c @@ -1388,7 +1388,7 @@ __cgfsng_ops static bool cgfsng_monitor_enter(struct cgroup_ops *ops, if (ret) return log_error_errno(false, errno, "Failed to enter cgroup \"%s\"", h->monitor_full_path); - if (handler->transient_pid < 0) + if (handler->transient_pid <= 0) return true; ret = lxc_writeat(h->cgfd_mon, "cgroup.procs", transient, transient_len); -- 2.26.0 ++++++ 0003-cgroups-fix-build-warning-on-GCC-7.patch ++++++ >From fdb0b8ab2d83eace642153626a5dd5ef04d6f749 Mon Sep 17 00:00:00 2001 From: Aleksa Sarai <[email protected]> Date: Fri, 3 Apr 2020 02:13:11 +1100 Subject: [PATCH] cgroups: fix build warning on GCC 7 GCC 7 appears to be clever enough to detect that transient_len is uninitialised but not that it won't be used despite [1]. Just initialise it to zero to stop the complaining, and allow LXC to build on openSUSE Leap. [1]: 346830421a96 ("cgroups: fix "uninitialized transient_len" warning") Signed-off-by: Aleksa Sarai <[email protected]> --- src/lxc/cgroups/cgfsng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/cgroups/cgfsng.c b/src/lxc/cgroups/cgfsng.c index 21c2c3f7cec5..d3595bcdf9ee 100644 --- a/src/lxc/cgroups/cgfsng.c +++ b/src/lxc/cgroups/cgfsng.c @@ -1360,7 +1360,7 @@ __cgfsng_ops static inline bool cgfsng_payload_create(struct cgroup_ops *ops, __cgfsng_ops static bool cgfsng_monitor_enter(struct cgroup_ops *ops, struct lxc_handler *handler) { - int monitor_len, transient_len; + int monitor_len, transient_len = 0; char monitor[INTTYPE_TO_STRLEN(pid_t)], transient[INTTYPE_TO_STRLEN(pid_t)]; -- 2.26.0 ++++++ lxc-3.2.1.tar.gz -> lxc-4.0.0.tar.gz ++++++ ++++ 34389 lines of diff (skipped)
