Hello community, here is the log from the commit of package gtk-sharp3 for openSUSE:Factory checked in at 2020-04-16 23:02:56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gtk-sharp3 (Old) and /work/SRC/openSUSE:Factory/.gtk-sharp3.new.2738 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gtk-sharp3" Thu Apr 16 23:02:56 2020 rev:5 rq:794413 version:2.99.4 Changes: -------- --- /work/SRC/openSUSE:Factory/gtk-sharp3/gtk-sharp3.changes 2018-06-22 13:34:41.736175688 +0200 +++ /work/SRC/openSUSE:Factory/.gtk-sharp3.new.2738/gtk-sharp3.changes 2020-04-16 23:02:57.363659419 +0200 @@ -1,0 +2,6 @@ +Fri Apr 10 22:21:38 UTC 2020 - Michael Gorse <[email protected]> + +- Add cs8-build-fix.patch: fix build failure caused by C# 8 + changes in mcs. + +------------------------------------------------------------------- New: ---- cs8-build-fix.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gtk-sharp3.spec ++++++ --- /var/tmp/diff_new_pack.ies4hL/_old 2020-04-16 23:02:58.383660187 +0200 +++ /var/tmp/diff_new_pack.ies4hL/_new 2020-04-16 23:02:58.383660187 +0200 @@ -1,7 +1,7 @@ # # spec file for package gtk-sharp3 # -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,7 +12,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # @@ -28,6 +28,7 @@ Source: gtk-sharp3-%{vsuffix}.tar.xz Source99: create-source-archive.sh Patch1: profiler-update.patch +Patch2: cs8-build-fix.patch BuildRequires: gtkhtml2-devel BuildRequires: libmono-2_0-devel BuildRequires: librsvg-devel @@ -147,6 +148,7 @@ %prep %setup -q -n gtk-sharp3-%{vsuffix} %patch1 -p1 +%patch2 -p1 NOCONFIGURE=1 ./autogen.sh %build ++++++ cs8-build-fix.patch ++++++ >From a00552ad68ae349e89e440dca21b86dbd6bccd30 Mon Sep 17 00:00:00 2001 From: Ankit Jain <[email protected]> Date: Tue, 19 Feb 2019 23:53:27 -0500 Subject: [PATCH] Fix build failure with mcs caused by C#8 changes in mcs (#263) Recent addition of C#8 features to mcs possibly broke this: ``` mcs -out:WidgetViewer.exe -r:../../glib/glib-sharp.dll -r:../../pango/pango-sharp.dll -r:../../atk/atk-sharp.dll -r:../../gdk/gdk-sharp.dll -r:../../gtk/gtk-sharp.dll ./TestCheckButton.cs ./TestColorSelection.cs ./TestRadioButton.cs ./TestRange.cs ./TestStatusbar.cs ./TestDialog.cs ./TestFlipping.cs ./TestSizeGroup.cs ./TestCombo.cs ./TestComboBox.cs ./WidgetViewer.cs ./TestCombo.cs(17,14): warning CS0612: `Gtk.Combo' is obsolete ./TestRange.cs(35,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(35,13): error CS0030: Cannot convert type `Gtk.HScale' to `System.Range' ./TestRange.cs(42,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(42,13): error CS0030: Cannot convert type `Gtk.HScrollbar' to `System.Range' ./TestRange.cs(62,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(62,13): error CS0030: Cannot convert type `Gtk.VScale' to `System.Range' ``` This is because the compiler is resolving `Range` in the test as `System.Range` instead of `Gtk.Range`, so we disambiguate it. /cc @marek-safar --- sample/test/TestRange.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sample/test/TestRange.cs b/sample/test/TestRange.cs index 35fc8a6dd..d44a77d85 100644 --- a/sample/test/TestRange.cs +++ b/sample/test/TestRange.cs @@ -9,6 +9,8 @@ using System; using Gtk; +// disambiguate, Gtk.Range vs System.Range +using Range=Gtk.Range; namespace WidgetViewer { -- 2.26.0
