Hello community, here is the log from the commit of package mhvtl for openSUSE:Leap:15.2 checked in at 2020-06-01 19:40:29 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/mhvtl (Old) and /work/SRC/openSUSE:Leap:15.2/.mhvtl.new.3606 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "mhvtl" Mon Jun 1 19:40:29 2020 rev:5 rq:810639 version:1.62 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/mhvtl/mhvtl.changes 2020-01-15 15:30:13.054737360 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.mhvtl.new.3606/mhvtl.changes 2020-06-01 19:40:30.348093474 +0200 @@ -1,0 +2,81 @@ +Fri Nov 15 17:16:03 UTC 2019 - Lee Duncan <[email protected]> + +- Fix some builds of ppc and arm that were failing to compile + the dump_tape command. This adds the patch: + * mhvtl-fix-ppc-Makefile.patch + +------------------------------------------------------------------- +Sat Nov 9 04:13:39 UTC 2019 - Neal Gompa <[email protected]> + +- Use the correct macro for systemd generator directory + +------------------------------------------------------------------- +Mon Nov 4 23:43:56 UTC 2019 - Lee Duncan <[email protected]> + +- Change install of systemd generatos to /usr/lib/systemd/... + instead of /usr/libexec/systemd/..., which does not yet exist, + to fix build issue + +------------------------------------------------------------------- +Sun Oct 06 14:42:22 UTC 2019 - [email protected] + +- Update to version 1.62_release: + * Update the 1.6.2 tarball name + * Update spec file for 1.6-2 release + * mhvtl.ko: Bump module version to reflect white-listed buffer work + * mhvtl.ko: Use white-listed buffer to copy data to/from kernel space + * Bump kernel module version + * mhvtl.ko: scsi_host_template changed block .ioctl + * mhvtl.ko: Remove useless printk("\n") + * Reformat KERNEL_VERSION() to make checkpatch.pl happier + * Bump kernel module version + * Fix kernel build SUBDIR going away post 5.3 + * mhvtl.ko: Fix compile on 5.0+ kernels + * mhvtl.ko: Bump version number due to serial_number change + * mhvtl.ko: Remove dependency on scsi mid layer serial_number + * Remove dead code + * Only build symlink paths for tape devices + * Silence another gcc error regarding snprintf + * Silence another gcc error regarding snprintf + * Make sure target buffer is large enough + * Use systemd-path to query mhvtl-device-conf-generator path + * Change Vagrantbox for Centos to one that is publicly available. + * Remove lzo from the install script and added -g to lsscsi + * Add Vagrant file with install script for testing + * Revert "Correct yet another /usr -> / path - this time for systemd etc stuff" + * Correct yet another /usr -> / path - this time for systemd etc stuff + * Correct systemd-generator default path + * Fix path to modprobe + * Ubuntu/Debian need the systemd-generators install in /lib not /usr/lib + * Sample script to build /dev/tape/by-path/ entries + * Add test for root user on install + * Update Change log and spec file for 1.6-1_release + * Add CRC check on read path + * Update dump_tape to understand CRC32 + * Add CRC32 to each block write + * Add libcrc32c routines + * Add additional field to reflect if tape in drive + * Move true/false values into single bit field + * Allow to override build date with SOURCE_DATE_EPOCH + * dump_tape: Fix off-by-one reading argv[] + * Improve SCSI cdb logging format from kernel module + * Fix typo for mktape in make_vtl_media + * Simplify building of mktape + * Clean up white space formatting in source + * A very basic script to show how to setup LIO iSCSI via pscsi driver + * Fix a media unload race condition + * Force shared library and systemd refresh on install + * bump kernel module version string. + * Remove use of "use_clustering" in our kernel driver. + * Correct mhvtl-load-modules.service dependencies. + + This results in replacing mhvtl-1.60_release.tar.xz with + mhvtl-1.62_release.tar.xz, and removing two patches, no + longer needed. Removed: + * mhvtl-systemd-load-modules-cleanup.patch + * mhvtl-remove-use-of-use_clustering.patch + + Also, updated SPEC-file %build and %install make commands to pass + in systemd generator directory. + +------------------------------------------------------------------- Old: ---- mhvtl-1.60_release.tar.xz mhvtl-remove-use-of-use_clustering.patch mhvtl-systemd-load-modules-cleanup.patch New: ---- mhvtl-1.62_release.tar.xz mhvtl-fix-ppc-Makefile.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ mhvtl.spec ++++++ --- /var/tmp/diff_new_pack.ZnMyfj/_old 2020-06-01 19:40:30.652094445 +0200 +++ /var/tmp/diff_new_pack.ZnMyfj/_new 2020-06-01 19:40:30.652094445 +0200 @@ -27,7 +27,7 @@ Name: mhvtl Url: http://sites.google.com/site/linuxvtl2/ PreReq: %insserv_prereq %fillup_prereq -Version: 1.60 +Version: 1.62 Release: 0 Requires: mhvtl-kmp Requires: module-init-tools @@ -47,11 +47,12 @@ Group: System/Daemons Source: %{name}-%{version}_release.tar.xz Source2: %{name}.preamble -Patch1: %{name}-remove-use-of-use_clustering.patch -Patch2: %{name}-systemd-load-modules-cleanup.patch +Patch1: %{name}-fix-ppc-Makefile.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build %{?systemd_ordering} +%{?!_systemdgeneratordir:%define _systemdgeneratordir /usr/lib/systemd/system-generators} + %if 0%{buildkmp} == 1 %suse_kernel_module_package -n %{name} -p %{S:2} kdump ec2 um %endif @@ -80,10 +81,10 @@ %prep %setup -qn %{name}-%{version}_release %patch1 -p1 -%patch2 -p1 %build -make MHVTL_HOME_PATH=%{mhvtl_home_dir} VERSION=%{version}_release +make MHVTL_HOME_PATH=%{mhvtl_home_dir} VERSION=%{version}_release \ + SYSTEMD_GENERATOR_DIR=%{_systemdgeneratordir} %if 0%{buildkmp} == 1 for flavor in %flavors_to_build; do rm -rf obj/$flavor @@ -96,7 +97,8 @@ %install %make_install \ - MHVTL_HOME_PATH=%{mhvtl_home_dir} VERSION=%{version}_release LIBDIR=%{_libdir} + MHVTL_HOME_PATH=%{mhvtl_home_dir} VERSION=%{version}_release LIBDIR=%{_libdir} \ + SYSTEMD_GENERATOR_DIR=%{_systemdgeneratordir} %if 0%{buildkmp} == 1 export INSTALL_MOD_PATH=%{buildroot} export INSTALL_MOD_DIR=updates @@ -144,7 +146,7 @@ %config %{_sysconfdir}/mhvtl/device.conf %config %{_sysconfdir}/mhvtl/library_contents.10 %config %{_sysconfdir}/mhvtl/library_contents.30 -%{_libexecdir}/systemd/system-generators/ +%{_systemdgeneratordir}/ %{_unitdir}/mhvtl-load-modules.service %{_unitdir}/mhvtl.target %{_unitdir}/[email protected] ++++++ _service ++++++ --- /var/tmp/diff_new_pack.ZnMyfj/_old 2020-06-01 19:40:30.676094522 +0200 +++ /var/tmp/diff_new_pack.ZnMyfj/_new 2020-06-01 19:40:30.676094522 +0200 @@ -4,8 +4,8 @@ <param name="url">https://github.com/markh794/mhvtl.git</param> <param name="subdir"></param> <param name="filename">mhvtl</param> - <param name="versionformat">1.6-0_release</param> - <param name="revision">1.6-0_release</param> + <param name="versionformat">1.6-2_release</param> + <param name="revision">1.6-2_release</param> <param name="changesgenerate">enable</param> <param name="changesauthor">[email protected]</param> </service> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.ZnMyfj/_old 2020-06-01 19:40:30.688094561 +0200 +++ /var/tmp/diff_new_pack.ZnMyfj/_new 2020-06-01 19:40:30.688094561 +0200 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/markh794/mhvtl.git</param> - <param name="changesrevision">d324c2d4132c9675f96ad9d5cbbf03babdabda3b</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">06e325c2b5452fe1294fff04a0851118477a5a26</param></service></servicedata> \ No newline at end of file ++++++ mhvtl-1.60_release.tar.xz -> mhvtl-1.62_release.tar.xz ++++++ ++++ 2601 lines of diff (skipped) ++++++ mhvtl-fix-ppc-Makefile.patch ++++++ From: Lee Duncan <[email protected]> Date: Fri Nov 15 09:13:32 PST 2019 Subject: [PATCH] mhvtl: fix ppc Makefile Fix the Makefile in usr so that the dump_tape command can compile on ppcle64. Otherwise, you get errors like: > [ 74s] cc -Wall -Wshadow -g -O2 -D_LARGEFILE64_SOURCE -O2 -Wall > -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables > -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type > -flto=auto -g -I../kernel -DMHVTL_VERSION=\"1.62_release\" -D_GNU_SOURCE > -DMHVTL_DEBUG -DMHVTL_HOME_PATH=\"/var/lib/mhvtl\" > -DMHVTL_CONFIG_PATH=\"/etc/mhvtl\" -o dump_tape libcrc32c.o dump_tape.o > minilzo.o -L. \ > [ 74s] -lz -L. -lvtlcart -lvtlscsi > [ 75s] > /usr/lib64/gcc/aarch64-suse-linux/9/../../../../aarch64-suse-linux/bin/ld: > /tmp/dump_tape.H3eQFB.ltrans0.ltrans.o: relocation R_AARCH64_ADR_PREL_PG_HI21 > against symbol `c_pos' which may bind externally can not be used when making > a shared object; recompile with -fPIC > [ 75s] > /usr/lib64/gcc/aarch64-suse-linux/9/../../../../aarch64-suse-linux/bin/ld: > /tmp/dump_tape.H3eQFB.ltrans0.ltrans.o(.text.startup+0x590): unresolvable > R_AARCH64_ADR_PREL_PG_HI21 relocation against symbol `c_pos' > [ 75s] > /usr/lib64/gcc/aarch64-suse-linux/9/../../../../aarch64-suse-linux/bin/ld: > final link failed: bad value > [ 75s] collect2: error: ld returned 1 exit status > [ 75s] make[1]: *** [Makefile:96: dump_tape] Error 1 > [ 75s] make[1]: Leaving directory > '/home/abuild/rpmbuild/BUILD/mhvtl-1.62_release/usr' > [ 75s] make: *** [Makefile:56: usr] Error 2 --- diff -aurp mhvtl-1.62_release.orig/usr/Makefile mhvtl-1.62_release/usr/Makefile --- mhvtl-1.62_release.orig/usr/Makefile 2019-11-15 09:02:53.367425882 -0800 +++ mhvtl-1.62_release/usr/Makefile 2019-11-15 09:03:36.567320318 -0800 @@ -90,11 +90,14 @@ vtlcmd: vtlcmd.o minilzo.o: minilzo.c lzoconf.h lzodefs.h $(CC) $(CFLAGS) $(LZODEBUG) -o minilzo.o -c minilzo.c +dump_tape.o: dump_tape.c + $(CC) $(CFLAGS) -c -fPIC $? + dump_tape: dump_tape.o vtlcart.o libvtlscsi.so vtltape.h scsi.h \ ../kernel/vtl_common.h minilzo.c minilzo.h minilzo.o \ crc32c.h libcrc32c.o libcrc32c.c $(CC) $(CFLAGS) -o dump_tape libcrc32c.o dump_tape.o minilzo.o -L. \ - -lz -L. -lvtlcart -lvtlscsi + -lz -L. -lvtlcart -lvtlscsi -fPIC mktape: mktape.c mktape.o vtlcart.o libvtlscsi.so vtltape.h vtllib.h \ ../kernel/vtl_common.h
