Hello community,
here is the log from the commit of package python-Flask-SQLAlchemy for
openSUSE:Factory checked in at 2020-06-02 14:38:00
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/python-Flask-SQLAlchemy (Old)
and /work/SRC/openSUSE:Factory/.python-Flask-SQLAlchemy.new.3606 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "python-Flask-SQLAlchemy"
Tue Jun 2 14:38:00 2020 rev:4 rq:810457 version:2.4.3
Changes:
--------
---
/work/SRC/openSUSE:Factory/python-Flask-SQLAlchemy/python-Flask-SQLAlchemy.changes
2019-09-26 20:48:48.401328477 +0200
+++
/work/SRC/openSUSE:Factory/.python-Flask-SQLAlchemy.new.3606/python-Flask-SQLAlchemy.changes
2020-06-02 14:38:45.867545161 +0200
@@ -1,0 +2,14 @@
+Sun May 31 00:08:47 UTC 2020 - Arun Persaud <[email protected]>
+
+- specfile:
+ * update copyright year
+
+- update to version 2.4.3:
+ * Deprecate SQLALCHEMY_COMMIT_ON_TEARDOWN as it can cause various
+ design issues that are difficult to debug. Call
+ db.session.commit() directly instead. :issue:`216`
+
+- changes from version 2.4.2:
+ * Fix bad pagination when records are de-duped. :pr:`812`
+
+-------------------------------------------------------------------
Old:
----
Flask-SQLAlchemy-2.4.1.tar.gz
New:
----
Flask-SQLAlchemy-2.4.3.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ python-Flask-SQLAlchemy.spec ++++++
--- /var/tmp/diff_new_pack.k5Qpci/_old 2020-06-02 14:38:46.599547476 +0200
+++ /var/tmp/diff_new_pack.k5Qpci/_new 2020-06-02 14:38:46.603547488 +0200
@@ -1,7 +1,7 @@
#
# spec file for package python-Flask-SQLAlchemy
#
-# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2020 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -18,7 +18,7 @@
%{?!python_module:%define python_module() python-%{**} python3-%{**}}
Name: python-Flask-SQLAlchemy
-Version: 2.4.1
+Version: 2.4.3
Release: 0
Summary: SQLAlchemy support for Flask
License: BSD-3-Clause
++++++ Flask-SQLAlchemy-2.4.1.tar.gz -> Flask-SQLAlchemy-2.4.3.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Flask-SQLAlchemy-2.4.1/CHANGES.rst
new/Flask-SQLAlchemy-2.4.3/CHANGES.rst
--- old/Flask-SQLAlchemy-2.4.1/CHANGES.rst 2019-09-24 16:28:23.000000000
+0200
+++ new/Flask-SQLAlchemy-2.4.3/CHANGES.rst 2020-05-27 00:13:23.000000000
+0200
@@ -1,3 +1,21 @@
+Version 2.4.3
+-------------
+
+Released 2020-05-26
+
+- Deprecate ``SQLALCHEMY_COMMIT_ON_TEARDOWN`` as it can cause various
+ design issues that are difficult to debug. Call
+ ``db.session.commit()`` directly instead. :issue:`216`
+
+
+Version 2.4.2
+-------------
+
+Released 2020-05-25
+
+- Fix bad pagination when records are de-duped. :pr:`812`
+
+
Version 2.4.1
-------------
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Flask-SQLAlchemy-2.4.1/Flask_SQLAlchemy.egg-info/PKG-INFO
new/Flask-SQLAlchemy-2.4.3/Flask_SQLAlchemy.egg-info/PKG-INFO
--- old/Flask-SQLAlchemy-2.4.1/Flask_SQLAlchemy.egg-info/PKG-INFO
2019-09-24 16:32:27.000000000 +0200
+++ new/Flask-SQLAlchemy-2.4.3/Flask_SQLAlchemy.egg-info/PKG-INFO
2020-05-27 00:14:33.000000000 +0200
@@ -1,6 +1,6 @@
Metadata-Version: 1.2
Name: Flask-SQLAlchemy
-Version: 2.4.1
+Version: 2.4.3
Summary: Adds SQLAlchemy support to your Flask application.
Home-page: https://github.com/pallets/flask-sqlalchemy
Author: Armin Ronacher
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Flask-SQLAlchemy-2.4.1/PKG-INFO
new/Flask-SQLAlchemy-2.4.3/PKG-INFO
--- old/Flask-SQLAlchemy-2.4.1/PKG-INFO 2019-09-24 16:32:27.000000000 +0200
+++ new/Flask-SQLAlchemy-2.4.3/PKG-INFO 2020-05-27 00:14:33.831065400 +0200
@@ -1,6 +1,6 @@
Metadata-Version: 1.2
Name: Flask-SQLAlchemy
-Version: 2.4.1
+Version: 2.4.3
Summary: Adds SQLAlchemy support to your Flask application.
Home-page: https://github.com/pallets/flask-sqlalchemy
Author: Armin Ronacher
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Flask-SQLAlchemy-2.4.1/docs/config.rst
new/Flask-SQLAlchemy-2.4.3/docs/config.rst
--- old/Flask-SQLAlchemy-2.4.1/docs/config.rst 2019-09-24 16:15:11.000000000
+0200
+++ new/Flask-SQLAlchemy-2.4.3/docs/config.rst 2020-05-27 00:01:41.000000000
+0200
@@ -98,15 +98,17 @@
``SQLALCHEMY_TRACK_MODIFICATIONS`` will warn if unset.
.. versionchanged:: 2.4
+ * ``SQLALCHEMY_ENGINE_OPTIONS`` configuration key was added.
+ * Deprecated keys
-* ``SQLALCHEMY_ENGINE_OPTIONS`` configuration key was added.
-* Deprecated keys
+ * ``SQLALCHEMY_NATIVE_UNICODE``
+ * ``SQLALCHEMY_POOL_SIZE``
+ * ``SQLALCHEMY_POOL_TIMEOUT``
+ * ``SQLALCHEMY_POOL_RECYCLE``
+ * ``SQLALCHEMY_MAX_OVERFLOW``
- * ``SQLALCHEMY_NATIVE_UNICODE``
- * ``SQLALCHEMY_POOL_SIZE``
- * ``SQLALCHEMY_POOL_TIMEOUT``
- * ``SQLALCHEMY_POOL_RECYCLE``
- * ``SQLALCHEMY_MAX_OVERFLOW``
+.. versionchanged:: 2.4.3
+ Deprecated ``SQLALCHEMY_COMMIT_ON_TEARDOWN``.
Connection URI Format
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Flask-SQLAlchemy-2.4.1/flask_sqlalchemy/__init__.py
new/Flask-SQLAlchemy-2.4.3/flask_sqlalchemy/__init__.py
--- old/Flask-SQLAlchemy-2.4.1/flask_sqlalchemy/__init__.py 2019-09-24
16:28:23.000000000 +0200
+++ new/Flask-SQLAlchemy-2.4.3/flask_sqlalchemy/__init__.py 2020-05-27
00:13:23.000000000 +0200
@@ -24,7 +24,7 @@
from .model import DefaultMeta
from . import utils
-__version__ = "2.4.1"
+__version__ = "2.4.3"
# the best timer function for the platform
if sys.platform == 'win32':
@@ -498,12 +498,7 @@
if not items and page != 1 and error_out:
abort(404)
- # No need to count if we're on the first page and there are fewer
- # items than we expected.
- if page == 1 and len(items) < per_page:
- total = len(items)
- else:
- total = self.order_by(None).count()
+ total = self.order_by(None).count()
return Pagination(self, page, per_page, total, items)
@@ -699,6 +694,10 @@
.. versionchanged:: 2.4
The `use_native_unicode` parameter was deprecated.
+
+ .. versionchanged:: 2.4.3
+ ``COMMIT_ON_TEARDOWN`` is deprecated and will be removed in
+ version 3.1. Call ``db.session.commit()`` directly instead.
"""
#: Default query class used by :attr:`Model.query` and other queries.
@@ -848,6 +847,13 @@
@app.teardown_appcontext
def shutdown_session(response_or_exc):
if app.config['SQLALCHEMY_COMMIT_ON_TEARDOWN']:
+ warnings.warn(
+ "'COMMIT_ON_TEARDOWN' is deprecated and will be"
+ " removed in version 3.1. Call"
+ " 'db.session.commit()'` directly instead.",
+ DeprecationWarning,
+ )
+
if response_or_exc is None:
self.session.commit()
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Flask-SQLAlchemy-2.4.1/tests/test_commit_on_teardown.py
new/Flask-SQLAlchemy-2.4.3/tests/test_commit_on_teardown.py
--- old/Flask-SQLAlchemy-2.4.1/tests/test_commit_on_teardown.py 2019-03-11
15:38:41.000000000 +0100
+++ new/Flask-SQLAlchemy-2.4.3/tests/test_commit_on_teardown.py 2020-05-27
00:01:41.000000000 +0200
@@ -22,12 +22,16 @@
def test_commit_on_success(client):
- resp = client.post('/create')
+ with pytest.warns(DeprecationWarning, match="COMMIT_ON_TEARDOWN"):
+ resp = client.post('/create')
+
assert resp.status_code == 200
assert client.get('/').data == b'Test one'
def test_roll_back_on_failure(client):
- resp = client.post('/create', data={'fail': 'on'})
+ with pytest.warns(DeprecationWarning, match="COMMIT_ON_TEARDOWN"):
+ resp = client.post('/create', data={'fail': 'on'})
+
assert resp.status_code == 500
assert client.get('/').data == b''
