Hello community, here is the log from the commit of package libansilove for openSUSE:Factory checked in at 2020-06-03 20:31:18 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libansilove (Old) and /work/SRC/openSUSE:Factory/.libansilove.new.3606 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libansilove" Wed Jun 3 20:31:18 2020 rev:8 rq:809765 version:1.2.3 Changes: -------- --- /work/SRC/openSUSE:Factory/libansilove/libansilove.changes 2020-05-01 11:15:32.208132373 +0200 +++ /work/SRC/openSUSE:Factory/.libansilove.new.3606/libansilove.changes 2020-06-03 20:32:02.301085296 +0200 @@ -1,0 +2,10 @@ +Mon May 25 17:30:14 UTC 2020 - Martin Hauke <[email protected]> + +- Update to version 1.2.3 + * Call memset() to set all fontData struct fields to zero in + all loaders + * Refactor error handling in ansilove_savefile() + * Add error handling for fwrite() in ansilove_savefile() + * Fix includes in various source files + +------------------------------------------------------------------- Old: ---- libansilove-1.2.2.tar.gz New: ---- libansilove-1.2.3.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libansilove.spec ++++++ --- /var/tmp/diff_new_pack.jxZrSH/_old 2020-06-03 20:32:03.393088616 +0200 +++ /var/tmp/diff_new_pack.jxZrSH/_new 2020-06-03 20:32:03.397088627 +0200 @@ -20,7 +20,7 @@ %global sover 1 %global libname %{name}%{sover} Name: libansilove -Version: 1.2.2 +Version: 1.2.3 Release: 0 Summary: Library for converting ANSI, ASCII, and other formats to PNG License: BSD-2-Clause ++++++ libansilove-1.2.2.tar.gz -> libansilove-1.2.3.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/.travis.yml new/libansilove-1.2.3/.travis.yml --- old/libansilove-1.2.2/.travis.yml 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/.travis.yml 2020-05-25 18:47:27.000000000 +0200 @@ -31,7 +31,7 @@ coverity_scan: project: name: "ansilove/libansilove" - version: 1.2.2 + version: 1.2.3 description: "Library for converting ANSI, ASCII, and other formats to PNG" notification_email: [email protected] build_command_prepend: cmake . diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/CMakeLists.txt new/libansilove-1.2.3/CMakeLists.txt --- old/libansilove-1.2.2/CMakeLists.txt 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/CMakeLists.txt 2020-05-25 18:47:27.000000000 +0200 @@ -2,7 +2,7 @@ set(LIB_VERSION_MAJOR 1) set(LIB_VERSION_MINOR 2) -set(LIB_VERSION_PATCH 2) +set(LIB_VERSION_PATCH 3) set(LIB_VERSION_STRING ${LIB_VERSION_MAJOR}.${LIB_VERSION_MINOR}.${LIB_VERSION_PATCH}) project (ansilove C) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/ChangeLog new/libansilove-1.2.3/ChangeLog --- old/libansilove-1.2.2/ChangeLog 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/ChangeLog 2020-05-25 18:47:27.000000000 +0200 @@ -1,3 +1,12 @@ +libansilove 1.2.3 (2020-05-25) + +- Call memset() to set all fontData struct fields to zero in all loaders +- Refactor error handling in ansilove_savefile() +- Add error handling for fwrite() in ansilove_savefile() +- Fix includes in various source files + + + libansilove 1.2.2 (2020-04-30) - Refactor the output function, to allow combining DOS aspect ratio and Retina diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/include/ansilove.h new/libansilove-1.2.3/include/ansilove.h --- old/libansilove-1.2.2/include/ansilove.h 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/include/ansilove.h 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * ansilove.h - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -20,11 +20,11 @@ #define ANSILOVE_EXTERN __attribute__((visibility("default"))) /* Version number */ -#define ANSILOVE_VERSION "1.2.2" +#define ANSILOVE_VERSION "1.2.3" #define ANSILOVE_VERSION_MAJOR 1 #define ANSILOVE_VERSION_MINOR 2 -#define ANSILOVE_VERSION_PATCH 2 +#define ANSILOVE_VERSION_PATCH 3 /* Error codes */ #define ANSILOVE_INVALID_PARAM 1 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/clean.c new/libansilove-1.2.3/src/clean.c --- old/libansilove-1.2.2/src/clean.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/clean.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * clean.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/config.h new/libansilove-1.2.3/src/config.h --- old/libansilove-1.2.2/src/config.h 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/config.h 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * config.h - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/drawchar.c new/libansilove-1.2.3/src/drawchar.c --- old/libansilove-1.2.2/src/drawchar.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/drawchar.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * drawchar.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -10,7 +10,6 @@ * See LICENSE file for details. */ -#include <inttypes.h> #include <gd.h> #include "drawchar.h" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/drawchar.h new/libansilove-1.2.3/src/drawchar.h --- old/libansilove-1.2.2/src/drawchar.h 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/drawchar.h 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * drawchar.h - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -13,8 +13,8 @@ #ifndef DRAWCHAR_H #define DRAWCHAR_H +#include <stdint.h> #include <gd.h> -#include <sys/types.h> void drawchar(gdImagePtr, const uint8_t *, uint32_t, uint32_t, uint32_t, uint32_t, uint32_t, uint32_t, uint8_t); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/error.c new/libansilove-1.2.3/src/error.c --- old/libansilove-1.2.2/src/error.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/error.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * error.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/fonts.c new/libansilove-1.2.3/src/fonts.c --- old/libansilove-1.2.2/src/fonts.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/fonts.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * fonts.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/fonts.h new/libansilove-1.2.3/src/fonts.h --- old/libansilove-1.2.2/src/fonts.h 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/fonts.h 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * fonts.h - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/init.c new/libansilove-1.2.3/src/init.c --- old/libansilove-1.2.2/src/init.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/init.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * init.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/loaders/ansi.c new/libansilove-1.2.3/src/loaders/ansi.c --- old/libansilove-1.2.2/src/loaders/ansi.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/loaders/ansi.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * ansi.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/loaders/artworx.c new/libansilove-1.2.3/src/loaders/artworx.c --- old/libansilove-1.2.2/src/loaders/artworx.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/loaders/artworx.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * artworx.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/loaders/binary.c new/libansilove-1.2.3/src/loaders/binary.c --- old/libansilove-1.2.2/src/loaders/binary.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/loaders/binary.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * binary.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -13,6 +13,7 @@ #include <gd.h> #include <stddef.h> #include <stdint.h> +#include <string.h> #include "ansilove.h" #include "config.h" #include "drawchar.h" @@ -32,6 +33,7 @@ struct fontStruct fontData; /* font selection */ + memset(&fontData, 0, sizeof(struct fontStruct)); select_font(&fontData, options->font); /* libgd image pointers */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/loaders/icedraw.c new/libansilove-1.2.3/src/loaders/icedraw.c --- old/libansilove-1.2.2/src/loaders/icedraw.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/loaders/icedraw.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * icedraw.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -13,7 +13,6 @@ #include <gd.h> #include <stdint.h> #include <stdlib.h> -#include <string.h> #include "ansilove.h" #include "drawchar.h" #include "output.h" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/loaders/pcboard.c new/libansilove-1.2.3/src/loaders/pcboard.c --- old/libansilove-1.2.2/src/loaders/pcboard.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/loaders/pcboard.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * pcboard.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -51,6 +51,7 @@ uint16_t columns = options->columns; /* font selection */ + memset(&fontData, 0, sizeof(struct fontStruct)); select_font(&fontData, options->font); /* libgd image pointers */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/loaders/tundra.c new/libansilove-1.2.3/src/loaders/tundra.c --- old/libansilove-1.2.2/src/loaders/tundra.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/loaders/tundra.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * tundra.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -51,6 +51,7 @@ int16_t columns = options->columns; /* font selection */ + memset(&fontData, 0, sizeof(struct fontStruct)); select_font(&fontData, options->font); /* libgd image pointers */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/loaders/xbin.c new/libansilove-1.2.3/src/loaders/xbin.c --- old/libansilove-1.2.2/src/loaders/xbin.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/loaders/xbin.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * xbin.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/loadfile.c new/libansilove-1.2.3/src/loadfile.c --- old/libansilove-1.2.2/src/loadfile.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/loadfile.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * loadfile.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/output.c new/libansilove-1.2.3/src/output.c --- old/libansilove-1.2.2/src/output.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/output.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * output.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -18,9 +18,6 @@ output(struct ansilove_ctx *ctx, struct ansilove_options *options, gdImagePtr source) { - /* XXX Error handling */ - /* XXX The caller must invoke gdFree() */ - /* Handle DOS aspect ratio */ if (options->dos) { gdImagePtr dos = gdImageCreateTrueColor(source->sx, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/output.h new/libansilove-1.2.3/src/output.h --- old/libansilove-1.2.2/src/output.h 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/output.h 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * output.h - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libansilove-1.2.2/src/savefile.c new/libansilove-1.2.3/src/savefile.c --- old/libansilove-1.2.2/src/savefile.c 2020-04-30 13:40:18.000000000 +0200 +++ new/libansilove-1.2.3/src/savefile.c 2020-05-25 18:47:27.000000000 +0200 @@ -1,6 +1,6 @@ /* * savefile.c - * libansilove 1.2.2 + * libansilove 1.2.3 * https://www.ansilove.org * * Copyright (c) 2011-2020 Stefan Vogt, Brian Cassidy, and Frederic Cambus @@ -16,6 +16,8 @@ int ansilove_savefile(struct ansilove_ctx *ctx, char *output) { + size_t rw; + if (ctx == NULL || output == NULL) { if (ctx) ctx->error = ANSILOVE_INVALID_PARAM; @@ -25,13 +27,18 @@ FILE *file = fopen(output, "wb"); - if (file) { - fwrite(ctx->png.buffer, ctx->png.length, 1, file); - fclose(file); - } else { - ctx->error = ANSILOVE_FILE_WRITE_ERROR; - return -1; - } + if (!file) + goto err; + + rw = fwrite(ctx->png.buffer, 1, ctx->png.length, file); + fclose(file); + + if (rw != (size_t)ctx->png.length) + goto err; return 0; + +err: + ctx->error = ANSILOVE_FILE_WRITE_ERROR; + return -1; }
