Hello community, here is the log from the commit of package atftp for openSUSE:Factory checked in at 2020-06-04 17:48:50 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/atftp (Old) and /work/SRC/openSUSE:Factory/.atftp.new.3606 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "atftp" Thu Jun 4 17:48:50 2020 rev:37 rq:807963 version:0.7.2 Changes: -------- --- /work/SRC/openSUSE:Factory/atftp/atftp.changes 2019-07-08 15:01:03.618537760 +0200 +++ /work/SRC/openSUSE:Factory/.atftp.new.3606/atftp.changes 2020-06-04 17:49:08.455658537 +0200 @@ -1,0 +2,14 @@ +Sat Apr 25 13:16:41 UTC 2020 - [email protected] + +- fix logrotate + * change command to '/sbin/service atftpd restart' since there is no + init script and we are using systemd +- fix service file + * atftpd does not create logfile when there is none, hence we create + in ExecStartPre +- Update sysconfig file + * add ATFTPD_LOGFILE if we want to use our own logfile + * add comment to ATFTPD_BIND_ADDRESSES that it is obsolete since + systemd (binds to 0.0.0.0) + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ atftp.spec ++++++ --- /var/tmp/diff_new_pack.yGmIUy/_old 2020-06-04 17:49:14.747673069 +0200 +++ /var/tmp/diff_new_pack.yGmIUy/_new 2020-06-04 17:49:14.751673077 +0200 @@ -1,7 +1,7 @@ # # spec file for package atftp # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,7 +12,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # ++++++ atftpd.logrotate ++++++ --- /var/tmp/diff_new_pack.yGmIUy/_old 2020-06-04 17:49:14.819673235 +0200 +++ /var/tmp/diff_new_pack.yGmIUy/_new 2020-06-04 17:49:14.823673244 +0200 @@ -9,6 +9,6 @@ missingok create 640 tftp tftp postrotate - /etc/init.d/atftpd restart + /sbin/service atftpd restart endscript } ++++++ atftpd.service ++++++ --- /var/tmp/diff_new_pack.yGmIUy/_old 2020-06-04 17:49:14.843673290 +0200 +++ /var/tmp/diff_new_pack.yGmIUy/_new 2020-06-04 17:49:14.847673300 +0200 @@ -3,5 +3,7 @@ [Service] EnvironmentFile=/etc/sysconfig/atftpd +# atftpd does not create logfile when there is none +ExecStartPre=-/usr/bin/su -c "/usr/bin/touch $ATFTPD_LOGFILE" -s /bin/bash $ATFTPD_USER ExecStart=/usr/sbin/atftpd --user $ATFTPD_USER --group $ATFTPD_GROUP $ATFTPD_OPTIONS $ATFTPD_DIRECTORY StandardInput=socket ++++++ atftpd.sysconfig ++++++ --- /var/tmp/diff_new_pack.yGmIUy/_old 2020-06-04 17:49:14.875673364 +0200 +++ /var/tmp/diff_new_pack.yGmIUy/_new 2020-06-04 17:49:14.879673373 +0200 @@ -18,10 +18,23 @@ ## Default: "" ## ## INFO: -## "--daemon, --user, --group, --logfile" can not be removed/replaced here as -## atftp is started with them as default opts: "--daemon --user atftp --group atftp " +## logging to file, if enabled, defaults to: "/var/log/atftpd/atftp.log" +# +# atftpd logfile +# +ATFTPD_LOGFILE="/var/log/atftpd/atftp.log" + +## Type: string +## Default: "" +## +## INFO: +## "--daemon is obsolete since systemd" +## "--user, --group" can not be removed/replaced here as +## atftpd is started with them as default opts: "--user $ATFTPD_USER --group $ATFTPD_GROUP" ## and -## logging to file is set as default: "--logfile /var/log/atftpd/atftp.log " +## logging is set to syslog as default if not enabled: +## use the following to enable logging to own logfile +## "--logfile $ATFTPD_LOGFILE" # # atftpd options # @@ -51,4 +64,6 @@ # One instance of the service is started on each IP address. # By default atftpd will listen on all available IP addresses/interfaces. # +# obsolete since systemd socket binds to 0.0.0.0 +# ATFTPD_BIND_ADDRESSES=""
