Hello community, here is the log from the commit of package chromium for openSUSE:Factory checked in at 2020-06-08 23:44:10 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/chromium (Old) and /work/SRC/openSUSE:Factory/.chromium.new.3606 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "chromium" Mon Jun 8 23:44:10 2020 rev:258 rq:811311 version:83.0.4103.97 Changes: -------- --- /work/SRC/openSUSE:Factory/chromium/chromium.changes 2020-05-26 17:16:46.583645512 +0200 +++ /work/SRC/openSUSE:Factory/.chromium.new.3606/chromium.changes 2020-06-08 23:45:35.725653831 +0200 @@ -1,0 +2,33 @@ +Thu Jun 4 06:28:45 UTC 2020 - Tomáš Chvátal <[email protected]> + +- Update to 83.0.4103.97 bsc#1172496: + * CVE-2020-6493: Use after free in WebAuthentication. + * CVE-2020-6494: Incorrect security UI in payments. + * CVE-2020-6495: Insufficient policy enforcement in developer tools. + * CVE-2020-6496: Use after free in payments. + +------------------------------------------------------------------- +Thu May 28 09:18:05 UTC 2020 - Tomáš Chvátal <[email protected]> + +- Add patch to not use bundled unrar: + * chromium-norar.patch + +------------------------------------------------------------------- +Thu May 28 08:59:02 UTC 2020 - Fabian Vogt <[email protected]> + +- Amend chromium-prop-codecs.patch to allow proprietary_codecs + without building third_party/openh264 + +------------------------------------------------------------------- +Wed May 27 12:03:31 UTC 2020 - Tomáš Chvátal <[email protected]> + +- Add revert of location setting commit that broke build on + openSUSE Leap 15.1: + * chromium-83-gcc-location-revert.patch + +------------------------------------------------------------------- +Mon May 25 09:16:54 UTC 2020 - Tomáš Chvátal <[email protected]> + +- Swtich to GCC 9.x on Leaps to avoid gcc bug exposed in gcc8 + +------------------------------------------------------------------- Old: ---- chromium-83.0.4103.61.tar.xz New: ---- chromium-83-gcc-location-revert.patch chromium-83.0.4103.97.tar.xz chromium-norar.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ chromium.spec ++++++ --- /var/tmp/diff_new_pack.TSHHw6/_old 2020-06-08 23:45:53.753709442 +0200 +++ /var/tmp/diff_new_pack.TSHHw6/_new 2020-06-08 23:45:53.757709455 +0200 @@ -46,7 +46,7 @@ %bcond_with clang %bcond_with wayland Name: chromium -Version: 83.0.4103.61 +Version: 83.0.4103.97 Release: 0 Summary: Google's open source browser project License: BSD-3-Clause AND LGPL-2.1-or-later @@ -89,6 +89,9 @@ Patch27: chromium-83-gcc-include.patch Patch28: chromium-83-gcc-10.patch Patch29: chromium-81-re2-0.2020.05.01.patch +Patch30: chromium-83-gcc-location-revert.patch +# Do not use unrar code, it is non-free +Patch31: chromium-norar.patch # Google seem not too keen on merging this but GPU accel is quite important # https://chromium-review.googlesource.com/c/chromium/src/+/532294 # https://github.com/saiarcot895/chromium-ubuntu-build/tree/master/debian/patches @@ -249,11 +252,11 @@ BuildRequires: clang >= 5.0.0 %else %if %{?suse_version} > 1500 -BuildRequires: gcc >= 8 -BuildRequires: gcc-c++ >= 8 +BuildRequires: gcc >= 9 +BuildRequires: gcc-c++ >= 9 %else -BuildRequires: gcc8 -BuildRequires: gcc8-c++ +BuildRequires: gcc9 +BuildRequires: gcc9-c++ %endif %endif @@ -399,7 +402,6 @@ third_party/node third_party/node/node_modules/polymer-bundler/lib/third_party/UglifyJS2 third_party/one_euro_filter - third_party/openh264 third_party/openscreen third_party/openscreen/src/third_party/tinycbor/src/src third_party/ots @@ -532,8 +534,8 @@ export AR=ar export NM=nm %if 0%{?suse_version} <= 1500 -export CC=gcc-8 -export CXX=g++-8 +export CC=gcc-9 +export CXX=g++-9 # some still call gcc/g++ mkdir -p "$HOME/bin/" ln -sfn %{_bindir}/$CC $HOME/bin/gcc @@ -630,7 +632,6 @@ %endif myconf_gn+=" enable_hangout_services_extension=true" myconf_gn+=" enable_vulkan=true" -myconf_gn+=" enable_hevc_demuxing=true" %if %{with pipewire} myconf_gn+=" rtc_use_pipewire=true rtc_link_pipewire=true" myconf_gn+=" rtc_use_pipewire_version=\"0.3\"" ++++++ chromium-83-gcc-location-revert.patch ++++++ >From c79ae4c2558778aa36e48c16ebc64946116bcdf2 Mon Sep 17 00:00:00 2001 From: Adam Rice <[email protected]> Date: Wed, 15 Jan 2020 03:45:37 +0000 Subject: [PATCH] Revert "Allow FROM_HERE to be backed by base::Location::Current()." This reverts commit 6c9388f9a927eb3391446d713bd2e68e1f4667d3. Reason for revert: Broke compile on ios-device-xcode-clang bot: https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/120239 Original change's description: > Allow FROM_HERE to be backed by base::Location::Current(). > > This allows the functionality of base::Location::Current() to be > verified in releases while still allowing a simple revert. > > One minor difference from before is that the helper macro > FROM_HERE_WITH_EXPLICIT_FUNCTION is no longer supported. Since > cc::BeginFrameTracker is the only user of this macro and doesn't > appear to need it, just revert it to use FROM_HERE directly. > > Bug: 974061 > Change-Id: Iae09bc02caf9f095a3ace9ea3ac70ded3dd493e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990262 > Commit-Queue: Daniel Cheng <[email protected]> > Reviewed-by: danakj <[email protected]> > Reviewed-by: Alexander Timin <[email protected]> > Reviewed-by: Jeremy Roman <[email protected]> > Auto-Submit: Daniel Cheng <[email protected]> > Cr-Commit-Position: refs/heads/master@{#731804} [email protected],[email protected],[email protected],[email protected] Change-Id: I4d545b08f3e784cb9302ad1fb1541741296af726 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000439 Reviewed-by: Adam Rice <[email protected]> Commit-Queue: Adam Rice <[email protected]> Cr-Commit-Position: refs/heads/master@{#731812} --- base/BUILD.gn | 8 -------- base/location.cc | 8 -------- base/location.h | 17 ++++++----------- base/location_unittest.cc | 2 -- cc/scheduler/begin_frame_tracker.h | 3 +++ cc/scheduler/scheduler.cc | 3 +-- cc/trees/layer_tree_host_impl.cc | 3 +-- components/viz/test/begin_frame_source_test.cc | 4 ++-- 8 files changed, 13 insertions(+), 35 deletions(-) Index: chromium-83.0.4103.61/base/BUILD.gn =================================================================== --- chromium-83.0.4103.61.orig/base/BUILD.gn +++ chromium-83.0.4103.61/base/BUILD.gn @@ -54,13 +54,6 @@ declare_args() { # file name) is saved. enable_location_source = true - # Whether or not the FROM_HERE macro uses base::Location::Current(). This - # allows the implementation to be reverted if needed while validating its - # replacement base::Location::Current(). On by default in non-official builds - # for testing purposes. - # TODO(https://crbug.com/974061): remove this eventually. - from_here_uses_location_builtins = !is_official_build - # Unsafe developer build. Has developer-friendly features that may weaken or # disable security measures like sandboxing or ASLR. # IMPORTANT: Unsafe developer builds should never be distributed to end users. @@ -2113,7 +2106,6 @@ buildflag_header("debugging_buildflags") flags = [ "ENABLE_LOCATION_SOURCE=$enable_location_source", - "FROM_HERE_USES_LOCATION_BUILTINS=$from_here_uses_location_builtins", "ENABLE_PROFILING=$enable_profiling", "CAN_UNWIND_WITH_FRAME_POINTERS=$can_unwind_with_frame_pointers", "UNSAFE_DEVELOPER_BUILD=$is_unsafe_developer_build", Index: chromium-83.0.4103.61/base/location.cc =================================================================== --- chromium-83.0.4103.61.orig/base/location.cc +++ chromium-83.0.4103.61/base/location.cc @@ -57,16 +57,11 @@ std::string Location::ToString() const { #define RETURN_ADDRESS() nullptr #endif -#if !BUILDFLAG(FROM_HERE_USES_LOCATION_BUILTINS) -#if !BUILDFLAG(ENABLE_LOCATION_SOURCE) - // static NOINLINE Location Location::CreateFromHere(const char* file_name) { return Location(file_name, RETURN_ADDRESS()); } -#else - // static NOINLINE Location Location::CreateFromHere(const char* function_name, const char* file_name, @@ -74,9 +69,6 @@ NOINLINE Location Location::CreateFromHe return Location(function_name, file_name, line_number, RETURN_ADDRESS()); } -#endif -#endif - #if SUPPORTS_LOCATION_BUILTINS && BUILDFLAG(ENABLE_LOCATION_SOURCE) // static NOINLINE Location Location::Current(const char* function_name, Index: chromium-83.0.4103.61/base/location.h =================================================================== --- chromium-83.0.4103.61.orig/base/location.h +++ chromium-83.0.4103.61/base/location.h @@ -83,15 +83,10 @@ class BASE_EXPORT Location { // are not available, this will return "pc:<hex address>". std::string ToString() const; -#if !BUILDFLAG(FROM_HERE_USES_LOCATION_BUILTINS) -#if !BUILDFLAG(ENABLE_LOCATION_SOURCE) static Location CreateFromHere(const char* file_name); -#else static Location CreateFromHere(const char* function_name, const char* file_name, int line_number); -#endif -#endif #if SUPPORTS_LOCATION_BUILTINS && BUILDFLAG(ENABLE_LOCATION_SOURCE) static Location Current(const char* function_name = __builtin_FUNCTION(), @@ -112,20 +107,20 @@ class BASE_EXPORT Location { BASE_EXPORT const void* GetProgramCounter(); -#if BUILDFLAG(FROM_HERE_USES_LOCATION_BUILTINS) - -#define FROM_HERE ::base::Location::Current() - // The macros defined here will expand to the current function. -#elif BUILDFLAG(ENABLE_LOCATION_SOURCE) +#if BUILDFLAG(ENABLE_LOCATION_SOURCE) // Full source information should be included. -#define FROM_HERE ::base::Location::CreateFromHere(__func__, __FILE__, __LINE__) +#define FROM_HERE FROM_HERE_WITH_EXPLICIT_FUNCTION(__func__) +#define FROM_HERE_WITH_EXPLICIT_FUNCTION(function_name) \ + ::base::Location::CreateFromHere(function_name, __FILE__, __LINE__) #else // TODO(http://crbug.com/760702) remove the __FILE__ argument from these calls. #define FROM_HERE ::base::Location::CreateFromHere(__FILE__) +#define FROM_HERE_WITH_EXPLICIT_FUNCTION(function_name) \ + ::base::Location::CreateFromHere(function_name, __FILE__, -1) #endif Index: chromium-83.0.4103.61/base/location_unittest.cc =================================================================== --- chromium-83.0.4103.61.orig/base/location_unittest.cc +++ chromium-83.0.4103.61/base/location_unittest.cc @@ -34,8 +34,6 @@ TEST(LocationTest, CurrentYieldsCorrectV #endif #elif defined(OFFICIAL_BUILD) #error Location builtins must be supported in official builds. -#elif BUILDFLAG(FROM_HERE_USES_LOCATION_BUILTINS) -#error FROM_HERE requires location builtins to be supported. #endif ALLOW_UNUSED_LOCAL(previous_line); } Index: chromium-83.0.4103.61/cc/scheduler/begin_frame_tracker.h =================================================================== --- chromium-83.0.4103.61.orig/cc/scheduler/begin_frame_tracker.h +++ chromium-83.0.4103.61/cc/scheduler/begin_frame_tracker.h @@ -8,11 +8,14 @@ #include <set> #include <string> +#include "base/location.h" #include "base/trace_event/trace_event.h" #include "base/trace_event/traced_value.h" #include "cc/cc_export.h" #include "components/viz/common/frame_sinks/begin_frame_args.h" +#define BEGINFRAMETRACKER_FROM_HERE FROM_HERE_WITH_EXPLICIT_FUNCTION("") + namespace perfetto { namespace protos { namespace pbzero { Index: chromium-83.0.4103.61/cc/scheduler/scheduler.cc =================================================================== --- chromium-83.0.4103.61.orig/cc/scheduler/scheduler.cc +++ chromium-83.0.4103.61/cc/scheduler/scheduler.cc @@ -9,7 +9,6 @@ #include "base/auto_reset.h" #include "base/bind.h" -#include "base/location.h" #include "base/logging.h" #include "base/single_thread_task_runner.h" #include "base/trace_event/trace_event.h" @@ -41,7 +40,7 @@ Scheduler::Scheduler( layer_tree_host_id_(layer_tree_host_id), task_runner_(task_runner), compositor_timing_history_(std::move(compositor_timing_history)), - begin_impl_frame_tracker_(FROM_HERE), + begin_impl_frame_tracker_(BEGINFRAMETRACKER_FROM_HERE), state_machine_(settings) { TRACE_EVENT1("cc", "Scheduler::Scheduler", "settings", settings_.AsValue()); DCHECK(client_); Index: chromium-83.0.4103.61/cc/trees/layer_tree_host_impl.cc =================================================================== --- chromium-83.0.4103.61.orig/cc/trees/layer_tree_host_impl.cc +++ chromium-83.0.4103.61/cc/trees/layer_tree_host_impl.cc @@ -18,7 +18,6 @@ #include "base/containers/flat_map.h" #include "base/debug/crash_logging.h" #include "base/debug/dump_without_crashing.h" -#include "base/location.h" #include "base/memory/ptr_util.h" #include "base/memory/read_only_shared_memory_region.h" #include "base/metrics/histogram.h" @@ -286,7 +285,7 @@ LayerTreeHostImpl::LayerTreeHostImpl( : client_(client), scheduling_client_(scheduling_client), task_runner_provider_(task_runner_provider), - current_begin_frame_tracker_(FROM_HERE), + current_begin_frame_tracker_(BEGINFRAMETRACKER_FROM_HERE), compositor_frame_reporting_controller_( std::make_unique<CompositorFrameReportingController>( /*should_report_metrics=*/!settings Index: chromium-83.0.4103.61/components/viz/test/begin_frame_source_test.cc =================================================================== --- chromium-83.0.4103.61.orig/components/viz/test/begin_frame_source_test.cc +++ chromium-83.0.4103.61/components/viz/test/begin_frame_source_test.cc @@ -4,7 +4,6 @@ #include "components/viz/test/begin_frame_source_test.h" -#include "base/location.h" #include "components/viz/test/begin_frame_args_test.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" @@ -34,7 +33,8 @@ const BeginFrameArgs MockBeginFrameObser #ifdef NDEBUG nullptr, #else - FROM_HERE, + FROM_HERE_WITH_EXPLICIT_FUNCTION( + "MockBeginFrameObserver::kDefaultBeginFrameArgs"), #endif BeginFrameArgs::kManualSourceId, BeginFrameArgs::kStartingFrameNumber, Index: chromium-83.0.4103.61/third_party/blink/renderer/platform/heap/persistent.h =================================================================== --- chromium-83.0.4103.61.orig/third_party/blink/renderer/platform/heap/persistent.h +++ chromium-83.0.4103.61/third_party/blink/renderer/platform/heap/persistent.h @@ -39,16 +39,10 @@ class PersistentLocation final { base::Location location_; }; -#if !BUILDFLAG(FROM_HERE_USES_LOCATION_BUILTINS) && \ - BUILDFLAG(RAW_HEAP_SNAPSHOTS) -#if !BUILDFLAG(ENABLE_LOCATION_SOURCE) -#define PERSISTENT_FROM_HERE \ - PersistentLocation(::base::Location::CreateFromHere(__FILE__)) -#else +#if BUILDFLAG(RAW_HEAP_SNAPSHOTS) #define PERSISTENT_FROM_HERE \ PersistentLocation( \ ::base::Location::CreateFromHere(__func__, __FILE__, __LINE__)) -#endif #else #define PERSISTENT_FROM_HERE PersistentLocation() #endif // BUILDFLAG(RAW_HEAP_SNAPSHOTS) ++++++ chromium-83.0.4103.61.tar.xz -> chromium-83.0.4103.97.tar.xz ++++++ /work/SRC/openSUSE:Factory/chromium/chromium-83.0.4103.61.tar.xz /work/SRC/openSUSE:Factory/.chromium.new.3606/chromium-83.0.4103.97.tar.xz differ: char 26, line 1 ++++++ chromium-norar.patch ++++++ Index: chromium-83.0.4103.61/chrome/common/safe_browsing/BUILD.gn =================================================================== --- chromium-83.0.4103.61.orig/chrome/common/safe_browsing/BUILD.gn +++ chromium-83.0.4103.61/chrome/common/safe_browsing/BUILD.gn @@ -57,39 +57,6 @@ if (safe_browsing_mode == 1) { public_deps = [ "//components/safe_browsing/core:csd_proto" ] } - source_set("rar_analyzer") { - sources = [ - "rar_analyzer.cc", - "rar_analyzer.h", - ] - - deps = [ - ":archive_analyzer_results", - ":download_type_util", - "//base", - "//base:i18n", - "//components/safe_browsing/core:features", - "//components/safe_browsing/core:file_type_policies", - "//third_party/unrar:unrar", - ] - - defines = [ - "_FILE_OFFSET_BITS=64", - "LARGEFILE_SOURCE", - "RAR_SMP", - "SILENT", - - # The following is set to disable certain macro definitions in the unrar - # source code. - "CHROMIUM_UNRAR", - - # Disables exceptions in unrar, replaces them with process termination. - "UNRAR_NO_EXCEPTIONS", - ] - - public_deps = [ "//components/safe_browsing/core:csd_proto" ] - } - source_set("disk_image_type_sniffer_mac") { sources = [ "disk_image_type_sniffer_mac.cc", @@ -156,7 +123,6 @@ source_set("safe_browsing") { ":archive_analyzer_results", ":binary_feature_extractor", ":download_type_util", - ":rar_analyzer", "//components/safe_browsing/core:features", ] Index: chromium-83.0.4103.61/chrome/common/safe_browsing/DEPS =================================================================== --- chromium-83.0.4103.61.orig/chrome/common/safe_browsing/DEPS +++ chromium-83.0.4103.61/chrome/common/safe_browsing/DEPS @@ -1,6 +1,5 @@ include_rules = [ "+components/safe_browsing", "+third_party/protobuf", - "+third_party/unrar", "+third_party/zlib", ] Index: chromium-83.0.4103.61/chrome/services/file_util/safe_archive_analyzer.cc =================================================================== --- chromium-83.0.4103.61.orig/chrome/services/file_util/safe_archive_analyzer.cc +++ chromium-83.0.4103.61/chrome/services/file_util/safe_archive_analyzer.cc @@ -46,10 +46,14 @@ void SafeArchiveAnalyzer::AnalyzeDmgFile void SafeArchiveAnalyzer::AnalyzeRarFile(base::File rar_file, base::File temporary_file, AnalyzeRarFileCallback callback) { +#if 0 DCHECK(rar_file.IsValid()); safe_browsing::ArchiveAnalyzerResults results; safe_browsing::rar_analyzer::AnalyzeRarFile( std::move(rar_file), std::move(temporary_file), &results); std::move(callback).Run(results); +#else + NOTREACHED(); +#endif } ++++++ chromium-prop-codecs.patch ++++++ --- /var/tmp/diff_new_pack.TSHHw6/_old 2020-06-08 23:45:53.965710096 +0200 +++ /var/tmp/diff_new_pack.TSHHw6/_new 2020-06-08 23:45:53.969710109 +0200 @@ -1,7 +1,8 @@ -diff -urN chromium-62.0.3192.0.orig/media/BUILD.gn chromium-62.0.3192.0/media/BUILD.gn ---- chromium-62.0.3192.0.orig/media/BUILD.gn 2017-08-25 11:22:39.294487172 +0200 -+++ chromium-62.0.3192.0/media/BUILD.gn 2017-08-25 11:25:41.674488175 +0200 -@@ -42,12 +42,6 @@ +Index: chromium-83.0.4103.61/media/BUILD.gn +=================================================================== +--- chromium-83.0.4103.61.orig/media/BUILD.gn ++++ chromium-83.0.4103.61/media/BUILD.gn +@@ -45,12 +45,6 @@ buildflag_header("media_buildflags") { ] } @@ -14,3 +15,17 @@ # Common configuration for targets in the media directory; these must not be # exported since things like USE_NEON and USE_CRAS have different meanings # elsewhere in the code base. +Index: chromium-83.0.4103.61/third_party/webrtc/webrtc.gni +=================================================================== +--- chromium-83.0.4103.61.orig/third_party/webrtc/webrtc.gni ++++ chromium-83.0.4103.61/third_party/webrtc/webrtc.gni +@@ -152,8 +152,7 @@ declare_args() { + # + # Enabling H264 when building with MSVC is currently not supported, see + # bugs.webrtc.org/9213#c13 for more info. +- rtc_use_h264 = +- proprietary_codecs && !is_android && !is_ios && !(is_win && !is_clang) ++ rtc_use_h264 = false + + # By default, use normal platform audio support or dummy audio, but don't + # use file-based audio playout and record.
