Hello community, here is the log from the commit of package vboot for openSUSE:Factory checked in at 2020-06-08 23:59:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/vboot (Old) and /work/SRC/openSUSE:Factory/.vboot.new.3606 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "vboot" Mon Jun 8 23:59:58 2020 rev:12 rq:812258 version:78.12499 Changes: -------- --- /work/SRC/openSUSE:Factory/vboot/vboot.changes 2020-02-24 15:56:03.739954780 +0100 +++ /work/SRC/openSUSE:Factory/.vboot.new.3606/vboot.changes 2020-06-09 00:03:56.981138573 +0200 @@ -1,0 +2,5 @@ +Sun Jun 7 16:18:07 UTC 2020 - Misha Komarovskiy <[email protected]> + +- add fix_vboot_version.patch to fix gcc10 build + +------------------------------------------------------------------- New: ---- fix_vboot_version.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ vboot.spec ++++++ --- /var/tmp/diff_new_pack.chHXb1/_old 2020-06-09 00:03:57.905141852 +0200 +++ /var/tmp/diff_new_pack.chHXb1/_new 2020-06-09 00:03:57.909141866 +0200 @@ -31,6 +31,7 @@ Patch1: fix_Makefile.patch Patch2: Fix-arch-detection-for-armv6.patch Patch3: reproducible.patch +Patch4: fix_vboot_version.patch BuildRequires: gcc-c++ BuildRequires: libgnutls-devel BuildRequires: libuuid-devel @@ -49,6 +50,7 @@ %patch1 %patch2 -p1 %patch3 -p1 +%patch4 -p1 %build export CFLAGS="-D_GNU_SOURCE %{optflags}" ++++++ fix_vboot_version.patch ++++++ >From df4d2000a22db673a788b8e57e8e7c0cc3cee777 Mon Sep 17 00:00:00 2001 From: Leonard Chan <[email protected]> Date: Thu, 3 Oct 2019 18:53:04 -0700 Subject: [PATCH] Make vboot_version extern in header When enabling `-fno-common` in Fuchsia, we get a bunch of linker errors when linking futility: ``` ld.lld: error: duplicate symbol: vboot_version >>> defined at futility.h:43 >>> (../../third_party/vboot_reference/futility/futility.h:43) >>> >>> host_x63-asan_no_detect_leaks/obj/third_party/vboot_reference/futility/futility.cmd_bdb.c.o:(vboot_version) >>> defined at futility.h:43 >>> (../../third_party/vboot_reference/futility/futility.h:43) >>> >>> host_x64-asan_no_detect_leaks/obj/third_party/vboot_reference/futility/futility.cmd_create.c.o:(.bss.vboot_version+0x0) ``` and think this is because -fno-common places vboot_version for unitialized global variables in the BSS section of each object file. Making it extern instead resolves each reference to its definition in futility/misc.c. Change-Id: I591f07abd1f975a8a9d078bb4366e2e0861390b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1839207 Reviewed-by: Julius Werner <[email protected]> Reviewed-by: Joel Kitching <[email protected]> Commit-Queue: Julius Werner <[email protected]> Tested-by: Julius Werner <[email protected]> Patch taken from upstream: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/df4d2000a22db673a788b8e57e8e7c0cc3cee777 Signed-off-by: Heiko Thiery <[email protected]> --- futility/futility.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/futility/futility.h b/futility/futility.h index 3bce1106..5dc426dd 100644 --- a/futility/futility.h +++ b/futility/futility.h @@ -41,7 +41,7 @@ enum vboot_version { }; /* What's our preferred API & data format? */ -enum vboot_version vboot_version; +extern enum vboot_version vboot_version; /* Here's a structure to define the commands that futility implements. */ struct futil_cmd_t { -- 2.20.1
