Hello community,
here is the log from the commit of package xf86-input-wacom for
openSUSE:Factory checked in at 2020-06-11 14:44:53
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/xf86-input-wacom (Old)
and /work/SRC/openSUSE:Factory/.xf86-input-wacom.new.3606 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "xf86-input-wacom"
Thu Jun 11 14:44:53 2020 rev:32 rq:812710 version:0.37.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/xf86-input-wacom/xf86-input-wacom.changes
2019-08-24 18:40:49.185789573 +0200
+++
/work/SRC/openSUSE:Factory/.xf86-input-wacom.new.3606/xf86-input-wacom.changes
2020-06-11 14:45:05.973451992 +0200
@@ -1,0 +2,6 @@
+Mon Jun 8 17:45:15 UTC 2020 - Stefan Dirsch <[email protected]>
+
+- U_Change-default-gesture-mode-touchpad-on-touchscreen-.patch
+ * disable gesture mode on Touchscreens by default (boo#1172669)
+
+-------------------------------------------------------------------
New:
----
U_Change-default-gesture-mode-touchpad-on-touchscreen-.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ xf86-input-wacom.spec ++++++
--- /var/tmp/diff_new_pack.oheb6Y/_old 2020-06-11 14:45:08.185458436 +0200
+++ /var/tmp/diff_new_pack.oheb6Y/_new 2020-06-11 14:45:08.189458447 +0200
@@ -1,7 +1,7 @@
#
# spec file for package xf86-input-wacom
#
-# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2020 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -22,12 +22,13 @@
Summary: Wacom input driver for the Xorg X server
License: GPL-2.0-or-later
Group: System/X11/Servers/XF86_4
-Url: https://github.com/linuxwacom/xf86-input-wacom
+URL: https://github.com/linuxwacom/xf86-input-wacom
Source0:
https://github.com/linuxwacom/xf86-input-wacom/releases/download/%{name}-%{version}/%{name}-%{version}.tar.bz2
Patch7: n_01-Add-option-to-enable-logging.patch
Patch8: n_02-Log-PROXIMITY-LOW-LEVEL-events.patch
Patch9: n_03-Log-PRESSURE-low-level-events.patch
Patch10: n_04-Log-BUTTON-HIGH-LEVEL-events.patch
+Patch11: U_Change-default-gesture-mode-touchpad-on-touchscreen-.patch
# For directory ownership
BuildRequires: libtool
BuildRequires: pkgconfig
@@ -77,6 +78,7 @@
%patch8 -p1
%patch9 -p1
%patch10 -p1
+%patch11 -p1
%build
autoreconf -fi
++++++ U_Change-default-gesture-mode-touchpad-on-touchscreen-.patch ++++++
>From 31a5405f7d9405bc514585709161287b0c67386e Mon Sep 17 00:00:00 2001
From: Jason Gerecke <[email protected]>
Date: Mon, 9 Sep 2019 15:32:17 -0700
Subject: [PATCH] Change default gesture mode: touchpad=on, touchscreen=off
A large number of users run the GNOME desktop which has its own gesture
engine that performs actions on touchscreens. These gestures are much
better than the ones we provide, so lets disable our engine by default
for touchscreens. Note that GNOME doesn't do anything with touchpad
gestures, so we leave them enabled by default.
Note that this change will effectively cause a feature regression for
users of other environments that do *not* have their own gesture
engines (Cinnamon, KDE, MATE, XFCE, etc.). Users will want to add an
xorg.conf.d snippet with `Option "Gesture" "on"` to bring back the
functionality.
Signed-off-by: Jason Gerecke <[email protected]>
---
src/wcmValidateDevice.c | 7 ++-----
src/xf86WacomDefs.h | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
index 0b20bd7..6176139 100644
--- a/src/wcmValidateDevice.c
+++ b/src/wcmValidateDevice.c
@@ -1019,13 +1019,10 @@ Bool wcmPreInitParseOptions(InputInfoPtr pInfo, Bool
is_primary,
if (TabletHasFeature(common, WCM_2FGT))
{
int gesture_is_on;
-
- /* GestureDefault was off for all devices
- * except when multi-touch is supported */
- common->wcmGestureDefault = 1;
+ Bool gesture_default = TabletHasFeature(priv->common, WCM_LCD)
? FALSE : TRUE;
gesture_is_on = xf86SetBoolOption(pInfo->options, "Gesture",
- common->wcmGestureDefault);
+ gesture_default);
if (is_primary || IsTouch(priv))
common->wcmGesture = gesture_is_on;
diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h
index 566211e..3305740 100644
--- a/src/xf86WacomDefs.h
+++ b/src/xf86WacomDefs.h
@@ -459,7 +459,6 @@ struct _WacomCommonRec
int wcmTouch; /* disable/enable touch event */
int wcmTouchDefault; /* default to disable when not supported */
int wcmGesture; /* disable/enable touch gesture */
- int wcmGestureDefault; /* default touch gesture to disable when
not supported */
int wcmGestureMode; /* data is in Gesture Mode? */
WacomDeviceState wcmGestureState[MAX_FINGERS]; /* inital state when in
gesture mode */
WacomGesturesParameters wcmGestureParameters;
--
2.16.4