Hello community, here is the log from the commit of package gnome-boxes for openSUSE:Factory checked in at 2020-06-14 18:14:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-boxes (Old) and /work/SRC/openSUSE:Factory/.gnome-boxes.new.3606 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-boxes" Sun Jun 14 18:14:19 2020 rev:72 rq:813505 version:3.36.5 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-boxes/gnome-boxes.changes 2020-06-08 23:48:01.734104226 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-boxes.new.3606/gnome-boxes.changes 2020-06-14 18:14:25.502665440 +0200 @@ -1,0 +2,17 @@ +Thu Jun 11 11:54:24 UTC 2020 - Bjørn Lie <[email protected]> + +- Update to version 3.36.5: + + Limit Notification message from expanding out of the window + + Update sensitivity of "Send File" option when user agent is + connected + + Fix misplacement of popover when performing an + express-installation + + Disable some shortcuts in display mode that interfer with the + guest + + Pass "wget" as user-agent in SoupSession calls + + Fix VM creation cancellation issues in the machine creation + Assistant + + Various Flatpak build fixes to cope with gcc 10 + + Disable creation of VMs with EFI firmware. + +------------------------------------------------------------------- Old: ---- gnome-boxes-3.36.4.tar.xz New: ---- gnome-boxes-3.36.5.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-boxes.spec ++++++ --- /var/tmp/diff_new_pack.718OxG/_old 2020-06-14 18:14:26.322668193 +0200 +++ /var/tmp/diff_new_pack.718OxG/_new 2020-06-14 18:14:26.326668207 +0200 @@ -22,7 +22,7 @@ %define govf_sover 0.1 %define gfrdp_sover 0.1 Name: gnome-boxes -Version: 3.36.4 +Version: 3.36.5 Release: 0 Summary: A GNOME 3 application to access remote or virtual systems License: LGPL-2.0-or-later ++++++ gnome-boxes-3.36.4.tar.xz -> gnome-boxes-3.36.5.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/NEWS new/gnome-boxes-3.36.5/NEWS --- old/gnome-boxes-3.36.4/NEWS 2020-05-25 16:19:51.301112700 +0200 +++ new/gnome-boxes-3.36.5/NEWS 2020-06-11 11:28:51.000000000 +0200 @@ -1,3 +1,21 @@ +3.36.5 - Jun 11, 2020 +===================== + +Changes since 3.36.4 + + - Limit Notification message from expanding out of the window + - Update sensitivity of "Send File" option when user agent is connected + - Fix misplacement of popover when performing an express-installation + - Disable some shortcuts in display mode that interfer with the guest + - Pass "wget" as user-agent in SoupSession calls + - Fix VM creation cancellation issues in the machine creation Assistant + - Various Flatpak build fixes to cope with gcc 10 + - Disable creation of VMs with EFI firmware + +All contributors to this release: + +Felipe Borges <[email protected]> + 3.36.4 - May 25, 2020 ===================== diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/build-aux/flatpak/freerdp-fix-extern-declarations.patch new/gnome-boxes-3.36.5/build-aux/flatpak/freerdp-fix-extern-declarations.patch --- old/gnome-boxes-3.36.4/build-aux/flatpak/freerdp-fix-extern-declarations.patch 1970-01-01 01:00:00.000000000 +0100 +++ new/gnome-boxes-3.36.5/build-aux/flatpak/freerdp-fix-extern-declarations.patch 2020-06-11 11:28:51.000000000 +0200 @@ -0,0 +1,33 @@ +From 9078b0deb9d30890b0320b29626abe2d7f241477 Mon Sep 17 00:00:00 2001 +From: Armin Novak <[email protected]> +Date: Wed, 24 Oct 2018 15:46:18 +0200 +Subject: [PATCH] Fixed extern declaration of rpc_bind p_uuid_t variables. + +--- + libfreerdp/core/gateway/rpc_bind.h | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/libfreerdp/core/gateway/rpc_bind.h b/libfreerdp/core/gateway/rpc_bind.h +index f52e38465..5b37ff512 100644 +--- a/libfreerdp/core/gateway/rpc_bind.h ++++ b/libfreerdp/core/gateway/rpc_bind.h +@@ -25,13 +25,13 @@ + #include <winpr/wtypes.h> + #include <freerdp/api.h> + +-FREERDP_LOCAL const p_uuid_t TSGU_UUID; ++FREERDP_LOCAL extern const p_uuid_t TSGU_UUID; + #define TSGU_SYNTAX_IF_VERSION 0x00030001 + +-FREERDP_LOCAL const p_uuid_t NDR_UUID; ++FREERDP_LOCAL extern const p_uuid_t NDR_UUID; + #define NDR_SYNTAX_IF_VERSION 0x00000002 + +-FREERDP_LOCAL const p_uuid_t BTFN_UUID; ++FREERDP_LOCAL extern const p_uuid_t BTFN_UUID; + #define BTFN_SYNTAX_IF_VERSION 0x00000001 + + FREERDP_LOCAL int rpc_send_bind_pdu(rdpRpc* rpc); +-- +2.27.0.rc2 + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/build-aux/flatpak/genisoimage-extern.patch new/gnome-boxes-3.36.5/build-aux/flatpak/genisoimage-extern.patch --- old/gnome-boxes-3.36.4/build-aux/flatpak/genisoimage-extern.patch 1970-01-01 01:00:00.000000000 +0100 +++ new/gnome-boxes-3.36.5/build-aux/flatpak/genisoimage-extern.patch 2020-06-11 11:28:51.000000000 +0200 @@ -0,0 +1,25 @@ +From 54d94c684d87152e98ebbf589b3dfc4e2b852034 Mon Sep 17 00:00:00 2001 +From: Felipe Borges <[email protected]> +Date: Wed, 3 Jun 2020 16:31:31 +0200 +Subject: [PATCH] WIP + +--- + genisoimage/genisoimage.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h +index bbedfb0..6f0f7d1 100644 +--- a/genisoimage/genisoimage.h ++++ b/genisoimage/genisoimage.h +@@ -376,7 +376,7 @@ extern int use_fileversion; + extern int split_SL_component; + extern int split_SL_field; + extern char *trans_tbl; +-char *outfile; ++extern char *outfile; + + #define JMAX 64 /* maximum Joliet file name length (spec) */ + #define JLONGMAX 103 /* out of spec Joliet file name length */ +-- +2.26.2 + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/build-aux/flatpak/libtirpc-1.2.5-avoid-multiple-definition.patch new/gnome-boxes-3.36.5/build-aux/flatpak/libtirpc-1.2.5-avoid-multiple-definition.patch --- old/gnome-boxes-3.36.4/build-aux/flatpak/libtirpc-1.2.5-avoid-multiple-definition.patch 1970-01-01 01:00:00.000000000 +0100 +++ new/gnome-boxes-3.36.5/build-aux/flatpak/libtirpc-1.2.5-avoid-multiple-definition.patch 2020-06-11 11:28:51.000000000 +0200 @@ -0,0 +1,44 @@ +From 69682de06816de9b9014441d23bda1918ee2e2fb Mon Sep 17 00:00:00 2001 +From: Mike Gilbert <[email protected]> +Date: Sun, 19 Jan 2020 16:57:45 -0500 +Subject: [PATCH] Avoid multiple-definiton with gcc -fno-common + +GCC 10 enables -fno-common by default. + +Bug: https://bugs.gentoo.org/705896 +--- + src/rpc_com.h | 3 +-- + src/svc.c | 3 +++ + 2 files changed, 4 insertions(+), 2 deletions(-) + +diff --git a/src/rpc_com.h b/src/rpc_com.h +index 10bec79..76badef 100644 +--- a/src/rpc_com.h ++++ b/src/rpc_com.h +@@ -61,8 +61,7 @@ void __xprt_unregister_unlocked(SVCXPRT *); + void __xprt_set_raddr(SVCXPRT *, const struct sockaddr_storage *); + + +-SVCXPRT **__svc_xports; +-int __svc_maxrec; ++extern int __svc_maxrec; + + #ifdef __cplusplus + } +diff --git a/src/svc.c b/src/svc.c +index b59467b..6db164b 100644 +--- a/src/svc.c ++++ b/src/svc.c +@@ -57,6 +57,9 @@ + + #define max(a, b) (a > b ? a : b) + ++static SVCXPRT **__svc_xports; ++int __svc_maxrec; ++ + /* + * The services list + * Each entry represents a set of procedures (an rpc program). +-- +2.25.0 + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/build-aux/flatpak/org.gnome.Boxes.json new/gnome-boxes-3.36.5/build-aux/flatpak/org.gnome.Boxes.json --- old/gnome-boxes-3.36.4/build-aux/flatpak/org.gnome.Boxes.json 2020-05-25 16:19:51.301112700 +0200 +++ new/gnome-boxes-3.36.5/build-aux/flatpak/org.gnome.Boxes.json 2020-06-11 11:28:51.000000000 +0200 @@ -120,8 +120,12 @@ "sources" : [ { "type" : "archive", - "url" : "http://downloads.sourceforge.net/sourceforge/libtirpc/libtirpc-1.1.4.tar.bz2";, - "sha256" : "2ca529f02292e10c158562295a1ffd95d2ce8af97820e3534fe1b0e3aec7561d" + "url" : "http://downloads.sourceforge.net/sourceforge/libtirpc/libtirpc-1.2.5.tar.bz2";, + "sha256" : "f3b6350c7e9c3cd9c58fc7a5e5f8e6be469cc571bb5eb31eb9790b3e675186ca" + }, + { + "type" : "patch", + "path" : "libtirpc-1.2.5-avoid-multiple-definition.patch" } ] }, @@ -260,6 +264,10 @@ "type" : "archive", "url" : "https://www.spice-space.org/download/gtk/spice-gtk-0.37.tar.bz2";, "sha256" : "1f28b706472ad391cda79a93fd7b4c7a03e84b88fc46ddb35dddbe323c923bb7" + }, + { + "type" : "patch", + "path" : "spice-include-math.patch" } ] }, @@ -376,6 +384,10 @@ "type" : "archive", "url" : "http://pub.freerdp.com/releases/freerdp-2.0.0-rc2.tar.gz";, "sha256" : "bf080f71655a4996942436d5aacd5ce4afe57e546d4282fc0dc42fb80bd9da0c" + }, + { + "type" : "patch", + "path" : "freerdp-fix-extern-declarations.patch" } ] }, @@ -387,6 +399,10 @@ "type" : "git", "url" : "https://github.com/Distrotech/cdrkit";, "branch" : "7b4bb72389ea5ea3ecc94545036dcff4728ec38a" + }, + { + "type" : "patch", + "path" : "genisoimage-extern.patch" } ] }, @@ -472,11 +488,6 @@ { "name" : "vte", "buildsystem" : "meson", - "build-options" : { - "env" : { - "CXXFLAGS" : "-fno-exceptions" - } - }, "sources" : [ { "type" : "git", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/build-aux/flatpak/spice-include-math.patch new/gnome-boxes-3.36.5/build-aux/flatpak/spice-include-math.patch --- old/gnome-boxes-3.36.4/build-aux/flatpak/spice-include-math.patch 1970-01-01 01:00:00.000000000 +0100 +++ new/gnome-boxes-3.36.5/build-aux/flatpak/spice-include-math.patch 2020-06-11 11:28:51.000000000 +0200 @@ -0,0 +1,25 @@ +From ba558294d9d0c8f003737134a195d2e059b3e3db Mon Sep 17 00:00:00 2001 +From: Felipe Borges <[email protected]> +Date: Wed, 3 Jun 2020 15:32:01 +0200 +Subject: [PATCH] WIP + +--- + meson.build | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/meson.build b/meson.build +index 405c589..5725b7a 100644 +--- a/meson.build ++++ b/meson.build +@@ -346,6 +346,8 @@ if d.found() + spice_gtk_config_data.set('USE_SMARTCARD', '1') + endif + ++spice_glib_deps += compiler.find_library('m', required: false) ++ + # + # global C defines + # +-- +2.26.2 + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/data/org.gnome.Boxes.appdata.xml.in new/gnome-boxes-3.36.5/data/org.gnome.Boxes.appdata.xml.in --- old/gnome-boxes-3.36.4/data/org.gnome.Boxes.appdata.xml.in 2020-05-25 16:19:51.318112600 +0200 +++ new/gnome-boxes-3.36.5/data/org.gnome.Boxes.appdata.xml.in 2020-06-11 11:28:51.000000000 +0200 @@ -39,9 +39,9 @@ </screenshot> </screenshots> <releases> - <release version="3.36.4" date="2020-05-25"> + <release version="3.36.5" date="2020-06-11"> <description> - <p>Boxes 3.36.4 is the latest stable version of GNOME Boxes, and it + <p>Boxes 3.36.5 is the latest stable version of GNOME Boxes, and it contains all the features and bugfixes introduced since our 3.36 release. </p> <ul> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/data/ui/notification.ui new/gnome-boxes-3.36.5/data/ui/notification.ui --- old/gnome-boxes-3.36.4/data/ui/notification.ui 2020-05-25 16:19:51.320112700 +0200 +++ new/gnome-boxes-3.36.5/data/ui/notification.ui 2020-06-11 11:28:51.000000000 +0200 @@ -21,12 +21,16 @@ <child> <object class="GtkLabel" id="message_label"> <property name="visible">True</property> + <property name="ellipsize">end</property> + <property name="lines">3</property> + <property name="wrap">True</property> </object> </child> <child> <object class="GtkButton" id="ok_button"> <property name="halign">end</property> + <property name="valign">end</property> <child> <object class="GtkLabel" id="ok_button_label"> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/meson.build new/gnome-boxes-3.36.5/meson.build --- old/gnome-boxes-3.36.4/meson.build 2020-05-25 16:19:51.329112800 +0200 +++ new/gnome-boxes-3.36.5/meson.build 2020-06-11 11:28:52.000000000 +0200 @@ -1,8 +1,8 @@ project ('gnome-boxes', ['vala', 'c'], - version: '3.36.4', + version: '3.36.5', license: 'LGPLv2+', - meson_version: '>= 0.50.0', + meson_version: '>= 0.49.2', ) gnome = import ('gnome') diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/meson_options.txt new/gnome-boxes-3.36.5/meson_options.txt --- old/gnome-boxes-3.36.4/meson_options.txt 2020-05-25 16:19:51.329112800 +0200 +++ new/gnome-boxes-3.36.5/meson_options.txt 2020-06-11 11:28:52.000000000 +0200 @@ -29,8 +29,3 @@ ], value: 'default' ) - -option ('uefi', - type: 'boolean', - value: true, - description: 'Use UEFI whenever it is possible') diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/actions-popover.vala new/gnome-boxes-3.36.5/src/actions-popover.vala --- old/gnome-boxes-3.36.4/src/actions-popover.vala 2020-05-25 16:19:51.349112700 +0200 +++ new/gnome-boxes-3.36.5/src/actions-popover.vala 2020-06-11 11:28:52.000000000 +0200 @@ -49,6 +49,9 @@ section.append (_("Send File…"), "box.send_file"); var action = action_group.lookup_action ("send_file") as GLib.SimpleAction; action.set_enabled (machine.display.can_transfer_files); + machine.display.notify["is-guest-agent-connected"].connect (() => { + action.set_enabled (machine.display.can_transfer_files); + }); // Take Screenshot section.append (_("Take Screenshot"), "box.take_screenshot"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/app-window.vala new/gnome-boxes-3.36.5/src/app-window.vala --- old/gnome-boxes-3.36.4/src/app-window.vala 2020-05-25 16:19:51.349112700 +0200 +++ new/gnome-boxes-3.36.5/src/app-window.vala 2020-06-11 11:28:52.000000000 +0200 @@ -402,7 +402,19 @@ fullscreened = !fullscreened; return true; - } else if (event.keyval == Gdk.Key.F1) { + } else if (((direction == Gtk.TextDirection.LTR && // LTR + event.keyval == Gdk.Key.Left) || // ALT + Left -> back + (direction == Gtk.TextDirection.RTL && // RTL + event.keyval == Gdk.Key.Right)) && // ALT + Right -> back + (event.state & default_modifiers) == Gdk.ModifierType.MOD1_MASK) { + topbar.click_back_button (); + return true; + } + + if (ui_state == UIState.DISPLAY) + return false; + + if (event.keyval == Gdk.Key.F1) { App.app.activate_action ("help", null); return true; @@ -412,9 +424,6 @@ return true; } else if (event.keyval == Gdk.Key.q && (event.state & default_modifiers) == Gdk.ModifierType.CONTROL_MASK) { - if (ui_state == UIState.DISPLAY) - return false; - App.app.quit_app (); return true; @@ -444,13 +453,6 @@ foreach_view ((view) => { view.unselect_all (); }); return true; - } else if (((direction == Gtk.TextDirection.LTR && // LTR - event.keyval == Gdk.Key.Left) || // ALT + Left -> back - (direction == Gtk.TextDirection.RTL && // RTL - event.keyval == Gdk.Key.Right)) && // ALT + Right -> back - (event.state & default_modifiers) == Gdk.ModifierType.MOD1_MASK) { - topbar.click_back_button (); - return true; } else if (event.keyval == Gdk.Key.Escape) { // ESC -> cancel topbar.click_cancel_button (); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/assistant/review-page.vala new/gnome-boxes-3.36.5/src/assistant/review-page.vala --- old/gnome-boxes-3.36.4/src/assistant/review-page.vala 2020-05-25 16:19:51.349112700 +0200 +++ new/gnome-boxes-3.36.5/src/assistant/review-page.vala 2020-06-11 11:28:52.000000000 +0200 @@ -14,7 +14,7 @@ private Stack customization_stack; private GLib.List<Boxes.Property> resource_properties; - private Cancellable cancellable = new GLib.Cancellable (); + private Cancellable? cancellable; [GtkCallback] private void on_customize_button_toggled () { @@ -23,7 +23,7 @@ } public async void setup (VMCreator vm_creator) { - resource_properties = new GLib.List<Boxes.Property> (); + cancellable = new GLib.Cancellable (); try { artifact = yield vm_creator.create_vm (cancellable); @@ -73,10 +73,14 @@ } private void populate_customization_grid (LibvirtMachine machine) { + resource_properties = new GLib.List<Boxes.Property> (); machine.properties.get_resources_properties (ref resource_properties); return_if_fail (resource_properties.length () > 0); + foreach (var child in customization_grid.get_children ()) + customization_grid.remove (child); + var current_row = 0; foreach (var property in resource_properties) { if (property.widget == null || property.extra_widget == null) { @@ -97,7 +101,10 @@ } public override void cleanup () { - cancellable.cancel (); + if (cancellable != null) { + cancellable.cancel (); + cancellable = null; + } summary.clear (); nokvm_infobar.hide (); @@ -123,6 +130,7 @@ foreach (var property in resource_properties) { property.flush (); } + resource_properties = null; done (artifact); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/display.vala new/gnome-boxes-3.36.5/src/display.vala --- old/gnome-boxes-3.36.4/src/display.vala 2020-05-25 16:19:51.350112700 +0200 +++ new/gnome-boxes-3.36.5/src/display.vala 2020-06-11 11:28:52.000000000 +0200 @@ -10,6 +10,7 @@ public bool can_grab_mouse { get; protected set; } public bool mouse_grabbed { get; protected set; } public bool keyboard_grabbed { get; protected set; } + public bool is_guest_agent_connected { get; protected set; } public bool need_password { get; protected set; } public bool need_username { get; protected set; } public string? password { get; set; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/downloader.vala new/gnome-boxes-3.36.5/src/downloader.vala --- old/gnome-boxes-3.36.4/src/downloader.vala 2020-05-25 16:19:51.350112700 +0200 +++ new/gnome-boxes-3.36.5/src/downloader.vala 2020-06-11 11:28:52.000000000 +0200 @@ -61,8 +61,9 @@ if (Environment.get_variable ("SOUP_DEBUG") != null) session.add_feature (new Soup.Logger (Soup.LoggerLogLevel.HEADERS, -1)); - var user_agent = get_user_agent (); - session.user_agent = user_agent; + // As some websites redirect based on UA, lets force wget user-agent so the + // website assumes it's a CLI tool downloading the file. + session.user_agent = "Wget/1.0"; } /** diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/icon-view.vala new/gnome-boxes-3.36.5/src/icon-view.vala --- old/gnome-boxes-3.36.4/src/icon-view.vala 2020-05-25 16:19:51.351112600 +0200 +++ new/gnome-boxes-3.36.5/src/icon-view.vala 2020-06-11 11:28:52.000000000 +0200 @@ -211,7 +211,7 @@ var thumbnail = (child.get_child () as IconViewChild).thumbnail; context_popover.update_for_item (item); - context_popover.set_relative_to (thumbnail); + context_popover.set_relative_to (thumbnail.get_parent ()); context_popover.show (); return true; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/installer-media.vala new/gnome-boxes-3.36.5/src/installer-media.vala --- old/gnome-boxes-3.36.4/src/installer-media.vala 2020-05-25 16:19:51.351112600 +0200 +++ new/gnome-boxes-3.36.5/src/installer-media.vala 2020-06-11 11:28:52.000000000 +0200 @@ -55,20 +55,6 @@ } } - public bool supports_efi { - get { - if (os == null) - return false; - - foreach (var iter in os.get_firmware_list (null) .get_elements ()) { - var firmware = iter as Firmware; - if (firmware.get_firmware_type () == "efi") - return true; - } - return false; - } - } - public virtual bool prefers_q35 { get { if (os == null) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/meson.build new/gnome-boxes-3.36.5/src/meson.build --- old/gnome-boxes-3.36.4/src/meson.build 2020-05-25 16:19:51.352112800 +0200 +++ new/gnome-boxes-3.36.5/src/meson.build 2020-06-11 11:28:52.000000000 +0200 @@ -194,9 +194,6 @@ dependencies += libovf.get_variable('govf_vapi') endif -if get_option('uefi') - vala_args += '--define=USE_UEFI' -endif executable ('gnome-boxes', vala_sources + resources, include_directories: config_h_dir, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/spice-display.vala new/gnome-boxes-3.36.5/src/spice-display.vala --- old/gnome-boxes-3.36.4/src/spice-display.vala 2020-05-25 16:19:51.353112700 +0200 +++ new/gnome-boxes-3.36.5/src/spice-display.vala 2020-06-11 11:28:52.000000000 +0200 @@ -84,11 +84,16 @@ can_grab_mouse = main_channel.mouse_mode != 2; new_file_transfer_id = main_channel.new_file_transfer.connect (on_new_file_transfer); + + agent_connected_id = main_channel.notify["agent-connected"].connect (() => { + is_guest_agent_connected = main_channel.agent_connected; + }); } } ulong main_event_id; ulong main_mouse_mode_id; ulong new_file_transfer_id; + ulong agent_connected_id; private void main_cleanup () { if (main_channel == null) @@ -101,6 +106,8 @@ main_mouse_mode_id = 0; o.disconnect (new_file_transfer_id); new_file_transfer_id = 0; + o.disconnect (agent_connected_id); + agent_connected_id = 0; main_channel = null; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/vm-configurator.vala new/gnome-boxes-3.36.5/src/vm-configurator.vala --- old/gnome-boxes-3.36.4/src/vm-configurator.vala 2020-05-25 16:19:51.354112600 +0200 +++ new/gnome-boxes-3.36.5/src/vm-configurator.vala 2020-06-11 11:28:52.000000000 +0200 @@ -38,7 +38,7 @@ private const string LIBOSINFO_XML = "<libosinfo>%s</libosinfo>"; private const string LIBOSINFO_OS_ID_XML = "<os id=\"%s\"/>"; - public static Domain create_domain_config (InstallerMedia install_media, string target_path, Capabilities caps, DomainCapabilities domain_caps) + public static Domain create_domain_config (InstallerMedia install_media, string target_path, Capabilities caps) throws VMConfiguratorError { var domain = new Domain (); @@ -51,7 +51,7 @@ var virt_type = guest_kvm_enabled (best_caps) ? DomainVirtType.KVM : DomainVirtType.QEMU; domain.set_virt_type (virt_type); - set_os_config (domain, install_media, best_caps, domain_caps); + set_os_config (domain, install_media, best_caps); string[] features = {}; if (guest_supports_feature (best_caps, "acpi")) @@ -375,45 +375,17 @@ os.set_arch (old_os.get_arch ()); os.set_machine (old_os.get_machine ()); -#if USE_UEFI - if (old_os.get_firmware () == GVirConfig.DomainOsFirmware.EFI) - os.set_firmware (GVirConfig.DomainOsFirmware.EFI); -#endif domain.set_os (os); } - private static bool domain_caps_supports_efi (DomainCapabilities domain_caps) { - foreach (var firmware in domain_caps.get_os ().get_firmwares()) { - if (firmware == GVirConfig.DomainOsFirmware.EFI) - return true; - } - - return false; - } - - private static bool supports_efi (InstallerMedia install_media, DomainCapabilities domain_caps) { - if (install_media == null || !install_media.supports_efi) - return false; - - if (domain_caps == null || !domain_caps_supports_efi (domain_caps)) - return false; - - return true; - } - - private static void set_os_config (Domain domain, InstallerMedia install_media, CapabilitiesGuest guest_caps, DomainCapabilities domain_caps) { + private static void set_os_config (Domain domain, InstallerMedia install_media, CapabilitiesGuest guest_caps) { var os = new DomainOs (); os.set_os_type (DomainOsType.HVM); os.set_arch (guest_caps.get_arch ().get_name ()); if (install_media.prefers_q35) os.set_machine ("q35"); -#if USE_UEFI - if (supports_efi (install_media, domain_caps)) - os.set_firmware (GVirConfig.DomainOsFirmware.EFI); -#endif - var boot_devices = new GLib.List<DomainOsBootDevice> (); install_media.set_direct_boot_params (os); boot_devices.append (DomainOsBootDevice.CDROM); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.36.4/src/vm-creator.vala new/gnome-boxes-3.36.5/src/vm-creator.vala --- old/gnome-boxes-3.36.4/src/vm-creator.vala 2020-05-25 16:19:51.354112600 +0200 +++ new/gnome-boxes-3.36.5/src/vm-creator.vala 2020-06-11 11:28:52.000000000 +0200 @@ -192,8 +192,7 @@ StorageVol volume, Cancellable? cancellable) throws GLib.Error { var caps = yield connection.get_capabilities_async (cancellable); - var domcaps = yield connection.get_domain_capabilities_async (null, null, null, null, 0, cancellable); - var config = VMConfigurator.create_domain_config (install_media, volume.get_path (), caps, domcaps); + var config = VMConfigurator.create_domain_config (install_media, volume.get_path (), caps); config.name = name; config.title = title;
