Hello community, here is the log from the commit of package wxEDID for openSUSE:Factory checked in at 2020-07-16 12:16:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/wxEDID (Old) and /work/SRC/openSUSE:Factory/.wxEDID.new.3592 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "wxEDID" Thu Jul 16 12:16:07 2020 rev:6 rq:820976 version:0.0.21 Changes: -------- --- /work/SRC/openSUSE:Factory/wxEDID/wxEDID.changes 2020-06-05 20:29:03.149320176 +0200 +++ /work/SRC/openSUSE:Factory/.wxEDID.new.3592/wxEDID.changes 2020-07-16 12:17:18.074894862 +0200 @@ -1,0 +2,20 @@ +Tue Jul 14 20:11:09 UTC 2020 - Mia Herkt <[email protected]> + +- Update to v0.0.21 +Fixed + * (BUG): BlockTree: root node was not showing EDID file name if + the file path was provided as an cmd line argument + (both binary and --text). + * (BUG) cea_hdrs_cl::init(): Incorrect min size for + "HDR Static Metadata Data Block" (TagCode=7, ExtTagCode=6): + the min. block size is 3, not 6 bytes. Fields for bytes 4..6 + are marked as unused, depending on the block size. + * (BUG) cea_hdrs_cl: incorrect bitfield definitions for reserved + fields: "ET6-7" & "SM1-7" + * Wrong evt ID for importing HEX-text EDID from cmd line arg: + should be id_mnu_imphex, not id_mnu_exphex. + * (Regression) if config file doen't exist, the + config.b_dtd_keep_aspect is set to OFF, but by default it + should be set to ON. + +------------------------------------------------------------------- Old: ---- wxedid-0.0.20.tar.gz New: ---- wxedid-0.0.21.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ wxEDID.spec ++++++ --- /var/tmp/diff_new_pack.z0pqsa/_old 2020-07-16 12:17:19.346896148 +0200 +++ /var/tmp/diff_new_pack.z0pqsa/_new 2020-07-16 12:17:19.346896148 +0200 @@ -17,7 +17,7 @@ Name: wxEDID -Version: 0.0.20 +Version: 0.0.21 Release: 0 Summary: Extended Display Identification Data editor License: GPL-3.0-only ++++++ wxedid-0.0.20.tar.gz -> wxedid-0.0.21.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/ChangeLog new/wxedid-0.0.21/ChangeLog --- old/wxedid-0.0.20/ChangeLog 2020-06-04 16:31:49.000000000 +0200 +++ new/wxedid-0.0.21/ChangeLog 2020-07-12 09:45:56.000000000 +0200 @@ -24,7 +24,26 @@ ____ +2020.07.12 + < released v0.0.21 > + +2020.07.10 + - Fixed: (BUG): BlockTree: root node was not showing EDID file name if the file path was provided + as an cmd line argument (both binary and --text). + +2020.06.12 + - Fixed: (BUG) cea_hdrs_cl::init(): Incorrect min size for "HDR Static Metadata Data Block" + (TagCode=7, ExtTagCode=6): the min. block size is 3, not 6 bytes. + Fields for bytes 4..6 are marked as unused, depending on the block size. + - Fixed: (BUG) cea_hdrs_cl: incorrect bitfield definitions for reserved fields: "ET6-7" & "SM1-7" + - Fixed: Wrong evt ID for importing HEX-text EDID from cmd line arg: should be id_mnu_imphex, not id_mnu_exphex. + +2020.06.05 + - Fixed: (Regression) if config file doen't exist, the config.b_dtd_keep_aspect is set to OFF, + but by default it should be set to ON. + 2020.06.04 + < released v0.0.20 > - Added: Loading/Importing EDID files from path passed as cmd line argument. - Added: Save settings: last used directory + last opened file, dtd_keep_aspect_ratio diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/INSTALL new/wxedid-0.0.21/INSTALL --- old/wxedid-0.0.20/INSTALL 2020-01-02 22:29:58.000000000 +0100 +++ new/wxedid-0.0.21/INSTALL 2020-07-12 09:49:47.000000000 +0200 @@ -8,10 +8,10 @@ To compile the program, the libwxgtkX.X-dev package is required. (where X.X is the wxWidgets version) -The libwxgtkX.X-dev package has quite a lot of additional dependancies, +The libwxgtkX.X-dev package has quite a lot of additional dependencies, which are normally installed automatically with the libwxgtk_xx -After compilation the libwxgtkX.X-dev and relatad packages can be safely removed. +After compilation the libwxgtkX.X-dev and related packages can be safely removed. *************** * Compilation * @@ -29,7 +29,7 @@ NOTE: Since rcode v1.x the program sources have to be preprocessed using rcd_autogen script. -The rcd_autogen requires bash v4.4+, what shouldn't be a problem *unless* You're +The rcd_autogen requires bash v4.4+, what should't be a problem *unless* You're using some very old distribution. In such situation, it's still possible to compile the program: > configure the source tree using distro with bash v4.4+ (f.e. in a VM) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/README new/wxedid-0.0.21/README --- old/wxedid-0.0.20/README 2020-06-04 16:45:00.000000000 +0200 +++ new/wxedid-0.0.21/README 2020-07-12 09:50:38.000000000 +0200 @@ -21,7 +21,7 @@ depending on selected type. The constructors could be invoked from contextual menus, by right-clicking on particular block in the block tree structure. - + 2. SVD: Short Video Descriptor: The data layout for this block depends on: a) CEA-861 header revision @@ -35,12 +35,12 @@ (what gives the effective range of 1-65536 for 0x0-0xFFFF), but the Std says that thanks to (pix_count-1) formula the maximum is 65535x65535, which is not true. wxEDID will use range of 1-65536. - + 4. CEA-DBC: Extended Tag Code=3: VESA Video Timing Block Extension (VTB-EXT): CTA-861-F/G references VTB-EXT Standard, Release A, November 24, 2003. The VTB-EXT extension block is defined as a 128 byte structure, what exceeds the range allowed by the DBC Extended Tag header (30 bytes). - None of the documents is adressing this issue. + None of the documents is addressing this issue. wxEDID will report error for Extended Tag Code=3. 5. Discrepancy in block length handling: @@ -59,7 +59,7 @@ wxEDID uses speaker names from the "G" revision - differences are mostly harmless. NOTE: -In wxEDID v0.0.20 the data structurtes defined for CTA-861-G are *NOT* fully tested - simply, +In wxEDID v0.0.21 the data structures defined for CTA-861-G are *NOT* fully tested - simply, I don't have a hardware which fully utilizes the "G" specification, so I can't make tests with 100% coverage. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/cb_project/wxEDID.cbp new/wxedid-0.0.21/cb_project/wxEDID.cbp --- old/wxedid-0.0.20/cb_project/wxEDID.cbp 2020-06-04 16:33:56.000000000 +0200 +++ new/wxedid-0.0.21/cb_project/wxEDID.cbp 2020-07-12 09:50:47.000000000 +0200 @@ -73,6 +73,12 @@ <Add option="`wx-config --libs std,aui`" /> </Linker> <Unit filename="../ChangeLog" /> + <Unit filename="../INSTALL"> + <Option target="<{~None~}>" /> + </Unit> + <Unit filename="../README"> + <Option target="<{~None~}>" /> + </Unit> <Unit filename="../src/CEA.h" /> <Unit filename="../src/CEA_EXT.h" /> <Unit filename="../src/CEA_EXT_class.cpp" /> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/configure new/wxedid-0.0.21/configure --- old/wxedid-0.0.20/configure 2020-06-04 16:34:35.000000000 +0200 +++ new/wxedid-0.0.21/configure 2020-07-12 09:37:43.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for wxEDID 0.0.20. +# Generated by GNU Autoconf 2.69 for wxEDID 0.0.21. # # Report bugs to <[email protected]>. # @@ -581,8 +581,8 @@ # Identity of this package. PACKAGE_NAME='wxEDID' PACKAGE_TARNAME='wxedid' -PACKAGE_VERSION='0.0.20' -PACKAGE_STRING='wxEDID 0.0.20' +PACKAGE_VERSION='0.0.21' +PACKAGE_STRING='wxEDID 0.0.21' PACKAGE_BUGREPORT='[email protected]' PACKAGE_URL='' @@ -1245,7 +1245,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures wxEDID 0.0.20 to adapt to many kinds of systems. +\`configure' configures wxEDID 0.0.21 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1312,7 +1312,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of wxEDID 0.0.20:";; + short | recursive ) echo "Configuration of wxEDID 0.0.21:";; esac cat <<\_ACEOF @@ -1408,7 +1408,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -wxEDID configure 0.0.20 +wxEDID configure 0.0.21 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1465,7 +1465,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by wxEDID $as_me 0.0.20, which was +It was created by wxEDID $as_me 0.0.21, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2333,7 +2333,7 @@ # Define the identity of the package. PACKAGE='wxedid' - VERSION='0.0.20' + VERSION='0.0.21' cat >>confdefs.h <<_ACEOF @@ -4192,7 +4192,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by wxEDID $as_me 0.0.20, which was +This file was extended by wxEDID $as_me 0.0.21, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -4254,7 +4254,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -wxEDID config.status 0.0.20 +wxEDID config.status 0.0.21 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/configure.ac new/wxedid-0.0.21/configure.ac --- old/wxedid-0.0.20/configure.ac 2020-06-03 12:03:46.000000000 +0200 +++ new/wxedid-0.0.21/configure.ac 2020-07-12 09:36:55.000000000 +0200 @@ -4,7 +4,7 @@ dnl wxEDID - Extended Display Identification Data editor AC_PREREQ([2.65]) -AC_INIT([wxEDID], [0.0.20], [[email protected]]) +AC_INIT([wxEDID], [0.0.21], [[email protected]]) AC_COPYRIGHT([Copyright (C) 2014-2020 Tomasz Pawlak, e-mail: [email protected]]) AC_CONFIG_SRCDIR([src/wxEDID_Main.cpp]) AC_CONFIG_HEADERS([src/config.h]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/src/CEA_EXT_class.cpp new/wxedid-0.0.21/src/CEA_EXT_class.cpp --- old/wxedid-0.0.20/src/CEA_EXT_class.cpp 2020-06-03 11:35:17.000000000 +0200 +++ new/wxedid-0.0.21/src/CEA_EXT_class.cpp 2020-07-11 04:01:25.000000000 +0200 @@ -759,12 +759,12 @@ "reserved (0)" }, {&EDID_cl::BitVal, NULL, offsetof(hdrs_t, hdrs2), 5, 1, EF_BIT|EF_RD, 0, 1, "ET_5", "reserved (0)" }, - {&EDID_cl::BitVal, NULL, offsetof(hdrs_t, hdrs2), 5, 1, EF_BIT|EF_RD, 0, 1, "resvd67", + {&EDID_cl::BitVal, NULL, offsetof(hdrs_t, hdrs2), 6, 2, EF_BIT|EF_RD, 0, 1, "ET6-7", "reserved (0)" }, //byte3 {&EDID_cl::BitVal, NULL, offsetof(hdrs_t, hdrs3), 0, 1, EF_BIT|EF_RD, 0, 1, "SM_0", "Static Metadata Type 1" }, - {&EDID_cl::BitF8Val, NULL, offsetof(hdrs_t, hdrs3), 0, 1, EF_BFLD|EF_INT|EF_RD, 0, 1, "SM1-7", + {&EDID_cl::BitF8Val, NULL, offsetof(hdrs_t, hdrs3), 1, 7, EF_BFLD|EF_INT|EF_RD, 0, 1, "SM1-7", "reserved (0)" }, //byte4,5,6 {&EDID_cl::ByteVal, NULL, offsetof(hdrs_t, max_lum), 0, 1, EF_BYTE|EF_INT|EF_RD, 0, 0xFF, "max_lum", @@ -778,15 +778,30 @@ rcode cea_hdrs_cl::init(u8_t* inst, u32_t orflags) { rcode retU; u32_t dlen; + u32_t fld_offs; if (inst == NULL) RCD_RETURN_FAULT(retU); dlen = reinterpret_cast <ethdr_t*> (inst)->ehdr.hdr.tag.blk_len; - if (dlen < 6) wxedid_RCD_RETURN_FAULT_VMSG(retU, "[E] %s: bad block length", "HDRS"); + if ((dlen < 3) || (dlen > 6)) wxedid_RCD_RETURN_FAULT_VMSG(retU, "[E] %s: bad block length", "HDRS"); type_id = ID_HDRS; + retU = init_fields(&fields[0], inst, fcount, orflags, Name, Desc); + if (! RCD_IS_OK(retU)) return retU; + + //Mark unused fields: + fld_offs = fcount; + fld_offs -= (6 - dlen); //for dlen==3 -> max_lum @ offs 12 + + for (int fld=dlen; fld<6; ++fld) { + edi_field_t *p_fld; + p_fld = reinterpret_cast <edi_field_t*> ( FieldsA.Item(fld_offs) ); + p_fld->flags |= EF_NU; + fld_offs ++ ; + } + return retU; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/src/Makefile new/wxedid-0.0.21/src/Makefile --- old/wxedid-0.0.20/src/Makefile 2020-06-04 17:28:03.000000000 +0200 +++ new/wxedid-0.0.21/src/Makefile 2020-07-12 09:38:01.000000000 +0200 @@ -208,15 +208,15 @@ PACKAGE = wxedid PACKAGE_BUGREPORT = [email protected] PACKAGE_NAME = wxEDID -PACKAGE_STRING = wxEDID 0.0.20 +PACKAGE_STRING = wxEDID 0.0.21 PACKAGE_TARNAME = wxedid PACKAGE_URL = -PACKAGE_VERSION = 0.0.20 +PACKAGE_VERSION = 0.0.21 PATH_SEPARATOR = : SET_MAKE = SHELL = /bin/bash STRIP = -VERSION = 0.0.20 +VERSION = 0.0.21 WX_CFLAGS = -I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -pthread WX_CFLAGS_ONLY = -pthread WX_CONFIG_PATH = /usr/bin/wx-config diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/src/config.h new/wxedid-0.0.21/src/config.h --- old/wxedid-0.0.20/src/config.h 2020-06-03 12:06:14.000000000 +0200 +++ new/wxedid-0.0.21/src/config.h 2020-07-12 09:38:01.000000000 +0200 @@ -11,7 +11,7 @@ #define PACKAGE_NAME "wxEDID" /* Define to the full name and version of this package. */ -#define PACKAGE_STRING "wxEDID 0.0.20" +#define PACKAGE_STRING "wxEDID 0.0.21" /* Define to the one symbol short name of this package. */ #define PACKAGE_TARNAME "wxedid" @@ -20,7 +20,7 @@ #define PACKAGE_URL "" /* Define to the version of this package. */ -#define PACKAGE_VERSION "0.0.20" +#define PACKAGE_VERSION "0.0.21" /* Version number of package */ -#define VERSION "0.0.20" +#define VERSION "0.0.21" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/src/stamp-h1 new/wxedid-0.0.21/src/stamp-h1 --- old/wxedid-0.0.20/src/stamp-h1 2020-06-04 17:28:03.000000000 +0200 +++ new/wxedid-0.0.21/src/stamp-h1 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -timestamp for src/config.h diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/src/wxEDID_App.cpp new/wxedid-0.0.21/src/wxEDID_App.cpp --- old/wxedid-0.0.20/src/wxEDID_App.cpp 2020-06-04 16:26:11.000000000 +0200 +++ new/wxedid-0.0.21/src/wxEDID_App.cpp 2020-07-10 04:07:09.000000000 +0200 @@ -80,7 +80,11 @@ cfg_fname.SetName( _(".wxEDID_cfg") ); cfg_str = cfg_fname.GetFullPath(); - if (! wxFileExists(cfg_str)) return; + if (! wxFileExists(cfg_str)) { + config.b_have_last_fpath = false; + config.b_dtd_keep_aspect = true; //default + return; + } { wxFile cfg_file; @@ -104,7 +108,7 @@ token = tokenz.GetNextToken(); tkidx ++ ; if (0 == (tkidx & 1)) continue; - //tokens @ odd idx holds the values + //tokens @ odd idx hold the values switch (tkidx) { case 1: //dtd aspect ratio mode { @@ -116,7 +120,7 @@ } case 3: //last path { - bool dexist; + bool dexist; wxFileName last_dir(token); cfg_str = last_dir.GetPath(); @@ -151,7 +155,7 @@ argstr = wxApp::argv[2]; fexist = wxFileExists(argstr); - if (!fexist) { + if (! fexist) { ERR_PRINT("[E!] Can't open file: \'%s\'\n", static_cast<const char*> (argstr.c_str()) ); return false; } @@ -166,7 +170,7 @@ else if (wxApp::argc == 2) { argstr = wxApp::argv[1]; fexist = wxFileExists(argstr); - if (!fexist) { + if (! fexist) { ERR_PRINT("[E!] Can't open file: \'%s\'\n", static_cast<const char*> (argstr.c_str()) ); return false; } @@ -174,14 +178,17 @@ config.b_cmdln_bin_file = true; } - //normalize file path - if (! wxIsAbsolutePath(config.cmd_open_file_path) ) { - + { wxFileName fname(config.cmd_open_file_path); - fname.Normalize(wxPATH_NORM_ALL, wxGetCwd()); - config.cmd_open_file_path = fname.GetFullPath(); - DBG0_PRINT("[i] Absolute path \'%s\'\n", static_cast<const char*> (config.cmd_open_file_path.c_str()) ); + if (! wxIsAbsolutePath(config.cmd_open_file_path) ) { //normalize file path + + fname.Normalize(wxPATH_NORM_ALL, wxGetCwd()); + DBG0_PRINT("[i] Absolute path \'%s\'\n", static_cast<const char*> (config.cmd_open_file_path.c_str()) ); + } + + config.cmd_open_file_path = fname.GetFullPath(); + config.last_used_fname = fname.GetFullName(); } return true; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/src/wxEDID_Main.cpp new/wxedid-0.0.21/src/wxEDID_Main.cpp --- old/wxedid-0.0.20/src/wxEDID_Main.cpp 2020-06-04 17:25:23.000000000 +0200 +++ new/wxedid-0.0.21/src/wxEDID_Main.cpp 2020-07-10 03:49:42.000000000 +0200 @@ -616,7 +616,7 @@ return; } if (config.b_cmdln_txt_file) { - wxCommandEvent evt(wxEVT_DEFERRED, id_mnu_exphex); + wxCommandEvent evt(wxEVT_DEFERRED, id_mnu_imphex); AddPendingEvent(evt); } } @@ -1169,7 +1169,7 @@ evt_open_edid_bin(evt); } - if (evt.GetId() == id_mnu_exphex) { + if (evt.GetId() == id_mnu_imphex) { evt_import_hex(evt); } } @@ -1199,7 +1199,8 @@ } else { //open EDID binary file provided as cmd line arg - tmps = config.cmd_open_file_path; + edid_file_name = config.last_used_fname; + tmps = config.cmd_open_file_path; config.b_cmdln_bin_file = false; //single shot } @@ -1560,7 +1561,8 @@ } else { //open EDID text file provided as cmd line arg - tmps = config.cmd_open_file_path; + edid_file_name = config.last_used_fname; + tmps = config.cmd_open_file_path; config.b_cmdln_txt_file = false; //single shot } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/wxedid-0.0.20/src/wxEDID_Main.h new/wxedid-0.0.21/src/wxEDID_Main.h --- old/wxedid-0.0.20/src/wxEDID_Main.h 2020-06-04 11:33:39.000000000 +0200 +++ new/wxedid-0.0.21/src/wxEDID_Main.h 2020-07-10 03:45:37.000000000 +0200 @@ -43,6 +43,7 @@ bool b_cmdln_txt_file; wxString cmd_open_file_path; wxString last_used_fpath; + wxString last_used_fname; } config_t;
