Hello community,

here is the log from the commit of package yast2-users for openSUSE:Factory 
checked in at 2020-08-06 10:38:42
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-users (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-users.new.3399 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-users"

Thu Aug  6 10:38:42 2020 rev:235 rq:824208 version:4.3.6

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-users/yast2-users.changes  2020-07-30 
10:00:19.291229134 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-users.new.3399/yast2-users.changes        
2020-08-06 10:38:45.946019234 +0200
@@ -1,0 +2,6 @@
+Mon Aug  3 12:42:59 UTC 2020 - Martin Vidner <[email protected]>
+
+- Remove ag_uid to save memory at installation time (bsc#1172139).
+- 4.3.6
+
+-------------------------------------------------------------------

Old:
----
  yast2-users-4.3.5.tar.bz2

New:
----
  yast2-users-4.3.6.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-users.spec ++++++
--- /var/tmp/diff_new_pack.84gYK5/_old  2020-08-06 10:38:46.546019534 +0200
+++ /var/tmp/diff_new_pack.84gYK5/_new  2020-08-06 10:38:46.546019534 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-users
-Version:        4.3.5
+Version:        4.3.6
 Release:        0
 Summary:        YaST2 - User and Group Configuration
 License:        GPL-2.0-only

++++++ yast2-users-4.3.5.tar.bz2 -> yast2-users-4.3.6.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.3.5/package/yast2-users.changes 
new/yast2-users-4.3.6/package/yast2-users.changes
--- old/yast2-users-4.3.5/package/yast2-users.changes   2020-07-28 
17:02:15.000000000 +0200
+++ new/yast2-users-4.3.6/package/yast2-users.changes   2020-08-03 
20:36:46.000000000 +0200
@@ -1,4 +1,10 @@
 -------------------------------------------------------------------
+Mon Aug  3 12:42:59 UTC 2020 - Martin Vidner <[email protected]>
+
+- Remove ag_uid to save memory at installation time (bsc#1172139).
+- 4.3.6
+
+-------------------------------------------------------------------
 Fri Jul 24 14:00:40 UTC 2020 - David Diaz <[email protected]>
 
 - Load the right nsswitch.conf from either, /usr/etc or /etc
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.3.5/package/yast2-users.spec 
new/yast2-users-4.3.6/package/yast2-users.spec
--- old/yast2-users-4.3.5/package/yast2-users.spec      2020-07-28 
17:02:15.000000000 +0200
+++ new/yast2-users-4.3.6/package/yast2-users.spec      2020-08-03 
20:36:46.000000000 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-users
-Version:        4.3.5
+Version:        4.3.6
 Release:        0
 Summary:        YaST2 - User and Group Configuration
 License:        GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.3.5/src/Makefile.am 
new/yast2-users-4.3.6/src/Makefile.am
--- old/yast2-users-4.3.5/src/Makefile.am       2020-07-28 17:02:15.000000000 
+0200
+++ new/yast2-users-4.3.6/src/Makefile.am       2020-08-03 20:36:46.000000000 
+0200
@@ -79,13 +79,11 @@
   lib/users/widgets.rb
 
 scrconf_DATA = \
-  scrconf/uid.scr \
   scrconf/etc_default_useradd.scr \
   scrconf/nis.scr
 
 agent_SCRIPTS = \
-  servers_non_y2/ag_nis \
-  servers_non_y2/ag_uid
+  servers_non_y2/ag_nis
 
 schemafilesdir = $(schemadir)/autoyast/rnc
 schemafiles_DATA = \
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.3.5/src/modules/UsersCache.pm 
new/yast2-users-4.3.6/src/modules/UsersCache.pm
--- old/yast2-users-4.3.5/src/modules/UsersCache.pm     2020-07-28 
17:02:15.000000000 +0200
+++ new/yast2-users-4.3.6/src/modules/UsersCache.pm     2020-08-03 
20:36:46.000000000 +0200
@@ -29,6 +29,7 @@
 
 use YaST::YCP qw(:LOGGING);
 use YaPI;
+use User::pwent;
 
 textdomain ("users");
 
@@ -232,9 +233,15 @@
 
 ##------------------------------------
 sub UIDConflicts {
+    my $id = $_[0];
 
-    my $ret = SCR->Read (".uid.uid", $_[0]);
-    return !$ret;
+    my $pw = getpwuid($id);
+    if (defined $pw) {
+        my $name = $pw->name;
+        y2debug ("$id is UID of user $name");
+        return 1;
+    }
+    return 0;
 }
  
 ##------------------------------------
@@ -273,9 +280,15 @@
 }
 
 sub UsernameConflicts {
+    my $username = $_[0];
 
-    my $ret = SCR->Read (".uid.username", $_[0]);
-    return !$ret;
+    my $pw = getpwnam($username);
+    if (defined $pw) {
+        my $uid = $pw->uid;
+        y2debug ("$username is used with uid $uid");
+        return 1;
+    }
+    return 0;
 }
 
 ##------------------------------------
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.3.5/src/scrconf/uid.scr 
new/yast2-users-4.3.6/src/scrconf/uid.scr
--- old/yast2-users-4.3.5/src/scrconf/uid.scr   2020-07-28 17:02:15.000000000 
+0200
+++ new/yast2-users-4.3.6/src/scrconf/uid.scr   1970-01-01 01:00:00.000000000 
+0100
@@ -1,14 +0,0 @@
-/**
- * File:       uid.scr
- * Summary:    Agent for testing if UID and/or username exists in system
- * Access:     read
- * Authors:    Jiri Suchomel <[email protected]>
- * Example:
- *     Read (.uid.username, "root");
- *     (true)
- *
- * $Id$
- */
-.uid
-
-`ag_uid ()
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.3.5/src/servers_non_y2/ag_uid 
new/yast2-users-4.3.6/src/servers_non_y2/ag_uid
--- old/yast2-users-4.3.5/src/servers_non_y2/ag_uid     2020-07-28 
17:02:15.000000000 +0200
+++ new/yast2-users-4.3.6/src/servers_non_y2/ag_uid     1970-01-01 
01:00:00.000000000 +0100
@@ -1,63 +0,0 @@
-#!/usr/bin/perl
-
-use lib "/usr/lib/YaST2/agents_non_y2";
-use ycp;
-use strict;
-use User::pwent;
-
-while ( <STDIN> )
-{
-    my ($command, $path, $argument) = ycp::ParseCommand ($_);
-
-    #----------------------------------------------------------
-    #  Expected calls:
-    #  Read(.uid.uid, id)
-    #  -> returns true if no user has "id" as UID 
-    #  Read(.uid.username, name) 
-    #  -> returns true if there is no user with "name" as username
-    #----------------------------------------------------------
-
-    if ( $command eq "Read" )
-    {
-       if ( $path eq '.uid' ) {
-           my $id = $argument;
-           my $pw = getpwuid($id);
-           my $result = "true";
-
-           if (defined $pw) {
-               my $name = $pw->name;
-               y2debug ("$id is UID of user $name");
-               $result = "false";
-           }
-           ycp::Return($result);
-       }
-       elsif ( $path eq '.username' ) {
-           my $username = $argument;
-           my $pw = getpwnam($username);
-           my $result = "true";
-          
-           if (defined $pw) {
-               my $uid = $pw->uid;
-               y2debug ("used with uid", $uid);
-               $result = "false";
-           }
-           ycp::Return($result);
-       }
-       else {
-           y2error ("wrong path ($path) or argument: ", ref ($argument));
-           ycp::Return("wrong path or argument");
-       }
-       #TODO: check gid/groupname?
-    }
-    elsif ($command eq "result")
-    {
-       exit;
-    }
-    else
-    {
-       y2error ("wrong command ($command), only Read is accepted");
-       ycp::Return("wrong command, only Read is accepted");
-    }
-}
-
-# end


Reply via email to