Hello community, here is the log from the commit of package xfwm4 for openSUSE:Factory checked in at 2020-08-12 10:29:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/xfwm4 (Old) and /work/SRC/openSUSE:Factory/.xfwm4.new.3399 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "xfwm4" Wed Aug 12 10:29:27 2020 rev:63 rq:825414 version:4.14.5 Changes: -------- --- /work/SRC/openSUSE:Factory/xfwm4/xfwm4.changes 2020-08-05 20:29:56.379115543 +0200 +++ /work/SRC/openSUSE:Factory/.xfwm4.new.3399/xfwm4.changes 2020-08-12 10:32:53.888168948 +0200 @@ -1,0 +2,7 @@ +Sun Aug 9 19:08:11 UTC 2020 - Marcel Kuehlhorn <tu...@opensuse.org> + +- Update to version 4.14.5 + * Fix an error leak in compositor (gxo#xfce/xfwm4#351) + * Fix compositor selection atom misuse + +------------------------------------------------------------------- Old: ---- xfwm4-4.14.4.tar.bz2 New: ---- xfwm4-4.14.5.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ xfwm4.spec ++++++ --- /var/tmp/diff_new_pack.G5iaNV/_old 2020-08-12 10:32:55.560170239 +0200 +++ /var/tmp/diff_new_pack.G5iaNV/_new 2020-08-12 10:32:55.560170239 +0200 @@ -18,7 +18,7 @@ %bcond_with git Name: xfwm4 -Version: 4.14.4 +Version: 4.14.5 Release: 0 Summary: Default Window Manager for the Xfce Desktop Environment License: GPL-2.0-or-later ++++++ xfwm4-4.14.4.tar.bz2 -> xfwm4-4.14.5.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.4/ChangeLog new/xfwm4-4.14.5/ChangeLog --- old/xfwm4-4.14.4/ChangeLog 2020-08-01 16:18:57.000000000 +0200 +++ new/xfwm4-4.14.5/ChangeLog 2020-08-09 13:07:12.000000000 +0200 @@ -1,3 +1,56 @@ +commit d331c9b2018a08dd536d2a23d957e96c3f30706b +Author: Olivier Fourdan <four...@xfce.org> +Date: Sun Aug 9 12:54:48 2020 +0200 + + Release 4.14.5! + + Signed-off-by: Olivier Fourdan <four...@xfce.org> + +commit 168cf03a26db673503558e0518c1790911396fac +Author: Michael Banack <bob5...@banack.net> +Date: Wed Aug 5 07:11:17 2020 -0700 + + Fix errorTrap leak in free_win_data + + The function free_win_data() may generate X11 errors as the client + window may already be gone. + + To avoid those, the entire function code is supposed to be enclosed + within an error trap/push. + + A typo in the code would however push twice instead of a balanced + push/pop which causes the list of event sequences in GDK to grow + indefinitely, leading to slowdowns as the list grows over time. + + Fix the leak by balancing the error push with an error pop at the end + of the function. + + https://gitlab.xfce.org/xfce/xfwm4/-/issues/351 + (cherry picked from commit e6a32cf7d789ca3058f50fd630de8e518d310cf8) + +commit ef6ed1fb08dc6c777bab63faccb4334e0064b6e9 +Author: Olivier Fourdan <four...@xfce.org> +Date: Sat Aug 8 18:25:14 2020 +0200 + + compositor: use actual atom + + The function compositorCheckCMSelection() would use the atom index in + our table of atoms, instead of the actual atom, so this is unlikely to + work as expected. + + Fix the code to use the appropriate atom as it should. + + Signed-off-by: Olivier Fourdan <four...@xfce.org> + (cherry picked from commit 78c5dc4264ec8cfa7bab59a39f193788bdcf4059) + +commit 90d5fba5473831aea25289294ec33f04e747558f +Author: Olivier Fourdan <four...@xfce.org> +Date: Sat Aug 1 16:26:56 2020 +0200 + + Post release tag bump + + Signed-off-by: Olivier Fourdan <four...@xfce.org> + commit c8588b3ec356e17f537ed47b38aa8071743dc63b Author: Olivier Fourdan <four...@xfce.org> Date: Sat Aug 1 15:38:58 2020 +0200 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.4/NEWS new/xfwm4-4.14.5/NEWS --- old/xfwm4-4.14.4/NEWS 2020-08-01 16:18:43.000000000 +0200 +++ new/xfwm4-4.14.5/NEWS 2020-08-09 13:06:54.000000000 +0200 @@ -1,3 +1,9 @@ +4.14.5 +====== + +- Fix an error leak in compositor (xfce/xfwm4#351) +- Fix compositor selection atom misuse + 4.14.4 ====== diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.4/configure new/xfwm4-4.14.5/configure --- old/xfwm4-4.14.4/configure 2020-08-01 16:18:52.000000000 +0200 +++ new/xfwm4-4.14.5/configure 2020-08-09 13:07:06.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for xfwm4 4.14.4. +# Generated by GNU Autoconf 2.69 for xfwm4 4.14.5. # # Report bugs to <xfce4-...@xfce.org>. # @@ -595,8 +595,8 @@ # Identity of this package. PACKAGE_NAME='xfwm4' PACKAGE_TARNAME='xfwm4' -PACKAGE_VERSION='4.14.4' -PACKAGE_STRING='xfwm4 4.14.4' +PACKAGE_VERSION='4.14.5' +PACKAGE_STRING='xfwm4 4.14.5' PACKAGE_BUGREPORT='xfce4-...@xfce.org' PACKAGE_URL='' @@ -1465,7 +1465,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures xfwm4 4.14.4 to adapt to many kinds of systems. +\`configure' configures xfwm4 4.14.5 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1539,7 +1539,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of xfwm4 4.14.4:";; + short | recursive ) echo "Configuration of xfwm4 4.14.5:";; esac cat <<\_ACEOF @@ -1701,7 +1701,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -xfwm4 configure 4.14.4 +xfwm4 configure 4.14.5 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -2075,7 +2075,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by xfwm4 $as_me 4.14.4, which was +It was created by xfwm4 $as_me 4.14.5, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2938,7 +2938,7 @@ # Define the identity of the package. PACKAGE='xfwm4' - VERSION='4.14.4' + VERSION='4.14.5' cat >>confdefs.h <<_ACEOF @@ -18705,8 +18705,8 @@ REVISION=unknown -if test x"c8588b3ec" != x""; then - REVISION=c8588b3ec +if test x"d331c9b20" != x""; then + REVISION=d331c9b20 fi cat >>confdefs.h <<_ACEOF @@ -19271,7 +19271,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by xfwm4 $as_me 4.14.4, which was +This file was extended by xfwm4 $as_me 4.14.5, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -19337,7 +19337,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -xfwm4 config.status 4.14.4 +xfwm4 config.status 4.14.5 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.4/configure.ac new/xfwm4-4.14.5/configure.ac --- old/xfwm4-4.14.4/configure.ac 2020-08-01 16:18:48.000000000 +0200 +++ new/xfwm4-4.14.5/configure.ac 2020-08-09 13:07:02.000000000 +0200 @@ -10,8 +10,8 @@ m4_define([xfwm4_version_major], [4]) m4_define([xfwm4_version_minor], [14]) -m4_define([xfwm4_version_micro], [4]) -m4_define([xfwm4_version_build], [c8588b3ec]) +m4_define([xfwm4_version_micro], [5]) +m4_define([xfwm4_version_build], [d331c9b20]) m4_define([xfwm4_version_tag], []) m4_define([xfwm4_version], [xfwm4_version_major().xfwm4_version_minor().xfwm4_version_micro()ifelse(xfwm4_version_tag(), [git], [xfwm4_version_tag().xfwm4_version_build()], [xfwm4_version_tag()])]) @@ -296,8 +296,8 @@ XDT_FEATURE_DEBUG REVISION=unknown -if test x"c8588b3ec" != x""; then - REVISION=c8588b3ec +if test x"d331c9b20" != x""; then + REVISION=d331c9b20 fi AC_DEFINE_UNQUOTED([REVISION], "$REVISION", [git id]) AC_SUBST([REVISION]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/xfwm4-4.14.4/src/compositor.c new/xfwm4-4.14.5/src/compositor.c --- old/xfwm4-4.14.4/src/compositor.c 2020-08-01 16:18:43.000000000 +0200 +++ new/xfwm4-4.14.5/src/compositor.c 2020-08-09 13:06:54.000000000 +0200 @@ -857,7 +857,7 @@ cw->saved_picture = cw->picture; cw->picture = None; } - myDisplayErrorTrapPush (display_info); + myDisplayErrorTrapPopIgnored (display_info); } static Picture @@ -3770,8 +3770,7 @@ } /* Older property "COMPOSITING_MANAGER" */ - a = XInternAtom (display_info->dpy, COMPOSITING_MANAGER, FALSE); - if (XGetSelectionOwner (display_info->dpy, a) != None) + if (XGetSelectionOwner (display_info->dpy, display_info->atoms[COMPOSITING_MANAGER]) != None) { return TRUE; }
