Hello community, here is the log from the commit of package PackageKit-Qt for openSUSE:Factory checked in at 2020-08-23 09:20:36 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/PackageKit-Qt (Old) and /work/SRC/openSUSE:Factory/.PackageKit-Qt.new.3399 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "PackageKit-Qt" Sun Aug 23 09:20:36 2020 rev:16 rq:828184 version:1.0.2 Changes: -------- --- /work/SRC/openSUSE:Factory/PackageKit-Qt/PackageKit-Qt.changes 2019-03-26 15:37:42.544365455 +0100 +++ /work/SRC/openSUSE:Factory/.PackageKit-Qt.new.3399/PackageKit-Qt.changes 2020-08-23 09:20:42.234669313 +0200 @@ -1,0 +2,13 @@ +Mon Aug 17 19:06:15 UTC 2020 - Dirk Mueller <[email protected]> + +- update to 1.0.2: + * Fix documentation (Aleix Pol) + * Fix pkg-config include path (Matthias Klumpp) + * Fix some documentation typos (Pekka Vuorela) + * Make sure the build is done as c++11 (Pekka Vuorela) + * Map DBusError::AccessDenied to Transaction::ErrorNotAuthorized (Raine Makelainen) +- remove 0001-Fix-pkg-config-include-path.patch + 0002-Fix-some-documentation-typos.patch + 0003-Make-sure-the-build-is-done-as-c-11.patch: upstream + +------------------------------------------------------------------- Old: ---- 0001-Fix-pkg-config-include-path.patch 0002-Fix-some-documentation-typos.patch 0003-Make-sure-the-build-is-done-as-c-11.patch PackageKit-Qt-1.0.1.tar.gz New: ---- PackageKit-Qt-1.0.2.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ PackageKit-Qt.spec ++++++ --- /var/tmp/diff_new_pack.XiMlMM/_old 2020-08-23 09:20:43.566670050 +0200 +++ /var/tmp/diff_new_pack.XiMlMM/_new 2020-08-23 09:20:43.566670050 +0200 @@ -1,7 +1,7 @@ # # spec file for package PackageKit-Qt # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -18,17 +18,13 @@ %define libpk libpackagekitqt5-1 Name: PackageKit-Qt -Version: 1.0.1 +Version: 1.0.2 Release: 0 Summary: Simple software installation management software License: LGPL-2.1-or-later Group: System/Daemons URL: http://packagekit.org/ Source: https://github.com/hughsie/PackageKit-Qt/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz -# PATCH-FIX-UPSTREAM -Patch1: 0001-Fix-pkg-config-include-path.patch -Patch2: 0002-Fix-some-documentation-typos.patch -Patch3: 0003-Make-sure-the-build-is-done-as-c-11.patch # PATCH-FIX-UPSTREAM boo#1103678 Patch4: 0001-Fix-PackageKit-not-emitting-network-state-changed-signal.patch BuildRequires: PackageKit-devel >= %{version} @@ -83,7 +79,7 @@ cmake \ -DCMAKE_INSTALL_PREFIX=%{_prefix} \ .. -make %{?_smp_mflags} +%make_build %install cd build ++++++ PackageKit-Qt-1.0.1.tar.gz -> PackageKit-Qt-1.0.2.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/CMakeLists.txt new/PackageKit-Qt-1.0.2/CMakeLists.txt --- old/PackageKit-Qt-1.0.1/CMakeLists.txt 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/CMakeLists.txt 2020-02-20 23:52:54.000000000 +0100 @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.1) +cmake_minimum_required(VERSION 3.2) cmake_policy(SET CMP0048 NEW) if (POLICY CMP0043) @@ -8,7 +8,7 @@ cmake_policy(SET CMP0063 NEW) endif() -project(packagekit-qt VERSION 1.0.1) +project(packagekit-qt VERSION 1.0.2) # Used to set installation paths set(CMAKE_AUTOMOC ON) @@ -56,14 +56,15 @@ set (CMAKECONFIG_INSTALL_DIR "${CMAKE_INSTALL_LIBDIR}/cmake/packagekitqt5/") add_definitions("-DLOCALSTATEDIR=\"${LOCALSTATEDIR}\"") +set (CMAKE_CXX_STANDARD 11) configure_file(config.h.in ${CMAKE_BINARY_DIR}/config.h) # # Custom C flags # -option (DISABLE_MAINTAINER_CFLAGS "Disable maintainer CFlags" ON) -if (NOT DISABLE_MAINTAINER_CFLAGS) +option (MAINTAINER "Enable maintainer CFlags" OFF) +if (MAINTAINER) set (MAINTAINER_CFLAGS "-Werror -Wall -Wcast-align -Wno-uninitialized -Wempty-body -Wformat-security -Winit-self") add_definitions(${MAINTAINER_CFLAGS}) endif () diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/NEWS new/PackageKit-Qt-1.0.2/NEWS --- old/PackageKit-Qt-1.0.1/NEWS 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/NEWS 2020-02-20 23:52:54.000000000 +0100 @@ -1,3 +1,34 @@ +Version 1.0.2 +~~~~~~~~~~~~~ +Released: 2020-02-20 + +Bugfixes: + * Fix documentation (Aleix Pol) + * Fix pkg-config include path (Matthias Klumpp) + * Fix some documentation typos (Pekka Vuorela) + * Make sure the build is done as c++11 (Pekka Vuorela) + * Map DBusError::AccessDenied to Transaction::ErrorNotAuthorized (Raine Makelainen) + +Version 1.0.1 +~~~~~~~~~~~~~ +Released: 2018-01-16 + +Bugfixes: + * Fix typo + * Fix class export + +Version 1.0.0 +~~~~~~~~~~~~~ +Released: 2018-01-12 + +Features: + * Full Offline interface support + +Bugfixes: + * Added missing enums + * Faster package-id parser + * Removed deprecated methods + Version 0.9.6 ~~~~~~~~~~~~~ Released: 2016-09-20 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/RELEASE new/PackageKit-Qt-1.0.2/RELEASE --- old/PackageKit-Qt-1.0.1/RELEASE 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/RELEASE 2020-02-20 23:52:54.000000000 +0100 @@ -2,12 +2,12 @@ 1. Write NEWS entries for PackageKit-Qt in the same format as usual. -git shortlog QPACKAGEKIT_0_9_6.. | grep -i -v trivial | grep -v Merge > NEWS.new +git shortlog v1.0.1.. | grep -i -v trivial | grep -v Merge > NEWS.new -------------------------------------------------------------------------------- -Version 0.9.7 +Version 1.0.2 ~~~~~~~~~~~~~ -Released: 2014-xx-xx +Released: 2020-xx-xx Notes: @@ -20,13 +20,13 @@ 3. Commit changes in PackageKit-Qt git: -git commit -a -m "Release version 0.9.7" -git tag -s -f -m "Release 0.9.7" QPACKAGEKIT_0_9_7 +git commit -a -m "Release version 1.0.2" +git tag -s -f -m "Release 1.0.2" v1.0.2 <gpg password> git push --tags git push -4. run './release.sh --version=0.9.7 --git-tag=QPACKAGEKIT_0_9_7 --sign' +4. run './release.sh --version=1.0.2 --git-tag=v1.0.2 --sign' 5. Upload tarball to: @@ -42,7 +42,7 @@ 8. Send an email to [email protected] ================================================= -PackageKit-Qt 0.9.7 released! +PackageKit-Qt 1.0.2 released! Tarballs available here: http://www.packagekit.org/releases/ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/release.sh new/PackageKit-Qt-1.0.2/release.sh --- old/PackageKit-Qt-1.0.1/release.sh 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/release.sh 2020-02-20 23:52:54.000000000 +0100 @@ -40,8 +40,10 @@ rm -rf ./release-tar-tmp # check if we can build PackageKit-Qt +rm -rf ./t-build-release mkdir -p ./t-build-release -make -C ./build clean all +cmake -B ./t-build-release -DMAINTAINER=ON +make -C ./t-build-release clean all rm -rf ./t-build-release mkdir -p ./release-tar-tmp diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/src/daemon.h new/PackageKit-Qt-1.0.2/src/daemon.h --- old/PackageKit-Qt-1.0.1/src/daemon.h 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/src/daemon.h 2020-02-20 23:52:54.000000000 +0100 @@ -184,7 +184,7 @@ * Allows a client to find out if it would be allowed to authorize an action. * The action ID, e.g. org.freedesktop.packagekit.system-network-proxy-configure * specified in \p actionId - * Returm might be either yes, no or interactive \sa Authorize. + * Return might be either yes, no or interactive \sa Authorize. */ static QDBusPendingReply<Authorize> canAuthorize(const QString &actionId); @@ -384,8 +384,11 @@ * Gets more details about the given \p files * * \sa Transaction::details - * \note This method emits \sa package() - * with details set + * \note this method emits: + * \li details() + * \li status() + * \li progress() + * \li error() * * \warning check \sa errorCode() signal to know if it the call has any error */ @@ -395,8 +398,12 @@ * Gets more details about the given \p file * * \sa Transaction::details - * \note This method emits \sa package() - * with details set + * + * \note this method emits: + * \li details() + * \li status() + * \li progress() + * \li error() * * \warning check \sa errorCode() signal to know if it the call has any error */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/src/packagekitqt5.pc.in new/PackageKit-Qt-1.0.2/src/packagekitqt5.pc.in --- old/PackageKit-Qt-1.0.1/src/packagekitqt5.pc.in 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/src/packagekitqt5.pc.in 2020-02-20 23:52:54.000000000 +0100 @@ -4,8 +4,8 @@ includedir=@CMAKE_INSTALL_FULL_INCLUDEDIR@ Name: @LIBNAME@ -Description: PackageKit is a system daemon for installing stuff. +Description: PackageKit is a package management abstraction layer. Version: @PROJECT_VERSION@ Requires: Qt5Core, Qt5DBus Libs: -L${libdir} -lpackagekitqt5 -Cflags: -I${includedir}/packagekitqt5/PackageKit +Cflags: -I${includedir}/packagekitqt5 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/src/transaction.cpp new/PackageKit-Qt-1.0.2/src/transaction.cpp --- old/PackageKit-Qt-1.0.1/src/transaction.cpp 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/src/transaction.cpp 2020-02-20 23:52:54.000000000 +0100 @@ -46,7 +46,10 @@ { QDBusPendingReply<QDBusObjectPath> reply = *call; if (reply.isError()) { - errorCode(Transaction::ErrorInternalError, reply.error().message()); + QDBusError error = reply.error(); + Transaction::Error transactionError = error.type() == QDBusError::AccessDenied ? Transaction::ErrorNotAuthorized + : Transaction::ErrorInternalError; + errorCode(transactionError, error.message()); d->finished(Transaction::ExitFailed, 0); d->destroy(); } else { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/src/transaction.h new/PackageKit-Qt-1.0.2/src/transaction.h --- old/PackageKit-Qt-1.0.1/src/transaction.h 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/src/transaction.h 2020-02-20 23:52:54.000000000 +0100 @@ -508,9 +508,9 @@ bool allowCancel() const; /** - * Indicates weither the transaction caller is active or not + * Indicates whether the transaction caller is active or not * - * The caller can be inactive if it has quitted before the transaction finished. + * The caller can be inactive if it has quit before the transaction finished. * * \return true if the caller is active, false else */ @@ -583,7 +583,7 @@ QDateTime timespec() const; /** - * Returns weither the transaction succeded or not + * Returns whether the transaction succeded or not * \return true if the transaction succeeded, false else * \note This function only returns a real value for old transactions returned by getOldTransactions */ @@ -597,7 +597,7 @@ uint duration() const; /** - * Returns some data set by the backend to pass additionnal information + * Returns some data set by the backend to pass additional information * \return a string set by the backend * \note This function only returns a real value for old transactions returned by getOldTransactions */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/PackageKit-Qt-1.0.1/src/transactionprivate.cpp new/PackageKit-Qt-1.0.2/src/transactionprivate.cpp --- old/PackageKit-Qt-1.0.1/src/transactionprivate.cpp 2018-01-16 20:47:08.000000000 +0100 +++ new/PackageKit-Qt-1.0.2/src/transactionprivate.cpp 2020-02-20 23:52:54.000000000 +0100 @@ -193,7 +193,10 @@ q, [this, q] (QDBusPendingCallWatcher *call) { QDBusPendingReply<> reply = *call; if (reply.isError()) { - q->errorCode(Transaction::ErrorInternalError, reply.error().message()); + QDBusError error = reply.error(); + Transaction::Error transactionError = error.type() == QDBusError::AccessDenied ? Transaction::ErrorNotAuthorized + : Transaction::ErrorInternalError; + q->errorCode(transactionError, error.message()); finished(Transaction::ExitFailed, 0); destroy(); }
