Hello community,
here is the log from the commit of package NetworkManager for openSUSE:Factory
checked in at 2012-04-20 15:18:55
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/NetworkManager (Old)
and /work/SRC/openSUSE:Factory/.NetworkManager.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "NetworkManager", Maintainer is "gnome-maintain...@suse.de"
Changes:
--------
--- /work/SRC/openSUSE:Factory/NetworkManager/NetworkManager.changes
2012-03-29 11:41:17.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.NetworkManager.new/NetworkManager.changes
2012-04-20 15:18:57.000000000 +0200
@@ -1,0 +2,6 @@
+Tue Apr 17 22:13:49 UTC 2012 - je...@suse.com
+
+- Add nm-gerror-must-be-null.patch: GError * must be initialized to
+ NULL (bnc#757656).
+
+-------------------------------------------------------------------
New:
----
nm-gerror-must-be-null.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ NetworkManager.spec ++++++
--- /var/tmp/diff_new_pack.SveP6f/_old 2012-04-20 15:18:58.000000000 +0200
+++ /var/tmp/diff_new_pack.SveP6f/_new 2012-04-20 15:18:58.000000000 +0200
@@ -41,6 +41,8 @@
Patch3: nm-don-t-consider-not-needed-secrets-for-has_system_secr.diff
# PATCH-HACK-OPENSUSE
nm-treat-not-saved-secrets-just-like-agent-owned-when-cl.diff lnus...@suse.com
-- avoid polkit popups for 802.11x
Patch4: nm-treat-not-saved-secrets-just-like-agent-owned-when-cl.diff
+# PATCH-FIX-UPSTREAM nm-gerror-must-be-null.patch bnc#757656 bgo#674042
je...@suse.com -- GError * must be initialized to NULL
+Patch5: nm-gerror-must-be-null.patch
BuildRequires: fdupes
BuildRequires: gobject-introspection-devel
BuildRequires: gtk-doc
@@ -180,6 +182,7 @@
%patch2 -p1
%patch3 -p1
%patch4 -p1
+%patch5 -p1
%build
pppddir=`ls -1d /usr/%_lib/pppd/2*`
++++++ nm-gerror-must-be-null.patch ++++++
From: Jeff Mahoney <je...@suse.com>
Subject: NetworkManager: GError * must be initialized to NULL
References: bnc#757656
The glib GError API expects a GError ** that it uses to assign an
API-allocated error descriptor. It expects that the calling code
has initialized to the pointer to NULL. If the pointer is uninitialized,
it will use whatever garbage is on the stack causing crashes or,
depending on the caller, potential memory corruption.
During testing with _MALLOC_PERTURB enabled, I encountered a crash
due to this issue where error->message contained the perturb value.
The following patch fixes the remaining call sites.
Signed-off-by: Jeff Mahoney <je...@suse.com>
---
libnm-glib/nm-object.c | 2 +-
libnm-glib/nm-remote-settings.c | 2 +-
src/nm-manager.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--- a/libnm-glib/nm-object.c
+++ b/libnm-glib/nm-object.c
@@ -1248,7 +1248,7 @@ reload_complete (NMObject *object)
NMObjectPrivate *priv = NM_OBJECT_GET_PRIVATE (object);
GSimpleAsyncResult *simple;
GSList *results, *iter;
- GError *error;
+ GError *error = NULL;
results = priv->reload_results;
priv->reload_results = NULL;
--- a/libnm-glib/nm-remote-settings.c
+++ b/libnm-glib/nm-remote-settings.c
@@ -109,7 +109,7 @@ static void
_nm_remote_settings_ensure_inited (NMRemoteSettings *self)
{
NMRemoteSettingsPrivate *priv = NM_REMOTE_SETTINGS_GET_PRIVATE (self);
- GError *error;
+ GError *error = NULL;
if (!priv->inited) {
if (!g_initable_init (G_INITABLE (self), NULL, &error)) {
--- a/src/nm-manager.c
+++ b/src/nm-manager.c
@@ -789,7 +789,7 @@ pending_activation_check_authorized (Pen
{
char *error_desc = NULL;
gulong sender_uid = G_MAXULONG;
- GError *error;
+ GError *error = NULL;
const char *wifi_permission = NULL;
NMConnection *connection;
NMSettings *settings;
--
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org
