Hello community,
here is the log from the commit of package yast2 for openSUSE:Factory checked
in at 2020-09-18 14:33:54
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2 (Old)
and /work/SRC/openSUSE:Factory/.yast2.new.4249 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2"
Fri Sep 18 14:33:54 2020 rev:494 rq:835177 version:4.3.27
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2/yast2.changes 2020-09-15
16:14:44.821826533 +0200
+++ /work/SRC/openSUSE:Factory/.yast2.new.4249/yast2.changes 2020-09-18
14:36:32.403742076 +0200
@@ -1,0 +2,17 @@
+Wed Sep 16 11:14:41 UTC 2020 - José Iván López González <jlo...@suse.com>
+
+- Hide heading of the dialog when no title is defined or title is
+ set to an empty string.
+- Related to bsc#1175489.
+- 4.3.27
+
+-------------------------------------------------------------------
+Tue Sep 15 09:29:51 UTC 2020 - Ladislav Slezák <lsle...@suse.cz>
+
+- Clear the download progres for the previous file when displaying
+ an error popup (bsc#1175926)
+- Enable additional callback logging when $Y2DEBUG_CALLBACKS is
+ set to "1"
+- 4.3.26
+
+-------------------------------------------------------------------
Old:
----
yast2-4.3.25.tar.bz2
New:
----
yast2-4.3.27.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2.spec ++++++
--- /var/tmp/diff_new_pack.lYNQS0/_old 2020-09-18 14:36:33.655743193 +0200
+++ /var/tmp/diff_new_pack.lYNQS0/_new 2020-09-18 14:36:33.655743193 +0200
@@ -17,7 +17,7 @@
Name: yast2
-Version: 4.3.25
+Version: 4.3.27
Release: 0
Summary: YaST2 Main Package
License: GPL-2.0-only
++++++ yast2-4.3.25.tar.bz2 -> yast2-4.3.27.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-4.3.25/.rubocop.yml
new/yast2-4.3.27/.rubocop.yml
--- old/yast2-4.3.25/.rubocop.yml 2020-09-10 12:53:09.000000000 +0200
+++ new/yast2-4.3.27/.rubocop.yml 2020-09-17 13:37:53.000000000 +0200
@@ -34,7 +34,7 @@
- "library/*/test/**/*_test.rb"
Metrics/PerceivedComplexity:
- Max: 65
+ Max: 70
# this needs more testing if we can have frozen string literals
Style/FrozenStringLiteralComment:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-4.3.25/library/packages/src/modules/PackageCallbacks.rb
new/yast2-4.3.27/library/packages/src/modules/PackageCallbacks.rb
--- old/yast2-4.3.25/library/packages/src/modules/PackageCallbacks.rb
2020-09-10 12:53:09.000000000 +0200
+++ new/yast2-4.3.27/library/packages/src/modules/PackageCallbacks.rb
2020-09-17 13:37:53.000000000 +0200
@@ -44,6 +44,52 @@
# symbols for ticking in cmd line
TICK_LABELS = ["/", "-", "\\", "|"].freeze
+ # Debugging: log the called callbacks when Y2DEBUG_CALLBACKS is set to 1
+ #
+ # This uses some Ruby meta programming, the "method_added" is called
whenever
+ # a new method is added into this class, i.e. when each of the following
"def"
+ # is processed.
+ #
+ # @param name [Symbol] name of the added method
+ def self.method_added(name)
+ # log the callbacks only when requested, it's quite verbose
+ return if ENV["Y2DEBUG_CALLBACKS"] != "1"
+
+ name_str = name.to_s
+
+ # do not add a hook for a hook itself otherwise it would result
+ # in an endless recursive loop adding a hook for a hook for a hook for...
+ if name_str.end_with?("_hook") ||
+ # ignore dynamically added helper methods for the published variables
+ name_str.start_with?("_") ||
+ # ignore lowercase methods, they are just some helper methods
+ name_str.match(/^[[:lower:]]/) ||
+ # already present
+ method_defined?("#{name}_hook")
+
+ return
+ end
+
+ # add a new *_hook method as a wrapper for the original method,
+ # log the name of the called method
+ hook = <<-HOOK
+ def #{name}_hook(*params)
+ log.info("Starting callback #{self}::#{name}")
+ result = #{name}_without_hook(*params)
+ log.info("Callback #{self}::#{name} returned: \#{result.inspect}")
+ result
+ end
+ HOOK
+ # __FILE__ and __LINE__ are used in a backtrace
+ class_eval(hook, __FILE__, __LINE__)
+
+ # rename the original method
+ class_eval("alias #{name}_without_hook #{name}", __FILE__, __LINE__)
+
+ # replace the original method with the hook
+ class_eval("alias #{name} #{name}_hook", __FILE__, __LINE__)
+ end
+
def main
Yast.import "Pkg"
Yast.import "UI"
@@ -588,6 +634,12 @@
current_device
)
+ if full_screen
+ # make sure the old subprogress is cleared when displaying a popup
(bsc#1175926)
+ Progress.SubprogressValue(0)
+ Progress.SubprogressTitle("")
+ end
+
url_scheme = Ops.get_string(URL.Parse(url), "scheme", "").downcase
# true if it makes sense to offer an eject button (for cd/dvd only ...)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-4.3.25/library/wizard/src/modules/Wizard.rb
new/yast2-4.3.27/library/wizard/src/modules/Wizard.rb
--- old/yast2-4.3.25/library/wizard/src/modules/Wizard.rb 2020-09-10
12:53:09.000000000 +0200
+++ new/yast2-4.3.27/library/wizard/src/modules/Wizard.rb 2020-09-17
13:37:53.000000000 +0200
@@ -282,12 +282,8 @@
HSpacing(1),
VBox(
VSpacing(0.2),
- HBox(
- # translators: dialog title to appear before any content is
initialized
- Heading(Id(:title), Opt(:hstretch), _("Initializing ...")),
- HStretch(),
- ReplacePoint(Id(:relnotes_rp), Empty())
- ),
+ # translators: dialog title to appear before any content is
initialized
+ ReplacePoint(Id(:heading), dialog_heading(_("Initializing
..."))),
VWeight(
1, # Layout trick: Lower layout priority with weight
HVCenter(Opt(:hvstretch), ReplacePoint(Id(:contents), Empty()))
@@ -333,15 +329,8 @@
70,
VBox(
VSpacing(0.2),
- HBox(
- # translators: dialog title to appear before any content is
initialized
- Heading(
- Id(:title),
- Opt(:hstretch),
- _("YaST\nInitializing ...\n")
- ),
- HStretch()
- ),
+ # translators: dialog title to appear before any content is
initialized
+ ReplacePoint(Id(:heading), dialog_heading(_("YaST\nInitializing
...\n"))),
VWeight(
1, # Layout trick: Lower layout priority with weight
HVCenter(Opt(:hvstretch), ReplacePoint(Id(:contents), Empty()))
@@ -828,7 +817,7 @@
UI.ChangeWidget(Id(:back), :Enabled, has_back) if
UI.WidgetExists(Id(:back))
UI.ChangeWidget(Id(:abort), :Enabled, true) if
UI.WidgetExists(Id(:abort))
- UI.ChangeWidget(Id(:title), :Value, title) if
UI.WidgetExists(Id(:title))
+ UI.ReplaceWidget(Id(:heading), dialog_heading(title)) if
UI.WidgetExists(Id(:heading))
UI.SetFocus(Id(:accept)) if set_focus && UI.WidgetExists(Id(:accept))
end
@@ -1861,6 +1850,21 @@
end
end
+ # Returns the content for the heading of the dialog
+ #
+ # The heading is hidden when no title is given
+ #
+ # @param title [String, nil]
+ def dialog_heading(title)
+ return Empty() if title.nil? || title.empty?
+
+ HBox(
+ Heading(Id(:title), Opt(:hstretch), title),
+ HStretch(),
+ ReplacePoint(Id(:relnotes_rp), Empty())
+ )
+ end
+
Wizard = WizardClass.new
Wizard.main
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-4.3.25/package/yast2.changes
new/yast2-4.3.27/package/yast2.changes
--- old/yast2-4.3.25/package/yast2.changes 2020-09-10 12:53:09.000000000
+0200
+++ new/yast2-4.3.27/package/yast2.changes 2020-09-17 13:37:53.000000000
+0200
@@ -1,4 +1,21 @@
-------------------------------------------------------------------
+Wed Sep 16 11:14:41 UTC 2020 - José Iván López González <jlo...@suse.com>
+
+- Hide heading of the dialog when no title is defined or title is
+ set to an empty string.
+- Related to bsc#1175489.
+- 4.3.27
+
+-------------------------------------------------------------------
+Tue Sep 15 09:29:51 UTC 2020 - Ladislav Slezák <lsle...@suse.cz>
+
+- Clear the download progres for the previous file when displaying
+ an error popup (bsc#1175926)
+- Enable additional callback logging when $Y2DEBUG_CALLBACKS is
+ set to "1"
+- 4.3.26
+
+-------------------------------------------------------------------
Thu Sep 10 07:30:52 UTC 2020 - Josef Reidinger <jreidin...@suse.com>
- Enhance GPG module with symmetric encryption
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-4.3.25/package/yast2.spec
new/yast2-4.3.27/package/yast2.spec
--- old/yast2-4.3.25/package/yast2.spec 2020-09-10 12:53:09.000000000 +0200
+++ new/yast2-4.3.27/package/yast2.spec 2020-09-17 13:37:53.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2
-Version: 4.3.25
+Version: 4.3.27
Release: 0
Summary: YaST2 Main Package
License: GPL-2.0-only
