Hello community,
here is the log from the commit of package perl-Log-Log4perl for
openSUSE:Factory checked in at 2020-09-21 17:08:42
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Log-Log4perl (Old)
and /work/SRC/openSUSE:Factory/.perl-Log-Log4perl.new.4249 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Log-Log4perl"
Mon Sep 21 17:08:42 2020 rev:34 rq:835364 version:1.53
Changes:
--------
--- /work/SRC/openSUSE:Factory/perl-Log-Log4perl/perl-Log-Log4perl.changes
2020-09-09 17:50:45.062612252 +0200
+++
/work/SRC/openSUSE:Factory/.perl-Log-Log4perl.new.4249/perl-Log-Log4perl.changes
2020-09-21 17:11:09.839339598 +0200
@@ -1,0 +2,9 @@
+Fri Sep 18 03:10:44 UTC 2020 - Tina Müller <[email protected]>
+
+- updated to 1.53
+ see /usr/share/doc/packages/perl-Log-Log4perl/Changes
+
+ 1.53 2020-09-17
+ - fix the broken "improved detection of modules" change
+
+-------------------------------------------------------------------
Old:
----
Log-Log4perl-1.52.tar.gz
New:
----
Log-Log4perl-1.53.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Log-Log4perl.spec ++++++
--- /var/tmp/diff_new_pack.g9iD9j/_old 2020-09-21 17:11:12.823342280 +0200
+++ /var/tmp/diff_new_pack.g9iD9j/_new 2020-09-21 17:11:12.827342284 +0200
@@ -17,7 +17,7 @@
Name: perl-Log-Log4perl
-Version: 1.52
+Version: 1.53
Release: 0
%define cpan_name Log-Log4perl
Summary: Log4j implementation for Perl
++++++ Log-Log4perl-1.52.tar.gz -> Log-Log4perl-1.53.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Log4perl-1.52/Changes
new/Log-Log4perl-1.53/Changes
--- old/Log-Log4perl-1.52/Changes 2020-09-07 02:39:01.000000000 +0200
+++ new/Log-Log4perl-1.53/Changes 2020-09-17 18:45:00.000000000 +0200
@@ -1,3 +1,6 @@
+1.53 2020-09-17
+- fix the broken "improved detection of modules" change
+
1.52 2020-09-07
- fix tests to work better on Windows
- doc fixes - thanks @whosgonna, @plicease, @simon04, @willsheppard
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Log4perl-1.52/META.json
new/Log-Log4perl-1.53/META.json
--- old/Log-Log4perl-1.52/META.json 2020-09-07 02:41:21.000000000 +0200
+++ new/Log-Log4perl-1.53/META.json 2020-09-17 18:46:27.000000000 +0200
@@ -55,6 +55,6 @@
},
"x_MailingList" : "mailto:[email protected]"
},
- "version" : "1.52",
+ "version" : "1.53",
"x_serialization_backend" : "JSON::PP version 4.00"
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Log4perl-1.52/META.yml
new/Log-Log4perl-1.53/META.yml
--- old/Log-Log4perl-1.52/META.yml 2020-09-07 02:41:21.000000000 +0200
+++ new/Log-Log4perl-1.53/META.yml 2020-09-17 18:46:27.000000000 +0200
@@ -33,5 +33,5 @@
resources:
MailingList: mailto:[email protected]
bugtracker: https://github.com/mschilli/log4perl/issues
-version: '1.52'
+version: '1.53'
x_serialization_backend: 'CPAN::Meta::YAML version 0.018'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Log4perl-1.52/lib/Log/Log4perl/Config.pm
new/Log-Log4perl-1.53/lib/Log/Log4perl/Config.pm
--- old/Log-Log4perl-1.52/lib/Log/Log4perl/Config.pm 2020-09-07
00:36:41.000000000 +0200
+++ new/Log-Log4perl-1.53/lib/Log/Log4perl/Config.pm 2020-09-17
18:38:53.000000000 +0200
@@ -259,8 +259,9 @@
$filter = Log::Log4perl::Filter->new($filter_name, $type);
} else {
# Filter class
- die "Filter class '$type' doesn't exist ($!)" unless
+ die "Filter class '$type' doesn't exist" unless
Log::Log4perl::Util::module_available($type);
+ eval "require $type" or die "Require of $type failed ($!)";
# Invoke with all defined parameter
# key/values (except the key 'value' which is the entry
@@ -512,10 +513,11 @@
$layout_class = "Log::Log4perl::Layout::$layout_class";
} else {
die "ERROR: trying to set layout for $appender_name to " .
- "'$layout_class' failed ($!)";
+ "'$layout_class' failed ($@)";
}
}
-
+ Log::Log4perl::Util::module_available($layout_class) or
+ die "Require to $layout_class failed ($@)";
$appender->layout($layout_class->new(
$data->{appender}->{$appender_name}->{layout},
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Log4perl-1.52/lib/Log/Log4perl/Util.pm
new/Log-Log4perl-1.53/lib/Log/Log4perl/Util.pm
--- old/Log-Log4perl-1.52/lib/Log/Log4perl/Util.pm 2020-09-07
02:33:20.000000000 +0200
+++ new/Log-Log4perl-1.53/lib/Log/Log4perl/Util.pm 2020-09-17
18:34:14.000000000 +0200
@@ -38,28 +38,19 @@
sub module_available { # Check if a module is available
##################################################
my($full_name) = @_;
-
- # Proper way to check if a module is available or not
- return 1 if keys %{ "${full_name}::" };
-
# Weird cases like "strict;" (including the semicolon) would
# succeed with the eval below, so check those up front.
# I can't believe Perl doesn't have a proper way to check if a
# module is available or not!
return 0 if $full_name =~ /[^\w:]/;
-
- # We can try to load it, if it is not avaiable yet
$full_name =~ s#::#/#g;
+ $full_name .= '.pm';
+ return 1 if $INC{$full_name};
eval {
- local $SIG{__DIE__} = sub {};
- require "$full_name.pm";
+ local $SIG{__DIE__} = sub {};
+ require $full_name;
};
-
- if($@) {
- return 0;
- }
-
- return 1;
+ return !$@;
}
##################################################
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Log4perl-1.52/lib/Log/Log4perl.pm
new/Log-Log4perl-1.53/lib/Log/Log4perl.pm
--- old/Log-Log4perl-1.52/lib/Log/Log4perl.pm 2020-09-07 02:39:48.000000000
+0200
+++ new/Log-Log4perl-1.53/lib/Log/Log4perl.pm 2020-09-17 18:45:09.000000000
+0200
@@ -16,7 +16,7 @@
use Log::Log4perl::Config;
use Log::Log4perl::Appender;
-our $VERSION = '1.52';
+our $VERSION = '1.53';
# set this to '1' if you're using a wrapper
# around Log::Log4perl
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Log4perl-1.52/t/040Filter.t
new/Log-Log4perl-1.53/t/040Filter.t
--- old/Log-Log4perl-1.52/t/040Filter.t 2020-09-07 02:34:42.000000000 +0200
+++ new/Log-Log4perl-1.53/t/040Filter.t 2020-09-17 18:23:27.000000000 +0200
@@ -16,7 +16,6 @@
use Test::More tests => 36;
use Log::Log4perl;
-require Log::Log4perl::Filter::LevelMatch; # else module_available thinks is
already loaded because stash created at compile-time by ::ok override
#############################################
# Use a pattern-matching subroutine as filter