Hello community,
here is the log from the commit of package yast2-ruby-bindings for
openSUSE:Factory checked in at 2020-09-25 16:23:25
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-ruby-bindings (Old)
and /work/SRC/openSUSE:Factory/.yast2-ruby-bindings.new.4249 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-ruby-bindings"
Fri Sep 25 16:23:25 2020 rev:104 rq:837207 version:4.3.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-ruby-bindings/yast2-ruby-bindings.changes
2020-08-14 13:10:26.057235458 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-ruby-bindings.new.4249/yast2-ruby-bindings.changes
2020-09-25 16:26:06.419601987 +0200
@@ -1,0 +2,13 @@
+Thu Sep 24 19:46:00 UTC 2020 - [email protected]
+
+- Fixes for gensalt handling with libxcrypt (bsc#1176924)
+- 4.3.4
+
+-------------------------------------------------------------------
+Wed Sep 23 12:00:57 UTC 2020 - Josef Reidinger <[email protected]>
+
+- Improve logger to log also method name in ruby (useful for any
+ debug like bsc#1144351)
+- 4.3.3
+
+-------------------------------------------------------------------
Old:
----
yast2-ruby-bindings-4.3.2.tar.bz2
New:
----
yast2-ruby-bindings-4.3.4.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-ruby-bindings.spec ++++++
--- /var/tmp/diff_new_pack.Zhwz0L/_old 2020-09-25 16:26:07.775603187 +0200
+++ /var/tmp/diff_new_pack.Zhwz0L/_new 2020-09-25 16:26:07.779603191 +0200
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 4.3.2
+Version: 4.3.4
Release: 0
URL: https://github.com/yast/yast-ruby-bindings
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-ruby-bindings-4.3.2.tar.bz2 -> yast2-ruby-bindings-4.3.4.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.3.2/package/yast2-ruby-bindings.changes
new/yast2-ruby-bindings-4.3.4/package/yast2-ruby-bindings.changes
--- old/yast2-ruby-bindings-4.3.2/package/yast2-ruby-bindings.changes
2020-08-12 14:37:02.000000000 +0200
+++ new/yast2-ruby-bindings-4.3.4/package/yast2-ruby-bindings.changes
2020-09-24 19:33:21.000000000 +0200
@@ -1,4 +1,17 @@
-------------------------------------------------------------------
+Thu Sep 24 19:46:00 UTC 2020 - [email protected]
+
+- Fixes for gensalt handling with libxcrypt (bsc#1176924)
+- 4.3.4
+
+-------------------------------------------------------------------
+Wed Sep 23 12:00:57 UTC 2020 - Josef Reidinger <[email protected]>
+
+- Improve logger to log also method name in ruby (useful for any
+ debug like bsc#1144351)
+- 4.3.3
+
+-------------------------------------------------------------------
Wed Aug 12 12:33:13 UTC 2020 - Stefan Hundhammer <[email protected]>
- Fixed yast-ycp-ui-bindings dependency (bsc#1175115)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.3.2/package/yast2-ruby-bindings.spec
new/yast2-ruby-bindings-4.3.4/package/yast2-ruby-bindings.spec
--- old/yast2-ruby-bindings-4.3.2/package/yast2-ruby-bindings.spec
2020-08-12 14:37:02.000000000 +0200
+++ new/yast2-ruby-bindings-4.3.4/package/yast2-ruby-bindings.spec
2020-09-24 19:33:21.000000000 +0200
@@ -1,7 +1,7 @@
#
# spec file for package yast2-ruby-bindings
#
-# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2020 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -12,14 +12,14 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
#
Name: yast2-ruby-bindings
-Version: 4.3.2
-Url: https://github.com/yast/yast-ruby-bindings
+Version: 4.3.4
Release: 0
+URL: https://github.com/yast/yast-ruby-bindings
BuildRoot: %{_tmppath}/%{name}-%{version}-build
Source0: yast2-ruby-bindings-%{version}.tar.bz2
Prefix: /usr
@@ -57,7 +57,7 @@
# bcond within macros are ignored by osc/OBS.
%bcond_with yast_run_ci_tests
%if %{with yast_run_ci_tests}
-BuildRequires: rubygem(%{rb_default_ruby_abi}:yast-rake-ci)
+BuildRequires: rubygem(%{rb_default_ruby_abi}:yast-rake-ci)
%endif
Requires: ruby
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-4.3.2/src/binary/Builtin.cc
new/yast2-ruby-bindings-4.3.4/src/binary/Builtin.cc
--- old/yast2-ruby-bindings-4.3.2/src/binary/Builtin.cc 2020-08-12
14:37:02.000000000 +0200
+++ new/yast2-ruby-bindings-4.3.4/src/binary/Builtin.cc 2020-09-24
19:33:21.000000000 +0200
@@ -187,8 +187,6 @@
return yrb_utf8_str_new(utf_res);
}
- // crypt part taken from y2crypt from yast core
- // TODO refactor to use sharedddd functionality
// TODO move to own module, it is stupid to have it as builtin
enum crypt_ybuiltin_t { CRYPT, MD5, BLOWFISH, SHA256, SHA512 };
@@ -223,35 +221,13 @@
static char*
make_crypt_salt (const char* crypt_prefix, int crypt_rounds)
{
-#define CRYPT_GENSALT_OUTPUT_SIZE (7 + 22 + 1)
-
-#ifndef RANDOM_DEVICE
-#define RANDOM_DEVICE "/dev/urandom"
-#endif
-
- int fd = open (RANDOM_DEVICE, O_RDONLY);
- if (fd < 0)
- {
- y2error ("Can't open %s for reading: %s\n", RANDOM_DEVICE,
- strerror (errno));
- return 0;
- }
-
- char entropy[16];
- if (read_loop (fd, entropy, sizeof(entropy)) != sizeof(entropy))
- {
- close (fd);
- y2error ("Unable to obtain entropy from %s\n", RANDOM_DEVICE);
- return 0;
- }
-
- close (fd);
+ // use gensalt own auto entropy
+ const char *entropy = NULL;
+ const size_t entropy_len = 0;
char output[CRYPT_GENSALT_OUTPUT_SIZE];
char* retval = crypt_gensalt_rn (crypt_prefix, crypt_rounds, entropy,
- sizeof(entropy), output, sizeof(output));
-
- memset (entropy, 0, sizeof (entropy));
+ entropy_len, output, sizeof(output));
if (!retval)
{
@@ -262,6 +238,7 @@
return strdup (retval);
}
+
// the return value should be free'd
char *
crypt_pass (const char* unencrypted, crypt_ybuiltin_t use_crypt)
@@ -316,7 +293,7 @@
y2debug ("encrypted %s", newencrypted);
//data lives on stack so dup it
- return strdup(newencrypted);
+ return strdup(newencrypted);
}
VALUE crypt_internal(crypt_ybuiltin_t type, VALUE unencrypted)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-4.3.2/src/binary/Yast.cc
new/yast2-ruby-bindings-4.3.4/src/binary/Yast.cc
--- old/yast2-ruby-bindings-4.3.2/src/binary/Yast.cc 2020-08-12
14:37:02.000000000 +0200
+++ new/yast2-ruby-bindings-4.3.4/src/binary/Yast.cc 2020-09-24
19:33:21.000000000 +0200
@@ -399,7 +399,8 @@
{
Check_Type(argv[i], T_STRING);
}
-
y2_logger((loglevel_t)FIX2INT(argv[0]),RSTRING_PTR(argv[1]),RSTRING_PTR(argv[2]),FIX2INT(argv[3]),"",RSTRING_PTR(argv[5]));
+ y2_logger((loglevel_t)FIX2INT(argv[0]), RSTRING_PTR(argv[1]),
RSTRING_PTR(argv[2]),
+ FIX2INT(argv[3]), RSTRING_PTR(argv[4]), RSTRING_PTR(argv[5]));
return Qnil;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-4.3.2/tests/builtins_spec.rb
new/yast2-ruby-bindings-4.3.4/tests/builtins_spec.rb
--- old/yast2-ruby-bindings-4.3.2/tests/builtins_spec.rb 2020-08-12
14:37:02.000000000 +0200
+++ new/yast2-ruby-bindings-4.3.4/tests/builtins_spec.rb 2020-09-24
19:33:21.000000000 +0200
@@ -560,11 +560,6 @@
it "works as expected" do
suffixes = ["", "md5", "blowfish", "sha256", "sha512"]
- # FIXME: Travis hack: skip some tests, only standard crypt and MD5
algorithms
- # work in Ubuntu, it uses a different cprypto setup in glibc,
- # cannot be easily fixed :-(
- suffixes = suffixes[0, 2] if ENV["TRAVIS"]
-
suffixes.each do |suffix|
res = Yast::Builtins.send(:"crypt#{suffix}", "test")
# crypt result is salted and cannot be reproduced
