Hello community, here is the log from the commit of package autoyast2 for openSUSE:Factory checked in at 2020-10-18 16:22:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/autoyast2 (Old) and /work/SRC/openSUSE:Factory/.autoyast2.new.3486 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "autoyast2" Sun Oct 18 16:22:59 2020 rev:291 rq:841498 version:4.3.61 Changes: -------- --- /work/SRC/openSUSE:Factory/autoyast2/autoyast2.changes 2020-09-25 16:28:49.159746054 +0200 +++ /work/SRC/openSUSE:Factory/.autoyast2.new.3486/autoyast2.changes 2020-10-18 16:23:18.192541080 +0200 @@ -1,0 +2,60 @@ +Tue Oct 13 10:06:05 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Allow setting the 't' (or 'config:type') attribute in the + 'backup' and 'upgrade' elements (bsc#1176834 and bsc#1176848). +- 4.3.61 + +------------------------------------------------------------------- +Thu Oct 8 15:31:12 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Do not show a warning the user when a script just did not run + (bsc#1177057). +- 4.3.60 + +------------------------------------------------------------------- +Thu Oct 8 08:33:12 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Fix the progress bar length during autoinstallation + initialization (bsc#1177322). + +------------------------------------------------------------------- +Tue Oct 6 07:20:14 UTC 2020 - Ladislav Slezák <lsle...@suse.cz> + +- Resolve "zzz_reboot" script conflict (bsc#1177036) +- 4.3.59 + +------------------------------------------------------------------- +Fri Oct 2 07:04:25 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Fix 'inst_autosetup' tests (bsc#1177227). +- 4.3.58 + +------------------------------------------------------------------- +Thu Oct 1 05:58:50 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Add validation of 'activate_systemd_default_target' and + 'final_restart_services' elements in the 'general/mode' section + (related to bsc#1176595). +- 4.3.57 + +------------------------------------------------------------------- +Tue Sep 29 13:55:29 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Improve validation errors presentation (related to bsc#1176973). +- 4.3.56 + +------------------------------------------------------------------- +Tue Sep 29 09:52:11 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Drop the 'general/mouse' element from the schema. It has been + unsupported since version 3.0.3, FATE#313101 (bsc#1176973). +- 4.3.55 + +------------------------------------------------------------------- +Mon Sep 28 13:08:26 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Fix tests for CWM::ComboBox (related to the CWM changes for + bsc#1136454). +- 4.3.54 + +------------------------------------------------------------------- Old: ---- autoyast2-4.3.53.tar.bz2 New: ---- autoyast2-4.3.61.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ autoyast2.spec ++++++ --- /var/tmp/diff_new_pack.3LbET6/_old 2020-10-18 16:23:20.016541892 +0200 +++ /var/tmp/diff_new_pack.3LbET6/_new 2020-10-18 16:23:20.016541892 +0200 @@ -22,7 +22,7 @@ %endif Name: autoyast2 -Version: 4.3.53 +Version: 4.3.61 Release: 0 Summary: YaST2 - Automated Installation License: GPL-2.0-only ++++++ autoyast2-4.3.53.tar.bz2 -> autoyast2-4.3.61.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/package/autoyast2.changes new/autoyast2-4.3.61/package/autoyast2.changes --- old/autoyast2-4.3.53/package/autoyast2.changes 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/package/autoyast2.changes 2020-10-13 13:08:13.000000000 +0200 @@ -1,4 +1,64 @@ ------------------------------------------------------------------- +Tue Oct 13 10:06:05 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Allow setting the 't' (or 'config:type') attribute in the + 'backup' and 'upgrade' elements (bsc#1176834 and bsc#1176848). +- 4.3.61 + +------------------------------------------------------------------- +Thu Oct 8 15:31:12 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Do not show a warning the user when a script just did not run + (bsc#1177057). +- 4.3.60 + +------------------------------------------------------------------- +Thu Oct 8 08:33:12 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Fix the progress bar length during autoinstallation + initialization (bsc#1177322). + +------------------------------------------------------------------- +Tue Oct 6 07:20:14 UTC 2020 - Ladislav Slezák <lsle...@suse.cz> + +- Resolve "zzz_reboot" script conflict (bsc#1177036) +- 4.3.59 + +------------------------------------------------------------------- +Fri Oct 2 07:04:25 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Fix 'inst_autosetup' tests (bsc#1177227). +- 4.3.58 + +------------------------------------------------------------------- +Thu Oct 1 05:58:50 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Add validation of 'activate_systemd_default_target' and + 'final_restart_services' elements in the 'general/mode' section + (related to bsc#1176595). +- 4.3.57 + +------------------------------------------------------------------- +Tue Sep 29 13:55:29 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Improve validation errors presentation (related to bsc#1176973). +- 4.3.56 + +------------------------------------------------------------------- +Tue Sep 29 09:52:11 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Drop the 'general/mouse' element from the schema. It has been + unsupported since version 3.0.3, FATE#313101 (bsc#1176973). +- 4.3.55 + +------------------------------------------------------------------- +Mon Sep 28 13:08:26 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Fix tests for CWM::ComboBox (related to the CWM changes for + bsc#1136454). +- 4.3.54 + +------------------------------------------------------------------- Thu Sep 24 13:04:47 UTC 2020 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> - Add the schema for 'backup' and 'upgrade' sections (bsc#1176834). diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/package/autoyast2.spec new/autoyast2-4.3.61/package/autoyast2.spec --- old/autoyast2-4.3.53/package/autoyast2.spec 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/package/autoyast2.spec 2020-10-13 13:08:13.000000000 +0200 @@ -22,7 +22,7 @@ %endif Name: autoyast2 -Version: 4.3.53 +Version: 4.3.61 Release: 0 Summary: YaST2 - Automated Installation License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/src/autoyast-rnc/backup.rnc new/autoyast2-4.3.61/src/autoyast-rnc/backup.rnc --- old/autoyast2-4.3.53/src/autoyast-rnc/backup.rnc 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/src/autoyast-rnc/backup.rnc 2020-10-13 13:08:13.000000000 +0200 @@ -4,7 +4,10 @@ backup = element backup { - element modified { BOOLEAN }? & - element remove_old { BOOLEAN }? & - element sysconfig { BOOLEAN }? + MAP, + ( + element modified { BOOLEAN }? & + element remove_old { BOOLEAN }? & + element sysconfig { BOOLEAN }? + ) } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/src/autoyast-rnc/general.rnc new/autoyast2-4.3.61/src/autoyast-rnc/general.rnc --- old/autoyast2-4.3.53/src/autoyast-rnc/general.rnc 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/src/autoyast-rnc/general.rnc 2020-10-13 13:08:13.000000000 +0200 @@ -10,18 +10,19 @@ element mode { MAP, ( - element confirm { BOOLEAN }? & - element halt { BOOLEAN }? & - element second_stage { BOOLEAN }? & - element final_halt { BOOLEAN }? & - element final_reboot { BOOLEAN }? & - element forceboot { BOOLEAN }? & - element confirm_base_product_license { BOOLEAN }? & + element activate_systemd_default_target { BOOLEAN }? & + element confirm { BOOLEAN }? & + element confirm_base_product_license { BOOLEAN }? & + element final_halt { BOOLEAN }? & + element final_reboot { BOOLEAN }? & + element final_restart_services { BOOLEAN }? & + element forceboot { BOOLEAN }? & + element halt { BOOLEAN }? & + element max_systemd_wait { INTEGER }? & element ntp_sync_time_before_installation { STRING }? & - element max_systemd_wait { INTEGER }? + element second_stage { BOOLEAN }? ) }? & - mouse? & ask-list? & semi-automatic? & minimal-configuration? & @@ -126,9 +127,6 @@ element halt { BOOLEAN } second_stage = element second_stage { BOOLEAN } -mouse = element mouse { - element id { STRING } -} module = element module { MAP, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/src/autoyast-rnc/upgrade.rnc new/autoyast2-4.3.61/src/autoyast-rnc/upgrade.rnc --- old/autoyast2-4.3.53/src/autoyast-rnc/upgrade.rnc 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/src/autoyast-rnc/upgrade.rnc 2020-10-13 13:08:13.000000000 +0200 @@ -4,5 +4,8 @@ upgrade = element upgrade { - element stop_on_solver_conflict { BOOLEAN }? + MAP, + ( + element stop_on_solver_conflict { BOOLEAN }? + ) } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/src/clients/inst_autoconfigure.rb new/autoyast2-4.3.61/src/clients/inst_autoconfigure.rb --- old/autoyast2-4.3.53/src/clients/inst_autoconfigure.rb 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/src/clients/inst_autoconfigure.rb 2020-10-13 13:08:13.000000000 +0200 @@ -160,7 +160,9 @@ if @online_update_ret == :reboot # AddEditScript(scriptName, source, interpreter, type, chrooted, debug, feedback, # feedback_type, location, notification) - AutoinstScripts.AddEditScript("zzz_reboot", "shutdown -r now", "shell", "init", + # make sure to avoid conflicts with "zzz_reboot" script here + # https://github.com/yast/yast-autoinstallation/blob/104c18f1a56d02ab50055cdf09653db964b97888/src/modules/Profile.rb#L157 + AutoinstScripts.AddEditScript("zzzz_reboot", "shutdown -r now", "shell", "init", false, false, false, "", "", "") # wonderful API without defaults end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/src/lib/autoinstall/clients/inst_autoinit.rb new/autoyast2-4.3.61/src/lib/autoinstall/clients/inst_autoinit.rb --- old/autoyast2-4.3.53/src/lib/autoinstall/clients/inst_autoinit.rb 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/src/lib/autoinstall/clients/inst_autoinit.rb 2020-10-13 13:08:13.000000000 +0200 @@ -59,7 +59,7 @@ Yast::Progress.New( _("Preparing System for Automatic Installation"), "", # progress_title - 6, # progress bar length + 7, # progress bar length progress_stages, [], help_text diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/src/lib/autoinstall/script.rb new/autoyast2-4.3.61/src/lib/autoinstall/script.rb --- old/autoyast2-4.3.53/src/lib/autoinstall/script.rb 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/src/lib/autoinstall/script.rb 2020-10-13 13:08:13.000000000 +0200 @@ -269,7 +269,7 @@ "python" => "/usr/bin/python" }.freeze # Runs the script - # @return [Boolean] if exit code is zero + # @return [Boolean,nil] if exit code is zero; nil if the script was not executed def execute return if already_run? && !rerun diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/src/lib/autoinstall/xml_checks.rb new/autoyast2-4.3.61/src/lib/autoinstall/xml_checks.rb --- old/autoyast2-4.3.53/src/lib/autoinstall/xml_checks.rb 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/src/lib/autoinstall/xml_checks.rb 2020-10-13 13:08:13.000000000 +0200 @@ -168,7 +168,8 @@ # TRANSLATORS: Warn user about using invalid XML _("Using an invalid XML document might result in an unexpected behavior, " \ "crash or even data loss!") + - "</p><h4>" + _("Details") + "</h4>" + ERB::Util.html_escape(errors.join("<br>")) + + "</p><h4>" + _("Details") + "</h4>" \ + "<p>" + ERB::Util.html_escape(errors.join("<br>")) + "</p>" \ "<h4>" + _("Note") + "</h4>" + # TRANSLATORS: A hint how to check a XML file, displayed as a part of the # validation error message, %{jing} and %{xmllint} are replaced by shell commands, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/src/modules/AutoinstScripts.rb new/autoyast2-4.3.61/src/modules/AutoinstScripts.rb --- old/autoyast2-4.3.53/src/modules/AutoinstScripts.rb 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/src/modules/AutoinstScripts.rb 2020-10-13 13:08:13.000000000 +0200 @@ -245,7 +245,7 @@ def Write(type, special) return true if !Mode.autoinst && !Mode.autoupgrade - target_scripts = @scripts.select { |s| s.class.type == type } + target_scripts = scripts.select { |s| s.class.type == type } target_scripts.select! { |s| s.chrooted == special } if type == "chroot-scripts" target_scripts.each(&:create_script_file) @@ -259,6 +259,7 @@ Popup.ShowFeedback("", script.notification) unless script.notification.empty? res = script.execute + next if res.nil? # the script was not executed Popup.ClearFeedback unless script.notification.empty? diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/test/AutoinstScripts_test.rb new/autoyast2-4.3.61/test/AutoinstScripts_test.rb --- old/autoyast2-4.3.53/test/AutoinstScripts_test.rb 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/test/AutoinstScripts_test.rb 2020-10-13 13:08:13.000000000 +0200 @@ -261,6 +261,24 @@ subject.Import(data) subject.Write("pre-scripts", true) end + + context "when the script does not run" do + let(:script) do + Y2Autoinstallation::PreScript.new( + "location" => "http://test.com/script", "rerun" => false + ) + end + + before do + allow(subject).to receive(:scripts).and_return([script]) + allow(script).to receive(:execute).and_return(nil) + end + + it "does not report any problem" do + expect(Yast::Report).to_not receive(:Warning) + subject.Write("pre-scripts", false) + end + end end context "for postpartitioning-scripts" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/test/lib/clients/inst_autosetup_test.rb new/autoyast2-4.3.61/test/lib/clients/inst_autosetup_test.rb --- old/autoyast2-4.3.53/test/lib/clients/inst_autosetup_test.rb 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/test/lib/clients/inst_autosetup_test.rb 2020-10-13 13:08:13.000000000 +0200 @@ -42,7 +42,7 @@ allow(Yast::Progress).to receive(:Title) allow(Yast::AutoinstStorage).to receive(:Import).and_return(true) allow(Yast::AutoinstStorage).to receive(:Write).and_return(true) - allow(Yast::Profile).to receive(:current).and_return(profile) + allow(Yast::WFM).to receive(:CallFunction).with(/_auto/, Array).and_return(true) allow(Yast::Popup).to receive(:ConfirmAbort).and_return(true) @@ -59,6 +59,7 @@ allow(subject).to receive(:probe_storage) allow(Yast::AutoinstSoftware).to receive(:Write).and_return(true) allow(Yast::ServicesManager).to receive(:import) + Yast::Profile.current = profile end it "sets up the network" do @@ -174,7 +175,7 @@ end it "sets up the software" do - expect(Yast::AutoinstSoftware).to receive(:Import).with(profile["software"]) + expect(Yast::AutoinstSoftware).to receive(:Import).with(a_hash_including(profile["software"])) expect(Yast::AutoinstSoftware).to receive(:Write).and_return(true) subject.main end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.3.53/test/lib/widgets/storage/shared_examples.rb new/autoyast2-4.3.61/test/lib/widgets/storage/shared_examples.rb --- old/autoyast2-4.3.53/test/lib/widgets/storage/shared_examples.rb 2020-09-24 17:13:19.000000000 +0200 +++ new/autoyast2-4.3.61/test/lib/widgets/storage/shared_examples.rb 2020-10-13 13:08:13.000000000 +0200 @@ -150,6 +150,10 @@ end describe "#value=" do + before do + allow(subject).to receive(:change_items) + end + context "when given value is a valid disk size" do let(:size) { 67108864 }