Hello community,
here is the log from the commit of package yast2-packager for openSUSE:Factory
checked in at 2020-10-30 11:45:56
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-packager (Old)
and /work/SRC/openSUSE:Factory/.yast2-packager.new.3463 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-packager"
Fri Oct 30 11:45:56 2020 rev:404 rq:844233 version:4.3.10
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-packager/yast2-packager.changes
2020-10-18 16:22:43.984525855 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-packager.new.3463/yast2-packager.changes
2020-10-30 11:46:03.377621708 +0100
@@ -1,0 +2,6 @@
+Mon Oct 26 21:01:37 UTC 2020 - Josef Reidinger <jreidin...@suse.com>
+
+- Confirm abort in product license dialog (bsc#1178005)
+- 4.3.10
+
+-------------------------------------------------------------------
Old:
----
yast2-packager-4.3.9.tar.bz2
New:
----
yast2-packager-4.3.10.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-packager.spec ++++++
--- /var/tmp/diff_new_pack.BWI0nX/_old 2020-10-30 11:46:04.077622328 +0100
+++ /var/tmp/diff_new_pack.BWI0nX/_new 2020-10-30 11:46:04.081622331 +0100
@@ -17,7 +17,7 @@
Name: yast2-packager
-Version: 4.3.9
+Version: 4.3.10
Release: 0
Summary: YaST2 - Package Library
License: GPL-2.0-or-later
++++++ yast2-packager-4.3.9.tar.bz2 -> yast2-packager-4.3.10.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.3.9/package/yast2-packager.changes
new/yast2-packager-4.3.10/package/yast2-packager.changes
--- old/yast2-packager-4.3.9/package/yast2-packager.changes 2020-10-12
13:20:37.000000000 +0200
+++ new/yast2-packager-4.3.10/package/yast2-packager.changes 2020-10-27
10:17:50.000000000 +0100
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Mon Oct 26 21:01:37 UTC 2020 - Josef Reidinger <jreidin...@suse.com>
+
+- Confirm abort in product license dialog (bsc#1178005)
+- 4.3.10
+
+-------------------------------------------------------------------
Mon Oct 12 11:39:08 CEST 2020 - sch...@suse.de
- VNC installation: Removed xorg-x11 package from the needed
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.3.9/package/yast2-packager.spec
new/yast2-packager-4.3.10/package/yast2-packager.spec
--- old/yast2-packager-4.3.9/package/yast2-packager.spec 2020-10-12
13:20:37.000000000 +0200
+++ new/yast2-packager-4.3.10/package/yast2-packager.spec 2020-10-27
10:17:50.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-packager
-Version: 4.3.9
+Version: 4.3.10
Release: 0
Summary: YaST2 - Package Library
License: GPL-2.0-or-later
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-packager-4.3.9/src/lib/y2packager/dialogs/inst_product_license.rb
new/yast2-packager-4.3.10/src/lib/y2packager/dialogs/inst_product_license.rb
--- old/yast2-packager-4.3.9/src/lib/y2packager/dialogs/inst_product_license.rb
2020-10-12 13:20:37.000000000 +0200
+++
new/yast2-packager-4.3.10/src/lib/y2packager/dialogs/inst_product_license.rb
2020-10-27 10:17:50.000000000 +0100
@@ -17,6 +17,7 @@
require "y2packager/widgets/product_license_confirmation"
Yast.import "Language"
+Yast.import "Popup"
module Y2Packager
module Dialogs
@@ -61,6 +62,11 @@
)
end
+ # Overwrite abort handler to ask for confirmation
+ def abort_handler
+ Yast::Popup.ConfirmAbort(:painless)
+ end
+
private
# Return the license confirmation widget if required
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-packager-4.3.9/test/lib/dialogs/inst_product_license_test.rb
new/yast2-packager-4.3.10/test/lib/dialogs/inst_product_license_test.rb
--- old/yast2-packager-4.3.9/test/lib/dialogs/inst_product_license_test.rb
2020-10-12 13:20:37.000000000 +0200
+++ new/yast2-packager-4.3.10/test/lib/dialogs/inst_product_license_test.rb
2020-10-27 10:17:50.000000000 +0100
@@ -54,4 +54,18 @@
dialog.contents
end
end
+
+ describe "#abort_handler" do
+ it "returns true if user confirm abort" do
+ allow(Yast::Popup).to receive(:ConfirmAbort).and_return(true)
+
+ expect(subject.abort_handler).to eq true
+ end
+
+ it "returns false if user cancel abort confirmation" do
+ allow(Yast::Popup).to receive(:ConfirmAbort).and_return(false)
+
+ expect(subject.abort_handler).to eq false
+ end
+ end
end
