Hello community,

here is the log from the commit of package perl-Want for openSUSE:Factory 
checked in at 2012-05-31 17:08:56
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Want (Old)
 and      /work/SRC/openSUSE:Factory/.perl-Want.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "perl-Want", Maintainer is ""

Changes:
--------
--- /work/SRC/openSUSE:Factory/perl-Want/perl-Want.changes      2011-09-23 
12:39:23.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.perl-Want.new/perl-Want.changes 2012-05-31 
17:08:57.000000000 +0200
@@ -1,0 +2,13 @@
+Wed May 30 08:24:07 UTC 2012 - co...@suse.com
+
+- updated to 0.21
+    - Change tests to avoid the new warning 'Useless assignment to a 
temporary' added in 5.15.
+
+    - Remove a test that was testing the behaviour of perl, rather than of 
this module,
+      and was testing an aspect of perl’s behaviour that has changed 
(bf8fb5ebd) in
+      in such a way that the test was failing with bleadperl.
+
+    - Avoid leaking the RHS of an lnoreturn lvalue sub, thanks to Father 
Chrysostomos
+      https://rt.cpan.org/Public/Bug/Display.html?id=72083
+
+-------------------------------------------------------------------

Old:
----
  Want-0.18.tar.gz

New:
----
  Want-0.21.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ perl-Want.spec ++++++
--- /var/tmp/diff_new_pack.Iq0dsZ/_old  2012-05-31 17:08:59.000000000 +0200
+++ /var/tmp/diff_new_pack.Iq0dsZ/_new  2012-05-31 17:08:59.000000000 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package perl-Want
 #
-# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -16,19 +16,19 @@
 #
 
 
-
 Name:           perl-Want
-Version:        0.18
-Release:        1
-License:        GPL-1.0+ or Artistic-1.0
+Version:        0.21
+Release:        0
 %define cpan_name Want
 Summary:        A generalisation of C<wantarray>
-Url:            http://search.cpan.org/dist/Want/
+License:        GPL-1.0+ or Artistic-1.0
 Group:          Development/Libraries/Perl
+Url:            http://search.cpan.org/dist/Want/
 Source:         
http://www.cpan.org/authors/id/R/RO/ROBIN/%{cpan_name}-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 BuildRequires:  perl
 BuildRequires:  perl-macros
+#BuildRequires: perl(Want)
 %{perl_requires}
 
 %description
@@ -51,9 +51,6 @@
 %perl_process_packlist
 %perl_gen_filelist
 
-%clean
-%{__rm} -rf %{buildroot}
-
 %files -f %{name}.files
 %defattr(-,root,root,755)
 %doc Changes README TODO

++++++ Want-0.18.tar.gz -> Want-0.21.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/Changes new/Want-0.21/Changes
--- old/Want-0.18/Changes       2008-02-04 10:37:09.000000000 +0100
+++ new/Want-0.21/Changes       2012-02-29 17:54:37.000000000 +0100
@@ -94,3 +94,15 @@
 
 0.18  Mon Feb  4 09:35:56 GMT 2008
     - Code identical to 0.17; eliminate ._files by using gnutar.
+
+0.19  Sat 30 Jul 2011 17:07:16 BST
+    - Change tests to avoid the new warning 'Useless assignment to a 
temporary' added in 5.15.
+
+0.20  Sun  5 Feb 2012 17:43:22 GMT
+    - Remove a test that was testing the behaviour of perl, rather than of 
this module,
+      and was testing an aspect of perl’s behaviour that has changed 
(bf8fb5ebd) in
+      in such a way that the test was failing with bleadperl.
+
+0.21  Wed 29 Feb 2012 16:47:58 GMT
+    - Avoid leaking the RHS of an lnoreturn lvalue sub, thanks to Father 
Chrysostomos
+      https://rt.cpan.org/Public/Bug/Display.html?id=72083
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/MANIFEST new/Want-0.21/MANIFEST
--- old/Want-0.18/MANIFEST      2007-05-01 22:40:23.000000000 +0200
+++ new/Want-0.21/MANIFEST      2012-03-01 00:08:24.000000000 +0100
@@ -15,3 +15,4 @@
 t/threads.p
 t/threads.t
 META.yml                                 Module meta-data (added by MakeMaker)
+META.json                                Module JSON meta-data (added by 
MakeMaker)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/META.json new/Want-0.21/META.json
--- old/Want-0.18/META.json     1970-01-01 01:00:00.000000000 +0100
+++ new/Want-0.21/META.json     2012-03-01 00:08:24.000000000 +0100
@@ -0,0 +1,39 @@
+{
+   "abstract" : "unknown",
+   "author" : [
+      "unknown"
+   ],
+   "dynamic_config" : 1,
+   "generated_by" : "ExtUtils::MakeMaker version 6.58, CPAN::Meta::Converter 
version 2.110930001",
+   "license" : [
+      "unknown"
+   ],
+   "meta-spec" : {
+      "url" : "http://search.cpan.org/perldoc?CPAN::Meta::Spec";,
+      "version" : "2"
+   },
+   "name" : "Want",
+   "no_index" : {
+      "directory" : [
+         "t",
+         "inc"
+      ]
+   },
+   "prereqs" : {
+      "build" : {
+         "requires" : {
+            "ExtUtils::MakeMaker" : 0
+         }
+      },
+      "configure" : {
+         "requires" : {
+            "ExtUtils::MakeMaker" : 0
+         }
+      },
+      "runtime" : {
+         "requires" : {}
+      }
+   },
+   "release_status" : "stable",
+   "version" : "0.21"
+}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/META.yml new/Want-0.21/META.yml
--- old/Want-0.18/META.yml      2008-02-04 10:38:34.000000000 +0100
+++ new/Want-0.21/META.yml      2012-03-01 00:08:23.000000000 +0100
@@ -1,12 +1,21 @@
---- #YAML:1.0
-name:                Want
-version:             0.18
-abstract:            ~
-license:             ~
-author:              ~
-generated_by:        ExtUtils::MakeMaker version 6.42
-distribution_type:   module
-requires:     
+---
+abstract: unknown
+author:
+  - unknown
+build_requires:
+  ExtUtils::MakeMaker: 0
+configure_requires:
+  ExtUtils::MakeMaker: 0
+dynamic_config: 1
+generated_by: 'ExtUtils::MakeMaker version 6.58, CPAN::Meta::Converter version 
2.110930001'
+license: unknown
 meta-spec:
-    url:     http://module-build.sourceforge.net/META-spec-v1.3.html
-    version: 1.3
+  url: http://module-build.sourceforge.net/META-spec-v1.4.html
+  version: 1.4
+name: Want
+no_index:
+  directory:
+    - t
+    - inc
+requires: {}
+version: 0.21
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/README new/Want-0.21/README
--- old/Want-0.18/README        2008-02-04 10:38:07.000000000 +0100
+++ new/Want-0.21/README        2012-02-29 19:43:15.000000000 +0100
@@ -1,5 +1,5 @@
 -----------------------------------------------------------------------------
-| Want v0.18    - Robin Houston, 2008-02-04
+| Want v0.21    - Robin Houston, 2012-02-29
 -----------------------------------------------------------------------------
 
 For full documentation, see the POD included with the module.
@@ -68,14 +68,16 @@
     print ((pi)[3]);    # prints 1
 
 
+    use Want;
+    use strict;
     sub backstr :lvalue {
         if (want(qw'LVALUE ASSIGN')) {
             my ($a) = want('ASSIGN');
             $_[0] = reverse $a;
-            return undef;
+            lnoreturn;
         }
         elsif (want('RVALUE')) {
-            my $t = scalar reverse $_[0];
+            rreturn scalar reverse $_[0];
         }
         else {
             carp("Not in ASSIGN context");
@@ -92,7 +94,7 @@
        Robin Houston, <ro...@cpan.org>
        
        Thanks to Damian Conway for encouragement and good
-       suggestions.
+       suggestions, and Father Chrysostomos for a patch.
 
 SEE ALSO
        o   the wantarray entry in the perlfunc manpage
@@ -101,6 +103,6 @@
            http://dev.perl.org/rfc/21.html
 
 COPYRIGHT
-       Copyright (c) 2001-2006, Robin Houston. All Rights Reserved.
+       Copyright (c) 2001-2012, Robin Houston. All Rights Reserved.
        This module is free software. It may be used, redistributed
        and/or modified under the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/Want.pm new/Want-0.21/Want.pm
--- old/Want-0.18/Want.pm       2008-02-04 10:35:55.000000000 +0100
+++ new/Want-0.21/Want.pm       2012-02-29 19:54:14.000000000 +0100
@@ -12,7 +12,7 @@
 
 our @EXPORT = qw(want rreturn lnoreturn);
 our @EXPORT_OK = qw(howmany wantref);
-our $VERSION = '0.18';
+our $VERSION = '0.21';
 
 bootstrap Want $VERSION;
 
@@ -177,7 +177,7 @@
         croak "Can't lnoreturn except in ASSIGN context";
     }
     double_return();
-    return undef;
+    return disarm_temp(my $undef);
 }
 
 # Some naughty people were relying on these internal methods.
@@ -497,7 +497,8 @@
 Use this function instead of C<return> from inside an lvalue subroutine when
 you know that you're in RVALUE context. If you try to use a normal C<return>,
 you'll get a compile-time error in Perl 5.6.1 and above unless you return an
-lvalue.
+lvalue. (Note: this is no longer true in Perl 5.16, where an ordinary return
+will once again work.)
 
 =item lnoreturn
 
@@ -508,7 +509,7 @@
 If you use C<rreturn> or C<lnoreturn>, then you have to put a bare C<return;>
 at the very end of your lvalue subroutine, in order to stop the Perl compiler
 from complaining. Think of it as akin to the C<1;> that you have to put at the
-end of a module.
+end of a module. (Note: this is no longer true in Perl 5.16.)
 
 =item howmany()
 
@@ -690,7 +691,8 @@
 
 Robin Houston, E<lt>ro...@cpan.orge<gt>
 
-Thanks to Damian Conway for encouragement and good suggestions.
+Thanks to Damian Conway for encouragement and good suggestions,
+and Father Chrysostomos for a patch.
 
 =head1 SEE ALSO
 
@@ -709,7 +711,7 @@
 
 =head1 COPYRIGHT
 
-Copyright (c) 2001-2006, Robin Houston. All Rights Reserved.
+Copyright (c) 2001-2012, Robin Houston. All Rights Reserved.
 This module is free software. It may be used, redistributed
 and/or modified under the same terms as Perl itself.
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/Want.xs new/Want-0.21/Want.xs
--- old/Want-0.18/Want.xs       2008-02-03 23:29:35.000000000 +0100
+++ new/Want-0.21/Want.xs       2012-02-29 17:54:37.000000000 +0100
@@ -676,3 +676,11 @@
 #endif
 
     return;
+
+SV *
+disarm_temp(sv)
+SV *sv;
+  CODE:
+    RETVAL = sv_2mortal(SvREFCNT_inc(SvREFCNT_inc(sv)));
+  OUTPUT:
+    RETVAL
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/t/all.t new/Want-0.21/t/all.t
--- old/Want-0.18/t/all.t       2007-05-04 12:59:46.000000000 +0200
+++ new/Want-0.21/t/all.t       2012-02-05 18:42:48.000000000 +0100
@@ -8,9 +8,10 @@
 
 # Now test the private low-level mechanisms
 
+my $xxx;
 sub lv :lvalue {
     print (Want::want_lvalue(0) ? "ok 2\n" : "not ok 2\n");
-    my $xxx;
+    $xxx;
 }
 
 &lv = 23;
@@ -141,7 +142,13 @@
 @x = \(g(37, 'LVALUE', 'LIST'));
 ($x) = \(scalar g(38, 'RVALUE'));
 $$x = 29;
-print ($y != 29 ? "ok 39\n" : "not ok 39\n");
+
+# There used to be a test here which tested that $y != 29. However this
+# is really testing the behaviour of perl itself rather than of the Want
+# module, and the behaviour of perl has changed since 5.14: see
+# commit bf8fb5ebd. So we don’t have to renumber all following tests,
+# we just insert a dummy test 39 that always passes.
+print "ok 39 # Not a real test\n";
 
 ng(41, 'REF') = g(40, 'HASH')->{foo};
 $y = sub {}; # Just to silence warning
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Want-0.18/t/assign.t new/Want-0.21/t/assign.t
--- old/Want-0.18/t/assign.t    2001-08-29 11:28:30.000000000 +0200
+++ new/Want-0.21/t/assign.t    2011-07-30 18:09:16.000000000 +0200
@@ -13,8 +13,9 @@
     print (want(@_) ? "ok $t\n" : "not ok $t\n");
 }
 
+my $t;
 sub tl :lvalue {
-    my $t = shift();
+    $t = shift();
     print (want(@_) ? "ok $t\n" : "not ok $t\n");
     $t;
 }

-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org

Reply via email to