Hello community,
here is the log from the commit of package smb4k for openSUSE:Factory checked
in at 2012-06-29 10:24:18
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/smb4k (Old)
and /work/SRC/openSUSE:Factory/.smb4k.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "smb4k", Maintainer is "kde-maintain...@suse.de"
Changes:
--------
--- /work/SRC/openSUSE:Factory/smb4k/smb4k.changes 2012-06-10
23:04:54.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.smb4k.new/smb4k.changes 2012-06-29
10:44:59.000000000 +0200
@@ -1,0 +2,9 @@
+Mon Jun 25 19:56:12 UTC 2012 - asterios.dra...@gmail.com
+
+- Update to version 1.0.3:
+ * Make sure that output from the mount and unmount process is trimmed, so
+ that there are no false error messages.
+ * Fixed error notifications being shown although mounting and unmounting
+ shares was successful.
+
+-------------------------------------------------------------------
Old:
----
smb4k-1.0.2.tar.bz2
New:
----
smb4k-1.0.3.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ smb4k.spec ++++++
--- /var/tmp/diff_new_pack.rArhQF/_old 2012-06-29 10:45:00.000000000 +0200
+++ /var/tmp/diff_new_pack.rArhQF/_new 2012-06-29 10:45:00.000000000 +0200
@@ -17,7 +17,7 @@
Name: smb4k
-Version: 1.0.2
+Version: 1.0.3
Release: 0
Summary: Advanced Network Neighborhood Browser for KDE
License: GPL-2.0+
++++++ smb4k-1.0.2.tar.bz2 -> smb4k-1.0.3.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/smb4k-1.0.2/CMakeLists.txt
new/smb4k-1.0.3/CMakeLists.txt
--- old/smb4k-1.0.2/CMakeLists.txt 2012-05-30 22:01:49.000000000 +0200
+++ new/smb4k-1.0.3/CMakeLists.txt 2012-06-23 15:59:52.000000000 +0200
@@ -1,9 +1,9 @@
project( smb4k )
-set( VERSION 1.0.2 )
+set( VERSION 1.0.3 )
set( VERSION_MAJOR 1 )
set( VERSION_MINOR 0 )
-set( VERSION_PATCH 2 )
+set( VERSION_PATCH 3 )
cmake_minimum_required( VERSION 2.6 )
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/smb4k-1.0.2/ChangeLog new/smb4k-1.0.3/ChangeLog
--- old/smb4k-1.0.2/ChangeLog 2012-05-30 22:01:49.000000000 +0200
+++ new/smb4k-1.0.3/ChangeLog 2012-06-23 15:59:52.000000000 +0200
@@ -1,3 +1,9 @@
+Smb4K 1.0.3 (2012-06-23):
+- Make sure that output from the mount and unmount process is trimmed, so
+ that there are no false error messages.
+- Fixed error notifications being shown although mounting and unmounting
+ shares was successful.
+
Smb4K 1.0.2 (2012-05-30):
- Fixed two potential crashes in class Smb4KHomesSharesHandler.
- Fixed a wrong comparision between QString and QByteArray in
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/smb4k-1.0.2/core/smb4kmounter_p.cpp
new/smb4k-1.0.3/core/smb4kmounter_p.cpp
--- old/smb4k-1.0.2/core/smb4kmounter_p.cpp 2012-05-30 22:01:50.000000000
+0200
+++ new/smb4k-1.0.3/core/smb4kmounter_p.cpp 2012-06-23 15:59:52.000000000
+0200
@@ -729,7 +729,7 @@
// Check if the mount process reported an error
QString stderr( reply.data()["stderr"].toString() );
- if ( QString::compare( share->canonicalPath(),
reply.data()["share_mountpoint"].toString() ) == 0 && stderr.isEmpty() )
+ if ( QString::compare( share->canonicalPath(),
reply.data()["share_mountpoint"].toString() ) == 0 && !stderr.isEmpty() )
{
#ifndef Q_OS_FREEBSD
if ( stderr.contains( "mount error 13", Qt::CaseSensitive ) ||
stderr.contains( "mount error(13)" )
@@ -1020,7 +1020,7 @@
// Check if the unmount process reported an error
QString stderr( reply.data()["stderr"].toString() );
- if ( QString::compare( share->canonicalPath(),
reply.data()["share_mountpoint"].toString() ) == 0 && stderr.isEmpty() )
+ if ( QString::compare( share->canonicalPath(),
reply.data()["share_mountpoint"].toString() ) == 0 && !stderr.isEmpty() )
{
Smb4KNotification *notification = new Smb4KNotification();
notification->unmountingFailed( share, stderr );
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/smb4k-1.0.2/helpers/smb4kmounthelper.cpp
new/smb4k-1.0.3/helpers/smb4kmounthelper.cpp
--- old/smb4k-1.0.2/helpers/smb4kmounthelper.cpp 2012-05-30
22:01:50.000000000 +0200
+++ new/smb4k-1.0.3/helpers/smb4kmounthelper.cpp 2012-06-23
15:59:52.000000000 +0200
@@ -102,11 +102,11 @@
{
// Check if there is output on stderr.
QString stderr = QString::fromUtf8( proc.readAllStandardError() );
- reply.addData( "stderr", stderr );
+ reply.addData( "stderr", stderr.trimmed() );
// Check if there is output on stdout.
QString stdout = QString::fromUtf8( proc.readAllStandardOutput() );
- reply.addData( "stdout", stdout );
+ reply.addData( "stdout", stdout.trimmed() );
}
}
else
@@ -211,11 +211,11 @@
{
// Check if there is output on stderr.
QString stderr = QString::fromUtf8( proc.readAllStandardError() );
- reply.addData( "stderr", stderr );
+ reply.addData( "stderr", stderr.trimmed() );
// Check if there is output on stdout.
QString stdout = QString::fromUtf8( proc.readAllStandardOutput() );
- reply.addData( "stdout", stdout );
+ reply.addData( "stdout", stdout.trimmed() );
}
}
else
--
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org
