Hello community,

here is the log from the commit of package libid3tag for openSUSE:Factory 
checked in at 2012-11-24 21:49:27
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libid3tag (Old)
 and      /work/SRC/openSUSE:Factory/.libid3tag.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "libid3tag", Maintainer is "ti...@suse.com"

Changes:
--------
--- /work/SRC/openSUSE:Factory/libid3tag/libid3tag.changes      2011-11-21 
12:35:23.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.libid3tag.new/libid3tag.changes 2012-11-24 
21:49:28.000000000 +0100
@@ -1,0 +2,8 @@
+Thu Nov 22 18:26:13 UTC 2012 - crrodrig...@opensuse.org
+
+- libid3tag-visibility.patch: Hide all symbols that are not
+  part of the public API.
+- spec file: DO not inject bogus dependencies into the
+  system via pkgconfig files. 
+
+-------------------------------------------------------------------

New:
----
  libid3tag-visibility.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ libid3tag.spec ++++++
--- /var/tmp/diff_new_pack.5aKUGj/_old  2012-11-24 21:49:29.000000000 +0100
+++ /var/tmp/diff_new_pack.5aKUGj/_new  2012-11-24 21:49:29.000000000 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package libid3tag
 #
-# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -15,18 +15,17 @@
 # Please submit bugfixes or comments via http://bugs.opensuse.org/
 #
 
-# norootforbuild
-
 
 Name:           libid3tag
-BuildRequires:  gperf zlib-devel
-BuildRequires:  pkg-config
+BuildRequires:  gperf
 BuildRequires:  libtool
+BuildRequires:  pkg-config
+BuildRequires:  zlib-devel
 Summary:        ID3 Tag Manipulation Library
-Version:        0.15.1b
-Release:        169
-Group:          System/Libraries
 License:        GPL-2.0+
+Group:          System/Libraries
+Version:        0.15.1b
+Release:        0
 Url:            http://www.underbit.com/products/mad/
 Source:         %{name}-%{version}.tar.bz2
 Patch:          libid3tag-noweak.dif
@@ -35,6 +34,7 @@
 Patch3:         libid3tag-automake-fix.dif
 Patch4:         libid3tag-optflags.patch
 Patch5:         libid3tag-0.15.1b-fix_overflow.patch
+Patch6:         libid3tag-visibility.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
 %description
@@ -42,10 +42,10 @@
 the various versions of ID3v2.
 
 %package devel
-License:        GPL-2.0+
 Summary:        Development package for libid3tag library
 Group:          Development/Libraries/C and C++
-Requires:       libid3tag = %version zlib-devel
+Requires:       glibc-devel
+Requires:       libid3tag = %version
 
 %description devel
 This package contains the header files and static libraries needed to
@@ -59,12 +59,12 @@
 %patch3
 %patch4
 %patch5
-
+%patch6
 %build
-autoreconf -fi
+autoreconf -fiv
 %configure --disable-static
 make %{?jobs:-j %jobs}
-echo -e 
"prefix=%_prefix\nexec_prefix=%_prefix\nlibdir=%_libdir\nincludedir=%_includedir\nName:
 id3tag\nDescription: ID3 tag library\nRequires:\nVersion: %version\nLibs: 
-L%_libdir -lid3tag\nLibs.private: -lz\nCflags: -I%_includedir\n" > id3tag.pc
+echo -e 
"prefix=%_prefix\nexec_prefix=%_prefix\nlibdir=%_libdir\nincludedir=%_includedir\nName:
 id3tag\nDescription: ID3 tag library\nRequires:\nVersion: %version\nLibs: 
-L%_libdir -lid3tag\nCflags: -I%_includedir\n" > id3tag.pc
 
 %install
 %makeinstall
@@ -76,7 +76,7 @@
 %postun -p /sbin/ldconfig
 
 %clean
-[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
+rm -rf $RPM_BUILD_ROOT
 
 %files
 %defattr(-,root,root)

++++++ libid3tag-visibility.patch ++++++
--- configure.ac.orig
+++ configure.ac
@@ -36,7 +36,9 @@ AC_CANONICAL_HOST
 
 dnl Checks for programs.
 
-AC_PROG_CC
+AC_PROG_CC_STDC
+AC_USE_SYSTEM_EXTENSIONS
+AC_SYS_LARGEFILE
 
 if test "$GCC" = yes
 then
@@ -61,7 +63,7 @@ dnl Support for libtool.
 
 dnl AC_DISABLE_SHARED
 dnl AC_LIBTOOL_WIN32_DLL
-AC_PROG_LIBTOOL
+LT_INIT([disable-static pic-only])
 
 AC_SUBST(LIBTOOL_DEPS)
 
--- compat.h.orig
+++ compat.h
@@ -24,6 +24,8 @@
 
 # include "id3tag.h"
 
+#pragma GCC visibility push(hidden)
+
 typedef int id3_compat_func_t(struct id3_frame *, char const *,
                              id3_byte_t const *, id3_length_t);
 
@@ -38,4 +40,5 @@ struct id3_compat const *id3_compat_look
 
 int id3_compat_fixup(struct id3_tag *);
 
+#pragma GCC visibility pop
 # endif
--- crc.h.orig
+++ crc.h
@@ -23,7 +23,7 @@
 # define LIBID3TAG_CRC_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 unsigned long id3_crc_compute(id3_byte_t const *, id3_length_t);
-
+#pragma GCC visibility pop
 # endif
--- debug.h.orig
+++ debug.h
@@ -23,12 +23,12 @@
 # define LIBID3TAG_DEBUG_H
 
 # include <stdlib.h>
-
+#pragma GCC visibility push(hidden)
 void *id3_debug_malloc(size_t, char const *, unsigned int);
 void *id3_debug_calloc(size_t, size_t, char const *, unsigned int);
 void *id3_debug_realloc(void *, size_t, char const *, unsigned int);
 void id3_debug_free(void *, char const *, unsigned int);
 
 void *id3_debug_release(void *, char const *, unsigned int);
-
+#pragma GCC visibility pop
 # endif
--- field.h.orig
+++ field.h
@@ -23,7 +23,7 @@
 # define LIBID3TAG_FIELD_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 void id3_field_init(union id3_field *, enum id3_field_type);
 void id3_field_finish(union id3_field *);
 
@@ -32,5 +32,5 @@ int id3_field_parse(union id3_field *, i
 
 id3_length_t id3_field_render(union id3_field const *, id3_byte_t **,
                              enum id3_field_textencoding *, int);
-
+#pragma GCC visibility pop
 # endif
--- frame.h.orig
+++ frame.h
@@ -23,7 +23,7 @@
 # define LIBID3TAG_FRAME_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 int id3_frame_validid(char const *);
 
 void id3_frame_addref(struct id3_frame *);
@@ -32,5 +32,5 @@ void id3_frame_delref(struct id3_frame *
 struct id3_frame *id3_frame_parse(id3_byte_t const **, id3_length_t,
                                  unsigned int);
 id3_length_t id3_frame_render(struct id3_frame const *, id3_byte_t **, int);
-
+#pragma GCC visibility pop
 # endif
--- frametype.h.orig
+++ frametype.h
@@ -21,7 +21,7 @@
 
 # ifndef LIBID3TAG_FRAMETYPE_H
 # define LIBID3TAG_FRAMETYPE_H
-
+#pragma GCC visibility push(hidden)
 struct id3_frametype {
   char const *id;
   unsigned int nfields;
@@ -38,5 +38,5 @@ extern struct id3_frametype const id3_fr
 
 struct id3_frametype const *id3_frametype_lookup(register char const *,
                                                 register unsigned int);
-
+#pragma GCC visibility pop
 # endif
--- latin1.h.orig
+++ latin1.h
@@ -23,7 +23,7 @@
 # define LIBID3TAG_LATIN1_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 id3_length_t id3_latin1_length(id3_latin1_t const *);
 id3_length_t id3_latin1_size(id3_latin1_t const *);
 
@@ -41,5 +41,5 @@ id3_latin1_t id3_latin1_get(id3_byte_t c
 
 id3_length_t id3_latin1_serialize(id3_byte_t **, id3_ucs4_t const *, int);
 id3_ucs4_t *id3_latin1_deserialize(id3_byte_t const **, id3_length_t);
-
+#pragma GCC visibility pop
 # endif
--- parse.h.orig
+++ parse.h
@@ -21,7 +21,7 @@
 
 # ifndef LIBID3TAG_PARSE_H
 # define LIBID3TAG_PARSE_H
-
+#pragma GCC visibility push(hidden)
 signed long id3_parse_int(id3_byte_t const **, unsigned int);
 unsigned long id3_parse_uint(id3_byte_t const **, unsigned int);
 unsigned long id3_parse_syncsafe(id3_byte_t const **, unsigned int);
@@ -30,5 +30,5 @@ id3_latin1_t *id3_parse_latin1(id3_byte_
 id3_ucs4_t *id3_parse_string(id3_byte_t const **, id3_length_t,
                             enum id3_field_textencoding, int);
 id3_byte_t *id3_parse_binary(id3_byte_t const **, id3_length_t);
-
+#pragma GCC visibility pop
 # endif
--- render.h.orig
+++ render.h
@@ -23,7 +23,7 @@
 # define LIBID3TAG_RENDER_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 id3_length_t id3_render_immediate(id3_byte_t **, char const *, unsigned int);
 id3_length_t id3_render_syncsafe(id3_byte_t **, unsigned long, unsigned int);
 id3_length_t id3_render_int(id3_byte_t **, signed long, unsigned int);
@@ -36,5 +36,5 @@ id3_length_t id3_render_padding(id3_byte
 
 id3_length_t id3_render_paddedstring(id3_byte_t **, id3_ucs4_t const *,
                                     id3_length_t);
-
+#pragma GCC visibility pop
 # endif
--- tag.h.orig
+++ tag.h
@@ -23,8 +23,8 @@
 # define LIBID3TAG_TAG_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 void id3_tag_addref(struct id3_tag *);
 void id3_tag_delref(struct id3_tag *);
-
+#pragma GCC visibility pop
 # endif
--- ucs4.h.orig
+++ ucs4.h
@@ -25,7 +25,7 @@
 # include "id3tag.h"
 
 # define ID3_UCS4_REPLACEMENTCHAR  0x000000b7L  /* middle dot */
-
+#pragma GCC visibility push(hidden)
 extern id3_ucs4_t const id3_ucs4_empty[];
 
 id3_length_t id3_ucs4_length(id3_ucs4_t const *);
@@ -37,5 +37,5 @@ id3_length_t id3_ucs4_utf8size(id3_ucs4_
 
 void id3_ucs4_copy(id3_ucs4_t *, id3_ucs4_t const *);
 id3_ucs4_t *id3_ucs4_duplicate(id3_ucs4_t const *);
-
+#pragma GCC visibility pop
 # endif
--- utf16.h.orig
+++ utf16.h
@@ -23,7 +23,7 @@
 # define LIBID3TAG_UTF16_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 enum id3_utf16_byteorder {
   ID3_UTF16_BYTEORDER_ANY,
   ID3_UTF16_BYTEORDER_BE,
@@ -47,5 +47,5 @@ id3_length_t id3_utf16_serialize(id3_byt
                                 enum id3_utf16_byteorder, int);
 id3_ucs4_t *id3_utf16_deserialize(id3_byte_t const **, id3_length_t,
                                  enum id3_utf16_byteorder);
-
+#pragma GCC visibility pop
 # endif
--- utf8.h.orig
+++ utf8.h
@@ -23,7 +23,7 @@
 # define LIBID3TAG_UTF8_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 id3_length_t id3_utf8_length(id3_utf8_t const *);
 id3_length_t id3_utf8_size(id3_utf8_t const *);
 
@@ -38,5 +38,5 @@ id3_utf8_t id3_utf8_get(id3_byte_t const
 
 id3_length_t id3_utf8_serialize(id3_byte_t **, id3_ucs4_t const *, int);
 id3_ucs4_t *id3_utf8_deserialize(id3_byte_t const **, id3_length_t);
-
+#pragma GCC visibility pop
 # endif
--- util.h.orig
+++ util.h
@@ -23,7 +23,7 @@
 # define LIBID3TAG_UTIL_H
 
 # include "id3tag.h"
-
+#pragma GCC visibility push(hidden)
 id3_length_t id3_util_unsynchronise(id3_byte_t *, id3_length_t);
 id3_length_t id3_util_deunsynchronise(id3_byte_t *, id3_length_t);
 
@@ -31,5 +31,5 @@ id3_byte_t *id3_util_compress(id3_byte_t
                              id3_length_t *);
 id3_byte_t *id3_util_decompress(id3_byte_t const *, id3_length_t,
                                id3_length_t);
-
+#pragma GCC visibility pop
 # endif
--- Makefile.am.orig
+++ Makefile.am
@@ -93,7 +93,7 @@ EXTRA_libid3tag_la_SOURCES =  \
                        debug.c debug.h
 
 libid3tag_la_LIBADD  =  -lz
-libid3tag_la_LDFLAGS = -version-info $(version_info)
+libid3tag_la_LDFLAGS = -no-undefined -version-info $(version_info)
 
 BUILT_SOURCES =                frametype.c compat.c genre.dat
 
-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org

Reply via email to