Hello community, here is the log from the commit of package yast2-dns-server for openSUSE:Factory checked in at 2013-01-08 16:44:31 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-dns-server (Old) and /work/SRC/openSUSE:Factory/.yast2-dns-server.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-dns-server", Maintainer is "[email protected]" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-dns-server/yast2-dns-server.changes 2012-06-10 21:52:51.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-dns-server.new/yast2-dns-server.changes 2013-01-08 16:44:32.000000000 +0100 @@ -1,0 +2,19 @@ +Fri Nov 9 13:19:35 UTC 2012 - [email protected] + +- Enhanced checking for errors while writing to LDAP (bnc#768708) +- 2.23.4 + +------------------------------------------------------------------ +Wed Aug 15 16:30:42 UTC 2012 - [email protected] + +- Checking for return values while writing into LDAP and reporting + errors (bnc#768708). + +------------------------------------------------------------------ +Wed Jun 20 09:42:53 UTC 2012 - [email protected] + +- Additional fix for (bnc#765445). No error reported to stdout + even while writing /etc/named.conf without having bind package + installed. + +------------------------------------------------------------------ Old: ---- yast2-dns-server-2.23.3.tar.bz2 New: ---- yast2-dns-server-2.23.4.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-dns-server.spec ++++++ --- /var/tmp/diff_new_pack.u51O7S/_old 2013-01-08 16:44:33.000000000 +0100 +++ /var/tmp/diff_new_pack.u51O7S/_new 2013-01-08 16:44:33.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package yast2-dns-server # -# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: yast2-dns-server -Version: 2.23.3 +Version: 2.23.4 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-dns-server-2.23.3.tar.bz2 -> yast2-dns-server-2.23.4.tar.bz2 ++++++ ++++ 4124 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-dns-server-2.23.3/MAINTAINER new/yast2-dns-server-2.23.4/MAINTAINER --- old/yast2-dns-server-2.23.3/MAINTAINER 2012-06-07 16:09:12.000000000 +0200 +++ new/yast2-dns-server-2.23.4/MAINTAINER 2013-01-07 13:07:13.000000000 +0100 @@ -1 +1 @@ -Lukas Ocilka <[email protected]> +YaST2 Maintainers <[email protected]> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-dns-server-2.23.3/VERSION new/yast2-dns-server-2.23.4/VERSION --- old/yast2-dns-server-2.23.3/VERSION 2012-06-07 16:09:12.000000000 +0200 +++ new/yast2-dns-server-2.23.4/VERSION 2012-11-09 15:53:55.000000000 +0100 @@ -1 +1 @@ -2.23.3 +2.23.4 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-dns-server-2.23.3/configure.in new/yast2-dns-server-2.23.4/configure.in --- old/yast2-dns-server-2.23.3/configure.in 2012-06-07 16:10:51.000000000 +0200 +++ new/yast2-dns-server-2.23.4/configure.in 2013-01-07 13:14:50.000000000 +0100 @@ -1,9 +1,9 @@ dnl configure.in for yast2-dns-server dnl -dnl -- This file is generated by y2autoconf 2.21.9 - DO NOT EDIT! -- +dnl -- This file is generated by y2autoconf 2.23.2 - DO NOT EDIT! -- dnl (edit configure.in.in instead) -AC_INIT(yast2-dns-server, 2.23.3, http://bugs.opensuse.org/, yast2-dns-server) +AC_INIT(yast2-dns-server, 2.23.4, http://bugs.opensuse.org/, yast2-dns-server) dnl Check for presence of file 'RPMNAME' AC_CONFIG_SRCDIR([RPMNAME]) @@ -18,9 +18,9 @@ AM_INIT_AUTOMAKE(tar-ustar -Wno-portability) dnl Important YaST2 variables -VERSION="2.23.3" +VERSION="2.23.4" RPMNAME="yast2-dns-server" -MAINTAINER="Lukas Ocilka <[email protected]>" +MAINTAINER="YaST2 Maintainers <[email protected]>" dnl pkgconfig honors lib64 pkgconfigdir=\${libdir}/pkgconfig diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-dns-server-2.23.3/missing new/yast2-dns-server-2.23.4/missing --- old/yast2-dns-server-2.23.3/missing 2012-06-07 16:10:54.000000000 +0200 +++ new/yast2-dns-server-2.23.4/missing 2013-01-07 13:14:53.000000000 +0100 @@ -1,10 +1,9 @@ #! /bin/sh # Common stub for a few missing GNU programs while installing. -scriptversion=2009-04-28.21; # UTC +scriptversion=2012-01-06.18; # UTC -# Copyright (C) 1996, 1997, 1999, 2000, 2002, 2003, 2004, 2005, 2006, -# 2008, 2009 Free Software Foundation, Inc. +# Copyright (C) 1996-2012 Free Software Foundation, Inc. # Originally by Fran,cois Pinard <[email protected]>, 1996. # This program is free software; you can redistribute it and/or modify @@ -26,7 +25,7 @@ # the same distribution terms that you use for the rest of that program. if test $# -eq 0; then - echo 1>&2 "Try \`$0 --help' for more information" + echo 1>&2 "Try '$0 --help' for more information" exit 1 fi @@ -34,7 +33,7 @@ sed_output='s/.* --output[ =]\([^ ]*\).*/\1/p' sed_minuso='s/.* -o \([^ ]*\).*/\1/p' -# In the cases where this matters, `missing' is being run in the +# In the cases where this matters, 'missing' is being run in the # srcdir already. if test -f configure.ac; then configure_ac=configure.ac @@ -65,7 +64,7 @@ echo "\ $0 [OPTION]... PROGRAM [ARGUMENT]... -Handle \`PROGRAM [ARGUMENT]...' for when PROGRAM is missing, or return an +Handle 'PROGRAM [ARGUMENT]...' for when PROGRAM is missing, or return an error status if there is no known handling for PROGRAM. Options: @@ -74,21 +73,20 @@ --run try to run the given command, and emulate it if it fails Supported PROGRAM values: - aclocal touch file \`aclocal.m4' - autoconf touch file \`configure' - autoheader touch file \`config.h.in' + aclocal touch file 'aclocal.m4' + autoconf touch file 'configure' + autoheader touch file 'config.h.in' autom4te touch the output file, or create a stub one - automake touch all \`Makefile.in' files - bison create \`y.tab.[ch]', if possible, from existing .[ch] - flex create \`lex.yy.c', if possible, from existing .c + automake touch all 'Makefile.in' files + bison create 'y.tab.[ch]', if possible, from existing .[ch] + flex create 'lex.yy.c', if possible, from existing .c help2man touch the output file - lex create \`lex.yy.c', if possible, from existing .c + lex create 'lex.yy.c', if possible, from existing .c makeinfo touch the output file - tar try tar, gnutar, gtar, then tar without non-portable flags - yacc create \`y.tab.[ch]', if possible, from existing .[ch] + yacc create 'y.tab.[ch]', if possible, from existing .[ch] -Version suffixes to PROGRAM as well as the prefixes \`gnu-', \`gnu', and -\`g' are ignored when checking the name. +Version suffixes to PROGRAM as well as the prefixes 'gnu-', 'gnu', and +'g' are ignored when checking the name. Send bug reports to <[email protected]>." exit $? @@ -100,8 +98,8 @@ ;; -*) - echo 1>&2 "$0: Unknown \`$1' option" - echo 1>&2 "Try \`$0 --help' for more information" + echo 1>&2 "$0: Unknown '$1' option" + echo 1>&2 "Try '$0 --help' for more information" exit 1 ;; @@ -122,22 +120,13 @@ # Not GNU programs, they don't have --version. ;; - tar*) - if test -n "$run"; then - echo 1>&2 "ERROR: \`tar' requires --run" - exit 1 - elif test "x$2" = "x--version" || test "x$2" = "x--help"; then - exit 1 - fi - ;; - *) if test -z "$run" && ($1 --version) > /dev/null 2>&1; then # We have it, but it failed. exit 1 elif test "x$2" = "x--version" || test "x$2" = "x--help"; then # Could not run --version or --help. This is probably someone - # running `$TOOL --version' or `$TOOL --help' to check whether + # running '$TOOL --version' or '$TOOL --help' to check whether # $TOOL exists and not knowing $TOOL uses missing. exit 1 fi @@ -149,27 +138,27 @@ case $program in aclocal*) echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified \`acinclude.m4' or \`${configure_ac}'. You might want - to install the \`Automake' and \`Perl' packages. Grab them from +WARNING: '$1' is $msg. You should only need it if + you modified 'acinclude.m4' or '${configure_ac}'. You might want + to install the Automake and Perl packages. Grab them from any GNU archive site." touch aclocal.m4 ;; autoconf*) echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified \`${configure_ac}'. You might want to install the - \`Autoconf' and \`GNU m4' packages. Grab them from any GNU +WARNING: '$1' is $msg. You should only need it if + you modified '${configure_ac}'. You might want to install the + Autoconf and GNU m4 packages. Grab them from any GNU archive site." touch configure ;; autoheader*) echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified \`acconfig.h' or \`${configure_ac}'. You might want - to install the \`Autoconf' and \`GNU m4' packages. Grab them +WARNING: '$1' is $msg. You should only need it if + you modified 'acconfig.h' or '${configure_ac}'. You might want + to install the Autoconf and GNU m4 packages. Grab them from any GNU archive site." files=`sed -n 's/^[ ]*A[CM]_CONFIG_HEADER(\([^)]*\)).*/\1/p' ${configure_ac}` test -z "$files" && files="config.h" @@ -186,9 +175,9 @@ automake*) echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified \`Makefile.am', \`acinclude.m4' or \`${configure_ac}'. - You might want to install the \`Automake' and \`Perl' packages. +WARNING: '$1' is $msg. You should only need it if + you modified 'Makefile.am', 'acinclude.m4' or '${configure_ac}'. + You might want to install the Automake and Perl packages. Grab them from any GNU archive site." find . -type f -name Makefile.am -print | sed 's/\.am$/.in/' | @@ -197,10 +186,10 @@ autom4te*) echo 1>&2 "\ -WARNING: \`$1' is needed, but is $msg. +WARNING: '$1' is needed, but is $msg. You might have modified some files without having the proper tools for further handling them. - You can get \`$1' as part of \`Autoconf' from any GNU + You can get '$1' as part of Autoconf from any GNU archive site." file=`echo "$*" | sed -n "$sed_output"` @@ -220,13 +209,13 @@ bison*|yacc*) echo 1>&2 "\ -WARNING: \`$1' $msg. You should only need it if - you modified a \`.y' file. You may need the \`Bison' package +WARNING: '$1' $msg. You should only need it if + you modified a '.y' file. You may need the Bison package in order for those modifications to take effect. You can get - \`Bison' from any GNU archive site." + Bison from any GNU archive site." rm -f y.tab.c y.tab.h if test $# -ne 1; then - eval LASTARG="\${$#}" + eval LASTARG=\${$#} case $LASTARG in *.y) SRCFILE=`echo "$LASTARG" | sed 's/y$/c/'` @@ -250,13 +239,13 @@ lex*|flex*) echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified a \`.l' file. You may need the \`Flex' package +WARNING: '$1' is $msg. You should only need it if + you modified a '.l' file. You may need the Flex package in order for those modifications to take effect. You can get - \`Flex' from any GNU archive site." + Flex from any GNU archive site." rm -f lex.yy.c if test $# -ne 1; then - eval LASTARG="\${$#}" + eval LASTARG=\${$#} case $LASTARG in *.l) SRCFILE=`echo "$LASTARG" | sed 's/l$/c/'` @@ -273,10 +262,10 @@ help2man*) echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if +WARNING: '$1' is $msg. You should only need it if you modified a dependency of a manual page. You may need the - \`Help2man' package in order for those modifications to take - effect. You can get \`Help2man' from any GNU archive site." + Help2man package in order for those modifications to take + effect. You can get Help2man from any GNU archive site." file=`echo "$*" | sed -n "$sed_output"` test -z "$file" && file=`echo "$*" | sed -n "$sed_minuso"` @@ -291,12 +280,12 @@ makeinfo*) echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified a \`.texi' or \`.texinfo' file, or any other file +WARNING: '$1' is $msg. You should only need it if + you modified a '.texi' or '.texinfo' file, or any other file indirectly affecting the aspect of the manual. The spurious - call might also be the consequence of using a buggy \`make' (AIX, - DU, IRIX). You might want to install the \`Texinfo' package or - the \`GNU make' package. Grab either from any GNU archive site." + call might also be the consequence of using a buggy 'make' (AIX, + DU, IRIX). You might want to install the Texinfo package or + the GNU make package. Grab either from any GNU archive site." # The file to touch is that specified with -o ... file=`echo "$*" | sed -n "$sed_output"` test -z "$file" && file=`echo "$*" | sed -n "$sed_minuso"` @@ -318,49 +307,14 @@ touch $file ;; - tar*) - shift - - # We have already tried tar in the generic part. - # Look for gnutar/gtar before invocation to avoid ugly error - # messages. - if (gnutar --version > /dev/null 2>&1); then - gnutar "$@" && exit 0 - fi - if (gtar --version > /dev/null 2>&1); then - gtar "$@" && exit 0 - fi - firstarg="$1" - if shift; then - case $firstarg in - *o*) - firstarg=`echo "$firstarg" | sed s/o//` - tar "$firstarg" "$@" && exit 0 - ;; - esac - case $firstarg in - *h*) - firstarg=`echo "$firstarg" | sed s/h//` - tar "$firstarg" "$@" && exit 0 - ;; - esac - fi - - echo 1>&2 "\ -WARNING: I can't seem to be able to run \`tar' with the given arguments. - You may want to install GNU tar or Free paxutils, or check the - command line arguments." - exit 1 - ;; - *) echo 1>&2 "\ -WARNING: \`$1' is needed, and is $msg. +WARNING: '$1' is needed, and is $msg. You might have modified some files without having the - proper tools for further handling them. Check the \`README' file, + proper tools for further handling them. Check the 'README' file, it often tells you about the needed prerequisites for installing this package. You may also peek at any GNU archive site, in case - some other package would contain this missing \`$1' program." + some other package would contain this missing '$1' program." exit 1 ;; esac diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-dns-server-2.23.3/src/DnsServer.pm new/yast2-dns-server-2.23.4/src/DnsServer.pm --- old/yast2-dns-server-2.23.3/src/DnsServer.pm 2012-06-07 16:09:12.000000000 +0200 +++ new/yast2-dns-server-2.23.4/src/DnsServer.pm 2012-11-09 15:53:55.000000000 +0100 @@ -402,7 +402,11 @@ my %zone = %{$_}; $zone{"zone"}; } @zones; - DnsZones->ZonesDeleteLdap (\@zone_names); + + unless (DnsZones->ZonesDeleteLdap (\@zone_names)) { + y2error ("Cannot delete selected zones"); + return 0; + } } # delete all removed options @@ -1322,8 +1326,12 @@ ### Bugzilla #46121, Configuration file changed by hand, INI-Agent would break my $new_configuration_timestamp = $self->GetConfigurationStat(); my $yast2_suffix = ".yast2-save"; + # timestamp differs from the Read() - if ($new_configuration_timestamp ne $configuration_timestamp) { + if (defined $configuration_timestamp + and defined $new_configuration_timestamp + and $configuration_timestamp ne $new_configuration_timestamp + ) { y2warning("Stat of the configuration file was changed during the YaST2 configuration"); # moving into yast2-save file my $ret = SCR->Execute (".target.bash_output", "mv --force ".$configfile." ".$configfile.$yast2_suffix); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-dns-server-2.23.3/src/DnsZones.pm new/yast2-dns-server-2.23.4/src/DnsZones.pm --- old/yast2-dns-server-2.23.3/src/DnsZones.pm 2012-06-07 16:09:12.000000000 +0200 +++ new/yast2-dns-server-2.23.4/src/DnsZones.pm 2012-11-09 15:53:55.000000000 +0100 @@ -25,6 +25,7 @@ YaST::YCP::Import ("Hostname"); YaST::YCP::Import ("String"); YaST::YCP::Import ("Mode"); +YaST::YCP::Import ("Ldap"); #use io_routines; #use check_routines; @@ -690,16 +691,22 @@ } y2debug ("New base record: ".Dumper(\%ldap_record)); + my $ldap_write = 1; if (scalar (@{$found_ref || []}) == 0) { y2milestone ("Creating new zone record"); - SCR->Write (".ldap.add", \%ldap_cmd, \%ldap_record); + $ldap_write = SCR->Write(".ldap.add", \%ldap_cmd, \%ldap_record); } else { y2milestone ("Modifying existing zone record"); delete $ldap_record{"objectClass"}; # objectclass can be changed by mail-server - SCR->Write (".ldap.modify", \%ldap_cmd, \%ldap_record); + $ldap_write = SCR->Write(".ldap.modify", \%ldap_cmd, \%ldap_record); + } + unless ($ldap_write) { + y2error("LDAP Error (write): ".Ldap->LDAPError()); + Ldap->LDAPErrorMessage('write', Ldap->LDAPError()); + return 0; } my @all_records = map { @@ -741,7 +748,13 @@ foreach my $d (@deleted) { y2milestone ("Removing all records regarding $d"); - SCR->Write (".ldap.delete", {"dn" => "relativeDomainName=$d,$zone_dn"}); + $ldap_write = SCR->Write(".ldap.delete", {"dn" => "relativeDomainName=$d,$zone_dn"}); + last unless $ldap_write; # skip the rest + } + unless ($ldap_write) { + y2error("LDAP Error (delete): ".Ldap->LDAPError()); + Ldap->LDAPErrorMessage('write', Ldap->LDAPError()); + return 0; } # write all the other records @@ -797,14 +810,22 @@ if (scalar (@{$found_ref || []}) == 0) { - SCR->Write (".ldap.add", \%ldap_cmd, \%ldap_record); + $ldap_write = SCR->Write (".ldap.add", \%ldap_cmd, \%ldap_record); + last unless $ldap_write; # skip the rest } else { - SCR->Write (".ldap.modify", \%ldap_cmd, \%ldap_record); + $ldap_write = SCR->Write (".ldap.modify", \%ldap_cmd, \%ldap_record); + last unless $ldap_write; # skip the rest } } - return 1; + unless ($ldap_write) { + y2error("LDAP Error (write): ".Ldap->LDAPError()); + Ldap->LDAPErrorMessage('write', Ldap->LDAPError()); + return 0; + } + + return $ldap_write; } BEGIN { $TYPEINFO{ZonesDeleteLdap} = ["function", "boolean", [ "list", "string",]];} @@ -821,14 +842,24 @@ @check_zones == 0; } @current_zones_in_ldap; + my $ldap_write = 1; + foreach my $z (@zones_to_delete) { y2milestone ("Removing zone $z from LDAP"); my %request = ( "dn" => "zoneName=$z,$zone_base_config_dn", "subtree" => 1, ); - SCR->Write (".ldap.delete", \%request); + $ldap_write = SCR->Write (".ldap.delete", \%request); + + unless ($ldap_write) { + y2error("LDAP Error (write): ".Ldap->LDAPError()); + Ldap->LDAPErrorMessage('write', Ldap->LDAPError()); + last; + } } + + return $ldap_write; } BEGIN{ $TYPEINFO{ZonesListLdap} = ["function", ["list", "string"]];} -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
