Hello community,

here is the log from the commit of package virt-viewer for openSUSE:Factory 
checked in at 2013-01-17 10:55:15
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/virt-viewer (Old)
 and      /work/SRC/openSUSE:Factory/.virt-viewer.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "virt-viewer", Maintainer is "[email protected]"

Changes:
--------
--- /work/SRC/openSUSE:Factory/virt-viewer/virt-viewer.changes  2012-12-05 
14:10:15.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.virt-viewer.new/virt-viewer.changes     
2013-01-17 10:55:17.000000000 +0100
@@ -1,0 +2,11 @@
+Wed Jan  2 14:12:13 MST 2013 - [email protected]
+
+- Enable virt-viewer to be built for s390x
+
+-------------------------------------------------------------------
+Thu Dec  6 13:41:22 MST 2012 - [email protected]
+
+- Upstream bug fix
+  virtview-git-transport-segv.patch 
+
+-------------------------------------------------------------------

New:
----
  virtview-git-transport-segv.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ virt-viewer.spec ++++++
--- /var/tmp/diff_new_pack.exVc9C/_old  2013-01-17 10:55:19.000000000 +0100
+++ /var/tmp/diff_new_pack.exVc9C/_new  2013-01-17 10:55:19.000000000 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package virt-viewer
 #
-# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -28,13 +28,14 @@
 Patch2:         virtview-git-spice-rounding.patch
 Patch3:         virtview-git-spice-resize-window.patch
 Patch4:         virtview-git-ssh-localhost-connect.patch
+Patch5:         virtview-git-transport-segv.patch
 Patch20:        netcat.diff
 Patch21:        windows-keycombo.patch
 Patch22:        netware-keycombo.patch
 Patch23:        glade-keycombo.patch
 Patch24:        report-error.patch
 Patch25:        virtview-desktop.patch
-ExclusiveArch:  %ix86 x86_64
+ExclusiveArch:  %ix86 x86_64 s390x
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 BuildRequires:  automake
 BuildRequires:  gtk2-devel
@@ -53,7 +54,7 @@
 BuildRequires:  intltool
 # Our build requirements
 BuildRequires:  vim
-BuildRequires:  xen-devel
+#BuildRequires:  xen-devel
 Requires:       netcat
 
 %description
@@ -68,6 +69,7 @@
 %patch2 -p1
 %patch3 -p1
 %patch4 -p1
+%patch5 -p1
 %patch20 -p1
 %patch21 -p1
 %patch22 -p1

++++++ virtview-git-transport-segv.patch ++++++

Subject: Don't SIGSEGV if no transport is used.
From: Michal Privoznik [email protected] Wed Nov 14 15:20:58 2012 +0100
Date: Wed Nov 14 15:20:58 2012 +0100:
Git: 9983fe74dd7eae1fac17bafa31ae44995ce28769

One of previous commits (74b1b62510d939) allowed us to connect to
localhost directly if ssh transport was used. However, if there's
not transport, we SIGSEGV'ed as g_str_equal doesn't like NULL as
one of arguments. Change this to g_strcmp0 which does the same
service but is more friendly to NULL arguments.

Index: virt-viewer-0.5.4/src/virt-viewer.c
===================================================================
--- virt-viewer-0.5.4.orig/src/virt-viewer.c
+++ virt-viewer-0.5.4/src/virt-viewer.c
@@ -376,7 +376,7 @@ virt_viewer_extract_connect_info(VirtVie
      */
     if (virt_viewer_replace_host(ghost)) {
         gchar *replacement_host = NULL;
-        if (g_str_equal(transport, "ssh")) {
+        if (g_strcmp0(transport, "ssh") == 0) {
             replacement_host = g_strdup("localhost");
         } else {
             replacement_host = g_strdup(host);
-- 
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to