Hello community, here is the log from the commit of package perl-Email-Valid for openSUSE:Factory checked in at 2013-06-06 12:20:08 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-Email-Valid (Old) and /work/SRC/openSUSE:Factory/.perl-Email-Valid.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Email-Valid" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-Email-Valid/perl-Email-Valid.changes 2012-02-27 18:35:43.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.perl-Email-Valid.new/perl-Email-Valid.changes 2013-06-06 12:20:09.000000000 +0200 @@ -1,0 +2,12 @@ +Tue Jun 4 08:43:46 UTC 2013 - [email protected] + +- updated to 0.190 + fix skip test count + + addresses in the form rjbs@[1.2.3.4], when allowed by allow_ip, + are not failed for the tld check (reported by Marcel Grünauer) + + fix [rt.cpan.org #75736], in which [email protected] was considered + invalid (thanks for the fix from Steve Bertrand) + +------------------------------------------------------------------- Old: ---- Email-Valid-0.187.tar.gz New: ---- Email-Valid-0.190.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-Email-Valid.spec ++++++ --- /var/tmp/diff_new_pack.Whc0lA/_old 2013-06-06 12:20:10.000000000 +0200 +++ /var/tmp/diff_new_pack.Whc0lA/_new 2013-06-06 12:20:10.000000000 +0200 @@ -1,7 +1,7 @@ # # spec file for package perl-Email-Valid # -# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: perl-Email-Valid -Version: 0.187 +Version: 0.190 Release: 0 %define cpan_name Email-Valid Summary: Check validity of Internet email addresses @@ -33,7 +33,7 @@ BuildRequires: perl(Net::DNS) #BuildRequires: perl(Email::Valid) #BuildRequires: perl(IO::CaptureOutput) -#BuildRequires: perl(Net::Domain::TLD) +#BuildRequires: perl(Net::Domain::TLD) >= 1.65 Requires: perl(Mail::Address) Requires: perl(Net::DNS) %{perl_requires} @@ -53,7 +53,7 @@ %{__make} %{?_smp_mflags} %check -#broken %{__make} test +%{__make} test %install %perl_make_install ++++++ Email-Valid-0.187.tar.gz -> Email-Valid-0.190.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Email-Valid-0.187/Changes new/Email-Valid-0.190/Changes --- old/Email-Valid-0.187/Changes 2012-01-27 17:23:47.000000000 +0100 +++ new/Email-Valid-0.190/Changes 2012-03-27 02:03:47.000000000 +0200 @@ -1,5 +1,16 @@ Revision history for Perl extension Email::Valid. +0.190 2012-03-26 + fix skip test count + +0.189 2012-03-26 + addresses in the form rjbs@[1.2.3.4], when allowed by allow_ip, + are not failed for the tld check (reported by Marcel Grünauer) + +0.188 2012-03-15 + fix [rt.cpan.org #75736], in which [email protected] was considered + invalid (thanks for the fix from Steve Bertrand) + 0.187 2012-01-27 addresses in the form rjbs@[1.2.3.4] are now (correctly) considered valid; this can be disabled with the -allow_ip option diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Email-Valid-0.187/META.json new/Email-Valid-0.190/META.json --- old/Email-Valid-0.187/META.json 2012-01-27 17:28:09.000000000 +0100 +++ new/Email-Valid-0.190/META.json 2012-03-27 02:04:21.000000000 +0200 @@ -4,7 +4,7 @@ "unknown" ], "dynamic_config" : 1, - "generated_by" : "ExtUtils::MakeMaker version 6.62, CPAN::Meta::Converter version 2.113640", + "generated_by" : "ExtUtils::MakeMaker version 6.62, CPAN::Meta::Converter version 2.120351", "license" : [ "perl_5" ], @@ -22,20 +22,20 @@ "prereqs" : { "build" : { "requires" : { - "ExtUtils::MakeMaker" : 0 + "ExtUtils::MakeMaker" : "0" } }, "configure" : { "requires" : { - "ExtUtils::MakeMaker" : 0 + "ExtUtils::MakeMaker" : "0" } }, "runtime" : { "requires" : { - "Mail::Address" : 0, - "Net::DNS" : 0, - "Scalar::Util" : 0, - "Test::More" : 0, + "Mail::Address" : "0", + "Net::DNS" : "0", + "Scalar::Util" : "0", + "Test::More" : "0", "perl" : "5.006" } } @@ -46,5 +46,5 @@ "url" : "http://github.com/rjbs/email-valid"; } }, - "version" : "0.187" + "version" : "0.190" } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Email-Valid-0.187/META.yml new/Email-Valid-0.190/META.yml --- old/Email-Valid-0.187/META.yml 2012-01-27 17:28:08.000000000 +0100 +++ new/Email-Valid-0.190/META.yml 2012-03-27 02:04:21.000000000 +0200 @@ -7,7 +7,7 @@ configure_requires: ExtUtils::MakeMaker: 0 dynamic_config: 1 -generated_by: 'ExtUtils::MakeMaker version 6.62, CPAN::Meta::Converter version 2.113640' +generated_by: 'ExtUtils::MakeMaker version 6.62, CPAN::Meta::Converter version 2.120351' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -25,4 +25,4 @@ perl: 5.006 resources: repository: http://github.com/rjbs/email-valid -version: 0.187 +version: 0.190 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Email-Valid-0.187/lib/Email/Valid.pm new/Email-Valid-0.190/lib/Email/Valid.pm --- old/Email-Valid-0.187/lib/Email/Valid.pm 2012-01-27 17:27:00.000000000 +0100 +++ new/Email-Valid-0.190/lib/Email/Valid.pm 2012-03-27 02:03:54.000000000 +0200 @@ -14,7 +14,7 @@ use bytes; -$VERSION = '0.187'; +$VERSION = '0.190'; %AUTOLOAD = ( fqdn => 1, @@ -286,7 +286,7 @@ sub _valid_local_part { my ($self, $localpart) = @_; - return 0 unless $localpart and length $localpart <= 64; + return 0 unless defined $localpart and length $localpart <= 64; return 1; } @@ -358,7 +358,7 @@ unless $ip_ok || ($domain_parts && $domain_parts > 1); } - if ($args{tldcheck}) { + if (! $ip_ok && $args{tldcheck}) { $self->tld( $addr->host ) or return $self->details('tldcheck'); } @@ -553,11 +553,6 @@ value) by manipulating the global Net::DNS::Resolver instance stored in $Email::Valid::Resolver. -=item tld ( <ADDRESS> ) - -This method determines whether the domain part of an address is in a recognized -top-level domain. - =item rfc822 ( <ADDRESS> ) This method determines whether an address conforms to the RFC822 @@ -590,6 +585,15 @@ words, if you have set C<allow_ip> and the address ends in a bracketed IP address, the FQDN check will not occur. +=item tld ( <ADDRESS> ) + +This method determines whether the domain part of an address is in a +recognized top-level domain. + +B<Please note!> TLD checks only occur for non-domain-literals. In other +words, if you have set C<allow_ip> and the address ends in a bracketed IP +address, the TLD check will not occur. + =item local_rules ( <TRUE>|<FALSE> ) Specifies whether addresses passed to address() should be tested diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Email-Valid-0.187/t/valid.t new/Email-Valid-0.190/t/valid.t --- old/Email-Valid-0.187/t/valid.t 2012-01-27 17:27:27.000000000 +0100 +++ new/Email-Valid-0.190/t/valid.t 2012-03-27 02:03:30.000000000 +0200 @@ -1,7 +1,7 @@ #!perl use strict; -use Test::More tests => 31; +use Test::More tests => 34; BEGIN { use_ok('Email::Valid'); @@ -80,6 +80,18 @@ "space between @ and domain is valid", ); +is( + $v->address(-address => '[email protected]', -localpart => 1), + '[email protected]', + "localpart in true context succeeds", +); + +is( + $v->address(-address => '[email protected]', -localpart => 1), + '[email protected]', + "localpart in false context is defined (bug 75736)", +); + ok( $v->address('[email protected]'), 'an email can start with a dash', @@ -147,20 +159,39 @@ ); SKIP: { - skip "tests require Net::Domain::TLD 1.65", 3 + skip "tests require Net::Domain::TLD 1.65", 4 unless (eval {require Net::Domain::TLD;Net::Domain::TLD->VERSION(1.65);1}); - my $v = Email::Valid->new; + { + my $v = Email::Valid->new; - ok( - $v->address( -address => '[email protected]', -mxcheck => 0, -tldcheck => 1), - '[email protected] is ok with tldcheck', - ); + ok( + $v->address( + -address => '[email protected]', + -mxcheck => 0, + -tldcheck => 1, + ), + '[email protected] is ok with tldcheck', + ); + + ok( + ! $v->address( + -address => '[email protected]', + -mxcheck => 0, + -tldcheck => 1, + ), + '[email protected] is not ok with tldcheck', + ); + + is($v->details, 'tldcheck', "it was the tldcheck that broke this email"); + } ok( - ! $v->address( -address => '[email protected]', -mxcheck => 0, -tldcheck => 1), - '[email protected] is not ok with tldcheck', + Email::Valid->address( + -tldcheck => 1, + -allow_ip => 1, + -address => q!foo@[1.2.3.4]!, + ), + "allow_ip + domain literal = no tldcheck", ); - - is($v->details, 'tldcheck', "it was the tldcheck that broke this email"); } -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
