Hello community,
here is the log from the commit of package perl-Test-Spelling for
openSUSE:Factory checked in at 2013-06-06 12:57:42
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Test-Spelling (Old)
and /work/SRC/openSUSE:Factory/.perl-Test-Spelling.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Test-Spelling"
Changes:
--------
--- /work/SRC/openSUSE:Factory/perl-Test-Spelling/perl-Test-Spelling.changes
2011-12-21 10:02:53.000000000 +0100
+++
/work/SRC/openSUSE:Factory/.perl-Test-Spelling.new/perl-Test-Spelling.changes
2013-06-06 12:57:44.000000000 +0200
@@ -1,0 +2,24 @@
+Tue Jun 4 15:08:59 UTC 2013 - [email protected]
+
+- updated to 0.19
+ - for more consistent results avoid using the user's local aspell
+ dictionary [rt.cpan.org #56483] (Karen Etheridge)
+
+ - Work around Pod::Spell limitations (David Golden)
+ - Improve case handling (David Golden)
+ - Improve test failure reporting (Karen Etheridge)
+ - Include more useful info in Test-Spelling's own test
+ suite (Shawn Moore)
+
+ - Use IPC::Run3 instead of IPC::Open3
+ Quoth IPC::Open3:
+ If you try to read from the child's stdout writer
+ and their stderr writer, you'll have problems with
+ blocking ... This is very dangerous, as you may
+ block forever.
+ Also the code is nicely shorter. (Randy Stauner)
+
+ - Allow use of a custom POD parser rather than Pod::Spell
+ using set_pod_parser (Thomas Sibley)
+
+-------------------------------------------------------------------
Old:
----
Test-Spelling-0.15.tar.gz
New:
----
Test-Spelling-0.19.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Test-Spelling.spec ++++++
--- /var/tmp/diff_new_pack.piRuxV/_old 2013-06-06 12:57:44.000000000 +0200
+++ /var/tmp/diff_new_pack.piRuxV/_new 2013-06-06 12:57:44.000000000 +0200
@@ -1,7 +1,7 @@
#
# spec file for package perl-Test-Spelling
#
-# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: perl-Test-Spelling
-Version: 0.15
+Version: 0.19
Release: 0
%define cpan_name Test-Spelling
Summary: check for spelling errors in POD files
@@ -29,6 +29,7 @@
BuildRoot: %{_tmppath}/%{name}-%{version}-build
BuildRequires: perl
BuildRequires: perl-macros
+BuildRequires: perl(IPC::Run3) >= 0.044
BuildRequires: perl(Pod::Spell) >= 1.01
BuildRequires: perl(Test::More) >= 0.88
BuildRequires: perl(Test::Tester)
@@ -43,6 +44,7 @@
#BuildRequires: perl(Parse::CPAN::Meta)
#BuildRequires: perl(Test::Spelling)
#BuildRequires: perl(YAML::Tiny)
+Requires: perl(IPC::Run3) >= 0.044
Requires: perl(Pod::Spell) >= 1.01
%{perl_requires}
++++++ Test-Spelling-0.15.tar.gz -> Test-Spelling-0.19.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/.prove
new/Test-Spelling-0.19/.prove
--- old/Test-Spelling-0.15/.prove 1970-01-01 01:00:00.000000000 +0100
+++ new/Test-Spelling-0.19/.prove 2013-04-26 16:50:23.000000000 +0200
@@ -0,0 +1,72 @@
+---
+generation: 8
+last_run_time: 1366987823.5195
+tests:
+ t/basic.t:
+ elapsed: 0.0465278625488281
+ gen: 8
+ last_fail_time: 1366987823.46117
+ last_pass_time: 1366987750.13305
+ last_result: 15
+ last_run_time: 1366987823.46117
+ last_todo: 0
+ mtime: 1356046620
+ seq: 46
+ total_failures: 5
+ total_passes: 3
+ t/fake_checker.t:
+ elapsed: 0.0521571636199951
+ gen: 8
+ last_fail_time: 1366987823.45588
+ last_pass_time: 1366987750.13592
+ last_result: 15
+ last_run_time: 1366987823.45588
+ last_todo: 0
+ mtime: 1366986959
+ seq: 45
+ total_failures: 5
+ total_passes: 3
+ t/load.t:
+ elapsed: 0.00190591812133789
+ gen: 8
+ last_pass_time: 1366987823.41582
+ last_result: 0
+ last_run_time: 1366987823.41582
+ last_todo: 0
+ mtime: 1366987242
+ seq: 43
+ total_passes: 8
+ t/pod-spell.t:
+ elapsed: 0.0302088260650635
+ gen: 8
+ last_pass_time: 1366987823.51709
+ last_result: 0
+ last_run_time: 1366987823.51709
+ last_todo: 0
+ mtime: 1356046620
+ seq: 48
+ total_passes: 8
+ t/pod.t:
+ elapsed: 0.0278980731964111
+ gen: 8
+ last_pass_time: 1366987823.50121
+ last_result: 0
+ last_run_time: 1366987823.50121
+ last_todo: 0
+ mtime: 1356046620
+ seq: 47
+ total_passes: 8
+ t/stopword.t:
+ elapsed: 0.0294508934020996
+ gen: 8
+ last_fail_time: 1366987823.4445
+ last_pass_time: 1366987750.10773
+ last_result: 11
+ last_run_time: 1366987823.4445
+ last_todo: 0
+ mtime: 1366986959
+ seq: 44
+ total_failures: 5
+ total_passes: 3
+version: 1
+...
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/Changes
new/Test-Spelling-0.19/Changes
--- old/Test-Spelling-0.15/Changes 2011-08-22 23:13:05.000000000 +0200
+++ new/Test-Spelling-0.19/Changes 2013-05-05 17:03:47.000000000 +0200
@@ -1,5 +1,29 @@
Revision history for Test-Spelling
+0.19 2013-05-05
+ - for more consistent results avoid using the user's local aspell
+ dictionary [rt.cpan.org #56483] (Karen Etheridge)
+
+0.18 2013-04-26
+ - Work around Pod::Spell limitations (David Golden)
+ - Improve case handling (David Golden)
+ - Improve test failure reporting (Karen Etheridge)
+ - Include more useful info in Test-Spelling's own test
+ suite (Shawn Moore)
+
+0.17 2012-01-27
+ - Use IPC::Run3 instead of IPC::Open3
+ Quoth IPC::Open3:
+ If you try to read from the child's stdout writer
+ and their stderr writer, you'll have problems with
+ blocking ... This is very dangerous, as you may
+ block forever.
+ Also the code is nicely shorter. (Randy Stauner)
+
+0.16 2012-12-20
+ - Allow use of a custom POD parser rather than Pod::Spell
+ using set_pod_parser (Thomas Sibley)
+
0.15 2011-08-22
- Begin adding actual tests
(Hilariously, adding the suggested t/pod-spell.t to this
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/MANIFEST
new/Test-Spelling-0.19/MANIFEST
--- old/Test-Spelling-0.15/MANIFEST 2011-08-22 23:13:38.000000000 +0200
+++ new/Test-Spelling-0.19/MANIFEST 2013-05-05 17:04:17.000000000 +0200
@@ -1,3 +1,4 @@
+.prove
Changes
inc/Module/Install.pm
inc/Module/Install/AutoManifest.pm
@@ -20,6 +21,7 @@
t/corpus/good-pod.pm
t/corpus/no-pod.pm
t/corpus/stopword.pm
+t/fake_checker.t
t/load.t
t/pod-spell.t
t/pod.t
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/META.yml
new/Test-Spelling-0.19/META.yml
--- old/Test-Spelling-0.15/META.yml 2011-08-22 23:13:35.000000000 +0200
+++ new/Test-Spelling-0.19/META.yml 2013-05-05 17:03:57.000000000 +0200
@@ -3,13 +3,14 @@
author:
- ', Ivan Tubert-Brohman, All Rights Reserved.'
build_requires:
- ExtUtils::MakeMaker: 6.42
+ ExtUtils::MakeMaker: 6.59
Test::More: 0.88
Test::Tester: 0
configure_requires:
- ExtUtils::MakeMaker: 6.42
+ ExtUtils::MakeMaker: 6.59
distribution_type: module
-generated_by: 'Module::Install version 1.01'
+dynamic_config: 1
+generated_by: 'Module::Install version 1.06'
license: perl
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -20,13 +21,11 @@
- inc
- t
requires:
+ IPC::Run3: 0.044
Pod::Spell: 1.01
perl: 5.6.0
resources:
- homepage: http://github.com/sartak/test-spelling/tree
+ homepage: https://github.com/sartak/test-spelling/tree
license: http://dev.perl.org/licenses/
- repository:
- type: git
- url: git://github.com/sartak/test-spelling.git
- web: http://github.com/sartak/test-spelling/tree
-version: 0.15
+ repository: git://github.com/sartak/test-spelling.git
+version: 0.19
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/Makefile.PL
new/Test-Spelling-0.19/Makefile.PL
--- old/Test-Spelling-0.15/Makefile.PL 2011-08-22 23:02:58.000000000 +0200
+++ new/Test-Spelling-0.19/Makefile.PL 2013-01-27 19:40:07.000000000 +0100
@@ -8,6 +8,7 @@
githubmeta;
requires 'Pod::Spell' => '1.01';
+requires 'IPC::Run3' => '0.044';
test_requires 'Test::More' => '0.88';
test_requires 'Test::Tester';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install/Base.pm
new/Test-Spelling-0.19/inc/Module/Install/Base.pm
--- old/Test-Spelling-0.15/inc/Module/Install/Base.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/Base.pm 2013-05-05
17:03:56.000000000 +0200
@@ -4,7 +4,7 @@
use strict 'vars';
use vars qw{$VERSION};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.06';
}
# Suspend handler for "redefined" warnings
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install/Can.pm
new/Test-Spelling-0.19/inc/Module/Install/Can.pm
--- old/Test-Spelling-0.15/inc/Module/Install/Can.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/Can.pm 2013-05-05
17:03:56.000000000 +0200
@@ -3,13 +3,12 @@
use strict;
use Config ();
-use File::Spec ();
use ExtUtils::MakeMaker ();
use Module::Install::Base ();
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.06';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
@@ -29,7 +28,7 @@
eval { require $mod; $pkg->VERSION($ver || 0); 1 };
}
-# check if we can run some command
+# Check if we can run some command
sub can_run {
my ($self, $cmd) = @_;
@@ -38,14 +37,88 @@
for my $dir ((split /$Config::Config{path_sep}/, $ENV{PATH}), '.') {
next if $dir eq '';
- my $abs = File::Spec->catfile($dir, $_[1]);
+ require File::Spec;
+ my $abs = File::Spec->catfile($dir, $cmd);
return $abs if (-x $abs or $abs = MM->maybe_command($abs));
}
return;
}
-# can we locate a (the) C compiler
+# Can our C compiler environment build XS files
+sub can_xs {
+ my $self = shift;
+
+ # Ensure we have the CBuilder module
+ $self->configure_requires( 'ExtUtils::CBuilder' => 0.27 );
+
+ # Do we have the configure_requires checker?
+ local $@;
+ eval "require ExtUtils::CBuilder;";
+ if ( $@ ) {
+ # They don't obey configure_requires, so it is
+ # someone old and delicate. Try to avoid hurting
+ # them by falling back to an older simpler test.
+ return $self->can_cc();
+ }
+
+ # Do we have a working C compiler
+ my $builder = ExtUtils::CBuilder->new(
+ quiet => 1,
+ );
+ unless ( $builder->have_compiler ) {
+ # No working C compiler
+ return 0;
+ }
+
+ # Write a C file representative of what XS becomes
+ require File::Temp;
+ my ( $FH, $tmpfile ) = File::Temp::tempfile(
+ "compilexs-XXXXX",
+ SUFFIX => '.c',
+ );
+ binmode $FH;
+ print $FH <<'END_C';
+#include "EXTERN.h"
+#include "perl.h"
+#include "XSUB.h"
+
+int main(int argc, char **argv) {
+ return 0;
+}
+
+int boot_sanexs() {
+ return 1;
+}
+
+END_C
+ close $FH;
+
+ # Can the C compiler access the same headers XS does
+ my @libs = ();
+ my $object = undef;
+ eval {
+ local $^W = 0;
+ $object = $builder->compile(
+ source => $tmpfile,
+ );
+ @libs = $builder->link(
+ objects => $object,
+ module_name => 'sanexs',
+ );
+ };
+ my $result = $@ ? 0 : 1;
+
+ # Clean up all the build files
+ foreach ( $tmpfile, $object, @libs ) {
+ next unless defined $_;
+ 1 while unlink;
+ }
+
+ return $result;
+}
+
+# Can we locate a (the) C compiler
sub can_cc {
my $self = shift;
my @chunks = split(/ /, $Config::Config{cc}) or return;
@@ -78,4 +151,4 @@
__END__
-#line 156
+#line 236
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install/Fetch.pm
new/Test-Spelling-0.19/inc/Module/Install/Fetch.pm
--- old/Test-Spelling-0.15/inc/Module/Install/Fetch.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/Fetch.pm 2013-05-05
17:03:56.000000000 +0200
@@ -6,7 +6,7 @@
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.06';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install/GithubMeta.pm
new/Test-Spelling-0.19/inc/Module/Install/GithubMeta.pm
--- old/Test-Spelling-0.15/inc/Module/Install/GithubMeta.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/GithubMeta.pm 2013-05-05
17:03:56.000000000 +0200
@@ -7,26 +7,21 @@
use base qw(Module::Install::Base);
use vars qw($VERSION);
-$VERSION = '0.12';
+$VERSION = '0.22';
sub githubmeta {
my $self = shift;
return unless $Module::Install::AUTHOR;
return unless _under_git();
return unless $self->can_run('git');
- return unless my ($git_url) = `git remote show -n origin` =~ /URL: (.*)$/m;
+ my $remote = shift || 'origin';
+ return unless my ($git_url) = `git remote show -n $remote` =~ /URL: (.*)$/m;
return unless $git_url =~ /github\.com/; # Not a Github repository
my $http_url = $git_url;
$git_url =~ s![\w\-]+\@([^:]+):!git://$1/!;
- $http_url =~ s![\w\-]+\@([^:]+):!http://$1/!;
+ $http_url =~ s![\w\-]+\@([^:]+):!https://$1/!;
$http_url =~ s!\.git$!/tree!;
- $self->repository(
- {
- type => 'git',
- url => $git_url,
- web => $http_url,
- },
- );
+ $self->repository( $git_url );
$self->homepage( $http_url ) unless $self->homepage();
return 1;
}
@@ -53,4 +48,4 @@
'Github';
__END__
-#line 114
+#line 111
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install/Makefile.pm
new/Test-Spelling-0.19/inc/Module/Install/Makefile.pm
--- old/Test-Spelling-0.15/inc/Module/Install/Makefile.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/Makefile.pm 2013-05-05
17:03:56.000000000 +0200
@@ -8,7 +8,7 @@
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.06';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
@@ -215,18 +215,22 @@
require ExtUtils::MakeMaker;
if ( $perl_version and $self->_cmp($perl_version, '5.006') >= 0 ) {
- # MakeMaker can complain about module versions that include
- # an underscore, even though its own version may contain one!
- # Hence the funny regexp to get rid of it. See RT #35800
- # for details.
- my $v = $ExtUtils::MakeMaker::VERSION =~ /^(\d+\.\d+)/;
- $self->build_requires( 'ExtUtils::MakeMaker' => $v );
- $self->configure_requires( 'ExtUtils::MakeMaker' => $v );
+ # This previous attempted to inherit the version of
+ # ExtUtils::MakeMaker in use by the module author, but this
+ # was found to be untenable as some authors build releases
+ # using future dev versions of EU:MM that nobody else has.
+ # Instead, #toolchain suggests we use 6.59 which is the most
+ # stable version on CPAN at time of writing and is, to quote
+ # ribasushi, "not terminally fucked, > and tested enough".
+ # TODO: We will now need to maintain this over time to push
+ # the version up as new versions are released.
+ $self->build_requires( 'ExtUtils::MakeMaker' => 6.59 );
+ $self->configure_requires( 'ExtUtils::MakeMaker' => 6.59 );
} else {
# Allow legacy-compatibility with 5.005 by depending on the
# most recent EU:MM that supported 5.005.
- $self->build_requires( 'ExtUtils::MakeMaker' => 6.42 );
- $self->configure_requires( 'ExtUtils::MakeMaker' => 6.42 );
+ $self->build_requires( 'ExtUtils::MakeMaker' => 6.36 );
+ $self->configure_requires( 'ExtUtils::MakeMaker' => 6.36 );
}
# Generate the MakeMaker params
@@ -241,7 +245,6 @@
'all_from' if you prefer) in Makefile.PL.
EOT
- $DB::single = 1;
if ( $self->tests ) {
my @tests = split ' ', $self->tests;
my %seen;
@@ -412,4 +415,4 @@
__END__
-#line 541
+#line 544
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Test-Spelling-0.15/inc/Module/Install/ManifestSkip.pm
new/Test-Spelling-0.19/inc/Module/Install/ManifestSkip.pm
--- old/Test-Spelling-0.15/inc/Module/Install/ManifestSkip.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/ManifestSkip.pm 2013-05-05
17:03:56.000000000 +0200
@@ -9,7 +9,7 @@
# - Module::Manifest::Skip
package Module::Install::ManifestSkip;
-use 5.008003;
+use 5.008001;
use strict;
use warnings;
@@ -19,7 +19,7 @@
use Module::Manifest::Skip 0.10 ();
";
-our $VERSION = '0.19';
+our $VERSION = '0.20';
our $AUTHOR_ONLY = 1;
my $skip_file = "MANIFEST.SKIP";
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install/Metadata.pm
new/Test-Spelling-0.19/inc/Module/Install/Metadata.pm
--- old/Test-Spelling-0.15/inc/Module/Install/Metadata.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/Metadata.pm 2013-05-05
17:03:56.000000000 +0200
@@ -6,7 +6,7 @@
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.06';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
@@ -151,15 +151,21 @@
sub install_as_vendor { $_[0]->installdirs('vendor') }
sub dynamic_config {
- my $self = shift;
- unless ( @_ ) {
- warn "You MUST provide an explicit true/false value to
dynamic_config\n";
- return $self;
+ my $self = shift;
+ my $value = @_ ? shift : 1;
+ if ( $self->{values}->{dynamic_config} ) {
+ # Once dynamic we never change to static, for safety
+ return 0;
}
- $self->{values}->{dynamic_config} = $_[0] ? 1 : 0;
+ $self->{values}->{dynamic_config} = $value ? 1 : 0;
return 1;
}
+# Convenience command
+sub static_config {
+ shift->dynamic_config(0);
+}
+
sub perl_version {
my $self = shift;
return $self->{values}->{perl_version} unless @_;
@@ -170,7 +176,7 @@
# Normalize the version
$version = $self->_perl_version($version);
- # We don't support the reall old versions
+ # We don't support the really old versions
unless ( $version >= 5.005 ) {
die "Module::Install only supports 5.005 or newer (use
ExtUtils::MakeMaker)\n";
}
@@ -582,7 +588,7 @@
sub requires_from {
my $self = shift;
my $content = Module::Install::_readperl($_[0]);
- my @requires = $content =~
m/^use\s+([^\W\d]\w*(?:::\w+)*)\s+([\d\.]+)/mg;
+ my @requires = $content =~
m/^use\s+([^\W\d]\w*(?:::\w+)*)\s+(v?[\d\.]+)/mg;
while ( @requires ) {
my $module = shift @requires;
my $version = shift @requires;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install/Win32.pm
new/Test-Spelling-0.19/inc/Module/Install/Win32.pm
--- old/Test-Spelling-0.15/inc/Module/Install/Win32.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/Win32.pm 2013-05-05
17:03:56.000000000 +0200
@@ -6,7 +6,7 @@
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.06';
@ISA = 'Module::Install::Base';
$ISCORE = 1;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install/WriteAll.pm
new/Test-Spelling-0.19/inc/Module/Install/WriteAll.pm
--- old/Test-Spelling-0.15/inc/Module/Install/WriteAll.pm 2011-08-22
23:13:34.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install/WriteAll.pm 2013-05-05
17:03:56.000000000 +0200
@@ -6,7 +6,7 @@
use vars qw{$VERSION @ISA $ISCORE};
BEGIN {
- $VERSION = '1.01';
+ $VERSION = '1.06';
@ISA = qw{Module::Install::Base};
$ISCORE = 1;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/inc/Module/Install.pm
new/Test-Spelling-0.19/inc/Module/Install.pm
--- old/Test-Spelling-0.15/inc/Module/Install.pm 2011-08-22
23:13:33.000000000 +0200
+++ new/Test-Spelling-0.19/inc/Module/Install.pm 2013-05-05
17:03:56.000000000 +0200
@@ -31,7 +31,7 @@
# This is not enforced yet, but will be some time in the next few
# releases once we can make sure it won't clash with custom
# Module::Install extensions.
- $VERSION = '1.01';
+ $VERSION = '1.06';
# Storage for the pseudo-singleton
$MAIN = undef;
@@ -451,7 +451,7 @@
}
sub _cmp ($$) {
- _version($_[0]) <=> _version($_[1]);
+ _version($_[1]) <=> _version($_[2]);
}
# Cloned from Params::Util::_CLASS
@@ -467,4 +467,4 @@
1;
-# Copyright 2008 - 2011 Adam Kennedy.
+# Copyright 2008 - 2012 Adam Kennedy.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/lib/Test/Spelling.pm
new/Test-Spelling-0.19/lib/Test/Spelling.pm
--- old/Test-Spelling-0.15/lib/Test/Spelling.pm 2011-08-22 23:13:30.000000000
+0200
+++ new/Test-Spelling-0.19/lib/Test/Spelling.pm 2013-05-05 17:03:53.000000000
+0200
@@ -7,10 +7,10 @@
use Pod::Spell;
use Test::Builder;
use File::Spec;
-use IPC::Open3;
+use IPC::Run3;
use Symbol 'gensym';
-our $VERSION = '0.15';
+our $VERSION = '0.19';
our @EXPORT = qw(
pod_file_spelling_ok
@@ -20,12 +20,14 @@
all_pod_files
set_pod_file_filter
has_working_spellchecker
+ set_pod_parser
);
my $TEST = Test::Builder->new;
my $SPELLCHECKER;
my $FILE_FILTER = sub { 1 };
+my $POD_PARSER;
sub spellchecker_candidates {
# if they've specified a spellchecker, use only that one
@@ -33,7 +35,7 @@
return (
'spell', # for back-compat, this is the top candidate ...
- 'aspell list -l en', # ... but this should become first soon
+ 'aspell list -l en -p /dev/null', # ... but this should become first
soon
'ispell -l',
'hunspell -l',
);
@@ -58,27 +60,14 @@
for my $spellchecker (spellchecker_candidates()) {
my @words;
my $ok = eval {
- # IPC::Open3 says "If CHLD_ERR is false [...] then STDOUT and
- # STDERR of the child are on the same filehandle (this means that
- # an autovivified lexical cannot be used for the STDERR
- # filehandle [...])" - what a crummy API!
- my $child_error = gensym;
- my $pid = open3(my ($child_in, $spellcheck_results), $child_error,
$spellchecker);
+ my ($spellcheck_results, $errors);
+ IPC::Run3::run3($spellchecker, \$document, \$spellcheck_results,
\$errors);
- print $child_in $document;
+ @words = split /\n/, $spellcheck_results;
- # signal to spellchecker that we're done giving it words
- close $child_in or die $!;
-
- @words = <$spellcheck_results>;
-
- my $errors = do { local $/; <$child_error> };
die "spellchecker had errors: $errors" if length $errors;
- # wait for spellchecker to clean up
- waitpid $pid, 0;
-
1;
};
@@ -112,8 +101,7 @@
open my $handle, '>', \$document;
# save digested POD to the string $document
- my $checker = Pod::Spell->new;
- $checker->parse_from_file($file, $handle);
+ get_pod_parser()->parse_from_file($file, $handle);
my @words = _get_spellcheck_results($document);
@@ -134,7 +122,8 @@
my @words = invalid_words_in($file);
# remove stopwords, select unique errors
- @words = grep { !$Pod::Wordlist::Wordlist{$_} } @words;
+ my $WL = \%Pod::Wordlist::Wordlist;
+ @words = grep { !$WL->{$_} && !$WL->{lc $_} } @words;
my %seen;
@seen{@words} = ();
@words = sort keys %seen;
@@ -160,6 +149,7 @@
my $ok = 1;
for my $file (@files) {
+ local $Test::Builder::Level = $Test::Builder::Level + 1;
pod_file_spelling_ok($file) or undef $ok;
}
return $ok;
@@ -238,6 +228,16 @@
$FILE_FILTER = shift;
}
+# A new Pod::Spell object should be used for every file; people
+# providing custom pod parsers will have to do this themselves
+sub get_pod_parser {
+ return $POD_PARSER || Pod::Spell->new;
+}
+
+sub set_pod_parser {
+ $POD_PARSER = shift;
+}
+
1;
__END__
@@ -395,6 +395,14 @@
return 1;
});
+=head2 set_pod_parser($object)
+
+By default L<Pod::Spell> is used to generate text suitable for spellchecking
+from the input POD. If you want to use a different parser, perhaps a
+customized subclass of L<Pod::Spell>, call C<set_pod_parser> with an object
+that is-a L<Pod::Parser>. Be sure to create a fresh parser object for
+each file (don't use this with C<all_pod_files_spelling_ok>).
+
=head1 SEE ALSO
L<Pod::Spell>
@@ -407,7 +415,7 @@
=head1 MAINTAINER
-Shawn M Moore C<< <[email protected]> >>
+Shawn M Moore C<< <[email protected]> >>
=head1 COPYRIGHT
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/t/corpus/bad-pod.pm
new/Test-Spelling-0.19/t/corpus/bad-pod.pm
--- old/Test-Spelling-0.15/t/corpus/bad-pod.pm 2011-08-22 23:04:49.000000000
+0200
+++ new/Test-Spelling-0.19/t/corpus/bad-pod.pm 2013-04-26 16:50:57.000000000
+0200
@@ -4,6 +4,8 @@
sub foo {}
+1;
+
__END__
=head1 NAME
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/t/corpus/good-pod.pm
new/Test-Spelling-0.19/t/corpus/good-pod.pm
--- old/Test-Spelling-0.15/t/corpus/good-pod.pm 2011-08-22 23:04:49.000000000
+0200
+++ new/Test-Spelling-0.19/t/corpus/good-pod.pm 2013-04-26 16:50:57.000000000
+0200
@@ -4,6 +4,8 @@
sub foo {}
+1;
+
__END__
=head1 NAME
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/t/corpus/no-pod.pm
new/Test-Spelling-0.19/t/corpus/no-pod.pm
--- old/Test-Spelling-0.15/t/corpus/no-pod.pm 2011-08-22 23:04:10.000000000
+0200
+++ new/Test-Spelling-0.19/t/corpus/no-pod.pm 2013-04-26 16:50:57.000000000
+0200
@@ -4,5 +4,7 @@
sub foo {}
+1;
+
__END__
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/t/corpus/stopword.pm
new/Test-Spelling-0.19/t/corpus/stopword.pm
--- old/Test-Spelling-0.15/t/corpus/stopword.pm 2011-08-22 23:10:52.000000000
+0200
+++ new/Test-Spelling-0.19/t/corpus/stopword.pm 2013-04-26 16:50:57.000000000
+0200
@@ -4,11 +4,13 @@
sub foo {}
+1;
+
__END__
=head1 NAME
-Stopword::Pod - correctly spelled POD and a xzaue creator
+Stopword::Pod - correctly spelled POD and a Xzaue creator
=END
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/t/fake_checker.t
new/Test-Spelling-0.19/t/fake_checker.t
--- old/Test-Spelling-0.15/t/fake_checker.t 1970-01-01 01:00:00.000000000
+0100
+++ new/Test-Spelling-0.19/t/fake_checker.t 2013-04-26 16:35:59.000000000
+0200
@@ -0,0 +1,41 @@
+use Test::Tester;
+use Test::More;
+use Test::Spelling;
+
+# Use perl to fake a working spell checker
+# so we can test module portability even where no spell checker is present.
+
+my $spell_cmd = $^X . q< -e "print STDERR q[FOOBAR]">;
+set_spell_cmd($spell_cmd);
+
+is eval { pod_file_spelling_ok('t/corpus/bad-pod.pm', 'expect STDERR'); 1 },
+ undef, 'spell check died';
+
+like $@,
+ qr/Unable to find a working spellchecker:\n Unable to run
'\Q$spell_cmd\E': spellchecker had errors: FOOBAR/,
+ 'died with text found on STDERR';
+
+
+my $badword = 'Xzaue';
+$spell_cmd = $^X . qq< -ane "print grep { /$badword/i } \@F">;
+set_spell_cmd($spell_cmd);
+
+check_test(sub { pod_file_spelling_ok('t/corpus/good-pod.pm', 'no mistakes')
}, {
+ ok => 1,
+ name => 'no mistakes',
+});
+
+check_test(sub { pod_file_spelling_ok('t/corpus/stopword.pm', 'found
misspelled word') }, {
+ ok => 0,
+ name => 'found misspelled word',
+ diag => "Errors:\n $badword",
+});
+
+add_stopwords(lc $badword);
+
+check_test(sub { pod_file_spelling_ok('t/corpus/stopword.pm', 'used stopword')
}, {
+ ok => 1,
+ name => 'used stopword',
+});
+
+done_testing;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/t/load.t
new/Test-Spelling-0.19/t/load.t
--- old/Test-Spelling-0.15/t/load.t 2011-08-22 22:47:16.000000000 +0200
+++ new/Test-Spelling-0.19/t/load.t 2013-04-26 16:40:42.000000000 +0200
@@ -3,3 +3,11 @@
BEGIN {
use_ok( 'Test::Spelling' );
}
+
+if (my $checker = Test::Spelling::has_working_spellchecker()) {
+ diag "Test::Spelling found a spellchecker: $checker";
+}
+else {
+ diag "Test::Spelling did not find a spellchecker. Please make sure you
have spell, aspell, ispell, or hunspell installed.";
+}
+
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Test-Spelling-0.15/t/stopword.t
new/Test-Spelling-0.19/t/stopword.t
--- old/Test-Spelling-0.15/t/stopword.t 2011-08-22 23:11:14.000000000 +0200
+++ new/Test-Spelling-0.19/t/stopword.t 2013-04-26 16:35:59.000000000 +0200
@@ -11,7 +11,7 @@
check_test(sub { pod_file_spelling_ok('t/corpus/stopword.pm', 'stopword pod
file') }, {
ok => 0,
name => 'stopword pod file',
- diag => "Errors:\n xzaue",
+ diag => "Errors:\n Xzaue",
});
add_stopwords('xzaue');
--
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
