Hello community, here is the log from the commit of package perl-DateTime for openSUSE:Factory checked in at 2013-12-11 11:30:31 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-DateTime (Old) and /work/SRC/openSUSE:Factory/.perl-DateTime.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-DateTime" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-DateTime/perl-DateTime.changes 2013-06-05 17:51:05.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.perl-DateTime.new/perl-DateTime.changes 2013-12-11 11:30:32.000000000 +0100 @@ -1,0 +2,8 @@ +Mon Dec 9 11:18:09 UTC 2013 - [email protected] + +- updated to 1.04 + - Calling set_locale() or set_formatter() on an object with an ambiguous local + time could change the underlying UTC time for that object. Reported by Marta + Cuaresma Saturio. RT #90583. + +------------------------------------------------------------------- Old: ---- DateTime-1.03.tar.gz New: ---- DateTime-1.04.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-DateTime.spec ++++++ --- /var/tmp/diff_new_pack.ysj0rC/_old 2013-12-11 11:30:33.000000000 +0100 +++ /var/tmp/diff_new_pack.ysj0rC/_new 2013-12-11 11:30:33.000000000 +0100 @@ -17,7 +17,7 @@ Name: perl-DateTime -Version: 1.03 +Version: 1.04 Release: 0 %define cpan_name DateTime Summary: A date and time object ++++++ DateTime-1.03.tar.gz -> DateTime-1.04.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/Build.PL new/DateTime-1.04/Build.PL --- old/DateTime-1.03/Build.PL 2013-04-17 16:05:07.000000000 +0200 +++ new/DateTime-1.04/Build.PL 2013-12-07 16:12:44.000000000 +0100 @@ -18,7 +18,7 @@ "Dave Rolsky <autarch\@urth.org>" ], "dist_name" => "DateTime", - "dist_version" => "1.03", + "dist_version" => "1.04", "license" => "artistic_2", "module_name" => "DateTime", "recommends" => {}, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/Changes new/DateTime-1.04/Changes --- old/DateTime-1.03/Changes 2013-04-17 16:05:07.000000000 +0200 +++ new/DateTime-1.04/Changes 2013-12-07 16:12:44.000000000 +0100 @@ -1,6 +1,13 @@ +1.04 2013-12-07 + +- Calling set_locale() or set_formatter() on an object with an ambiguous local + time could change the underlying UTC time for that object. Reported by Marta + Cuaresma Saturio. RT #90583. + + 1.03 2013-04-17 -- The set_time_zone() method was not returning the object when caalled with a +- The set_time_zone() method was not returning the object when called with a name that matched the current zone. Reported by Noel Maddy. RT #84699. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/MANIFEST new/DateTime-1.04/MANIFEST --- old/DateTime-1.03/MANIFEST 2013-04-17 16:05:07.000000000 +0200 +++ new/DateTime-1.04/MANIFEST 2013-12-07 16:12:44.000000000 +0100 @@ -8,6 +8,15 @@ META.yml README TODO +_build/auto_features +_build/build_params +_build/cleanup +_build/config_data +_build/features +_build/magicnum +_build/notes +_build/prereqs +_build/runtime_params c/leap_seconds.h c/ppport.h dist.ini diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/META.json new/DateTime-1.04/META.json --- old/DateTime-1.03/META.json 2013-04-17 16:05:07.000000000 +0200 +++ new/DateTime-1.04/META.json 2013-12-07 16:12:44.000000000 +0100 @@ -4,7 +4,7 @@ "Dave Rolsky <[email protected]>" ], "dynamic_config" : 0, - "generated_by" : "Dist::Zilla version 4.300033, CPAN::Meta::Converter version 2.120921", + "generated_by" : "Dist::Zilla version 4.300039, CPAN::Meta::Converter version 2.131560", "license" : [ "artistic_2" ], @@ -26,6 +26,7 @@ }, "develop" : { "requires" : { + "Test::CPAN::Changes" : "0.19", "Test::Pod" : "1.41" } }, @@ -70,6 +71,6 @@ "web" : "http://git.urth.org/DateTime.pm.git" } }, - "version" : "1.03" + "version" : "1.04" } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/META.yml new/DateTime-1.04/META.yml --- old/DateTime-1.03/META.yml 2013-04-17 16:05:07.000000000 +0200 +++ new/DateTime-1.04/META.yml 2013-12-07 16:12:44.000000000 +0100 @@ -11,7 +11,7 @@ configure_requires: Module::Build: 0.3601 dynamic_config: 0 -generated_by: 'Dist::Zilla version 4.300033, CPAN::Meta::Converter version 2.120921' +generated_by: 'Dist::Zilla version 4.300039, CPAN::Meta::Converter version 2.131560' license: artistic_2 meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -37,4 +37,4 @@ resources: bugtracker: http://rt.cpan.org/NoAuth/Bugs.html?Dist=DateTime repository: git://git.urth.org/DateTime.pm.git -version: 1.03 +version: 1.04 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/README new/DateTime-1.04/README --- old/DateTime-1.03/README 2013-04-17 16:05:07.000000000 +0200 +++ new/DateTime-1.04/README 2013-12-07 16:12:44.000000000 +0100 @@ -1,7 +1,7 @@ This archive contains the distribution DateTime, -version 1.03: +version 1.04: A date and time object diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/auto_features new/DateTime-1.04/_build/auto_features --- old/DateTime-1.03/_build/auto_features 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/auto_features 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1,2 @@ +do{ my $x = {}; +$x; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/build_params new/DateTime-1.04/_build/build_params --- old/DateTime-1.03/_build/build_params 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/build_params 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1,123 @@ +do{ my $x = [ + { + 'ARGV' => [] + }, + {}, + { + 'verbose' => undef, + 'dist_suffix' => undef, + 'PL_files' => undef, + 'pollute' => undef, + 'metafile2' => 'META.json', + 'bindoc_dirs' => [ + 'blib/script' + ], + 'conflicts' => {}, + 'scripts' => undef, + 'recommends' => {}, + 'pod_files' => undef, + 'config_dir' => '_build', + 'dist_version' => 42, + 'sign' => undef, + 'recurse_into' => [], + 'build_bat' => 0, + 'extra_linker_flags' => [], + 'build_class' => 'Module::Build', + 'prereq_action_types' => [ + 'requires', + 'build_requires', + 'test_requires', + 'conflicts', + 'recommends' + ], + 'base_dir' => '/home/autarch/projects/DateTime.pm', + 'allow_mb_mismatch' => 0, + 'xs_files' => undef, + 'destdir' => undef, + 'metafile' => 'META.yml', + 'mb_version' => '0.4005', + 'use_tap_harness' => 0, + 'test_file_exts' => [ + '.t' + ], + 'dist_name' => 'DateTime', + 'has_config_data' => undef, + 'install_base' => undef, + 'module_name' => 'DateTime', + '_have_c_compiler' => 1, + 'recursive_test_files' => 1, + 'perl' => '/home/autarch/perl5/perlbrew/perls/perl-5.16.3/bin/perl', + 'libdoc_dirs' => [ + 'blib/lib', + 'blib/arch' + ], + 'dist_author' => undef, + 'bundle_inc' => [], + 'use_rcfile' => 1, + 'configure_requires' => {}, + 'pureperl_only' => 0, + 'test_files' => undef, + 'dist_abstract' => 'Whatever', + 'create_readme' => undef, + 'prefix_relpaths' => {}, + 'share_dir' => undef, + 'debug' => undef, + 'meta_merge' => {}, + 'get_options' => {}, + 'dist_version_from' => undef, + '_added_to_INC' => [], + 'auto_configure_requires' => 1, + 'create_license' => undef, + 'debugger' => undef, + 'html_css' => '', + 'cpan_client' => 'cpan', + 'mymetafile2' => 'MYMETA.json', + 'bundle_inc_preload' => [], + 'build_elements' => [ + 'PL', + 'support', + 'pm', + 'xs', + 'share_dir', + 'pod', + 'script' + ], + 'release_status' => 'stable', + 'needs_compiler' => 1, + 'orig_dir' => '/home/autarch/projects/DateTime.pm', + 'include_dirs' => [], + 'test_requires' => {}, + 'installdirs' => 'site', + 'mymetafile' => 'MYMETA.yml', + 'create_makefile_pl' => undef, + 'magic_number' => undef, + 'dynamic_config' => 1, + 'tap_harness_args' => {}, + 'install_sets' => {}, + 'install_base_relpaths' => {}, + 'create_packlist' => 1, + 'meta_add' => {}, + 'requires' => {}, + 'install_path' => {}, + 'pm_files' => undef, + 'quiet' => undef, + 'script_files' => undef, + 'extra_compiler_flags' => [ + '-Wall' + ], + 'build_script' => 'Build', + 'original_prefix' => {}, + 'c_source' => 'c', + 'program_name' => undef, + 'autosplit' => undef, + 'license' => 'artistic_2', + 'build_requires' => { + 'ExtUtils::CBuilder' => 0 + }, + 'allow_pureperl' => 0, + 'config' => undef, + 'blib' => 'blib', + 'prefix' => undef + } +]; +$x; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/cleanup new/DateTime-1.04/_build/cleanup --- old/DateTime-1.03/_build/cleanup 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/cleanup 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1,8 @@ +do{ my $x = { + 'lib/DateTime.o' => 1, + 'blib/arch/auto/DateTime/DateTime.bs' => 1, + 'blib/arch/auto/DateTime/DateTime.so' => 1, + 'lib/DateTime.c' => 1, + 'blib' => 1 +}; +$x; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/config_data new/DateTime-1.04/_build/config_data --- old/DateTime-1.03/_build/config_data 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/config_data 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1,2 @@ +do{ my $x = {}; +$x; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/features new/DateTime-1.04/_build/features --- old/DateTime-1.03/_build/features 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/features 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1,2 @@ +do{ my $x = {}; +$x; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/magicnum new/DateTime-1.04/_build/magicnum --- old/DateTime-1.03/_build/magicnum 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/magicnum 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1 @@ +731030 \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/notes new/DateTime-1.04/_build/notes --- old/DateTime-1.03/_build/notes 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/notes 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1,2 @@ +do{ my $x = {}; +$x; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/prereqs new/DateTime-1.04/_build/prereqs --- old/DateTime-1.03/_build/prereqs 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/prereqs 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1,10 @@ +do{ my $x = { + 'build_requires' => { + 'ExtUtils::CBuilder' => 0 + }, + 'test_requires' => {}, + 'conflicts' => {}, + 'requires' => {}, + 'recommends' => {} +}; +$x; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/_build/runtime_params new/DateTime-1.04/_build/runtime_params --- old/DateTime-1.03/_build/runtime_params 1970-01-01 01:00:00.000000000 +0100 +++ new/DateTime-1.04/_build/runtime_params 2013-12-07 16:12:44.000000000 +0100 @@ -0,0 +1,2 @@ +do{ my $x = {}; +$x; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/dist.ini new/DateTime-1.04/dist.ini --- old/DateTime-1.03/dist.ini 2013-04-17 16:05:07.000000000 +0200 +++ new/DateTime-1.04/dist.ini 2013-12-07 16:12:44.000000000 +0100 @@ -3,7 +3,7 @@ license = Artistic_2_0 copyright_holder = Dave Rolsky -version = 1.03 +version = 1.04 [NextRelease] format = %-6v %{yyyy-MM-dd}d diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/lib/DateTime/Duration.pm new/DateTime-1.04/lib/DateTime/Duration.pm --- old/DateTime-1.03/lib/DateTime/Duration.pm 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/lib/DateTime/Duration.pm 2013-12-07 16:12:44.000000000 +0100 @@ -1,6 +1,6 @@ package DateTime::Duration; { - $DateTime::Duration::VERSION = '1.03'; + $DateTime::Duration::VERSION = '1.04'; } use strict; @@ -318,7 +318,7 @@ =head1 VERSION -version 1.03 +version 1.04 =head1 SYNOPSIS diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/lib/DateTime/Helpers.pm new/DateTime-1.04/lib/DateTime/Helpers.pm --- old/DateTime-1.03/lib/DateTime/Helpers.pm 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/lib/DateTime/Helpers.pm 2013-12-07 16:12:44.000000000 +0100 @@ -1,6 +1,6 @@ package DateTime::Helpers; { - $DateTime::Helpers::VERSION = '1.03'; + $DateTime::Helpers::VERSION = '1.04'; } use strict; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/lib/DateTime/Infinite.pm new/DateTime-1.04/lib/DateTime/Infinite.pm --- old/DateTime-1.03/lib/DateTime/Infinite.pm 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/lib/DateTime/Infinite.pm 2013-12-07 16:12:44.000000000 +0100 @@ -1,6 +1,6 @@ package DateTime::Infinite; { - $DateTime::Infinite::VERSION = '1.03'; + $DateTime::Infinite::VERSION = '1.04'; } use strict; @@ -38,7 +38,7 @@ package DateTime::Infinite::Future; { - $DateTime::Infinite::Future::VERSION = '1.03'; + $DateTime::Infinite::Future::VERSION = '1.04'; } use strict; @@ -66,7 +66,7 @@ package DateTime::Infinite::Past; { - $DateTime::Infinite::Past::VERSION = '1.03'; + $DateTime::Infinite::Past::VERSION = '1.04'; } use strict; @@ -178,7 +178,7 @@ =head1 VERSION -version 1.03 +version 1.04 =head1 SYNOPSIS diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/lib/DateTime/LeapSecond.pm new/DateTime-1.04/lib/DateTime/LeapSecond.pm --- old/DateTime-1.03/lib/DateTime/LeapSecond.pm 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/lib/DateTime/LeapSecond.pm 2013-12-07 16:12:44.000000000 +0100 @@ -1,6 +1,6 @@ package DateTime::LeapSecond; { - $DateTime::LeapSecond::VERSION = '1.03'; + $DateTime::LeapSecond::VERSION = '1.04'; } use strict; @@ -131,7 +131,7 @@ =head1 VERSION -version 1.03 +version 1.04 =head1 SYNOPSIS diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/lib/DateTime.pm new/DateTime-1.04/lib/DateTime.pm --- old/DateTime-1.03/lib/DateTime.pm 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/lib/DateTime.pm 2013-12-07 16:12:44.000000000 +0100 @@ -1,6 +1,6 @@ package DateTime; { - $DateTime::VERSION = '1.03'; + $DateTime::VERSION = '1.04'; } use 5.008001; @@ -102,9 +102,7 @@ if (@_) { my $lang = shift; - DateTime::Locale->load($lang); - - $DefaultLocale = $lang; + $DefaultLocale = DateTime::Locale->load($lang); } return $DefaultLocale; @@ -228,14 +226,8 @@ my $self = bless {}, $class; $p{locale} = delete $p{language} if exists $p{language}; - $p{locale} = $class->DefaultLocale unless defined $p{locale}; - if ( ref $p{locale} ) { - $self->{locale} = $p{locale}; - } - else { - $self->{locale} = DateTime::Locale->load( $p{locale} ); - } + $self->_set_locale( $p{locale} ); $self->{tz} = ( ref $p{time_zone} @@ -286,15 +278,35 @@ return $self; } +sub _set_locale { + my $self = shift; + my $locale = shift; + + if ( defined $locale && ref $locale ) { + $self->{locale} = $locale; + } + else { + $self->{locale} + = $locale + ? DateTime::Locale->load($locale) + : $self->DefaultLocale(); + } + + return; +} + # This method exists for the benefit of internal methods which create # a new object based on the current object, like set() and truncate(). sub _new_from_self { my $self = shift; my %p = @_; - my %old = map { $_ => $self->$_() } - qw( year month day hour minute second nanosecond - locale time_zone ); + my %old = map { $_ => $self->$_() } qw( + year month day + hour minute second + nanosecond + locale time_zone + ); $old{formatter} = $self->formatter() if defined $self->formatter(); @@ -1901,8 +1913,29 @@ sub set_minute { $_[0]->set( minute => $_[1] ) } sub set_second { $_[0]->set( second => $_[1] ) } sub set_nanosecond { $_[0]->set( nanosecond => $_[1] ) } -sub set_locale { $_[0]->set( locale => $_[1] ) } -sub set_formatter { $_[0]->set( formatter => $_[1] ) } + +# These two are special cased because ... if the local time is the hour of a +# DST change where the same local time occurs twice then passing it through +# _new() can actually change the underlying UTC time, which is bad. + +sub set_locale { + my $self = shift; + + my ($locale) = validate_pos( @_, $BasicValidate->{locale} ); + + $self->_set_locale($locale); + + return $self; +} + +sub set_formatter { + my $self = shift; + my ($formatter) = validate_pos( @_, $BasicValidate->{formatter} ); + + $self->{formatter} = $formatter; + + return $self; +} { my %TruncateDefault = ( @@ -2083,7 +2116,7 @@ =head1 VERSION -version 1.03 +version 1.04 =head1 SYNOPSIS @@ -3728,11 +3761,11 @@ =item * d{1,2} -The numeric day of of the month. +The numeric day of the month. =item * D{1,3} -The numeric day of of the year. +The numeric day of the year. =item * F diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/t/14locale.t new/DateTime-1.04/t/14locale.t --- old/DateTime-1.03/t/14locale.t 2013-04-17 16:05:07.000000000 +0200 +++ new/DateTime-1.04/t/14locale.t 2013-12-07 16:12:44.000000000 +0100 @@ -43,4 +43,28 @@ DateTime->DefaultLocale('it'); is( DateTime->now->locale->id, 'it', 'default locale should now be "it"' ); +{ + my $dt = DateTime->new( + year => 2013, month => 10, day => 27, hour => 0, + time_zone => 'UTC' + ); + + my $after_zone = $dt->clone()->set_time_zone('Europe/Rome'); + + is( + $after_zone->offset(), + '7200', + 'offset is 7200 after set_time_zone()' + ); + + my $after_locale + = $dt->clone()->set_time_zone('Europe/Rome')->set_locale('en_GB'); + + is( + $after_locale->offset(), + '7200', + 'offset is 7200 after set_time_zone() and set_locale()' + ); +} + done_testing(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/t/31formatter.t new/DateTime-1.04/t/31formatter.t --- old/DateTime-1.03/t/31formatter.t 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/t/31formatter.t 2013-12-07 16:12:44.000000000 +0100 @@ -3,19 +3,22 @@ use Test::More; -BEGIN { - eval "use DateTime::Format::Strptime 1.2000"; - if ($@) { - plan skip_all => "DateTime::Format::Strptime 1.2000+ not installed"; +use DateTime; + +{ + package + Formatter; + + sub new { + return bless {}, __PACKAGE__; } -} -use DateTime; + sub format_datetime { + $_[1]->strftime('%Y%m%d %T'); + } +} -my $formatter = DateTime::Format::Strptime->new( - pattern => '%Y%m%d %T', - locale => 'en_US', -); +my $formatter = Formatter->new(); my $dt = DateTime->from_epoch( epoch => time(), formatter => $formatter ); ok( $dt, "Constructor (from_epoch) : $@" ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/t/44set-formatter.t new/DateTime-1.04/t/44set-formatter.t --- old/DateTime-1.03/t/44set-formatter.t 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/t/44set-formatter.t 2013-12-07 16:12:44.000000000 +0100 @@ -27,7 +27,7 @@ is( $dt->set_formatter($formatter), $dt, - 'set_format returns the datetime object' + 'set_formatter returns the datetime object' ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/t/release-cpan-changes.t new/DateTime-1.04/t/release-cpan-changes.t --- old/DateTime-1.03/t/release-cpan-changes.t 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/t/release-cpan-changes.t 2013-12-07 16:12:44.000000000 +0100 @@ -8,8 +8,12 @@ } -use Test::More; -eval 'use Test::CPAN::Changes'; -plan skip_all => 'Test::CPAN::Changes required for this test' if $@; -changes_ok(); +use strict; +use warnings; + +use Test::More 0.96 tests => 2; +use_ok('Test::CPAN::Changes'); +subtest 'changes_ok' => sub { + changes_file_ok('Changes'); +}; done_testing(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/t/release-pp-14locale.t new/DateTime-1.04/t/release-pp-14locale.t --- old/DateTime-1.03/t/release-pp-14locale.t 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/t/release-pp-14locale.t 2013-12-07 16:12:44.000000000 +0100 @@ -55,5 +55,29 @@ DateTime->DefaultLocale('it'); is( DateTime->now->locale->id, 'it', 'default locale should now be "it"' ); +{ + my $dt = DateTime->new( + year => 2013, month => 10, day => 27, hour => 0, + time_zone => 'UTC' + ); + + my $after_zone = $dt->clone()->set_time_zone('Europe/Rome'); + + is( + $after_zone->offset(), + '7200', + 'offset is 7200 after set_time_zone()' + ); + + my $after_locale + = $dt->clone()->set_time_zone('Europe/Rome')->set_locale('en_GB'); + + is( + $after_locale->offset(), + '7200', + 'offset is 7200 after set_time_zone() and set_locale()' + ); +} + done_testing(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/t/release-pp-31formatter.t new/DateTime-1.04/t/release-pp-31formatter.t --- old/DateTime-1.03/t/release-pp-31formatter.t 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/t/release-pp-31formatter.t 2013-12-07 16:12:44.000000000 +0100 @@ -15,19 +15,22 @@ use Test::More; -BEGIN { - eval "use DateTime::Format::Strptime 1.2000"; - if ($@) { - plan skip_all => "DateTime::Format::Strptime 1.2000+ not installed"; +use DateTime; + +{ + package + Formatter; + + sub new { + return bless {}, __PACKAGE__; } -} -use DateTime; + sub format_datetime { + $_[1]->strftime('%Y%m%d %T'); + } +} -my $formatter = DateTime::Format::Strptime->new( - pattern => '%Y%m%d %T', - locale => 'en_US', -); +my $formatter = Formatter->new(); my $dt = DateTime->from_epoch( epoch => time(), formatter => $formatter ); ok( $dt, "Constructor (from_epoch) : $@" ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/DateTime-1.03/t/release-pp-44set-formatter.t new/DateTime-1.04/t/release-pp-44set-formatter.t --- old/DateTime-1.03/t/release-pp-44set-formatter.t 2013-04-17 16:05:08.000000000 +0200 +++ new/DateTime-1.04/t/release-pp-44set-formatter.t 2013-12-07 16:12:44.000000000 +0100 @@ -39,7 +39,7 @@ is( $dt->set_formatter($formatter), $dt, - 'set_format returns the datetime object' + 'set_formatter returns the datetime object' ); } -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
