Hello community, here is the log from the commit of package shotwell for openSUSE:Factory checked in at 2014-07-04 17:18:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/shotwell (Old) and /work/SRC/openSUSE:Factory/.shotwell.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "shotwell" Changes: -------- --- /work/SRC/openSUSE:Factory/shotwell/shotwell.changes 2014-03-25 13:28:47.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.shotwell.new/shotwell.changes 2014-07-04 17:18:32.000000000 +0200 @@ -1,0 +2,9 @@ +Wed Jul 2 07:09:57 UTC 2014 - [email protected] + +- Update to version 0.18.1: + + Fix Flickr publishing errors due to Flickr moving to HTTPs-only. + + Fix crash when updating photo data/time. + + Fix crash due to nested tag and changing sidebar selection. + + Corrected URLs to point to new gnome.org pages. + +------------------------------------------------------------------- Old: ---- shotwell-0.18.0.tar.xz New: ---- shotwell-0.18.1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ shotwell.spec ++++++ --- /var/tmp/diff_new_pack.yEJdAP/_old 2014-07-04 17:18:33.000000000 +0200 +++ /var/tmp/diff_new_pack.yEJdAP/_new 2014-07-04 17:18:33.000000000 +0200 @@ -17,7 +17,7 @@ Name: shotwell -Version: 0.18.0 +Version: 0.18.1 Release: 0 Summary: Photo Manager for GNOME License: LGPL-2.1+ ++++++ shotwell-0.18.0.tar.xz -> shotwell-0.18.1.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/Makefile new/shotwell-0.18.1/Makefile --- old/shotwell-0.18.0/Makefile 2014-03-18 22:50:19.000000000 +0100 +++ new/shotwell-0.18.1/Makefile 2014-07-01 00:08:35.000000000 +0200 @@ -2,7 +2,7 @@ PROGRAM_THUMBNAILER = shotwell-video-thumbnailer PROGRAM_MIGRATOR = shotwell-settings-migrator -VERSION = 0.18.0 +VERSION = 0.18.1 GITVER := $(shell git log -n 1 2>/dev/null | head -n 1 | awk '{print $$2}') GETTEXT_PACKAGE = $(PROGRAM) BUILD_ROOT = 1 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/NEWS new/shotwell-0.18.1/NEWS --- old/shotwell-0.18.0/NEWS 2014-03-18 22:44:02.000000000 +0100 +++ new/shotwell-0.18.1/NEWS 2014-07-01 00:10:22.000000000 +0200 @@ -1,3 +1,12 @@ +Shotwell 0.18.1 - 30 Jun 2014 +----------------------------- + + * Fix Flickr publishing errors due to Flickr moving to HTTPs-only + * Fix crash when updating photo data/time + * Fix crash due to nested tag and changing sidebar selection + * Corrected URLs to point to new gnome.org pages + + Shotwell 0.18.0 - 17 March 2014 ------------------------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/plugins/common/Resources.vala new/shotwell-0.18.1/plugins/common/Resources.vala --- old/shotwell-0.18.0/plugins/common/Resources.vala 2014-03-04 23:54:12.000000000 +0100 +++ new/shotwell-0.18.1/plugins/common/Resources.vala 2014-06-30 23:52:47.000000000 +0200 @@ -7,7 +7,7 @@ namespace Resources { public const string WEBSITE_NAME = _("Visit the Yorba web site"); -public const string WEBSITE_URL = "http://www.yorba.org";; +public const string WEBSITE_URL = "https://wiki.gnome.org/Apps/Shotwell";; public const string LICENSE = """ Shotwell is free software; you can redistribute it and/or modify it under the diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/plugins/shotwell-publishing/FlickrPublishing.vala new/shotwell-0.18.1/plugins/shotwell-publishing/FlickrPublishing.vala --- old/shotwell-0.18.0/plugins/shotwell-publishing/FlickrPublishing.vala 2014-03-04 23:54:12.000000000 +0100 +++ new/shotwell-0.18.1/plugins/shotwell-publishing/FlickrPublishing.vala 2014-06-30 23:56:55.000000000 +0200 @@ -61,7 +61,7 @@ _("You are not currently logged into Flickr.\n\nClick Login to log into Flickr in your Web browser. You will have to authorize Shotwell Connect to link to your Flickr account."); internal const string RESTART_ERROR_MESSAGE = _("You have already logged in and out of Flickr during this Shotwell session.\nTo continue publishing to Flickr, quit and restart Shotwell, then try publishing again."); -internal const string ENDPOINT_URL = "http://api.flickr.com/services/rest";; +internal const string ENDPOINT_URL = "https://api.flickr.com/services/rest";; internal const string API_KEY = "60dd96d4a2ad04888b09c9e18d82c26f"; internal const string API_SECRET = "d0960565e03547c1"; internal const int ORIGINAL_SIZE = -1; @@ -414,7 +414,7 @@ } private void do_launch_system_browser(string token) { - string login_uri = "http://www.flickr.com/services/oauth/authorize?oauth_token="; + token + + string login_uri = "https://www.flickr.com/services/oauth/authorize?oauth_token="; + token + "&perms=write"; debug("ACTION: launching system browser with uri = '%s'", login_uri); @@ -844,14 +844,14 @@ internal class AuthenticationRequestTransaction : Transaction { public AuthenticationRequestTransaction(Session session) { - base.with_uri(session, "http://www.flickr.com/services/oauth/request_token";, + base.with_uri(session, "https://www.flickr.com/services/oauth/request_token";, Publishing.RESTSupport.HttpMethod.GET); } } internal class AccessTokenFetchTransaction : Transaction { public AccessTokenFetchTransaction(Session session, string user_verifier) { - base.with_uri(session, "http://www.flickr.com/services/oauth/access_token";, + base.with_uri(session, "https://www.flickr.com/services/oauth/access_token";, Publishing.RESTSupport.HttpMethod.GET); add_argument("oauth_verifier", user_verifier); add_argument("oauth_token", session.get_request_phase_token()); @@ -873,7 +873,7 @@ public UploadTransaction(Session session, PublishingParameters parameters, Spit.Publishing.Publishable publishable) { - base.with_endpoint_url(session, publishable, "http://api.flickr.com/services/upload";); + base.with_endpoint_url(session, publishable, "https://api.flickr.com/services/upload";); this.parameters = parameters; this.session = session; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/src/AppWindow.vala new/shotwell-0.18.1/src/AppWindow.vala --- old/shotwell-0.18.0/src/AppWindow.vala 2014-03-04 23:54:12.000000000 +0100 +++ new/shotwell-0.18.1/src/AppWindow.vala 2014-06-30 23:52:32.000000000 +0200 @@ -683,7 +683,7 @@ "version", Resources.APP_VERSION, "comments", get_app_role(), "copyright", Resources.COPYRIGHT, - "website", Resources.YORBA_URL, + "website", Resources.HOME_URL, "license", Resources.LICENSE, "website-label", _("Visit the Yorba web site"), "authors", Resources.AUTHORS, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/src/Event.vala new/shotwell-0.18.1/src/Event.vala --- old/shotwell-0.18.0/src/Event.vala 2014-03-04 23:54:12.000000000 +0100 +++ new/shotwell-0.18.1/src/Event.vala 2014-06-30 23:50:09.000000000 +0200 @@ -458,8 +458,6 @@ should_remake_thumb = true; } - assert(get_primary_source() is MediaSource); - if (should_remake_thumb) { // check whether we actually need to remake this thumbnail... if ((get_primary_source() == null) || (get_primary_source().get_rating() == Rating.REJECTED)) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/src/Resources.vala new/shotwell-0.18.1/src/Resources.vala --- old/shotwell-0.18.0/src/Resources.vala 2014-03-18 20:48:23.000000000 +0100 +++ new/shotwell-0.18.1/src/Resources.vala 2014-06-30 23:52:32.000000000 +0200 @@ -27,16 +27,14 @@ public const string COPYRIGHT = _("Copyright 2009-2014 Yorba Foundation"); public const string APP_GETTEXT_PACKAGE = GETTEXT_PACKAGE; - public const string YORBA_URL = "http://www.yorba.org";; - public const string WIKI_URL = "http://redmine.yorba.org/projects/shotwell/wiki/Shotwell";; - public const string FAQ_URL = "http://redmine.yorba.org/projects/shotwell/wiki/ShotwellFAQ";; - public const string BUG_DB_URL = "http://redmine.yorba.org/projects/shotwell/wiki/ReportingABug";; + public const string HOME_URL = "https://wiki.gnome.org/Apps/Shotwell";; + public const string FAQ_URL = "https://wiki.gnome.org/Apps/Shotwell/FAQ";; + public const string BUG_DB_URL = "https://wiki.gnome.org/Apps/Shotwell/ReportingABug";; public const string DIR_PATTERN_URI_SYSWIDE = "ghelp:shotwell?other-files"; private const string LIB = _LIB; private const string LIBEXECDIR = _LIBEXECDIR; - public const string PREFIX = _PREFIX; public const double TRANSIENT_WINDOW_OPACITY = 0.90; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/src/main.vala new/shotwell-0.18.1/src/main.vala --- old/shotwell-0.18.0/src/main.vala 2014-03-04 23:54:12.000000000 +0100 +++ new/shotwell-0.18.1/src/main.vala 2014-06-30 23:52:32.000000000 +0200 @@ -58,7 +58,7 @@ case Db.VerifyResult.UPGRADE_ERROR: errormsg = _("Shotwell was unable to upgrade your photo library from version %s (schema %d) to %s (schema %d). For more information please check the Shotwell Wiki at %s").printf( app_version, schema_version, Resources.APP_VERSION, DatabaseTable.SCHEMA_VERSION, - Resources.WIKI_URL); + Resources.HOME_URL); break; case Db.VerifyResult.NO_UPGRADE_AVAILABLE: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/src/plugins/SpitInterfaces.vala new/shotwell-0.18.1/src/plugins/SpitInterfaces.vala --- old/shotwell-0.18.0/src/plugins/SpitInterfaces.vala 2014-03-04 23:54:12.000000000 +0100 +++ new/shotwell-0.18.1/src/plugins/SpitInterfaces.vala 2014-06-30 23:52:32.000000000 +0200 @@ -15,7 +15,7 @@ * The Spit namespace is used for all interfaces and code that are made available to plugins or * are exposed by plugins. * - * More information can be found at [[http://trac.yorba.org/wiki/ShotwellArchWritingPlugins]] + * More information can be found at [[https://wiki.gnome.org/Apps/Shotwell/Architecture/WritingPlugins]] */ namespace Spit { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/shotwell-0.18.0/src/sidebar/Tree.vala new/shotwell-0.18.1/src/sidebar/Tree.vala --- old/shotwell-0.18.0/src/sidebar/Tree.vala 2014-03-04 23:54:12.000000000 +0100 +++ new/shotwell-0.18.1/src/sidebar/Tree.vala 2014-06-30 23:56:16.000000000 +0200 @@ -79,7 +79,6 @@ private Gtk.Menu? default_context_menu = null; private bool is_internal_drag_in_progress = false; private Sidebar.Entry? internal_drag_source_entry = null; - private Gtk.TreeRowReference? old_path_ref = null; public signal void entry_selected(Sidebar.SelectableEntry selectable); @@ -904,8 +903,9 @@ } } else if (event.button == 1 && event.type == Gdk.EventType.BUTTON_PRESS) { // Is this a click on an already-highlighted tree item? - if ((old_path_ref != null) && (old_path_ref.get_path() != null) - && (old_path_ref.get_path().compare(path) == 0)) { + Gtk.TreePath? cursor_path = null; + get_cursor(out cursor_path, null); + if ((cursor_path != null) && (cursor_path.compare(path) == 0)) { // yes, don't allow single-click editing, but // pass the event on for dragging. text_renderer.editable = false; @@ -917,9 +917,6 @@ if (path != null && get_wrapper_at_path(path).entry is Sidebar.RenameableEntry) { text_renderer.editable = true; } - - // Remember what tree item is highlighted for next time. - old_path_ref = (path != null) ? new Gtk.TreeRowReference(store, path) : null; } return base.button_press_event(event); -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
