Hello community,
here is the log from the commit of package perl-Sysadm-Install for
openSUSE:Factory checked in at 2014-09-17 17:26:10
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Sysadm-Install (Old)
and /work/SRC/openSUSE:Factory/.perl-Sysadm-Install.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Sysadm-Install"
Changes:
--------
--- /work/SRC/openSUSE:Factory/perl-Sysadm-Install/perl-Sysadm-Install.changes
2013-06-21 13:37:20.000000000 +0200
+++
/work/SRC/openSUSE:Factory/.perl-Sysadm-Install.new/perl-Sysadm-Install.changes
2014-09-17 17:26:32.000000000 +0200
@@ -1,0 +2,8 @@
+Tue Sep 16 08:07:56 UTC 2014 - co...@suse.com
+
+- updated to 0.44
+ (ms) replaced bin_find() implementation by File::Which
+ (ms) tap() with raise_error option set now dies with stderr output,
+ because $! isn't set on failed close().
+
+-------------------------------------------------------------------
Old:
----
Sysadm-Install-0.43.tar.gz
New:
----
Sysadm-Install-0.44.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Sysadm-Install.spec ++++++
--- /var/tmp/diff_new_pack.mWxy5y/_old 2014-09-17 17:26:33.000000000 +0200
+++ /var/tmp/diff_new_pack.mWxy5y/_new 2014-09-17 17:26:33.000000000 +0200
@@ -1,7 +1,7 @@
#
# spec file for package perl-Sysadm-Install
#
-# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: perl-Sysadm-Install
-Version: 0.43
+Version: 0.44
Release: 0
%define cpan_name Sysadm-Install
Summary: Typical installation tasks for system administrators
@@ -29,16 +29,11 @@
BuildRoot: %{_tmppath}/%{name}-%{version}-build
BuildRequires: perl
BuildRequires: perl-macros
+BuildRequires: perl(File::Which) >= 1.09
BuildRequires: perl(LWP::Simple)
BuildRequires: perl(Log::Log4perl) >= 1.28
BuildRequires: perl(Term::ReadKey)
-#BuildRequires: perl(Archive::Tar)
-#BuildRequires: perl(Expect)
-#BuildRequires: perl(HTTP::Request)
-#BuildRequires: perl(HTTP::Status)
-#BuildRequires: perl(Log::Log4perl::Util)
-#BuildRequires: perl(LWP::UserAgent)
-#BuildRequires: perl(Sysadm::Install)
+Requires: perl(File::Which) >= 1.09
Requires: perl(LWP::Simple)
Requires: perl(Log::Log4perl) >= 1.28
Requires: perl(Term::ReadKey)
++++++ Sysadm-Install-0.43.tar.gz -> Sysadm-Install-0.44.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/Changes
new/Sysadm-Install-0.44/Changes
--- old/Sysadm-Install-0.43/Changes 2013-03-17 08:23:53.000000000 +0100
+++ new/Sysadm-Install-0.44/Changes 2014-05-21 05:53:56.000000000 +0200
@@ -2,6 +2,11 @@
Revision history for Sysadm::Install
########################################
+0.44 (2014/05/20)
+ (ms) replaced bin_find() implementation by File::Which
+ (ms) tap() with raise_error option set now dies with stderr output,
+ because $! isn't set on failed close().
+
0.43 (2013/03/16)
(ms) Using binmode() now for slurp/blurt for compatibility with Win32
systems.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/META.json
new/Sysadm-Install-0.44/META.json
--- old/Sysadm-Install-0.43/META.json 2013-03-19 04:59:27.000000000 +0100
+++ new/Sysadm-Install-0.44/META.json 2014-05-21 05:54:09.000000000 +0200
@@ -4,7 +4,7 @@
"Mike Schilli <m...@perlmeister.com>"
],
"dynamic_config" : 1,
- "generated_by" : "ExtUtils::MakeMaker version 6.6302, CPAN::Meta::Converter
version 2.120630",
+ "generated_by" : "ExtUtils::MakeMaker version 6.98, CPAN::Meta::Converter
version 2.131560",
"license" : [
"unknown"
],
@@ -37,6 +37,7 @@
"File::Copy" : "0",
"File::Path" : "0",
"File::Temp" : "0.16",
+ "File::Which" : "1.09",
"LWP::Simple" : "0",
"Log::Log4perl" : "1.28",
"Term::ReadKey" : "0"
@@ -49,5 +50,5 @@
"url" : "http://github.com/mschilli/sysadm-install-perl";
}
},
- "version" : "0.43"
+ "version" : "0.44"
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/META.yml
new/Sysadm-Install-0.44/META.yml
--- old/Sysadm-Install-0.43/META.yml 2013-03-19 04:59:26.000000000 +0100
+++ new/Sysadm-Install-0.44/META.yml 2014-05-21 05:54:09.000000000 +0200
@@ -7,7 +7,7 @@
configure_requires:
ExtUtils::MakeMaker: 0
dynamic_config: 1
-generated_by: 'ExtUtils::MakeMaker version 6.6302, CPAN::Meta::Converter
version 2.120630'
+generated_by: 'ExtUtils::MakeMaker version 6.98, CPAN::Meta::Converter version
2.131560'
license: unknown
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -23,9 +23,10 @@
File::Copy: 0
File::Path: 0
File::Temp: 0.16
+ File::Which: 1.09
LWP::Simple: 0
Log::Log4perl: 1.28
Term::ReadKey: 0
resources:
repository: http://github.com/mschilli/sysadm-install-perl
-version: 0.43
+version: 0.44
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/MYMETA.json
new/Sysadm-Install-0.44/MYMETA.json
--- old/Sysadm-Install-0.43/MYMETA.json 2013-03-19 04:59:26.000000000 +0100
+++ new/Sysadm-Install-0.44/MYMETA.json 2014-05-21 05:54:09.000000000 +0200
@@ -4,7 +4,7 @@
"Mike Schilli <m...@perlmeister.com>"
],
"dynamic_config" : 0,
- "generated_by" : "ExtUtils::MakeMaker version 6.6302, CPAN::Meta::Converter
version 2.120630",
+ "generated_by" : "ExtUtils::MakeMaker version 6.98, CPAN::Meta::Converter
version 2.131560",
"license" : [
"unknown"
],
@@ -37,6 +37,7 @@
"File::Copy" : "0",
"File::Path" : "0",
"File::Temp" : "0.16",
+ "File::Which" : "1.09",
"LWP::Simple" : "0",
"Log::Log4perl" : "1.28",
"Term::ReadKey" : "0"
@@ -49,5 +50,5 @@
"url" : "http://github.com/mschilli/sysadm-install-perl";
}
},
- "version" : "0.43"
+ "version" : "0.44"
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/MYMETA.yml
new/Sysadm-Install-0.44/MYMETA.yml
--- old/Sysadm-Install-0.43/MYMETA.yml 2013-03-19 04:59:26.000000000 +0100
+++ new/Sysadm-Install-0.44/MYMETA.yml 2014-05-21 05:54:09.000000000 +0200
@@ -7,7 +7,7 @@
configure_requires:
ExtUtils::MakeMaker: 0
dynamic_config: 0
-generated_by: 'ExtUtils::MakeMaker version 6.6302, CPAN::Meta::Converter
version 2.120630'
+generated_by: 'ExtUtils::MakeMaker version 6.98, CPAN::Meta::Converter version
2.131560'
license: unknown
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -23,9 +23,10 @@
File::Copy: 0
File::Path: 0
File::Temp: 0.16
+ File::Which: 1.09
LWP::Simple: 0
Log::Log4perl: 1.28
Term::ReadKey: 0
resources:
repository: http://github.com/mschilli/sysadm-install-perl
-version: 0.43
+version: 0.44
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/Makefile.PL
new/Sysadm-Install-0.44/Makefile.PL
--- old/Sysadm-Install-0.43/Makefile.PL 2013-03-15 21:07:26.000000000 +0100
+++ new/Sysadm-Install-0.44/Makefile.PL 2014-05-07 08:37:21.000000000 +0200
@@ -44,6 +44,7 @@
File::Copy => 0,
File::Path => 0,
File::Basename => 0,
+ File::Which => 1.09,
Term::ReadKey => 0,
LWP::Simple => 0,
Cwd => 0,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/README
new/Sysadm-Install-0.44/README
--- old/Sysadm-Install-0.43/README 2013-03-19 04:59:25.000000000 +0100
+++ new/Sysadm-Install-0.44/README 2014-05-21 05:54:09.000000000 +0200
@@ -1,5 +1,5 @@
######################################################################
- Sysadm::Install 0.43
+ Sysadm::Install 0.44
######################################################################
NAME
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/lib/Sysadm/Install.pm
new/Sysadm-Install-0.44/lib/Sysadm/Install.pm
--- old/Sysadm-Install-0.43/lib/Sysadm/Install.pm 2013-03-17
08:26:01.000000000 +0100
+++ new/Sysadm-Install-0.44/lib/Sysadm/Install.pm 2014-05-21
05:51:38.000000000 +0200
@@ -6,10 +6,11 @@
use strict;
use warnings;
-our $VERSION = '0.43';
+our $VERSION = '0.44';
use File::Copy;
use File::Path;
+use File::Which;
use Log::Log4perl qw(:easy);
use Log::Log4perl::Util;
use File::Basename;
@@ -1044,20 +1045,20 @@
my $exit_code = $?;
- if($exit_code != 0 and $opts->{raise_error}) {
- LOGCROAK("tap $cmd | failed ($!)");
+ my $stderr = slurp($tmpfile, $options);
+
+ if( $opts->{ stderr_limit } ) {
+ $stderr = snip( $stderr, $opts->{ stderr_limit } );
}
- my $stderr = slurp($tmpfile, $options);
+ if($exit_code != 0 and $opts->{raise_error}) {
+ LOGCROAK("tap $cmd | failed ($stderr)");
+ }
if( $opts->{ stdout_limit } ) {
$stdout = snip( $stdout, $opts->{ stdout_limit } );
}
- if( $opts->{ stderr_limit } ) {
- $stderr = snip( $stderr, $opts->{ stderr_limit } );
- }
-
DEBUG "tap $cmd results: rc=$exit_code stderr=[$stderr] stdout=[$stdout]";
return ($stdout, $stderr, $exit_code);
@@ -1465,17 +1466,9 @@
######################################
my($exe) = @_;
- require Config;
- my $path_sep = ":";
- $path_sep = $Config::Config{path_sep} if defined $Config::Config{path_sep};
-
- for my $path (split /$path_sep/, $ENV{PATH}) {
- my $full = File::Spec->catfile($path, $exe);
-
- return $full if -x $full and ! -d $full;
- }
-
- return undef;
+ # File::Which returns a list in list context, we just want the first
+ # match.
+ return scalar File::Which::which( $exe );
}
=pod
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Sysadm-Install-0.43/t/012tap.t
new/Sysadm-Install-0.44/t/012tap.t
--- old/Sysadm-Install-0.43/t/012tap.t 2013-03-15 21:07:26.000000000 +0100
+++ new/Sysadm-Install-0.44/t/012tap.t 2014-05-21 05:51:16.000000000 +0200
@@ -2,9 +2,10 @@
# Tests for Sysadm::Install
#####################################
-use Test::More tests => 4;
+use Test::More tests => 5;
use Sysadm::Install qw(:all);
+use File::Temp qw( tempfile );
SKIP: {
skip "echo not supported on Win32", 2 if $^O eq "MSWin32";
@@ -24,4 +25,16 @@
$ENV{ PATH } = "";
($stdout, $stderr, $rc) = tap $ls, "/";
is($rc, 0, "cmd ok");
+
+ # Capture STDERR to a temporary file and a filehandle to read from it
+ my( $fh, $tmpfile ) = tempfile();
+ open STDERR, ">$tmpfile";
+ select STDERR; $| = 1; #needed on win32
+ open IN, "<$tmpfile" or die "Cannot open $tmpfile";
+ sub readstderr { return join("", <IN>); }
+
+ eval {
+ tap { raise_error => 1 }, "ls", "/gobbelgobbel987gobbel";
+ };
+ ok length $@ > 10, "raise_error prints error message"
}
--
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org
