Hello community,

here is the log from the commit of package mdadm for openSUSE:Factory checked 
in at 2015-02-06 10:21:18
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/mdadm (Old)
 and      /work/SRC/openSUSE:Factory/.mdadm.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "mdadm"

Changes:
--------
--- /work/SRC/openSUSE:Factory/mdadm/mdadm.changes      2014-11-11 
09:59:13.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.mdadm.new/mdadm.changes 2015-02-06 
10:21:19.000000000 +0100
@@ -1,0 +2,8 @@
+Tue Feb  3 23:40:32 UTC 2015 - nfbr...@suse.com
+
+- mdcheck-careful.patch
+  Be careful about reading all output of "mdadm --detail --export"
+  as shell commands - it isn't quoted.
+  (bnc#910500)
+
+-------------------------------------------------------------------

New:
----
  mdcheck-careful.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ mdadm.spec ++++++
--- /var/tmp/diff_new_pack.2SjoiJ/_old  2015-02-06 10:21:20.000000000 +0100
+++ /var/tmp/diff_new_pack.2SjoiJ/_new  2015-02-06 10:21:20.000000000 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package mdadm
 #
-# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -44,6 +44,8 @@
 Patch2:         0001-Grow-fix-removal-of-line-in-wrong-case.patch
 # PATCH-FIX-UPSTREAM mdcheck-no-devices.fix bnc#903051 nfbr...@suse.de
 Patch3:         mdcheck-no-devices.fix
+# PATCH-FIX-UPSTREAM mdcheck-careful.patch bnc#910500 nfbr...@suse.de
+Patch4:         mdcheck-careful.patch
 
 %define _udevdir %(pkg-config --variable=udevdir udev)
 %define _systemdshutdowndir %{_unitdir}/../system-shutdown
@@ -58,6 +60,7 @@
 %patch1 -p1
 %patch2 -p1
 %patch3 -p1
+%patch4 -p1
 
 %build
 make %{?_smp_mflags} CC="%__cc" CXFLAGS="$RPM_OPT_FLAGS -Wno-error" SUSE=yes

++++++ mdcheck-careful.patch ++++++
>From 979b1feb093b1c2e0f8b58716329f2da092741d4 Mon Sep 17 00:00:00 2001
From: NeilBrown <ne...@suse.de>
Date: Wed, 4 Feb 2015 09:06:47 +1100
Subject: [PATCH] mdcheck: be careful when sourcing the output of "mdadm
 --detail --export"

The output of "mdadm --detail --export" isn't quoted properly so
fields that contain spaces can be a problem.
We only want the MD_UUID field, and it has a very well defined
format with no spaces.
So use 'grep' to limit the output to just that.

Signed-off-by: NeilBrown <ne...@suse.de>

diff --git a/misc/mdcheck b/misc/mdcheck
index ca5fe84a1284..2c8f54d6e4cf 100644
--- a/misc/mdcheck
+++ b/misc/mdcheck
@@ -88,7 +88,7 @@ do
                continue
        fi
 
-       mdadm --detail --export "$dev" > $tmp || continue
+       mdadm --detail --export "$dev" | grep '^MD_UUID=' > $tmp || continue
        source $tmp
        fl="/var/lib/mdcheck/MD_UUID_$MD_UUID"
        if [ -z "$cont" ]
-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org

Reply via email to