Hello community, here is the log from the commit of package gedit-code-assistance for openSUSE:Factory checked in at 2015-03-25 10:00:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gedit-code-assistance (Old) and /work/SRC/openSUSE:Factory/.gedit-code-assistance.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gedit-code-assistance" Changes: -------- --- /work/SRC/openSUSE:Factory/gedit-code-assistance/gedit-code-assistance.changes 2015-03-18 13:05:26.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.gedit-code-assistance.new/gedit-code-assistance.changes 2015-03-25 10:01:00.000000000 +0100 @@ -1,0 +2,6 @@ +Mon Mar 23 16:26:45 UTC 2015 - dims...@opensuse.org + +- Update to version 3.14.3: + + Fix crash at exit when closing several documents. + +------------------------------------------------------------------- Old: ---- gedit-code-assistance-3.14.2.tar.xz New: ---- gedit-code-assistance-3.14.3.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gedit-code-assistance.spec ++++++ --- /var/tmp/diff_new_pack.Vrtlx7/_old 2015-03-25 10:01:01.000000000 +0100 +++ /var/tmp/diff_new_pack.Vrtlx7/_new 2015-03-25 10:01:01.000000000 +0100 @@ -17,7 +17,7 @@ Name: gedit-code-assistance -Version: 3.14.2 +Version: 3.14.3 Release: 0 Summary: Plugin for gedit which provides code assistance for C, C++ and Objective-C License: GPL-3.0+ ++++++ gedit-code-assistance-3.14.2.tar.xz -> gedit-code-assistance-3.14.3.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gedit-code-assistance-3.14.2/ChangeLog new/gedit-code-assistance-3.14.3/ChangeLog --- old/gedit-code-assistance-3.14.2/ChangeLog 2015-03-14 20:54:22.000000000 +0100 +++ new/gedit-code-assistance-3.14.3/ChangeLog 2015-03-23 17:19:12.000000000 +0100 @@ -1,6 +1,23 @@ +commit 7c562e35d952b42febd4c76fa9ef7ba872d56788 +Author: Ignacio Casal Quinteiro <i...@gnome.org> +Date: 2015-03-19 + + Fix crash when closing several documents + +M src/gca-backend.vala + +commit b18097c42b18659626e64e877dcfa7dfacd217b6 +Author: Ignacio Casal Quinteiro <i...@gnome.org> +Date: 2015-03-14 + + Release 3.14.2 + +M NEWS +M configure.ac + commit c9e516d1985579b2da93b7cad817e8e2344bf58c Author: Ignacio Casal Quinteiro <i...@gnome.org> -Date: 2015-03-14 +Date: 2015-03-14 indentbackends: we need to directly link to the libcodeassistance diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gedit-code-assistance-3.14.2/NEWS new/gedit-code-assistance-3.14.3/NEWS --- old/gedit-code-assistance-3.14.2/NEWS 2015-03-14 20:53:20.000000000 +0100 +++ new/gedit-code-assistance-3.14.3/NEWS 2015-03-23 17:18:48.000000000 +0100 @@ -1,4 +1,9 @@ ============================ +gedit-code-assistance 3.14.3 +============================ +Fix crash at exit when closing several documents + +============================ gedit-code-assistance 3.14.2 ============================ Fix problem loading indent backends with new libpeas diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gedit-code-assistance-3.14.2/configure new/gedit-code-assistance-3.14.3/configure --- old/gedit-code-assistance-3.14.2/configure 2015-03-14 20:53:52.000000000 +0100 +++ new/gedit-code-assistance-3.14.3/configure 2015-03-23 17:19:03.000000000 +0100 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for gedit-code-assistance 3.14.2. +# Generated by GNU Autoconf 2.69 for gedit-code-assistance 3.14.3. # # Report bugs to <http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-code-assistance>. # @@ -651,8 +651,8 @@ # Identity of this package. PACKAGE_NAME='gedit-code-assistance' PACKAGE_TARNAME='gedit-code-assistance' -PACKAGE_VERSION='3.14.2' -PACKAGE_STRING='gedit-code-assistance 3.14.2' +PACKAGE_VERSION='3.14.3' +PACKAGE_STRING='gedit-code-assistance 3.14.3' PACKAGE_BUGREPORT='http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-code-assistance' PACKAGE_URL='http://live.gnome.org/Gedit/Plugins' @@ -1398,7 +1398,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures gedit-code-assistance 3.14.2 to adapt to many kinds of systems. +\`configure' configures gedit-code-assistance 3.14.3 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1469,7 +1469,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of gedit-code-assistance 3.14.2:";; + short | recursive ) echo "Configuration of gedit-code-assistance 3.14.3:";; esac cat <<\_ACEOF @@ -1588,7 +1588,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -gedit-code-assistance configure 3.14.2 +gedit-code-assistance configure 3.14.3 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1866,7 +1866,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by gedit-code-assistance $as_me 3.14.2, which was +It was created by gedit-code-assistance $as_me 3.14.3, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -11238,7 +11238,7 @@ # Define the identity of the package. PACKAGE='gedit-code-assistance' - VERSION='3.14.2' + VERSION='3.14.3' cat >>confdefs.h <<_ACEOF @@ -12614,7 +12614,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by gedit-code-assistance $as_me 3.14.2, which was +This file was extended by gedit-code-assistance $as_me 3.14.3, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -12681,7 +12681,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -gedit-code-assistance config.status 3.14.2 +gedit-code-assistance config.status 3.14.3 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gedit-code-assistance-3.14.2/configure.ac new/gedit-code-assistance-3.14.3/configure.ac --- old/gedit-code-assistance-3.14.2/configure.ac 2015-03-14 20:51:53.000000000 +0100 +++ new/gedit-code-assistance-3.14.3/configure.ac 2015-03-23 17:18:27.000000000 +0100 @@ -2,7 +2,7 @@ m4_define(gedit_code_assistance_major_version, 3) m4_define(gedit_code_assistance_minor_version, 14) -m4_define(gedit_code_assistance_micro_version, 2) +m4_define(gedit_code_assistance_micro_version, 3) m4_define(gedit_code_assistance_version, gedit_code_assistance_major_version.gedit_code_assistance_minor_version.gedit_code_assistance_micro_version) AC_INIT([gedit-code-assistance],[gedit_code_assistance_version],[http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-code-assistance],[gedit-code-assistance],[http://live.gnome.org/Gedit/Plugins]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gedit-code-assistance-3.14.2/data/codeassistance.plugin new/gedit-code-assistance-3.14.3/data/codeassistance.plugin --- old/gedit-code-assistance-3.14.2/data/codeassistance.plugin 2015-03-14 20:53:55.000000000 +0100 +++ new/gedit-code-assistance-3.14.3/data/codeassistance.plugin 2015-03-23 17:19:06.000000000 +0100 @@ -6,4 +6,4 @@ Authors=Jesse van den Kieboom <jesse...@gnome.org> Copyright=Copyright © 2011 Jesse van den Kieboom Website=http://www.gedit.org -Version=3.14.2 +Version=3.14.3 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gedit-code-assistance-3.14.2/src/gca-backend.c new/gedit-code-assistance-3.14.3/src/gca-backend.c --- old/gedit-code-assistance-3.14.2/src/gca-backend.c 2015-03-14 20:06:45.000000000 +0100 +++ new/gedit-code-assistance-3.14.3/src/gca-backend.c 2015-03-19 16:56:16.000000000 +0100 @@ -1778,7 +1778,7 @@ _inner_error_ = NULL; _tmp5_ = e; _tmp6_ = _tmp5_->message; - gca_log_debug ("gca-backend.vala:224: Failed to parse: %s", _tmp6_); + gca_log_debug ("gca-backend.vala:232: Failed to parse: %s", _tmp6_); _g_error_free0 (e); _g_free0 (ret); return; @@ -1812,34 +1812,36 @@ gchar* data_path = NULL; GAsyncResult* _tmp0_ = NULL; gchar* _tmp1_ = NULL; - gchar* path = NULL; + GcaDocument* doc = NULL; GcaView* _tmp2_ = NULL; GcaDocument* _tmp3_ = NULL; GcaDocument* _tmp4_ = NULL; - gchar* _tmp5_ = NULL; - gchar* _tmp6_ = NULL; + GcaDocument* _tmp5_ = NULL; + GcaDocument* _tmp6_ = NULL; + gchar* path = NULL; + GcaDocument* _tmp7_ = NULL; + gchar* _tmp8_ = NULL; + gchar* _tmp9_ = NULL; GcaSourceLocation cursor = {0}; - GcaView* _tmp7_ = NULL; - GcaDocument* _tmp8_ = NULL; - GcaDocument* _tmp9_ = NULL; - GcaSourceLocation _tmp10_ = {0}; + GcaDocument* _tmp10_ = NULL; GcaSourceLocation _tmp11_ = {0}; + GcaSourceLocation _tmp12_ = {0}; GHashTable* options = NULL; - GHashFunc _tmp12_ = NULL; - GEqualFunc _tmp13_ = NULL; - GHashTable* _tmp14_ = NULL; - const gchar* _tmp15_ = NULL; + GHashFunc _tmp13_ = NULL; + GEqualFunc _tmp14_ = NULL; + GHashTable* _tmp15_ = NULL; + const gchar* _tmp16_ = NULL; GcaDBusSourceLocation dbuscurs = {0}; - GcaSourceLocation _tmp18_ = {0}; - gint _tmp19_ = 0; - GcaSourceLocation _tmp20_ = {0}; - gint _tmp21_ = 0; - GcaDBusSourceLocation _tmp22_ = {0}; - GcaDBusService* _tmp23_ = NULL; - const gchar* _tmp24_ = NULL; + GcaSourceLocation _tmp19_ = {0}; + gint _tmp20_ = 0; + GcaSourceLocation _tmp21_ = {0}; + gint _tmp22_ = 0; + GcaDBusSourceLocation _tmp23_ = {0}; + GcaDBusService* _tmp24_ = NULL; const gchar* _tmp25_ = NULL; - GcaDBusSourceLocation _tmp26_ = {0}; - GHashTable* _tmp27_ = NULL; + const gchar* _tmp26_ = NULL; + GcaDBusSourceLocation _tmp27_ = {0}; + GHashTable* _tmp28_ = NULL; self = _data2_->self; g_return_if_fail (res != NULL); _tmp0_ = res; @@ -1848,44 +1850,52 @@ _tmp2_ = _data2_->view; _tmp3_ = gca_view_get_document (_tmp2_); _tmp4_ = _tmp3_; - _tmp5_ = gca_document_get_path (_tmp4_); - _tmp6_ = _tmp5_; - path = _tmp6_; - _tmp7_ = _data2_->view; - _tmp8_ = gca_view_get_document (_tmp7_); + _tmp5_ = _g_object_ref0 (_tmp4_); + doc = _tmp5_; + _tmp6_ = doc; + if (_tmp6_ == NULL) { + _g_object_unref0 (doc); + _g_free0 (data_path); + return; + } + _tmp7_ = doc; + _tmp8_ = gca_document_get_path (_tmp7_); _tmp9_ = _tmp8_; - gca_document_get_cursor (_tmp9_, &_tmp10_); - _tmp11_ = _tmp10_; - cursor = _tmp11_; - _tmp12_ = g_str_hash; - _tmp13_ = g_str_equal; - _tmp14_ = g_hash_table_new_full (_tmp12_, _tmp13_, _g_free0_, _g_variant_unref0_); - options = _tmp14_; - _tmp15_ = data_path; - if (_tmp15_ == NULL) { - const gchar* _tmp16_ = NULL; - gchar* _tmp17_ = NULL; - _tmp16_ = path; - _tmp17_ = g_strdup (_tmp16_); + path = _tmp9_; + _tmp10_ = doc; + gca_document_get_cursor (_tmp10_, &_tmp11_); + _tmp12_ = _tmp11_; + cursor = _tmp12_; + _tmp13_ = g_str_hash; + _tmp14_ = g_str_equal; + _tmp15_ = g_hash_table_new_full (_tmp13_, _tmp14_, _g_free0_, _g_variant_unref0_); + options = _tmp15_; + _tmp16_ = data_path; + if (_tmp16_ == NULL) { + const gchar* _tmp17_ = NULL; + gchar* _tmp18_ = NULL; + _tmp17_ = path; + _tmp18_ = g_strdup (_tmp17_); _g_free0 (data_path); - data_path = _tmp17_; + data_path = _tmp18_; } - _tmp18_ = cursor; - _tmp19_ = _tmp18_.line; - _tmp20_ = cursor; - _tmp21_ = _tmp20_.column; - memset (&_tmp22_, 0, sizeof (GcaDBusSourceLocation)); - _tmp22_.line = (gint64) _tmp19_; - _tmp22_.column = (gint64) _tmp21_; - dbuscurs = _tmp22_; - _tmp23_ = self->priv->d_service; - _tmp24_ = path; - _tmp25_ = data_path; - _tmp26_ = dbuscurs; - _tmp27_ = options; - gca_dbus_service_parse (_tmp23_, _tmp24_, _tmp25_, &_tmp26_, _tmp27_, ___lambda7__gasync_ready_callback, block2_data_ref (_data2_)); + _tmp19_ = cursor; + _tmp20_ = _tmp19_.line; + _tmp21_ = cursor; + _tmp22_ = _tmp21_.column; + memset (&_tmp23_, 0, sizeof (GcaDBusSourceLocation)); + _tmp23_.line = (gint64) _tmp20_; + _tmp23_.column = (gint64) _tmp22_; + dbuscurs = _tmp23_; + _tmp24_ = self->priv->d_service; + _tmp25_ = path; + _tmp26_ = data_path; + _tmp27_ = dbuscurs; + _tmp28_ = options; + gca_dbus_service_parse (_tmp24_, _tmp25_, _tmp26_, &_tmp27_, _tmp28_, ___lambda7__gasync_ready_callback, block2_data_ref (_data2_)); _g_hash_table_unref0 (options); _g_free0 (path); + _g_object_unref0 (doc); _g_free0 (data_path); } @@ -1994,7 +2004,7 @@ _inner_error_ = NULL; _tmp6_ = e; _tmp7_ = _tmp6_->message; - gca_log_debug ("gca-backend.vala:257: Failed to parse: %s", _tmp7_); + gca_log_debug ("gca-backend.vala:272: Failed to parse: %s", _tmp7_); _g_error_free0 (e); ret = (_vala_GcaDBusRemoteDocument_array_free (ret, ret_length1), NULL); return; @@ -2078,30 +2088,36 @@ GcaDBusOpenDocument* _tmp2_ = NULL; gint docs_length1 = 0; gint _docs_size_ = 0; - gchar* path = NULL; + GcaDocument* doc = NULL; GcaView* _tmp3_ = NULL; GcaDocument* _tmp4_ = NULL; GcaDocument* _tmp5_ = NULL; - gchar* _tmp6_ = NULL; - gchar* _tmp7_ = NULL; + GcaDocument* _tmp6_ = NULL; + GcaDocument* _tmp7_ = NULL; + gchar* path = NULL; + GcaDocument* _tmp8_ = NULL; + gchar* _tmp9_ = NULL; + gchar* _tmp10_ = NULL; GcaSourceLocation cursor = {0}; - GcaView* _tmp8_ = NULL; - GcaDocument* _tmp9_ = NULL; - GcaDocument* _tmp10_ = NULL; - GcaSourceLocation _tmp11_ = {0}; + GcaDocument* _tmp11_ = NULL; GcaSourceLocation _tmp12_ = {0}; + GcaSourceLocation _tmp13_ = {0}; GHashTable* options = NULL; - GHashFunc _tmp13_ = NULL; - GEqualFunc _tmp14_ = NULL; - GHashTable* _tmp15_ = NULL; + GHashFunc _tmp14_ = NULL; + GEqualFunc _tmp15_ = NULL; + GHashTable* _tmp16_ = NULL; GcaDBusSourceLocation dbuscurs = {0}; - GcaSourceLocation _tmp16_ = {0}; - gint _tmp17_ = 0; - GcaSourceLocation _tmp18_ = {0}; - gint _tmp19_ = 0; - GcaDBusSourceLocation _tmp20_ = {0}; - GcaDBusProject* _tmp21_ = NULL; - GcaDBusSourceLocation _tmp22_ = {0}; + GcaSourceLocation _tmp17_ = {0}; + gint _tmp18_ = 0; + GcaSourceLocation _tmp19_ = {0}; + gint _tmp20_ = 0; + GcaDBusSourceLocation _tmp21_ = {0}; + GcaDBusProject* _tmp22_ = NULL; + const gchar* _tmp23_ = NULL; + GcaDBusOpenDocument* _tmp24_ = NULL; + gint _tmp24__length1 = 0; + GcaDBusSourceLocation _tmp25_ = {0}; + GHashTable* _tmp26_ = NULL; self = _data3_->self; g_return_if_fail (res != NULL); _tmp0_ = res; @@ -2112,32 +2128,44 @@ _tmp3_ = _data3_->view; _tmp4_ = gca_view_get_document (_tmp3_); _tmp5_ = _tmp4_; - _tmp6_ = gca_document_get_path (_tmp5_); - _tmp7_ = _tmp6_; - path = _tmp7_; - _tmp8_ = _data3_->view; - _tmp9_ = gca_view_get_document (_tmp8_); + _tmp6_ = _g_object_ref0 (_tmp5_); + doc = _tmp6_; + _tmp7_ = doc; + if (_tmp7_ == NULL) { + _g_object_unref0 (doc); + docs = (_vala_GcaDBusOpenDocument_array_free (docs, docs_length1), NULL); + return; + } + _tmp8_ = doc; + _tmp9_ = gca_document_get_path (_tmp8_); _tmp10_ = _tmp9_; - gca_document_get_cursor (_tmp10_, &_tmp11_); - _tmp12_ = _tmp11_; - cursor = _tmp12_; - _tmp13_ = g_str_hash; - _tmp14_ = g_str_equal; - _tmp15_ = g_hash_table_new_full (_tmp13_, _tmp14_, _g_free0_, _g_variant_unref0_); - options = _tmp15_; - _tmp16_ = cursor; - _tmp17_ = _tmp16_.line; - _tmp18_ = cursor; - _tmp19_ = _tmp18_.column; - memset (&_tmp20_, 0, sizeof (GcaDBusSourceLocation)); - _tmp20_.line = (gint64) _tmp17_; - _tmp20_.column = (gint64) _tmp19_; - dbuscurs = _tmp20_; - _tmp21_ = self->priv->d_project; - _tmp22_ = dbuscurs; - gca_dbus_project_parse_all (_tmp21_, path, docs, docs_length1, &_tmp22_, options, ___lambda5__gasync_ready_callback, g_object_ref (self)); + path = _tmp10_; + _tmp11_ = doc; + gca_document_get_cursor (_tmp11_, &_tmp12_); + _tmp13_ = _tmp12_; + cursor = _tmp13_; + _tmp14_ = g_str_hash; + _tmp15_ = g_str_equal; + _tmp16_ = g_hash_table_new_full (_tmp14_, _tmp15_, _g_free0_, _g_variant_unref0_); + options = _tmp16_; + _tmp17_ = cursor; + _tmp18_ = _tmp17_.line; + _tmp19_ = cursor; + _tmp20_ = _tmp19_.column; + memset (&_tmp21_, 0, sizeof (GcaDBusSourceLocation)); + _tmp21_.line = (gint64) _tmp18_; + _tmp21_.column = (gint64) _tmp20_; + dbuscurs = _tmp21_; + _tmp22_ = self->priv->d_project; + _tmp23_ = path; + _tmp24_ = docs; + _tmp24__length1 = docs_length1; + _tmp25_ = dbuscurs; + _tmp26_ = options; + gca_dbus_project_parse_all (_tmp22_, _tmp23_, _tmp24_, _tmp24__length1, &_tmp25_, _tmp26_, ___lambda5__gasync_ready_callback, g_object_ref (self)); _g_hash_table_unref0 (options); _g_free0 (path); + _g_object_unref0 (doc); docs = (_vala_GcaDBusOpenDocument_array_free (docs, docs_length1), NULL); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gedit-code-assistance-3.14.2/src/gca-backend.vala new/gedit-code-assistance-3.14.3/src/gca-backend.vala --- old/gedit-code-assistance-3.14.2/src/gca-backend.vala 2014-02-17 14:44:29.000000000 +0100 +++ new/gedit-code-assistance-3.14.3/src/gca-backend.vala 2015-03-19 16:56:06.000000000 +0100 @@ -197,8 +197,16 @@ { unsaved_document.begin(view, (obj, res) => { var data_path = unsaved_document.end(res); - var path = view.document.path; - var cursor = view.document.cursor; + + var doc = view.document; + if (doc == null) { + // This happens when a document has been closed while we're + // getting the unsaved document + return; + } + + var path = doc.path; + var cursor = doc.cursor; var options = new HashTable<string, Variant>(str_hash, str_equal); @@ -235,8 +243,15 @@ open_documents.begin(view, (obj, res) => { var docs = open_documents.end(res); - var path = view.document.path; - var cursor = view.document.cursor; + var doc = view.document; + if (doc == null) { + // This happens when a document has been closed while we're + // opening the documents + return; + } + + var path = doc.path; + var cursor = doc.cursor; var options = new HashTable<string, Variant>(str_hash, str_equal); -- To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org For additional commands, e-mail: opensuse-commit+h...@opensuse.org